Re: Iterative Reviews
Thanks David & Russell for the inisght and clarifications. Cheers, -Lyndon- Lyndon Washington w: http://blog.the-washingtons.com/ On Sat, Nov 8, 2008 at 11:59 AM, Russell Bryant <[EMAIL PROTECTED]>wrote: > > > On Sat, Nov 8, 2008 at 10:35 AM, Lyndon Washington < > [EMAIL PROTECTED]> wrote: > >> We are planning to move to Subversion for some of our projects. Is the >> experience any different with that repository? > > > I do this with subversion. Basically, developers do their work in branches > off of trunk, for example. Then, the diff that gets uploaded for review is > the diff between trunk and the branch. As suggestions get incorporated and > committed, a new diff gets created between trunk and the branch and gets > uploaded to the review request as the updated diff. It works just fine and > dandy this way ... > > -- > Russell > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Iterative Reviews
On Sat, Nov 8, 2008 at 10:35 AM, Lyndon Washington < [EMAIL PROTECTED]> wrote: > We are planning to move to Subversion for some of our projects. Is the > experience any different with that repository? I do this with subversion. Basically, developers do their work in branches off of trunk, for example. Then, the diff that gets uploaded for review is the diff between trunk and the branch. As suggestions get incorporated and committed, a new diff gets created between trunk and the branch and gets uploaded to the review request as the updated diff. It works just fine and dandy this way ... -- Russell --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Iterative Reviews
We are planning to move to Subversion for some of our projects. Is the experience any different with that repository? Cheers, -Lyndon- Lyndon Washington w: http://blog.the-washingtons.com/ On Fri, Nov 7, 2008 at 5:46 PM, David Trowbridge <[EMAIL PROTECTED]> wrote: > > With Perforce, review requests are tied to changeset numbers. What you > describe would involve creating a new review request. This is because > we wrote it with pre-commit reviews in mind instead of post-commit. > > -David > > On Fri, Nov 7, 2008 at 2:37 PM, Lyndon Washington > <[EMAIL PROTECTED]> wrote: > > Hi, > > > > I think I read this somewhere, or maybe I just dreamed it . . . > > > > Scenario is . . . > > > > implement some changes and commit to perforce repo. > > submit and publish a review request for that changeset. > > get feedback > > incorporate feedback and commit once again. > > update the original review request with the recent changeset. > > > > Is step #5 possible? or, would I need to create a new review request? > > > > Thanks ahead of time for any insight. > > > > Cheers, > > -Lyndon- > > > > Lyndon Washington > > w: http://blog.the-washingtons.com/ > > > > > > > > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Iterative Reviews
With Perforce, review requests are tied to changeset numbers. What you describe would involve creating a new review request. This is because we wrote it with pre-commit reviews in mind instead of post-commit. -David On Fri, Nov 7, 2008 at 2:37 PM, Lyndon Washington <[EMAIL PROTECTED]> wrote: > Hi, > > I think I read this somewhere, or maybe I just dreamed it . . . > > Scenario is . . . > > implement some changes and commit to perforce repo. > submit and publish a review request for that changeset. > get feedback > incorporate feedback and commit once again. > update the original review request with the recent changeset. > > Is step #5 possible? or, would I need to create a new review request? > > Thanks ahead of time for any insight. > > Cheers, > -Lyndon- > > Lyndon Washington > w: http://blog.the-washingtons.com/ > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
