On 2013-11-15 19:13, Christian Hammond wrote:
I'm pretty sure it doesn't support it today.
diff_line = self.lines[linenum].split()
No, I imagine that doesn't end well in cases of paths containing
whitespace characters. I suspect that that code should instead be doing
something more like s
I'm pretty sure it doesn't support it today.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Fri, Nov 15, 2013 at 4:12 PM, David Trowbridge wrote:
> I don't think any of us have worked with diff parsin
I don't think any of us have worked with diff parsing recently enough to
know the answer to whether the implementation handles that off the top of
our heads. If git diff produces these files, and Review Board doesn't parse
them correctly, then yes, we should probably fix it. The technical answers
y
