Re: post-review degrades into O(n)

2009-02-23 Thread Gary M. Josack
Just a heads up, I pushed this into reviews.review-board.org, awaiting feedback. http://reviews.review-board.org/r/749/ Gary M. Josack wrote: > Yes these are all internal to our company, we have a lot of > repositories. I'll likely to start working on this in the near future, > I'll let you kn

Re: post-review degrades into O(n)

2009-02-20 Thread Gary M. Josack
Yes these are all internal to our company, we have a lot of repositories. I'll likely to start working on this in the near future, I'll let you know when I have a patch. Thanks! Christian Hammond wrote: > I'd be perfectly fine with it :) Anything to increase speed is > welcome, especially if

Re: post-review degrades into O(n)

2009-02-20 Thread Christian Hammond
I'd be perfectly fine with it :) Anything to increase speed is welcome, especially if it's a pain point for you. I must say I've never heard of anyone using Review Board with so many repositories. Are these all internal to your company (like one per project) or do you have it set up with a bunch o

Re: post-review degrades into O(n)

2009-02-20 Thread plumpy
I can't speak for the maintainers, since I'm not one, but I wrote the SVN UUID code. Basically you want to fetch and store the UUID for an SVN repository any time you create or edit one, correct? That seems perfectly reasonable to me. I say go for it. On Feb 20, 8:52 am, "Gary M. Josack" wrote:

Re: post-review degrades into O(n)

2009-02-20 Thread Gary M. Josack
Sorry for the slow response, I've been busy. We actually have hundreds of repositories and use HTTP which isn't always kind. I'll admit that we have some less than ideal solutions in place that could contribute to it being slower than a small shop but even if it took a half second per request

Re: post-review degrades into O(n)

2009-02-17 Thread Kevin Kubasik
Even for a large reviewboard install (several dozen repos) I don't see this being a major performance benefit/detriment. Can you provide some numbers showing this as a problem? It seems like a largely theoretical slowdown. -Kevin On Tue, Feb 17, 2009 at 2:59 PM, Gary M. Josack wrote: > > Discla