You may be interested to see what I did with the mercurial-reviewboard
postreview extension solving this exact issue.
You can find the patch here:
http://code.google.com/p/mercurial-reviewboard/issues/detail?id=8
Chris Bayley
On Dec 3 2009, 2:13 pm, Akhilesh akhileshjo...@gmail.com wrote:
Yeah, modifying postreview.py isn't ideal. It was just one suggestion. What
I'd like to see, I think, is an optional configuration variable in the
user's .reviewboardrc that allows users to control post-review's proxy
settings manually.
Christian
--
Christian Hammond - chip...@chipx86.com
My 2 cents.
Modifying the registry and then restoring is not a great idea. I can see
why you are doing it but I'd encourage you to NOT do this. There is a
potential here for a background web app to fail (e.g. web browser based
IM tool).
I'd be tempted to monkey patch urllib(2), presumably
Sadly, this is due to Python's usage of the system proxy settings. I'd have
to see if there's anything we can do for this. On Linux, I know you can set
the HTTP_PROXY variable to an empty string to work around it, but I doubt
that works on Windows...
Christian
--
Christian Hammond -
Thanks Christian. I tried setting http_proxy environment variable to
empty string but Windows wouldn't allow me. I set it to (with
space) - but as expected it didn't work.
Is there any work-around? The problem is that one of the sites in our
organization uses proxy and all developers from that
Is the Review Board server on HTTP or HTTPS?
It sounds like custom code would need to be added to specifically disable
the proxy server. It's also possible that a 2.6 release would fix this
issue, but I don't know.
If you were to modify postreview.py , you could try adding some code like:
