Re: how to use reviewboard hook

[David Trowbridge]

Hi,

You need to create an extension, which is a full python package that can be
installed alongside Review Board. Details on how to do this are in the
manual:

https://www.reviewboard.org/docs/manual/4.0/extending/

David

On Mon, Oct 25, 2021 at 9:21 PM 'liudaolunhuibl' via Review Board Community
 wrote:

> I now have this application scenario. After calling the Http interface of
> chat software to notify users after completing code review, I should use
> hook. There is no doubt that reviewBoard supports it.
> https://www.reviewboard.org/docs/manual/2.0/extending/extensions/hooks/
> But it doesn't say how to use hook, Write a python script and put it in a
> directory of the review board deployed on the server?
>
> --
> Supercharge your Review Board with Power Pack:
> https://www.reviewboard.org/powerpack/
> Want us to host Review Board for you? Check out RBCommons:
> https://rbcommons.com/
> Happy user? Let us know! https://www.reviewboard.org/users/
> ---
> You received this message because you are subscribed to the Google Groups
> "Review Board Community" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to reviewboard+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/reviewboard/b0255283-935b-4b3d-9b18-f6cc18ac00edn%40googlegroups.com
> 
> .
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/CAFS3VNWU2FhoYD479Z_yJ5h8Gmv4-1JoUs_-iEK0sG_B0EQDKg%40mail.gmail.com.

how to use reviewboard hook

['liudaolunhuibl' via Review Board Community]

I now have this application scenario. After calling the Http interface of 
chat software to notify users after completing code review, I should use 
hook. There is no doubt that reviewBoard supports it. 
https://www.reviewboard.org/docs/manual/2.0/extending/extensions/hooks/ But 
it doesn't say how to use hook, Write a python script and put it in a 
directory of the review board deployed on the server?

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/b0255283-935b-4b3d-9b18-f6cc18ac00edn%40googlegroups.com.

ReviewBoard Hook

[Allen]

Hi guys,

Does anybody familiar with the Hook system of ReviewBoard? 
The thing is my team really needs a feature that requires ReviewBoard to 
create a Jira ticket along with a new code review request. 
Write an extension is too much work for me and I also dont think it`s a 
good idea to directly modify the source code of ReviewBoard, so I am 
wondering is it possible to just write a script, and when a new code review 
request is published, the ReviewBoard will trigger my script which will do 
the Jira ticket creation?
I have looked into the Hook`s documentation but did not get any helpful 
information.
Hope someone can give me a clue or some suggestions! Really appreciate your 
help! Thanks!

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBoard Hook

[Christian Hammond]

Hi Allen,

We don't have hook support in the way you're describing. What you likely
saw was our extension support, which I assure you is not that hard to use
if you have any Python experience.

Work is being done on official Jira support, though won't land until after
2.0.

Christian


On Wednesday, March 12, 2014, Allen zhangsan8...@gmail.com wrote:

 Hi guys,

 Does anybody familiar with the Hook system of ReviewBoard?
 The thing is my team really needs a feature that requires ReviewBoard to
 create a Jira ticket along with a new code review request.
 Write an extension is too much work for me and I also dont think it`s a
 good idea to directly modify the source code of ReviewBoard, so I am
 wondering is it possible to just write a script, and when a new code review
 request is published, the ReviewBoard will trigger my script which will do
 the Jira ticket creation?
 I have looked into the Hook`s documentation but did not get any helpful
 information.
 Hope someone can give me a clue or some suggestions! Really appreciate
 your help! Thanks!

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google Groups
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to 
 reviewboard+unsubscr...@googlegroups.comjavascript:_e(%7B%7D,'cvml','reviewboard%2bunsubscr...@googlegroups.com');
 .
 For more options, visit https://groups.google.com/d/optout.



-- 
-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBoard Hook

[Allen]

Official Jira support, I am so glad to hear that... Pretty cool and may I 
ask when this feature will be released? If I need to wait about half a 
year, then my boss may push me to develop one...
And BTW, I tried the extension system of RB today, and with no luck I 
failed on the first step. When I tried to create a empty extension using 
the generate_extension.py tool, I got this error 
jinja2.exceptions.TemplateNotFound: extension/__init__.py, any idea why 
this is happening? 
Really appreciate your help, thanks!

On Wednesday, March 12, 2014 2:47:52 PM UTC-4, Christian Hammond wrote:

 Hi Allen,

 We don't have hook support in the way you're describing. What you likely 
 saw was our extension support, which I assure you is not that hard to use 
 if you have any Python experience.

 Work is being done on official Jira support, though won't land until after 
 2.0.

 Christian


 On Wednesday, March 12, 2014, Allen zhangs...@gmail.com javascript: 
 wrote:

 Hi guys,

 Does anybody familiar with the Hook system of ReviewBoard? 
 The thing is my team really needs a feature that requires ReviewBoard to 
 create a Jira ticket along with a new code review request. 
 Write an extension is too much work for me and I also dont think it`s a 
 good idea to directly modify the source code of ReviewBoard, so I am 
 wondering is it possible to just write a script, and when a new code review 
 request is published, the ReviewBoard will trigger my script which will do 
 the Jira ticket creation?
 I have looked into the Hook`s documentation but did not get any helpful 
 information.
 Hope someone can give me a clue or some suggestions! Really appreciate 
 your help! Thanks!

 -- 
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 --- 
 You received this message because you are subscribed to the Google Groups 
 reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



 -- 
 -- 
 Christian Hammond - chi...@chipx86.com javascript:
 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBoard Hook

[A.M.]

On Wed, 12 Mar 2014 08:15:36 -0700 (PDT), Allen zhangsan8...@gmail.com
wrote:
 Hi guys,
 
 Does anybody familiar with the Hook system of ReviewBoard? 
 The thing is my team really needs a feature that requires ReviewBoard to 
 create a Jira ticket along with a new code review request. 
 Write an extension is too much work for me and I also dont think it`s a 
 good idea to directly modify the source code of ReviewBoard, so I am 
 wondering is it possible to just write a script, and when a new code
review
 
 request is published, the ReviewBoard will trigger my script which will
do 
 the Jira ticket creation?
 I have looked into the Hook`s documentation but did not get any helpful 
 information.

We initially implemented a reviewboard extension to add the reviewboard URL
to JIRA tickets in a Code Review URL field and update the issue status to
In Code Review. What we discovered is that, since the operation is
synchronous with JIRA, it slowed down submitting changes to reviewboard.
Also, when JIRA dies (not an uncommon occurrence), the request to update
the JIRA issue can just puke in the log file, cause reviewboard timeouts,
and is then subsequently lost. 

To mitigate these problems, we implemented a cron job that polls for the
latest reviewboard changes and updates JIRA out-of-band. The cron job uses
the rbtools and jira-python modules. The downside is that the JIRA issue
updating is not instantaneous.

Cheers,
M

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBoard Hook

[Christian Hammond]

Hi Allen,

The extension stuff in current releases may have some issues. We'll have
them fixed up for the RC.

I'd recommend checking out one of our released extensions (
https://github.com/reviewboard/rb-extension-pack/) and using those as a
base.

We can answer any development questions on the reviewboard-dev list.

The Jira support will probably be in 2.1, if all goes well. Given that 2.0
is out, we're not talking a few weeks. It might be as much as half a year,
depending.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com


On Wed, Mar 12, 2014 at 12:05 PM, Allen zhangsan8...@gmail.com wrote:

 Official Jira support, I am so glad to hear that... Pretty cool and may I
 ask when this feature will be released? If I need to wait about half a
 year, then my boss may push me to develop one...
 And BTW, I tried the extension system of RB today, and with no luck I
 failed on the first step. When I tried to create a empty extension using
 the generate_extension.py tool, I got this error
 jinja2.exceptions.TemplateNotFound: extension/__init__.py, any idea why
 this is happening?
 Really appreciate your help, thanks!

 On Wednesday, March 12, 2014 2:47:52 PM UTC-4, Christian Hammond wrote:

 Hi Allen,

 We don't have hook support in the way you're describing. What you likely
 saw was our extension support, which I assure you is not that hard to use
 if you have any Python experience.

 Work is being done on official Jira support, though won't land until
 after 2.0.

 Christian


 On Wednesday, March 12, 2014, Allen zhangs...@gmail.com wrote:

 Hi guys,

 Does anybody familiar with the Hook system of ReviewBoard?
 The thing is my team really needs a feature that requires ReviewBoard to
 create a Jira ticket along with a new code review request.
 Write an extension is too much work for me and I also dont think it`s a
 good idea to directly modify the source code of ReviewBoard, so I am
 wondering is it possible to just write a script, and when a new code review
 request is published, the ReviewBoard will trigger my script which will do
 the Jira ticket creation?
 I have looked into the Hook`s documentation but did not get any helpful
 information.
 Hope someone can give me a clue or some suggestions! Really appreciate
 your help! Thanks!

 --
 Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
 ---
 Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
 ---
 Happy user? Let us know at http://www.reviewboard.org/users/
 ---
 You received this message because you are subscribed to the Google
 Groups reviewboard group.
 To unsubscribe from this group and stop receiving emails from it, send
 an email to reviewboard+unsubscr...@googlegroups.com.
 For more options, visit https://groups.google.com/d/optout.



 --
 --
 Christian Hammond - chi...@chipx86.com

 Review Board - http://www.reviewboard.org
 Beanbag, Inc. - http://www.beanbaginc.com



-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBoard Hook

[Christian Hammond]

On Wed, Mar 12, 2014 at 12:12 PM, A.M. age...@themactionfaction.com wrote:

 On Wed, 12 Mar 2014 08:15:36 -0700 (PDT), Allen zhangsan8...@gmail.com
 wrote:
  Hi guys,
 
  Does anybody familiar with the Hook system of ReviewBoard?
  The thing is my team really needs a feature that requires ReviewBoard to
  create a Jira ticket along with a new code review request.
  Write an extension is too much work for me and I also dont think it`s a
  good idea to directly modify the source code of ReviewBoard, so I am
  wondering is it possible to just write a script, and when a new code
 review
 
  request is published, the ReviewBoard will trigger my script which will
 do
  the Jira ticket creation?
  I have looked into the Hook`s documentation but did not get any helpful
  information.

 We initially implemented a reviewboard extension to add the reviewboard URL
 to JIRA tickets in a Code Review URL field and update the issue status to
 In Code Review. What we discovered is that, since the operation is
 synchronous with JIRA, it slowed down submitting changes to reviewboard.
 Also, when JIRA dies (not an uncommon occurrence), the request to update
 the JIRA issue can just puke in the log file, cause reviewboard timeouts,
 and is then subsequently lost.

 To mitigate these problems, we implemented a cron job that polls for the
 latest reviewboard changes and updates JIRA out-of-band. The cron job uses
 the rbtools and jira-python modules. The downside is that the JIRA issue
 updating is not instantaneous.

 Cheers,
 M


Another option to consider is setting up RabbitMQ, and having your
extension make use of celery (http://www.celeryproject.org/) to put a
request in a distributed queue to do the update. With that, you don't have
to have the request wait around for the Jira communication to finish, and
you can code smart retries.

Review Bot (https://github.com/reviewboard/ReviewBot) makes use of celery
to do asynchronous operations.

Christian

-- 
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com

-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBoard Hook

[Allen]

Sounds cool! And is there a way to automatically create a Jira ticket along 
with a new code reivew? You know, people just want to do things at one 
place and they hate to create something twice even they should...
Anyway thanks for letting me know!

On Wednesday, March 12, 2014 3:12:34 PM UTC-4, A.M. wrote:

 On Wed, 12 Mar 2014 08:15:36 -0700 (PDT), Allen 
 zhangs...@gmail.comjavascript: 

 wrote: 
  Hi guys, 
  
  Does anybody familiar with the Hook system of ReviewBoard? 
  The thing is my team really needs a feature that requires ReviewBoard to 
  create a Jira ticket along with a new code review request. 
  Write an extension is too much work for me and I also dont think it`s a 
  good idea to directly modify the source code of ReviewBoard, so I am 
  wondering is it possible to just write a script, and when a new code 
 review 
  
  request is published, the ReviewBoard will trigger my script which will 
 do 
  the Jira ticket creation? 
  I have looked into the Hook`s documentation but did not get any helpful 
  information. 

 We initially implemented a reviewboard extension to add the reviewboard 
 URL 
 to JIRA tickets in a Code Review URL field and update the issue status 
 to 
 In Code Review. What we discovered is that, since the operation is 
 synchronous with JIRA, it slowed down submitting changes to reviewboard. 
 Also, when JIRA dies (not an uncommon occurrence), the request to update 
 the JIRA issue can just puke in the log file, cause reviewboard timeouts, 
 and is then subsequently lost. 

 To mitigate these problems, we implemented a cron job that polls for the 
 latest reviewboard changes and updates JIRA out-of-band. The cron job uses 
 the rbtools and jira-python modules. The downside is that the JIRA issue 
 updating is not instantaneous. 

 Cheers, 
 M 


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: ReviewBoard Hook

[Allen]

And also, is that extension ready to use or still under developing? I can 
do some test work for you if you like to.

On Wednesday, March 12, 2014 3:12:34 PM UTC-4, A.M. wrote:

 On Wed, 12 Mar 2014 08:15:36 -0700 (PDT), Allen 
 zhangs...@gmail.comjavascript: 

 wrote: 
  Hi guys, 
  
  Does anybody familiar with the Hook system of ReviewBoard? 
  The thing is my team really needs a feature that requires ReviewBoard to 
  create a Jira ticket along with a new code review request. 
  Write an extension is too much work for me and I also dont think it`s a 
  good idea to directly modify the source code of ReviewBoard, so I am 
  wondering is it possible to just write a script, and when a new code 
 review 
  
  request is published, the ReviewBoard will trigger my script which will 
 do 
  the Jira ticket creation? 
  I have looked into the Hook`s documentation but did not get any helpful 
  information. 

 We initially implemented a reviewboard extension to add the reviewboard 
 URL 
 to JIRA tickets in a Code Review URL field and update the issue status 
 to 
 In Code Review. What we discovered is that, since the operation is 
 synchronous with JIRA, it slowed down submitting changes to reviewboard. 
 Also, when JIRA dies (not an uncommon occurrence), the request to update 
 the JIRA issue can just puke in the log file, cause reviewboard timeouts, 
 and is then subsequently lost. 

 To mitigate these problems, we implemented a cron job that polls for the 
 latest reviewboard changes and updates JIRA out-of-band. The cron job uses 
 the rbtools and jira-python modules. The downside is that the JIRA issue 
 updating is not instantaneous. 

 Cheers, 
 M 


-- 
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.