Re: Reviewing non-revision controlled source codes
These are the main things you'd need to do, though having experience with Python would be helpful. The information you pasted would be relevant here. Also, you'd ideally want post-review support in order to automatically generate and upload the diff, but the first step would be to make the new SCMTool. I couldn't find any place on that site for evaluating Synchronicity, so I wouldn't be able to look into this too much myself. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Nov 2, 2009 at 5:30 PM, marypap wrote: > > Hi Christian, > > Synchronicity is another SCM. You can get some information from here: > http://www.3ds.com/products/enovia > > I'm not too familiar with Python. I found this in other threads. Are > these the only things that have to be modified > if new SCM was to be added? > > > Basically, you'll create a subclass of SCMTool that does the > following: > > > 1) Grabs a file from a repository, given a file path andrevision. > > > 2) Provide a DiffParser subclass that handles pulling out filenames and > revisions and any other necessary data from a diff (most of the code for all > this is common, so you just hook into things -- see the other files for > > 3) If Vault has a concept of server-side changesets (you register a > changeset with a description, and other data, and the server always knows > what you have checked out on the client) then you'll need to implement > get_changeset(). So the general model is that this code will have three > classes: > > > > > > >> > > > 1) VaultTool > > > > > > >> > > > 2) VaultDiffParser > > > > > > >> > > > 3) VaultClient > > > > > > >> > > > VaultTool will be a subclass of SCMTool and will be what > Review Board talks to. > > > > > > >> > > > VaultDiffParser will be a subclass of DiffParser and will > override functions to parse revision info out of a diff. > > > > > > >> > > > VaultClient will be a wrapper around the command line > tool, which VaultClient will talk to. > > > > > > >> > > > Now, let's talk diffs. Many revision control systems > provide tools that generate diffs unsuitable for Review Board, and sometimes > we have to work around them. If vault's tool generates a diff containing > revision information for a file that can be used to pull data from the > repository, then we're good. If not, you'll need to implement this in > post-review. > > > Thanks > > On Oct 29, 10:27 am, Christian Hammond wrote: > > Hi, > > > > There's no good way of doing this right now. Review Board really requires > a > > repository of some sort. > > > > Is Synchronicity the name of the SCM? I haven't seen this one. I'd love > the > > URL if you have it. > > > > Assuming there are tools available for fetching a file on a remote server > > given a filename and a revision, then someone should be able to write > > support for this (though it'll need to be someone who has access to a > > Synchronicity repository and has real-world uses for it). > > > > Christian > > > > -- > > Christian Hammond - chip...@chipx86.com > > Review Board -http://www.reviewboard.org > > VMware, Inc. -http://www.vmware.com > > > > On Wed, Oct 28, 2009 at 3:14 AM, marypap wrote: > > > > > Hi, > > > > > I have been using reviewboard for doing a code review based on CVS. > > > However, there are new projects that are based on other repository > > > that is not in the supported list (Example: Synchronicity). > > > > > Is there a way to create review of those stored in non-supported > > > repository or any files that are not revision controlled and do a > > > "view diff"? > > > > > Thanks a lot, > > > mary > > > > > > To unsubscribe from this group, send email to > > > reviewboard+unsubscr...@googlegroups.com > > > > > > For more options, visit this group at > > >http://groups.google.com/group/reviewboard?hl=en > > > -~--~~~~--~~--~--~--- > > > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -~--~~~~--~~--~--~--- > > --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Reviewing non-revision controlled source codes
Hi Christian, Synchronicity is another SCM. You can get some information from here: http://www.3ds.com/products/enovia I'm not too familiar with Python. I found this in other threads. Are these the only things that have to be modified if new SCM was to be added? > Basically, you'll create a subclass of SCMTool that does the following: > 1) Grabs a file from a repository, given a file path andrevision. > 2) Provide a DiffParser subclass that handles pulling out filenames and > revisions and any other necessary data from a diff (most of the code for all > this is common, so you just hook into things -- see the other files for > 3) If Vault has a concept of server-side changesets (you register a changeset > with a description, and other data, and the server always knows what you have > checked out on the client) then you'll need to implement get_changeset(). So > the general model is that this code will have three classes: > > > > >> > > > 1) VaultTool > > > > >> > > > 2) VaultDiffParser > > > > >> > > > 3) VaultClient > > > > >> > > > VaultTool will be a subclass of SCMTool and will be what > > > > >> > > > Review Board talks to. > > > > >> > > > VaultDiffParser will be a subclass of DiffParser and will > > > > >> > > > override functions to parse revision info out of a diff. > > > > >> > > > VaultClient will be a wrapper around the command line tool, > > > > >> > > > which VaultClient will talk to. > > > > >> > > > Now, let's talk diffs. Many revision control systems provide > > > > >> > > > tools that generate diffs unsuitable for Review Board, and > > > > >> > > > sometimes we have to work around them. If vault's tool > > > > >> > > > generates a diff containing revision information for a file > > > > >> > > > that can be used to pull data from the repository, then we're > > > > >> > > > good. If not, you'll need to implement this in post-review. Thanks On Oct 29, 10:27 am, Christian Hammond wrote: > Hi, > > There's no good way of doing this right now. Review Board really requires a > repository of some sort. > > Is Synchronicity the name of the SCM? I haven't seen this one. I'd love the > URL if you have it. > > Assuming there are tools available for fetching a file on a remote server > given a filename and a revision, then someone should be able to write > support for this (though it'll need to be someone who has access to a > Synchronicity repository and has real-world uses for it). > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board -http://www.reviewboard.org > VMware, Inc. -http://www.vmware.com > > On Wed, Oct 28, 2009 at 3:14 AM, marypap wrote: > > > Hi, > > > I have been using reviewboard for doing a code review based on CVS. > > However, there are new projects that are based on other repository > > that is not in the supported list (Example: Synchronicity). > > > Is there a way to create review of those stored in non-supported > > repository or any files that are not revision controlled and do a > > "view diff"? > > > Thanks a lot, > > mary > > > > To unsubscribe from this group, send email to > > reviewboard+unsubscr...@googlegroups.com > > For more options, visit this group at > >http://groups.google.com/group/reviewboard?hl=en > > -~--~~~~--~~--~--~--- --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Reviewing non-revision controlled source codes
Hi, There's no good way of doing this right now. Review Board really requires a repository of some sort. Is Synchronicity the name of the SCM? I haven't seen this one. I'd love the URL if you have it. Assuming there are tools available for fetching a file on a remote server given a filename and a revision, then someone should be able to write support for this (though it'll need to be someone who has access to a Synchronicity repository and has real-world uses for it). Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Wed, Oct 28, 2009 at 3:14 AM, marypap wrote: > > Hi, > > I have been using reviewboard for doing a code review based on CVS. > However, there are new projects that are based on other repository > that is not in the supported list (Example: Synchronicity). > > Is there a way to create review of those stored in non-supported > repository or any files that are not revision controlled and do a > "view diff"? > > Thanks a lot, > mary > > > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > -~--~~~~--~~--~--~--- > > --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Reviewing non-revision controlled source codes
Hi, I have been using reviewboard for doing a code review based on CVS. However, there are new projects that are based on other repository that is not in the supported list (Example: Synchronicity). Is there a way to create review of those stored in non-supported repository or any files that are not revision controlled and do a "view diff"? Thanks a lot, mary --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
