Re: diff generated from Trac not accepted

2009-06-27 Thread Christian Hammond
We require either a tab or more than one space. The reason for this is that the filename may contain spaces, and we have no good way of knowing where the filename ends and the revision info begins. Yes, in this case it's marked by parens, but much of the diff parsing code is generic, and we have to

diff generated from Trac not accepted

2009-06-26 Thread Eric P
Kind of a strange issue here. I created a diff file via Trac (OSS project mgmt software), but Review Board won't accept it. Here's the error I receive: "No valid separator after the filename was found in the diff header" The exact same diff if procured via the Subversion client works fine. Up