Re: post-review: Ignore whitespace?
This is just a toggle when viewing the diff. Look at the options at the bottom of the review request box, just above the first diff. It should be on 1.6.3, but that's such an old release that I don't remember. Christian Robert Dailey wrote: Thanks for the quick response Christian. Is this option under the "My Account" page? I don't currently see an option for this. I'm on version 1.6.3. Can you comment if this is one of the versions the option you speak of is not working in? Does the server configuration have to enable this option as well? Thanks again. On Fri, Jul 12, 2013 at 5:27 PM, Christian Hammond wrote: Hi Robert, We purposefully do not provide this feature for diff uploads. From the Review Board diff viewer, you can hide lines that are whitespace-only changes (okay, this is broken in the past couple releases, but the next one will fix it). We prefer to do customization of display like that on the Review Board side, and in fact, it's very important that Review Board does not have a mangled view of how the diff looks, since we apply the patch and do some processing and caching on the result. Christian Robert Dailey wrote: Is there a way to tell post-review to ignore whitespace in diffs that it uploads? I use this tool through P4V (perforce visual client). Sometimes a file is full of tabs to spaces conversions and it mixes in with real, useful code changes. I'd like to see a way to upload a diff without whitespace OR a user-option in ReviewBoard to hide diffs on lines with only whitespace changes. Anyone? Thanks. -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review: Ignore whitespace?
Thanks for the quick response Christian. Is this option under the "My Account" page? I don't currently see an option for this. I'm on version 1.6.3. Can you comment if this is one of the versions the option you speak of is not working in? Does the server configuration have to enable this option as well? Thanks again. On Fri, Jul 12, 2013 at 5:27 PM, Christian Hammond wrote: > Hi Robert, > > We purposefully do not provide this feature for diff uploads. From the > Review Board diff viewer, you can hide lines that are whitespace-only > changes (okay, this is broken in the past couple releases, but the next one > will fix it). > > We prefer to do customization of display like that on the Review Board side, > and in fact, it's very important that Review Board does not have a mangled > view of how the diff looks, since we apply the patch and do some processing > and caching on the result. > > Christian > > > > Robert Dailey wrote: >> >> Is there a way to tell post-review to ignore whitespace in diffs that >> it uploads? I use this tool through P4V (perforce visual client). >> Sometimes a file is full of tabs to spaces conversions and it mixes in >> with real, useful code changes. >> >> I'd like to see a way to upload a diff without whitespace OR a >> user-option in ReviewBoard to hide diffs on lines with only whitespace >> changes. >> >> Anyone? Thanks. >> > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > Beanbag, Inc. - http://www.beanbaginc.com > > -- > Want to help the Review Board project? Donate today at > http://www.reviewboard.org/donate/ > Happy user? Let us know at http://www.reviewboard.org/users/ > -~--~~~~--~~--~--~--- > To unsubscribe from this group, send email to > reviewboard+unsubscr...@googlegroups.com > For more options, visit this group at > http://groups.google.com/group/reviewboard?hl=en > --- You received this message because you are subscribed to the Google > Groups "reviewboard" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to reviewboard+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > > -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review: Ignore whitespace?
Hi Robert, We purposefully do not provide this feature for diff uploads. From the Review Board diff viewer, you can hide lines that are whitespace-only changes (okay, this is broken in the past couple releases, but the next one will fix it). We prefer to do customization of display like that on the Review Board side, and in fact, it's very important that Review Board does not have a mangled view of how the diff looks, since we apply the patch and do some processing and caching on the result. Christian Robert Dailey wrote: Is there a way to tell post-review to ignore whitespace in diffs that it uploads? I use this tool through P4V (perforce visual client). Sometimes a file is full of tabs to spaces conversions and it mixes in with real, useful code changes. I'd like to see a way to upload a diff without whitespace OR a user-option in ReviewBoard to hide diffs on lines with only whitespace changes. Anyone? Thanks. -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
post-review: Ignore whitespace?
Is there a way to tell post-review to ignore whitespace in diffs that it uploads? I use this tool through P4V (perforce visual client). Sometimes a file is full of tabs to spaces conversions and it mixes in with real, useful code changes. I'd like to see a way to upload a diff without whitespace OR a user-option in ReviewBoard to hide diffs on lines with only whitespace changes. Anyone? Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
