Re: post-review failing to work on CVS because I have cleartool with a view set
David McCloskey wrote: But Another problem is appearing now. Once it tries to do the post, I get an error that the connection was refused on port 2401. I'm guessing this is because we're using ssh tunnels only to connect to our CVS servers. Is there some special way to configure my repository through the web interface to make it work through the ssh tunnel? Or to configure my environment somehow? I don't know very much about CVS unfortunately. I'm doing this to help a colleague. I'm not a CVS user either. However you may find you need the latest RB as ssh implies authentication, authentication isn't support with RB 1.0. If you have the new version the config for auth should be obvious in the web admin - again "should be" I'm not using either CVS or any auth options for the SCM with ReviewBoard. Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review failing to work on CVS because I have cleartool with a view set
Actually, what ended up happening is I was in the parent directory of where I was supposed to be. That is, I checked out something from CVS but didn't go in to what I checked out, so it wasn't finding the CVS directory. It works without changing post-review now. But Another problem is appearing now. Once it tries to do the post, I get an error that the connection was refused on port 2401. I'm guessing this is because we're using ssh tunnels only to connect to our CVS servers. Is there some special way to configure my repository through the web interface to make it work through the ssh tunnel? Or to configure my environment somehow? I don't know very much about CVS unfortunately. I'm doing this to help a colleague. On Jan 19, 12:59 pm, Chris Clark wrote: > Christian Hammond wrote: > > What you could do now is modify postreview.py so that the CVSClient > > instance is created before the ClearCaseClient. That would guarantee > > that CVS would check first. > > An easy technique for dealing with this is to add another definition for > SCMCLIENTS, this way if the SCMCLIENTS is ever changed upstream it is > still possible to automatically merge your diffs without a manual > conflict resolution, e.g.immediate after SCMCLIENTS: > > SCMCLIENTS = ( > SVNClient(), > CVSClient(), > GitClient(), > MercurialClient(), > PerforceClient(), > ClearCaseClient(), > ) > > > > ### re-define SCMCLIENTS, this makes merging changes easier (than > customizing SCMCLIENTS) :-) > SCMCLIENTS = ( > SVNClient(), > PiccoloClient(), > ) > > > Sort of brute force but it works :-) > > Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review failing to work on CVS because I have cleartool with a view set
Christian Hammond wrote: What you could do now is modify postreview.py so that the CVSClient instance is created before the ClearCaseClient. That would guarantee that CVS would check first. An easy technique for dealing with this is to add another definition for SCMCLIENTS, this way if the SCMCLIENTS is ever changed upstream it is still possible to automatically merge your diffs without a manual conflict resolution, e.g.immediate after SCMCLIENTS: SCMCLIENTS = ( SVNClient(), CVSClient(), GitClient(), MercurialClient(), PerforceClient(), ClearCaseClient(), ) ### re-define SCMCLIENTS, this makes merging changes easier (than customizing SCMCLIENTS) :-) SCMCLIENTS = ( SVNClient(), PiccoloClient(), ) Sort of brute force but it works :-) Chris -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review failing to work on CVS because I have cleartool with a view set
This is a large part of why we need to move the clearcase configuration out
into a .reviewboardrc...
What you could do now is modify postreview.py so that the CVSClient instance
is created before the ClearCaseClient. That would guarantee that CVS would
check first.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Mon, Jan 18, 2010 at 1:30 PM, David McCloskey wrote:
> I'm in a directory with a checkout trying to do a post-review with
> CVS, but post-review is tripping up on a clearcase check:
>
> >>> svn info
> >>> git rev-parse --git-dir
> >>> cleartool pwv -short
> >>> repository info: Path: /view/DEFAULT/vobs/, Base path:
> /view/DEFAULT/vobs/, Supports changesets: False
> Traceback (most recent call last):
> File "/users/mcclosdl/proj/reviewboard/bin/post-review", line 8, in
>
>load_entry_point('RBTools==0.2beta2', 'console_scripts', 'post-
> review')()
> File "/users/mcclosdl/proj/reviewboard/lib/python2.6/site-packages/
> RBTools-0.2beta2-py2.6.egg/rbtools/postreview.py", line 2506, in main
>repository_info)
> File "/users/mcclosdl/proj/reviewboard/lib/python2.6/site-packages/
> RBTools-0.2beta2-py2.6.egg/rbtools/postreview.py", line 965, in
> diff_between_revisions
>return self.do_diff(rev_str)
> File "/users/mcclosdl/proj/reviewboard/lib/python2.6/site-packages/
> RBTools-0.2beta2-py2.6.egg/rbtools/postreview.py", line 981, in
> do_diff
>onam = params.pop(0)
> AttributeError: 'str' object has no attribute 'pop'
>
>
> Is there a way to force post-review to use cvs? Or do I need to do
> some kind of hack?
>
> --
> Want to help the Review Board project? Donate today at
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to
> reviewboard+unsubscr...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/reviewboard?hl=en
>
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
post-review failing to work on CVS because I have cleartool with a view set
I'm in a directory with a checkout trying to do a post-review with
CVS, but post-review is tripping up on a clearcase check:
>>> svn info
>>> git rev-parse --git-dir
>>> cleartool pwv -short
>>> repository info: Path: /view/DEFAULT/vobs/, Base path: /view/DEFAULT/vobs/,
>>> Supports changesets: False
Traceback (most recent call last):
File "/users/mcclosdl/proj/reviewboard/bin/post-review", line 8, in
load_entry_point('RBTools==0.2beta2', 'console_scripts', 'post-
review')()
File "/users/mcclosdl/proj/reviewboard/lib/python2.6/site-packages/
RBTools-0.2beta2-py2.6.egg/rbtools/postreview.py", line 2506, in main
repository_info)
File "/users/mcclosdl/proj/reviewboard/lib/python2.6/site-packages/
RBTools-0.2beta2-py2.6.egg/rbtools/postreview.py", line 965, in
diff_between_revisions
return self.do_diff(rev_str)
File "/users/mcclosdl/proj/reviewboard/lib/python2.6/site-packages/
RBTools-0.2beta2-py2.6.egg/rbtools/postreview.py", line 981, in
do_diff
onam = params.pop(0)
AttributeError: 'str' object has no attribute 'pop'
Is there a way to force post-review to use cvs? Or do I need to do
some kind of hack?
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
