Re: Review Request 50067: Error message does not deliver when executing ambari-server command as a non-root user

2016-08-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50067/#review146476 --- ambari-server/sbin/ambari-server (line 62)

Re: Review Request 51309: "Restart all required" services operation failed at Metrics Collector since HDFS was not yet up

2016-08-22 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51309/#review146462 --- Ship it! Ship It! - Sumit Mohanty On Aug. 23, 2016, 12:14

Review Request 51309: "Restart all required" services operation failed at Metrics Collector since HDFS was not yet up

2016-08-22 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51309/ --- Review request for Ambari, Aravindan Vijayan, Jaimin Jetly, and Sumit Mohanty.

Re: Review Request 49944: optimize log description of ambari agent stop

2016-08-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49944/#review146457 --- Pushed to trunk, commit 91cd8274ae299f4fd4e6553bbd7f58f54148b65e

Re: Review Request 51303: AMBARI-18234. Fix for : (1). Hive service check for HSI and (2). HSI alert on wire encrypted cluster.

2016-08-22 Thread Swapan Shridhar
> On Aug. 22, 2016, 10:30 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_interactive_thrift_port.py, > > line 46 > > > > > > Lets verify

Re: Review Request 51304: Atlas file permissions of /var/lib/ambari-agent/tmp/atlas_hbase_setup.rb need to be ${hbase_user}:${hadoop_group} (submitted by Vitaly and tested by Alejandro)

2016-08-22 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51304/#review146450 --- Ship it! Ship It! - Jayush Luniya On Aug. 22, 2016, 10:20

Re: Review Request 51303: AMBARI-18234. Fix for : (1). Hive service check for HSI and (2). HSI alert on wire encrypted cluster.

2016-08-22 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51303/#review146448 ---

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/#review146447 --- Ship it! This logic makes me a bit nauseous; it's definitely

Re: Review Request 51304: Atlas file permissions of /var/lib/ambari-agent/tmp/atlas_hbase_setup.rb need to be ${hbase_user}:${hadoop_group} (submitted by Vitaly and tested by Alejandro)

2016-08-22 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51304/#review146445 --- Ship it! Ship It! - Sumit Mohanty On Aug. 22, 2016, 10:20

Re: Review Request 51304: Atlas file permissions of /var/lib/ambari-agent/tmp/atlas_hbase_setup.rb need to be ${hbase_user}:${hadoop_group} (submitted by Vitaly and tested by Alejandro)

2016-08-22 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51304/#review146446 --- Ship it! Ship It! - Robert Levas On Aug. 22, 2016, 6:20

Re: Review Request 51304: Atlas file permissions of /var/lib/ambari-agent/tmp/atlas_hbase_setup.rb need to be ${hbase_user}:${hadoop_group} (submitted by Vitaly and tested by Alejandro)

2016-08-22 Thread Mahadev Konar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51304/#review146443 --- Ship it! Ship It! - Mahadev Konar On Aug. 22, 2016, 10:20

Re: Review Request 51304: Atlas file permissions of /var/lib/ambari-agent/tmp/atlas_hbase_setup.rb need to be ${hbase_user}:${hadoop_group} (submitted by Vitaly and tested by Alejandro)

2016-08-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51304/#review146444 --- Ship it! Ship It! - Jonathan Hurley On Aug. 22, 2016, 6:20

Re: Review Request 51303: AMBARI-18234. Fix for : (1). Hive service check for HSI and (2). HSI alert on wire encrypted cluster.

2016-08-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51303/#review146442 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 22, 2016,

Review Request 51304: Atlas file permissions of /var/lib/ambari-agent/tmp/atlas_hbase_setup.rb need to be ${hbase_user}:${hadoop_group} (submitted by Vitaly and tested by Alejandro)

2016-08-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51304/ --- Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Vitalyi

Re: Review Request 51303: AMBARI-18234. Fix for : (1). Hive service check for HSI and (2). HSI alert on wire encrypted cluster.

2016-08-22 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51303/ --- (Updated Aug. 22, 2016, 10:20 p.m.) Review request for Ambari, Alejandro

Review Request 51303: AMBARI-18234. Fix for : (1). Hive service check for HSI and (2). HSI alert on wire encrypted cluster.

2016-08-22 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51303/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 50995: Collect JVM Heap, GC and thread pool metrics from Ambari Server and push to AMS

2016-08-22 Thread Li-Wei Tseng
> On Aug. 20, 2016, 12:02 a.m., Alejandro Fernandez wrote: > > I will add a javadoc for next patch - Li-Wei --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50995/#review145539

Re: Review Request 50999: AMBARI-18112. Fix spark.executor.extraLibraryPath to include native gpl library

2016-08-22 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50999/#review146435 --- Ship it! Ship It! - Sumit Mohanty On Aug. 11, 2016, 9:38

Review Request 51300: Check Atlas work when Ranger installed

2016-08-22 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51300/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Dmytro

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/#review146426 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 22, 2016,

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Alejandro Fernandez
> On Aug. 22, 2016, 7:33 p.m., Nate Cole wrote: > > Just confirm with Alejandro why he had both a field and a value. One was a boolean to read from the XML file, and the other is the actual calculation by reading from the parent if the XML file did not explicitly provide a value. -

Re: Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/#review146414 --- Ship it! Just confirm with Alejandro why he had both a field

Review Request 51296: Error around ATLAS_SERVER version advertisement

2016-08-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51296/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-18231

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

2016-08-22 Thread Jonathan Hurley
> On Aug. 22, 2016, 11:32 a.m., Jonathan Hurley wrote: > > Looks good once the prior comments are resolved. > > Anita Jebaraj wrote: > Thank you, I have created a jira to move the code once the upgrade > catalog is identified for version 2.5 (AMBARI-18229). I have also included > the

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

2016-08-22 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51254/ --- (Updated Aug. 22, 2016, 4:42 p.m.) Review request for Ambari, Di Li, Jonathan

Re: Review Request 51289: Add unit tests for Log Search components and refactor them as needed - Vol 1

2016-08-22 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51289/ --- (Updated Aug. 22, 2016, 4:17 p.m.) Review request for Ambari, Hayat Behlim,

Re: Review Request 51284: Remove Redundant Embedded Postgres SQL

2016-08-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51284/#review146363 --- Out of curiousity, did you happen to compare the content of

Re: Review Request 51289: Add unit tests for Log Search components and refactor them as needed - Vol 1

2016-08-22 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51289/#review146365 --- Ship it! Ship It! one thing: you can use @TestSubject and

Re: Review Request 51254: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

2016-08-22 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51254/#review146362 --- Ship it! Looks good once the prior comments are resolved. -

Review Request 51289: Add unit tests for Log Search components and refactor them as needed - Vol 1

2016-08-22 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51289/ --- Review request for Ambari, Hayat Behlim, Dharmesh Makwana, Oliver Szabo, and

Re: Review Request 51288: Restarting services with stale configs failed while starting oozie server

2016-08-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51288/#review146351 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 22, 2016,

Review Request 51288: Restarting services with stale configs failed while starting oozie server

2016-08-22 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51288/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18228

Re: Review Request 51280: Ambari logo (and other images) missing in Chrome when SSL is enabled.

2016-08-22 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51280/#review146348 --- Ship it! Ship It! - Yusaku Sako On Aug. 22, 2016, 5:52

Review Request 51286: Remove Redundant Embedded Postgres SQL

2016-08-22 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51286/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18226

Re: Review Request 51241: RU: Storm components were stopped during RU and can not be started

2016-08-22 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51241/ --- (Updated Aug. 22, 2016, 3:43 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 51284: Remove Redundant Embedded Postgres SQL

2016-08-22 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51284/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18226

Re: Review Request 51282: Zeppelin service check fails after enabling SSL for Zeppelin

2016-08-22 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51282/#review146306 --- Ship it! Tested manually on CentOS, works well - Prabhjyot

Re: Review Request 51282: Zeppelin service check fails after enabling SSL for Zeppelin

2016-08-22 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51282/#review146304 --- Ship it! Ship It! - Rohit Choudhary On Aug. 22, 2016, 6:54

Review Request 51282: Zeppelin service check fails after enabling SSL for Zeppelin

2016-08-22 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51282/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar,