Re: Review Request 53722: AMBARI-18425:Support PAM as an authentication option for Ranger in Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53722/ --- (Updated Nov. 17, 2016, 7:47 a.m.) Review request for Ambari and Robert Levas.

Re: Review Request 53720: AMBARI-18870 Ranger PID file not being read if a custom location is provided

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53720/#review156174 --- Ship it! Ship It! - Gautam Borad On Nov. 14, 2016, 5:55 a.m.

Re: Review Request 53833: AMBARI-18916 - Manage JournalNodes Wizard: Text adjustments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53833/#review156165 --- Ship it! Ship It! - Xi Wang On Nov. 16, 2016, 5:54 p.m., Ric

Review Request 53833: AMBARI-18916 - Manage JournalNodes Wizard: Text adjustments

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53833/ --- Review request for Ambari and Xi Wang. Bugs: AMBARI-18916 https://issues.ap

Re: Review Request 53788: HTTP responses needs to have the character encoding specified in the content type header

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53788/#review156162 --- Ship it! Ship It! - Sangeeta Ravindran On Nov. 15, 2016, 10:

Re: Review Request 53821: Implement Create Alerts: Create a base wizard for all steps

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53821/#review156152 --- Ship it! Ship It! - Richard Zang On Nov. 16, 2016, 9:04 p.m.

Re: Review Request 53811: AMBARI-18907: Auto-start should respect maintenance mode on hosts and services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53811/ --- (Updated Nov. 16, 2016, 3:47 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53811: AMBARI-18907: Auto-start should respect maintenance mode on hosts and services

> On Nov. 16, 2016, 3:12 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/MaintenanceModeEvent.java, > > line 71 > > > > > > When would this ever be -1? You always have a c

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/#review156144 --- Ship it! Ship It! - Sid Wagle On Nov. 16, 2016, 11:17 p.m.,

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/ --- (Updated Nov. 16, 2016, 6:17 p.m.) Review request for Ambari, Nate Cole, Robert

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/ --- (Updated Nov. 16, 2016, 6:16 p.m.) Review request for Ambari, Nate Cole, Robert

Re: Review Request 53811: AMBARI-18907: Auto-start should respect maintenance mode on hosts and services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53811/#review156139 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 53811: AMBARI-18907: Auto-start should respect maintenance mode on hosts and services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53811/#review156129 --- Ship it! Ship It! - Sumit Mohanty On Nov. 16, 2016, 3:42 p.m

Re: Review Request 53824: Perf: Automate deployment of PERF stack on 2500+ Ambari Agents

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53824/#review156128 --- As v1 this looks good however, we should be porting this to make g

Re: Review Request 53824: Perf: Automate deployment of PERF stack on 2500+ Ambari Agents

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53824/#review156125 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 16, 2016, 10

Review Request 53824: Perf: Automate deployment of PERF stack on 2500+ Ambari Agents

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53824/ --- Review request for Ambari, Alejandro Fernandez and Sid Wagle. Bugs: AMBARI-1874

Re: Review Request 53808: AMBARI-18905 - Management pack purge option should support extensions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53808/#review156120 --- Ship it! Ship It! - Jayush Luniya On Nov. 16, 2016, 1:16 p.m

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

> On Nov. 16, 2016, 3:14 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java, > > line 489 > > > > > > Shouldn't the in-memory state be update after successful merge

Review Request 53821: Implement Create Alerts: Create a base wizard for all steps

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53821/ --- Review request for Ambari, Richard Zang and Yusaku Sako. Bugs: AMBARI-18903

Re: Review Request 53819: AMBARI-18911 : Storm start is failing due to metrics initialization error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53819/ --- (Updated Nov. 16, 2016, 8:48 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 53819: AMBARI-18911 : Storm start is failing due to metrics initialization error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53819/#review156114 --- Fix it, then Ship it! ambari-metrics/ambari-metrics-common/pom

Review Request 53819: AMBARI-18911 : Storm start is failing due to metrics initialization error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53819/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: AMBA

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/#review156113 --- ambari-server/src/main/java/org/apache/ambari/server/state/Config

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review156109 --- Ship it! Ship It! - Jonathan Hurley On Nov. 16, 2016, 2:39 p

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review156108 --- Ship it! Ship It! - Sumit Mohanty On Nov. 16, 2016, 7:39 p.m

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/ --- (Updated Nov. 16, 2016, 7:39 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/ --- (Updated Nov. 16, 2016, 2:35 p.m.) Review request for Ambari, Nate Cole, Robert

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/ --- (Updated Nov. 16, 2016, 2:34 p.m.) Review request for Ambari, Nate Cole, Robert

Re: Review Request 53816: SSL/TLS protocols should be explicitly enabled and then filtered when Ambari starts up

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53816/#review156105 --- Ship it! Ship It! - Robert Nettleton On Nov. 16, 2016, 6:47

Re: Review Request 53816: SSL/TLS protocols should be explicitly enabled and then filtered when Ambari starts up

> On Nov. 16, 2016, 1:49 p.m., Sumit Mohanty wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 772 > > > > > > Comment for later - should this list be configurabl

Re: Review Request 53816: SSL/TLS protocols should be explicitly enabled and then filtered when Ambari starts up

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53816/#review156102 --- ambari-server/src/main/java/org/apache/ambari/server/controller/A

Re: Review Request 53816: SSL/TLS protocols should be explicitly enabled and then filtered when Ambari starts up

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53816/#review156101 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 16, 2016, 6:

Review Request 53816: SSL/TLS protocols should be explicitly enabled and then filtered when Ambari starts up

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53816/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, Unla

Re: Review Request 53780: create separate RPM / DEB package for views during build process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53780/#review156097 --- Ship it! Ship It! - Pallav Kulshreshtha On Nov. 15, 2016, 11

Re: Review Request 53810: Oozie service check fails due to timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53810/#review156095 --- ambari-server/src/main/resources/common-services/MAHOUT/1.0.0.2.3

Re: Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53801/#review156094 --- ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/con

Re: Review Request 53815: Log Search - make logsearch rest api docs as default under /docs/ instead of petstore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53815/#review156091 --- Ship it! Ship It! - Robert Nettleton On Nov. 16, 2016, 5:58

Re: Review Request 53780: create separate RPM / DEB package for views during build process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53780/#review156088 --- contrib/views/wfmanager/pom.xml (line 249)

Review Request 53815: Log Search - make logsearch rest api docs as default under /docs/ instead of petstore

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53815/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs: AMBARI-18

Re: Review Request 52455: Ambari UI changes to support PAM authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/ --- (Updated Nov. 16, 2016, 5:29 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

> On Nov. 16, 2016, 10:40 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java, > > lines 281-309 > > > > > > There's rarely a case where we get configs without getti

Re: Review Request 53812: Ambari Kerberos Identity not displayed in the Configured Identities page of Enable Kerberos Wizard

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53812/#review156077 --- Ship it! Ship It! - Andrii Tkach On Nov. 16, 2016, 3:55 p.m.

Review Request 53812: Ambari Kerberos Identity not displayed in the Configured Identities page of Enable Kerberos Wizard

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53812/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-18908 https://issu

Review Request 53811: AMBARI-18907: Auto-start should respect maintenance mode on hosts and services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53811/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and

Review Request 53811: AMBARI-18907: Auto-start should respect maintenance mode on hosts and services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53811/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/#review156075 --- Ship it! Ship It! - Nate Cole On Nov. 16, 2016, 8:43 a.m., J

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/#review156074 --- ambari-server/src/main/java/org/apache/ambari/server/state/Config

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

> On Nov. 16, 2016, 8:43 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java, > > lines 281-309 > > > > > > This is one area I'd love feedback on. I left the d

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

> On Nov. 16, 2016, 10:24 a.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java, > > lines 281-309 > > > > > > If this is left as-is, wouldn't it be more efficient

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/#review156067 --- Fix it, then Ship it! ambari-server/src/main/java/org/apache/a

Re: Review Request 52455: Ambari UI changes to support PAM authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/ --- (Updated Nov. 16, 2016, 3:23 p.m.) Review request for Ambari, Alejandro Fernand

Re: Review Request 53810: Oozie service check fails due to timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53810/#review156066 --- Ship it! Ship It! - Sandor Magyari On Nov. 16, 2016, 2:12 p.

Re: Review Request 53810: Oozie service check fails due to timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53810/#review156064 --- Ship it! Ship It! - Attila Doroszlai On Nov. 16, 2016, 3:12

Re: Review Request 53810: Oozie service check fails due to timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53810/#review156063 --- Ship it! Ship It! - Laszlo Puskas On Nov. 16, 2016, 2:12 p.m

Re: Review Request 53810: Oozie service check fails due to timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53810/#review156062 --- Ship it! Ship It! - Sebastian Toader On Nov. 16, 2016, 3:12

Review Request 53810: Oozie service check fails due to timeout

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53810/ --- Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Sandor Magyari, and

Re: Review Request 53722: AMBARI-18425:Support PAM as an authentication option for Ranger in Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53722/#review156059 --- ambari-server/src/main/resources/common-services/RANGER/0.4.0/pac

Re: Review Request 53808: AMBARI-18905 - Management pack purge option should support extensions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53808/#review156061 --- Ship it! Ship It! - Di Li On Nov. 16, 2016, 1:16 p.m., Tim T

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/#review156057 --- ambari-server/src/main/java/org/apache/ambari/server/serveraction

Re: Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/ --- (Updated Nov. 16, 2016, 8:43 a.m.) Review request for Ambari, Nate Cole, Robert

Review Request 53809: Remove Unnecessary Locks Inside Of Config Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53809/ --- Review request for Ambari, Nate Cole, Robert Levas, Robert Nettleton, and Sid Wa

Review Request 53808: AMBARI-18905 - Management pack purge option should support extensions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53808/ --- Review request for Ambari, Di Li and Jayush Luniya. Bugs: AMBARI-18905 http

Re: Review Request 53798: AMBARI-18902 Minor typo fix in TimeliveMetricsStore class in AMS

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53798/#review156050 --- Ship it! Ship It! - Tim Thorpe On Nov. 15, 2016, 10:33 p.m.,

Review Request 53801: AMBARI-18901. Use 'Number of LLAP Nodes' selected as the driver for LLAP config calculations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53801/ --- Review request for Ambari, Alejandro Fernandez, Madhuvanthi Radhakrishnan, Sumit

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review156046 --- Ship it! Ship It! - Robert Levas On Nov. 14, 2016, 6:50 p.m.