Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-11-28 Thread Weiwei Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54121/ --- (Updated 十一月 29, 2016, 3:56 a.m.) Review request for Ambari and Di Li.

Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-11-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/ --- Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Sumit Mohanty,

Re: Review Request 54144: AMBARI-19005. 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

2016-11-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54144/#review157186 ---

Review Request 54144: AMBARI-19005. 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

2016-11-28 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54144/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin
> On 十一月 28, 2016, 4:56 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > lines 88-90 > > > > > > 255.255.255.255 - 15 characters. But this is still

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin
> On 十一月 28, 2016, 2:34 p.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > lines 88-90 > > > > > > Why is this needed and where the 15 comes from?

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- (Updated 十一月 29, 2016, 1:04 a.m.) Review request for Ambari, Alejandro

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread wang yaoxin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- (Updated 十一月 29, 2016, 12:57 a.m.) Review request for Ambari, Alejandro

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54086/#review157159 ---

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-28 Thread Di Li
> On Nov. 28, 2016, 9:42 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicePresenceCheck.java, > > lines 155-167 > > > > > > These exceptions all say the same thing

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-28 Thread Nate Cole
> On Nov. 28, 2016, 4:42 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicePresenceCheck.java, > > lines 131-137 > > > > > > Should not use CSV here. Actually, I see now

Re: Review Request 54140: Perf: Fix deploy-gce-perf-cluster.py to deploy separate server onto own cluster with different settings for more cores and MySQL DB

2016-11-28 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54140/#review157149 --- Ship it! Ship It! - Sid Wagle On Nov. 28, 2016, 9:55 p.m.,

Re: Review Request 54140: Perf: Fix deploy-gce-perf-cluster.py to deploy separate server onto own cluster with different settings for more cores and MySQL DB

2016-11-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54140/#review157147 --- contrib/utils/perf/deploy-gce-perf-cluster.py (line 215)

Review Request 54140: Perf: Fix deploy-gce-perf-cluster.py to deploy separate server onto own cluster with different settings for more cores and MySQL DB

2016-11-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54140/ --- Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, Sumit Mohanty, Sid

Re: Review Request 54028: AMBARI-18962:Make check_package_condition in script.py overridable by services in stacks

2016-11-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54028/#review157144 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 28, 2016,

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54086/#review157142 --- Please add an XML test that shows how to use this.

Re: Review Request 54028: AMBARI-18962:Make check_package_condition in script.py overridable by services in stacks

2016-11-28 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54028/#review157138 --- Ship it! Ship It! - Tim Thorpe On Nov. 28, 2016, 9:04 p.m.,

Re: Review Request 54028: AMBARI-18962:Make check_package_condition in script.py overridable by services in stacks

2016-11-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54028/ --- (Updated Nov. 28, 2016, 9:04 p.m.) Review request for Ambari, Andrew Onischuk

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-11-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review157126 ---

Review Request 54137: Ambari widgets and service checks to honor LLAP clusters with 100% allocation to LLAP daemons

2016-11-28 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54137/ --- Review request for Ambari, Aleksandr Kovalenko and Jaimin Jetly. Bugs:

Re: Review Request 54047: AMBARI-18980 Add manual confirm task before finalizing host-ordered upgrade

2016-11-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54047/#review157113 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 24, 2016,

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-11-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54121/#review157111 ---

Re: Review Request 54132: Support configurable grok filters (output + ambari)

2016-11-28 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54132/#review157094 --- Ship it! Ship It! - Robert Nettleton On Nov. 28, 2016, 5:12

Re: Review Request 54080: Preview: Auto-fix common issues found by the DB consistency checker

2016-11-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/#review157062 ---

Re: Review Request 54130: Unable to Start Multiple Flume Agents Due to Missing Import

2016-11-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54130/#review157063 --- Ship it! Ship It! - Nate Cole On Nov. 28, 2016, 11:29 a.m.,

Re: Review Request 54080: Preview: Auto-fix common issues found by the DB consistency checker

2016-11-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/#review157058 ---

Re: Review Request 53725: AMBARI-18834 Add Ranger proxy user under Ranger KMS config during stack upgrade

2016-11-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53725/#review157061 --- Ship it! Ship It! - Jonathan Hurley On Nov. 24, 2016, 2:16

Review Request 54132: Support configurable grok filters (output + ambari)

2016-11-28 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54132/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs:

Re: Review Request 54080: Preview: Auto-fix common issues found by the DB consistency checker

2016-11-28 Thread Dmitro Lisnichenko
> On Nov. 28, 2016, 7:11 p.m., Dmitro Lisnichenko wrote: > > Current patch preview contains: > > * Inconsistency for table hostcomponentdesiredstate and hostcomponentstate > > for stack upgrade (seems to work) > > * Schema name in postgres is not ambari (we print warnings for any DB type, > >

Re: Review Request 54080: Preview: Auto-fix common issues found by the DB consistency checker

2016-11-28 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/#review157059 --- Current patch preview contains: * Inconsistency for table

Re: Review Request 54080: Preview: Auto-fix common issues found by the DB consistency checker

2016-11-28 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/ --- (Updated Nov. 28, 2016, 7:10 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 54047: AMBARI-18980 Add manual confirm task before finalizing host-ordered upgrade

2016-11-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54047/#review157054 --- Ship it! Ship It! - Nate Cole On Nov. 23, 2016, 7:04 p.m.,

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157051 ---

Re: Review Request 54047: AMBARI-18980 Add manual confirm task before finalizing host-ordered upgrade

2016-11-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54047/#review157050 --- Ship it! Ship It! - Jonathan Hurley On Nov. 23, 2016, 7:04

Re: Review Request 54130: Unable to Start Multiple Flume Agents Due to Missing Import

2016-11-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54130/#review157046 --- Ship it! Ship It! - Robert Levas On Nov. 28, 2016, 11:29

Review Request 54130: Unable to Start Multiple Flume Agents Due to Missing Import

2016-11-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54130/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-18999

Re: Review Request 54131: Ambari-server fails to restart with --debug if it is already running

2016-11-28 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54131/#review157045 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 28, 2016,

Re: Review Request 54131: Ambari-server fails to restart with --debug if it is already running

2016-11-28 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54131/ --- (Updated Nov. 28, 2016, 4:25 p.m.) Review request for Ambari and Dmitro

Review Request 54131: Ambari-server fails to restart with --debug if it is already running

2016-11-28 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54131/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-19000

Re: Review Request 54079: Log level filter labels not getting updated with host name filter

2016-11-28 Thread Oliver Szabo
> On Nov. 28, 2016, 4:18 p.m., Robert Nettleton wrote: > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java, > > line 105 > > > > > > Minor question: > > > >

Re: Review Request 54079: Log level filter labels not getting updated with host name filter

2016-11-28 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54079/#review157042 --- Ship it! Patch looks fine to me, just a minor question below

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157043 --- Ship it! Ship It! - Robert Levas On Nov. 25, 2016, 4:46

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-11-28 Thread Weiwei Yang
> On 十一月 28, 2016, 3:51 p.m., Di Li wrote: > > Hello Wei Wei, > > > > Could you please add "AMBARI-18929" to the "Bugs:" field ? Sure, just added that. Thank you. - Weiwei --- This is an automatically generated e-mail. To reply,

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-11-28 Thread Weiwei Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54121/ --- (Updated 十一月 28, 2016, 3:55 p.m.) Review request for Ambari and Di Li. Bugs:

Re: Review Request 54127: Create smart config tab for Hive and Oozie Database settings

2016-11-28 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54127/#review157040 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 28, 2016,

Re: Review Request 54125: Abillity to enable SPNEGO on Log Search Portal UI from Ambari

2016-11-28 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54125/#review157038 --- Fix it, then Ship it! The patch looks fine to me overall.

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-11-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54121/#review157039 --- Hello Wei Wei, Could you please add "AMBARI-18929" to the

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-11-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54121/#review157036 --- Ship it! Ship It! - Di Li On Nov. 28, 2016, 12:59 p.m.,

Review Request 54127: Create smart config tab for Hive and Oozie Database settings

2016-11-28 Thread Denys Buzhor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54127/ --- Review request for Ambari and Alexandr Antonenko. Bugs: AMBARI-18998

Re: Review Request 54125: Abillity to enable SPNEGO on Log Search Portal UI from Ambari

2016-11-28 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54125/ --- (Updated Nov. 28, 2016, 2:36 p.m.) Review request for Ambari, Miklos Gergely

Re: Review Request 54125: Abillity to enable SPNEGO on Log Search Portal UI from Ambari

2016-11-28 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54125/ --- (Updated Nov. 28, 2016, 2:41 p.m.) Review request for Ambari, Miklos Gergely

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157029 --- Please add the results of the unit tests to the reviewboard.

Review Request 54125: Abillity to enable SPNEGO on Log Search Portal UI from Ambari

2016-11-28 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54125/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs:

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-28 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157027 --- Ship it! Ship It! - Oliver Szabo On Nov. 25, 2016, 9:46

Re: Review Request 54118: HBASE service check fails if run with tty=true

2016-11-28 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54118/#review157026 --- Ship it! Ship It! - Dmitro Lisnichenko On Nov. 28, 2016,

Review Request 54124: ambari-server.pid might not be created on slow harware

2016-11-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/ --- Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-28 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/ --- (Updated Ноя. 28, 2016, 1:57 п.п.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 54123: AMBARI-18992: Stack version input text field on Register Version page should align properly even when resizing the page

2016-11-28 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54123/#review157025 --- Ship it! Ship It! - Tim Thorpe On Nov. 28, 2016, 1:40 p.m.,

Re: Review Request 54123: AMBARI-18992: Stack version input text field on Register Version page should align properly even when resizing the page

2016-11-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54123/ --- (Updated Nov. 28, 2016, 1:40 p.m.) Review request for Ambari and Tim Thorpe.

Review Request 54123: AMBARI-18992: Stack version input text field on Register Version page should align properly even when resizing the page

2016-11-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54123/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-18992

Review Request 54122: AMBARI-18994 In HA cluster copy the hdfs-site.xml and hbase-site.xml to Ranger conf directory

2016-11-28 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54122/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Vishal Suvagia,

Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-11-28 Thread Weiwei Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54121/ --- Review request for Ambari and Di Li. Repository: ambari Description ---

Review Request 54118: HBASE service check fails if run with tty=true

2016-11-28 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54118/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-18995

Re: Review Request 54079: Log level filter labels not getting updated with host name filter

2016-11-28 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54079/#review157004 --- Ship it! Ship It! - Miklos Gergely On Nov. 25, 2016, 3:39