Review Request 54930: Remove Spark dependency from Zeppelin service def

2016-12-20 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54930/ --- Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush

Review Request 54922: Improve and Fix "Dashboard page" after new guidelines

2016-12-20 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54922/ --- Review request for Ambari, Jaimin Jetly, Vivek Ratnavel Subramanian, and Yusaku

Re: Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

2016-12-20 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54911/#review159782 --- Ship it! Ship It! - Alexandr Antonenko On Dec. 20, 2016,

Re: Review Request 54760: Add common log rotation settings to HDFS configs

2016-12-20 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54760/ --- (Updated Dec. 20, 2016, 9:59 p.m.) Review request for Ambari, Andrii Voloshyn

Re: Review Request 54912: When Updating An Alert Group a ConcurrentModificationException is Thrown

2016-12-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54912/ --- (Updated Dec. 20, 2016, 4:49 p.m.) Review request for Ambari, Nate Cole and

Re: Review Request 54760: Add common log rotation settings to HDFS configs

2016-12-20 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54760/#review159753 --- Ship it! Ship It! - Sumit Mohanty On Dec. 20, 2016, 9:21

Re: Review Request 54760: Add common log rotation settings to HDFS configs

2016-12-20 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54760/ --- (Updated Dec. 20, 2016, 9:21 p.m.) Review request for Ambari, Andrii Voloshyn

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/#review159748 --- This has been pushed to trunk. Please close the review. - Nate

Re: Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

2016-12-20 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54911/ --- (Updated Dec. 20, 2016, 8:53 p.m.) Review request for Ambari, Alexandr

Re: Review Request 54912: When Updating An Alert Group a ConcurrentModificationException is Thrown

2016-12-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54912/#review159746 --- Ship it! Ship It! - Robert Levas On Dec. 20, 2016, 3:19

Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

2016-12-20 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54911/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-19206

Re: Review Request 54912: When Updating An Alert Group a ConcurrentModificationException is Thrown

2016-12-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54912/#review159744 --- Ship it! Ship It! - Nate Cole On Dec. 20, 2016, 3:19 p.m.,

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Attila Doroszlai
> On Dec. 20, 2016, 7:31 p.m., Nate Cole wrote: > > I don't seem to be getting a clean merge with this diff. Yes, the change comitted in the meantime for AMBARI-19195 introduced conflict. - Attila --- This is an automatically generated

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/ --- (Updated Dec. 20, 2016, 9:26 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 54912: When Updating An Alert Group a ConcurrentModificationException is Thrown

2016-12-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54912/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-19259

Re: Review Request 54760: Add common log rotation settings to HDFS configs

2016-12-20 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54760/ --- (Updated Dec. 20, 2016, 8:16 p.m.) Review request for Ambari, Andrii Voloshyn

Re: Review Request 54908: AMBARI-19258 - Extension directories are not properly sync'd to agent nodes

2016-12-20 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54908/#review159741 --- Ship it! Ship It! - Di Li On Dec. 20, 2016, 5:51 p.m., Tim

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/#review159736 --- I don't seem to be getting a clean merge with this diff. - Nate

Re: Review Request 54900: Add permission for Service Auto Start

2016-12-20 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54900/#review159735 --- Ship it! Ship It! - Attila Magyar On Dec. 20, 2016, 5:02

Review Request 54908: AMBARI-19258 - Extension directories are not properly sync'd to agent nodes

2016-12-20 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54908/ --- Review request for Ambari, Di Li, Jayush Luniya, and Sumit Mohanty. Bugs:

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/#review159733 --- Ship it! Ship It! - Jonathan Hurley On Dec. 20, 2016, 11:55

Re: Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/#review159730 --- Ship it!

Re: Review Request 54900: Add permission for Service Auto Start

2016-12-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54900/ --- (Updated Dec. 20, 2016, 12:02 p.m.) Review request for Ambari, Attila Magyar,

Review Request 54904: AMBARI-19149. Code cleanup: apply checks to test sources, too

2016-12-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54904/ --- Review request for Ambari, Jonathan Hurley, Laszlo Puskas, and Nate Cole.

Re: Review Request 54900: Add permission for Service Auto Start

2016-12-20 Thread Attila Magyar
> On Dec. 20, 2016, 4:19 p.m., Attila Magyar wrote: > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java, > > line 538 > > > > > > Do we really need to specify how many times

Re: Review Request 54864: AMBARI-19225 Ambari server should prints error messages to its log if it can't find property for given property attribute type

2016-12-20 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54864/ --- (Updated Dec. 20, 2016, 4:49 p.m.) Review request for Ambari and Tim Thorpe.

Re: Review Request 54900: Add permission for Service Auto Start

2016-12-20 Thread Robert Levas
> On Dec. 20, 2016, 11:19 a.m., Attila Magyar wrote: > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java, > > line 538 > > > > > > Do we really need to specify how many times

Review Request 54903: BE changes needed for SNMP Ambari MIB support

2016-12-20 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54903/ --- Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.

Re: Review Request 54902: AMBARI-19247 Add log to stack_select for details on which role to get version info

2016-12-20 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54902/#review159725 --- Ship it! Ship It! - Tim Thorpe On Dec. 20, 2016, 4:10 p.m.,

Re: Review Request 54900: Add permission for Service Auto Start

2016-12-20 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54900/#review159723 ---

Re: Review Request 54900: Add permission for Service Auto Start

2016-12-20 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54900/#review159721 --- Ship it! Ship It! - Eugene Chekanskiy On Dec. 20, 2016,

Re: Review Request 54874: AMBARI-19241 - Ambari python scripts should support hdfs download

2016-12-20 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54874/#review159720 --- Ship it! Ship It! - Di Li On Dec. 19, 2016, 9:24 p.m., Tim

Re: Review Request 54900: Add permission for Service Auto Start

2016-12-20 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54900/#review159719 --- Ship it! Ship It! - Jonathan Hurley On Dec. 20, 2016, 10:16

Re: Review Request 54900: Add permission for Service Auto Start

2016-12-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54900/#review159718 ---

Review Request 54900: Add permission for Service Auto Start

2016-12-20 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54900/ --- Review request for Ambari, Attila Magyar, Eugene Chekanskiy, Jonathan Hurley,

Re: Review Request 54891: Create quick links profile evaluator

2016-12-20 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54891/#review159704 --- Fix it, then Ship it!

Re: Review Request 54817: AMBARI-19227 :: Provide support to show Ranger solr-configs in Ambari.

2016-12-20 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54817/#review159716 --- Ship it! Ship It! - Mugdha Varadkar On Dec. 19, 2016, 4:14

Re: Review Request 54895: AMBARI-19256:Asset support Rest API

2016-12-20 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54895/ --- (Updated Dec. 20, 2016, 1:25 p.m.) Review request for Ambari, Gaurav Nagar,

Review Request 54895: AMBARI-19256:Asset support Rest API

2016-12-20 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54895/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav

Review Request 54892: AMBARI-19254 : Prompting for underlying workflow job properties in a coordinator and coordinator job properties in a bundle during job submission

2016-12-20 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54892/ --- Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav

Review Request 54891: Create quick links profile evaluator

2016-12-20 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54891/ --- Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor

Re: Review Request 54890: Ambari Agent start fails with local variable 'server_url' referenced before assignment

2016-12-20 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54890/#review159701 --- Ship it! Ship It! - Vitalyi Brodetskyi On Гру. 20, 2016,

Review Request 54890: Ambari Agent start fails with local variable 'server_url' referenced before assignment

2016-12-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54890/ --- Review request for Ambari and Dmitro Lisnichenko. Bugs: AMBARI-19246

Review Request 54888: Ambari capacity queue manager only accepts values in integers i.e not decimal values like 0.5

2016-12-20 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54888/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav

Re: Review Request 54809: AMBARI-19221:Preview xml feature is not functional across different tabs

2016-12-20 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54809/#review159693 --- Ship it! Ship It! - Nitiraj Rathore On Dec. 16, 2016, 10:54

Re: Review Request 54809: AMBARI-19221:Preview xml feature is not functional across different tabs

2016-12-20 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54809/#review159689 --- Ship it! Ship It! - Pallav Kulshreshtha On Dec. 16, 2016,