Re: Review Request 61376: AMBARI-21635 Show Audit to DB removal pre-check message during cross stack upgrade

2017-08-02 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61376/ --- (Updated Aug. 3, 2017, 5:09 a.m.) Review request for Ambari, Alejandro

Review Request 61396: Annotate upgrade packs for scope

2017-08-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61396/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-21643

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61283/#review182057 --- Ship it! Ship It! - Jonathan Hurley On Aug. 2, 2017, 9:06

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61283/ --- (Updated Aug. 3, 2017, 1:06 a.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61283/#review182053 ---

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Alejandro Fernandez
> On Aug. 2, 2017, 11:44 a.m., Tim Thorpe wrote: > > Are these needed in BigInsights 4.2.5 as well? > > Alejandro Fernandez wrote: > EU from BigInsights 4.2 to 4.2.5 already fixed most/all of these > properties already. I can still include it in 4.2.5 just to be safe. - Alejandro

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Alejandro Fernandez
> On Aug. 2, 2017, 11:44 a.m., Tim Thorpe wrote: > > Are these needed in BigInsights 4.2.5 as well? EU from BigInsights 4.2 to 4.2.5 already fixed most/all of these properties already. - Alejandro --- This is an automatically

Re: Review Request 61317: Configs For Target Stack Are Not Created During Upgrade

2017-08-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61317/#review182035 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 2, 2017,

Re: Review Request 61386: AMBARI-21640 : Certain templated Grafana dashboards not showing data.

2017-08-02 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61386/#review182033 --- Ship it! Ship It! - Sid Wagle On Aug. 2, 2017, 8:20 p.m.,

Review Request 61386: AMBARI-21640 : Certain templated Grafana dashboards not showing data.

2017-08-02 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61386/ --- Review request for Ambari, Vivek Ratnavel Subramanian and Yusaku Sako. Bugs:

Re: Review Request 61381: When Adding a New Service the Repository ID is Required

2017-08-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61381/ --- (Updated Aug. 2, 2017, 3:26 p.m.) Review request for Ambari, Dmitro

Re: Review Request 61376: AMBARI-21635 Show Audit to DB removal pre-check message during cross stack upgrade

2017-08-02 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61376/#review182024 --- Ship it! Ship It! - Alejandro Fernandez On Aug. 2, 2017,

Re: Review Request 61377: Hive CLI does not work after upgrade

2017-08-02 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61377/ --- (Updated Aug. 2, 2017, 8:30 p.m.) Review request for Ambari, Alejandro

Re: Review Request 61381: When Adding a New Service the Repository ID is Required

2017-08-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61381/ --- (Updated Aug. 2, 2017, 2:25 p.m.) Review request for Ambari, Dmitro

Re: Review Request 61381: When Adding a New Service the Repository ID is Required

2017-08-02 Thread Nate Cole
> On Aug. 2, 2017, 2:07 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > > Lines 1082 (patched) > > > > > > Should we do the

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-02 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/#review182016 --- Fix it, then Ship it! This looks great! Thanks for making

Re: Review Request 61381: When Adding a New Service the Repository ID is Required

2017-08-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61381/#review182017 --- Fix it, then Ship it!

Review Request 61381: When Adding a New Service the Repository ID is Required

2017-08-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61381/ --- Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. Bugs:

Re: Review Request 61273: Do not call refreshnodes command after deleting a slave

2017-08-02 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61273/#review182009 --- Ship it! Ship It! - Sid Wagle On Aug. 2, 2017, 3:08 p.m.,

Re: Review Request 61273: Do not call refreshnodes command after deleting a slave

2017-08-02 Thread Dmytro Sen
> On Aug. 2, 2017, 5:10 p.m., Sid Wagle wrote: > > ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py > > Line 248 (original), 248 (patched) > > > > > > The description

Re: Review Request 61273: Do not call refreshnodes command after deleting a slave

2017-08-02 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61273/#review182003 ---

Re: Review Request 61273: Do not call refreshnodes command after deleting a slave

2017-08-02 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61273/ --- (Updated Aug. 2, 2017, 3:08 p.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 61377: Hive CLI does not work after upgrade

2017-08-02 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61377/#review181992 ---

Re: Review Request 61377: Hive CLI does not work after upgrade

2017-08-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61377/#review181991 --- Ship it! Ship It! - Di Li On Aug. 2, 2017, 1:21 p.m.,

Re: Review Request 61377: Hive CLI does not work after upgrade

2017-08-02 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61377/#review181990 --- Ship it! Ship It! - Tim Thorpe On Aug. 2, 2017, 1:21 p.m.,

Re: Review Request 61277: Log Search Config should be separated into a Server and Log Feeder interface

2017-08-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61277/#review181989 --- Ship it! Ship It! - Robert Nettleton On Aug. 2, 2017, 11:05

Re: Review Request 61197: Log Feeder properties should be handled by one class

2017-08-02 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61197/#review181987 --- Ship it! Ship It! - Robert Nettleton On Aug. 2, 2017, 11:11

Re: Review Request 61377: Hive CLI does not work after upgrade

2017-08-02 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61377/#review181988 --- Ship it! Ship It! - Sumit Mohanty On Aug. 2, 2017, 1:21

Review Request 61377: Hive CLI does not work after upgrade

2017-08-02 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61377/ --- Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, Sumit

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/#review181983 --- Ship it! Ship It! - Di Li On Aug. 2, 2017, 1:12 p.m.,

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/#review181982 --- Ship it! Ship It! - Tim Thorpe On Aug. 2, 2017, 1:12 p.m.,

Re: Review Request 61317: Configs For Target Stack Are Not Created During Upgrade

2017-08-02 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61317/#review181980 --- Ship it! Ship It! - Dmitro Lisnichenko On Aug. 2, 2017,

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/ --- (Updated Aug. 2, 2017, 3:12 p.m.) Review request for Ambari, Di Li, Sid Wagle,

Re: Review Request 61317: Configs For Target Stack Are Not Created During Upgrade

2017-08-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61317/#review181975 --- Ship it! Ship It! - Nate Cole On Aug. 1, 2017, 8:32 p.m.,

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/#review181974 ---

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/#review181973 --- Ship it! Ship It! - Di Li On Aug. 2, 2017, 9:13 a.m.,

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/#review181972 --- Ship it! Ship It! - Sebastian Toader On Aug. 2, 2017, 1:59

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61283/#review181971 ---

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61283/#review181970 ---

Re: Review Request 61276: Replace Hard Coded conf-select Structures

2017-08-02 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61276/#review181969 --- Ship it! Ship It! - Nate Cole On Aug. 1, 2017, 10:09 a.m.,

Re: Review Request 61251: Dynamically determine what keytab files have been distributed

2017-08-02 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61251/ --- (Updated Aug. 2, 2017, 11:59 a.m.) Review request for Ambari, Balázs Bence

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/#review181965 --- Ship it! Ship It! - Tim Thorpe On Aug. 2, 2017, 9:13 a.m.,

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61283/#review181964 --- Ship it! Are these needed in BigInsights 4.2.5 as well? - Tim

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/#review181963 ---

Re: Review Request 61197: Log Feeder properties should be handled by one class

2017-08-02 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61197/ --- (Updated Aug. 2, 2017, 11:11 a.m.) Review request for Ambari, Oliver Szabo and

Re: Review Request 61277: Log Search Config should be separated into a Server and Log Feeder interface

2017-08-02 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61277/ --- (Updated Aug. 2, 2017, 11:05 a.m.) Review request for Ambari, Oliver Szabo and

Review Request 61376: AMBARI-21635 Show Audit to DB removal pre-check message during cross stack upgrade

2017-08-02 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61376/ --- Review request for Ambari, Alejandro Fernandez and Gautam Borad. Bugs:

Re: Review Request 61373: Alerts list not sorted by status even though header displayed as sorted

2017-08-02 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61373/#review181953 --- Ship it! Ship It! - Oleg Nechiporenko On Aug. 2, 2017, 9:20

Review Request 61373: Alerts list not sorted by status even though header displayed as sorted

2017-08-02 Thread Andrii Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61373/ --- Review request for Ambari and Oleg Nechiporenko. Bugs: AMBARI-21632

Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/ --- Review request for Ambari, Di Li, Sid Wagle, and Tim Thorpe. Bugs:

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-08-02 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61201/ --- (Updated Aug. 2, 2017, 8:26 a.m.) Review request for Ambari, Jayush Luniya and

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

2017-08-02 Thread Swapan Shridhar
> On Aug. 1, 2017, 5:51 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > > Lines 234 (patched) > > > > > > Shouldn't this be