Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review131962 --- Ship it! Ship It! - Jayush Luniya On May 5, 2016, 2:50

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On May 4, 2016, 2:37 p.m., Matt wrote: > > We have tested the following changes: > > - The logic for stack_advisor which was pulled into service_advisor works > > well. > > - Inheritance between stacks works well. We tested inheritance from > > common-services into stack 2.3, and then

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On May 4, 2016, 9:37 p.m., Matt wrote: > > We have tested the following changes: > > - The logic for stack_advisor which was pulled into service_advisor works > > well. > > - Inheritance between stacks works well. We tested inheritance from > > common-services into stack 2.3, and then

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated May 5, 2016, 2:50 p.m.) Review request for Ambari, Alexander

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review131747 --- Ship it! We have tested the following changes: - The logic for

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On May 3, 2016, 4:09 p.m., Matt wrote: > > The functionality of ServiceAdvisor works as expected. However more > > clarification is needed on how to use inheritance and override service > > advisor defined in common-services. > > For example: > > HAWQ200ServiceAdvisor is defined under

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated May 4, 2016, 2:17 p.m.) Review request for Ambari, Alexander

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On May 3, 2016, 11:09 p.m., Matt wrote: > > The functionality of ServiceAdvisor works as expected. However more > > clarification is needed on how to use inheritance and override service > > advisor defined in common-services. > > For example: > > HAWQ200ServiceAdvisor is defined under

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On May 3, 2016, 11:09 p.m., Matt wrote: > > The functionality of ServiceAdvisor works as expected. However more > > clarification is needed on how to use inheritance and override service > > advisor defined in common-services. > > For example: > > HAWQ200ServiceAdvisor is defined under

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review131579 --- The functionality of ServiceAdvisor works as expected. However

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated May 3, 2016, 7:04 p.m.) Review request for Ambari, Alexander

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On May 2, 2016, 11:07 p.m., Lav Jain wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 644 > > > > > > This method is not being called because the corresponding method in > > 2.0.6 stack

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On May 2, 2016, 11:07 p.m., Lav Jain wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 644 > > > > > > This method is not being called because the corresponding method in > > 2.0.6 stack

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated May 3, 2016, 2:21 p.m.) Review request for Ambari, Alexander

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On May 2, 2016, 11:07 p.m., Lav Jain wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 644 > > > > > > This method is not being called because the corresponding method in > > 2.0.6 stack

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 29, 2016, 12:12 a.m., Alexander Denissov wrote: > > Do we have a branch cut with these changes in so that we can test HAWQ and > > PXF with this new logic ? After testing the branch can be merged to trunk > > and we will avoid any major surprises. > > Tim Thorpe wrote: > There

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 29, 2016, 12:12 a.m., Alexander Denissov wrote: > > Do we have a branch cut with these changes in so that we can test HAWQ and > > PXF with this new logic ? After testing the branch can be merged to trunk > > and we will avoid any major surprises. > > Tim Thorpe wrote: > There

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 29, 2016, 12:12 a.m., Alexander Denissov wrote: > > Do we have a branch cut with these changes in so that we can test HAWQ and > > PXF with this new logic ? After testing the branch can be merged to trunk > > and we will avoid any major surprises. > > Tim Thorpe wrote: > There

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated April 29, 2016, 8:11 p.m.) Review request for Ambari, Alexander

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 29, 2016, 12:11 a.m., Alexander Denissov wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java, > > line 56 > > > > > > should we not have a convention at all

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 28, 2016, 10:54 p.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 110 > > > > > > if we make isLocalHost utility function

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 28, 2016, 10:54 p.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 110 > > > > > > if we make isLocalHost utility function

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 29, 2016, 12:11 a.m., Alexander Denissov wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java, > > line 56 > > > > > > should we not have a convention at all

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review131020 --- Do we have a branch cut with these changes in so that we can test

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review131009 ---

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review131002 ---

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 28, 2016, 7:12 p.m., Jayush Luniya wrote: > > Ship It! Thanks @Tim for your contribution. - Jayush --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130977

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130977 --- Ship it! Ship It! - Jayush Luniya On April 28, 2016, 4:36

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated April 28, 2016, 4:34 p.m.) Review request for Ambari, Alexander

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 11:19 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 118 > > > > > > There is some additional logic for HAWQ mentioned in > >

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 11:19 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 118 > > > > > > There is some additional logic for HAWQ mentioned in > >

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 11:19 p.m., Matt wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 44 > > > > > > *return componentName in ('HAWQMASTER', 'HAWQSTANDBY')* That

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote: > > > > Alexander Denissov wrote: > So, what will be the rules for SA logic inheritance ? > > When MYSERVICE/2.0.0 ships and needs to reuse the stack_advisor logic > from MYSERVICE/1.0.0 -- will we: > - rely on stack

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote: > > > > Alexander Denissov wrote: > So, what will be the rules for SA logic inheritance ? > > When MYSERVICE/2.0.0 ships and needs to reuse the stack_advisor logic > from MYSERVICE/1.0.0 -- will we: > - rely on stack

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote: > > So, what will be the rules for SA logic inheritance ? When MYSERVICE/2.0.0 ships and needs to reuse the stack_advisor logic from MYSERVICE/1.0.0 -- will we: - rely on stack inheritance ? - rely on SA inheritance within MYSERVICE ? -

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java, > > line 77 > > > > > > Trying to think

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java, > > line 77 > > > > > > Trying to think

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py, > > line 31 > > > > > > Lets say we have > >

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:58 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 473 > > > > > > I might be missing something, but it doesnt look like we are using > >

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:18 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 19 > > > > > > Please add Pivotal folks to the review to look at

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:33 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 522 > > > > > > loadServiceAdvisor() instead? > > Tim Thorpe wrote: > If I follow the

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 6:15 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py, > > line 31 > > > > > > Lets say we have > >

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130141 ---

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:33 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py, line 522 > > > > > > loadServiceAdvisor() instead? If I follow the tradition of the

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java, > > line 77 > > > > > > Trying to think

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:18 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 19 > > > > > > Please add Pivotal folks to the review to look at

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 22, 2016, 5:15 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/service_advisor.py, line 24 > > > > > > Add documentation for all functions here. I will make sure I document all the

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130131 --- ambari-server/src/main/resources/stacks/stack_advisor.py (line

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130126 ---

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130124 --- ambari-server/src/main/resources/stacks/service_advisor.py (line

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated April 22, 2016, 4:39 p.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On March 2, 2016, 9:37 p.m., jun aoki wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/service_advisor_HDP206HBASE.py, > > line 32 > > > > > > Could this inheritate a brand new

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On March 2, 2016, 9:37 p.m., jun aoki wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/service_advisor_HDP206HBASE.py, > > line 32 > > > > > > Could this inheritate a brand new

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On March 2, 2016, 1:37 p.m., jun aoki wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/service_advisor_HDP206HBASE.py, > > line 32 > > > > > > Could this inheritate a brand new

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On March 2, 2016, 6:58 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/default_stack_advisor.py, line 35 > > > > > > Please include Srimanth Gunturi in the code review, thanks! > >

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/ --- (Updated April 12, 2016, 5:33 p.m.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 5, 2016, 7:53 p.m., Srimanth Gunturi wrote: > > Tim, thanks for contributing to the stack-advisor feature. > > > > When we started the stack-advisor feature, there was a lot of interconnect > > between base service component-layout and configurations (HDFS, YARN, > > MapReduce,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On April 5, 2016, 5:32 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/GANGLIA/service_advisor_BIGTOP08GANGLIA.py, > > line 1 > > > > > > Naming each service_advisor

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On March 2, 2016, 4:56 a.m., Matt wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py, > > line 1 > > > > > > If I were to add HAWQ 2.0.0's metainfo.xml under HDP 2.3 stack,

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review127148 ---

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review127144 --- I dont think we should go down the route of breaking up the

Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services

> On March 2, 2016, 6:58 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/default_stack_advisor.py, line 35 > > > > > > Please include Srimanth Gunturi in the code review, thanks! +1 on