Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-21 Thread Andrew Onischuk
> On April 21, 2016, 12:25 a.m., Masahiro Tanaka wrote: > > Thanks for the review Nate and Andrew! > > Could you commit this? before we can commit we need an apache jira for this change, and +1 from Hadoop QA. Do you have one? If yes specify its id in "Bugs" field here. - Andrew

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-20 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129845 --- Thanks for the review Nate and Andrew! Could you commit this? -

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-20 Thread Masahiro Tanaka
> On 4月 20, 2016, 1:17 p.m., Nate Cole wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py, > > lines 117-119 > > > > > > Given how many things get

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-20 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129732 --- Ship it!

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-20 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review129700 --- Could anyone review this? - Masahiro Tanaka On 4月 16, 2016,

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-16 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/ --- (Updated April 16, 2016, 7:02 p.m.) Review request for Ambari, Andrew

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-11 Thread Masahiro Tanaka
> On April 11, 2016, 4:21 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh, > > line 84 > > > > > > I wonder where this $destdir

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-10 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review128064 ---

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-10 Thread Andrew Onischuk
> On April 11, 2016, 4:21 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh, > > line 84 > > > > > > I wonder where this $destdir

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-10 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45998/#review128062 ---