Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
> On June 6, 2016, 2:04 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > lines 664-666 > > > > > > I know this isn't a part of your change - but can

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48287/#review136347 --- Ship it! Ship It! - Nate Cole On June 6, 2016, 1:20 p.m.,

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Dmytro Grinenko
> On June 6, 2016, 6:04 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/script/script.py, > > lines 664-666 > > > > > > I know this isn't a part of your change - but can

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Dmytro Grinenko
> On June 6, 2016, 5:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? > > Jonathan Hurley wrote: > Same - only 2 changes and they are for logging. > > Dmytro Grinenko wrote: > no, as you can see, self.status(env)

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
> On June 6, 2016, 1:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? > > Jonathan Hurley wrote: > Same - only 2 changes and they are for logging. > > Dmytro Grinenko wrote: > no, as you can see, self.status(env)

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Jonathan Hurley
> On June 6, 2016, 1:31 p.m., Nate Cole wrote: > > I only see two changes here, and it's just logging. Was there some missed > > files? Same - only 2 changes and they are for logging. - Jonathan --- This is an automatically generated

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48287/#review136319 --- I only see two changes here, and it's just logging. Was there

Re: Review Request 48287: RU failed because of old service was not stopped

2016-06-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48287/ --- (Updated June 6, 2016, 8:20 p.m.) Review request for Ambari, Jonathan Hurley