Re: Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart

2016-10-12 Thread Sreenath Somarajapuram 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52688/#review152284
---




contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 79)


Need not bind, can pass this as the second argument of forEach.



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
 (line 81)


forEach accepts this as second argument.



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
 (line 120)


Why is this conditional operator required?



contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
 (line 252)


Is this conditional operator required?


- Sreenath Somarajapuram


On Oct. 10, 2016, 12:53 p.m., Akhil PB wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52688/
> ---
> 
> (Updated Oct. 10, 2016, 12:53 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and 
> Sreenath Somarajapuram.
> 
> 
> Bugs: AMBARI-18561
> https://issues.apache.org/jira/browse/AMBARI-18561
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Calculating absolute capacity for node labels
> Render sunburst chart based on node label capacity when selected
> Read-only mode for non-operator users in preemption and queue mappings
> Bug fixes
> 
> 
> Diffs
> -
> 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js
>  032b2ec 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js
>  1d07351 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js
>  d5b19ae 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js
>  af15fa5 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js
>  631edbb 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js
>  9d84704 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js
>  e7fba41 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js
>  aa139b1 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 
> e2d67bd 
>   contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 
> d838958 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less
>  1ab1740 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs
>  9973708 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs
>  6d398f6 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs
>  8fe627e 
>   
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs
>  f143911 
> 
> Diff: https://reviews.apache.org/r/52688/diff/
> 
> 
> Testing
> ---
> 
> Manual Unit Testing
> 
> 
> Thanks,
> 
> Akhil PB
> 
>

Re: Review Request 52749: Ambari should be able to create arbitrary Kerberos identities for itself as declared in the Kerberos Descriptor

2016-10-12 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52749/
---

(Updated Oct. 12, 2016, 4:59 a.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and 
Sandor Magyari.


Bugs: AMBARI-18564
https://issues.apache.org/jira/browse/AMBARI-18564


Repository: ambari


Description
---

Ambari should be able to create arbitrary Kerberos identities for itself as 
declared in the Kerberos Descriptor.

Currently, Ambari is hard-coded to create identities for itself and SPNEGO, but 
that may not be good enough for all scenarios. Therefore, there needs to be an 
`AMBARI` service block in the Kerberos descriptor to allow for arbitrary 
identities to be defined for the Ambari server - similar to how any other 
service  is defined in the Kerberos descriptor.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java
 1153d01 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 e15965b 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 c283a65 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ConfigureAmbariIdentitiesServerAction.java
 80acd0d 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/kerberos.json 0644f57 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 b2eb738 

Diff: https://reviews.apache.org/r/52749/diff/


Testing (updated)
---

Manually tested using the UI and BP ont he trunk and brach-2.5

# Jenkins test results: 

```
+1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12832740/AMBARI-18564_trunk_01.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/8847//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/8847//console
```


Thanks,

Robert Levas

Re: Review Request 51724: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2016-10-12 Thread Dmytro Sen 


> On Сен. 22, 2016, 7:54 п.п., Robert Levas wrote:
> > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py,
> >  line 33
> > 
> >
> > See `curl_krb_request`

I think, we don't want to do a separate HTTP connection for every call, now 
metrics monitor use the same cached connection + only GET is implemented in 
current curl_krb_request, we need POST for emmitting metrics.


- Dmytro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51724/#review150057
---


On Сен. 22, 2016, 12:44 п.п., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51724/
> ---
> 
> (Updated Сен. 22, 2016, 12:44 п.п.)
> 
> 
> Review request for Ambari, Di Li, Dmytro Sen, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17898
> https://issues.apache.org/jira/browse/AMBARI-17898
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ()This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> 
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector (in AMS distributed mode) web-console will be Kerberos HTTP 
> SPNEGO enabled too. But Ambari Metrics Monitor, a client of Ambari Metrics 
> Collector, currently does not support Kerberos HTTP SPNEGO authentication.
> 
> /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
> 2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
> http://metrics-collector:6188/ws/v1/timeline/metrics
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
> server. HTTP Error 401: Authentication required
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml d73a0af 
>   ambari-metrics/ambari-metrics-host-monitoring/conf/unix/metric_monitor.ini 
> e98c65c 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  3ca3a31 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/faked_kerberos.py
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/kerberos.json
>  51f541f 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py
>  6934924 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metric_monitor.ini.j2
>  3823912 
> 
> Diff: https://reviews.apache.org/r/51724/diff/
> 
> 
> Testing
> ---
> 
> 1. passed existing unittest cases.
> 2. manually tested with HDP-2.5.0.0/trunk 
>1) Non http spnego enabled clusters
>2) http spnego enabled cluster - tested the trunk's monitor code against a 
> http spnego enabled cluster 
>   http spnego enabled cluster is currently broken in trunk: the 
> distributed metrics collector's http server currently will not started with 
> http spnego enabled. so I had to manually test the trunk's monitor code with 
> http spnego enabled collector on a branch2.4 cluster. Need to mention that 
> the testing should be valid because the code change area is monitor code and 
> the trunk and branch2.4's collectors are same.
> 
> 
> Thanks,
> 
> Qin Liu
> 
>

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52183/#review152301
---



I can't really comment on the front-end work since that's not an area I'm 
familiar with. However, I do believe there are Jiras scoping a new "wizard" 
workflow for alerts in Ambari 3.0 which this may impact.

- Jonathan Hurley


On Sept. 22, 2016, 10:24 p.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52183/
> ---
> 
> (Updated Sept. 22, 2016, 10:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Zhe (Joe) Wang, and Oleg Tikhonov.
> 
> 
> Bugs: AMBARI-18423
> https://issues.apache.org/jira/browse/AMBARI-18423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari now only support creating/editing alert notifications of type 
> EMAIL/SNMP in web client.
> This patch aims to support another notification type  ALERT_SCRIPT
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  10a7918 
>   ambari-web/app/messages.js 2c819e5 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs a248e57 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  a0a4ce4 
> 
> Diff: https://reviews.apache.org/r/52183/diff/
> 
> 
> Testing
> ---
> 
> ambari-web/mvn test
> 
> 
> 30365 tests complete (43 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 52752: Hive shows restart indicator after RU

2016-10-12 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52752/#review152304
---


Ship it!




Ship It!

- Jonathan Hurley


On Oct. 11, 2016, 5:13 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52752/
> ---
> 
> (Updated Oct. 11, 2016, 5:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-18568
> https://issues.apache.org/jira/browse/AMBARI-18568
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *Only for HDP-2.5"
> 
> Move METASTORE to after HIVE_SERVER to make sure the configs are picked up.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 88d9b13 
> 
> Diff: https://reviews.apache.org/r/52752/diff/
> 
> 
> Testing
> ---
> 
> Manually tested RU for HDP-2.5.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 52785: Fix problem on Suse for ambari-agent installation

2016-10-12 Thread Zsombor Gegesy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/
---

Review request for Ambari.


Bugs: AMBARI-18577
https://issues.apache.org/jira/browse/AMBARI-18577


Repository: ambari


Description
---

Add "--non-interactive" flag to zypper invocations in setupAgent


Diffs
-

  ambari-server/src/main/python/setupAgent.py 9a1cae9 

Diff: https://reviews.apache.org/r/52785/diff/


Testing
---


Thanks,

Zsombor Gegesy

Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

2016-10-12 Thread Jonathan Hurley 


> On Oct. 11, 2016, 9:28 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java,
> >  line 45
> > 
> >
> > Why is exists query appropiate here, instead of stageId IN ??

I don't think you can use an IN instead of EXISTS here simply because that 
would require the DB processor to query the entire stage table first, no?

I do think you should move the `roleCommand.requestId = stage.requestId` to the 
first part of the WHERE in case some databases don't optimize this query.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52758/#review152247
---


On Oct. 11, 2016, 7:48 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52758/
> ---
> 
> (Updated Oct. 11, 2016, 7:48 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18576
> https://issues.apache.org/jira/browse/AMBARI-18576
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> * Install Ambari 2.4.0.1 with any HDP stack (e.g., 2.5) and HDFS, YARN, ZK
> * Run multiple commands in parallel (such as service checks)
> * Attempt to abort any one of them
> 
> Instead of aborting just the desired one, it will abort all requests.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
>  0e78cbc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  c31ca7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  e380ae4 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
> 8ef4a1b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  7659a23 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
>  9f12a94 
> 
> Diff: https://reviews.apache.org/r/52758/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster.
> Waiting for unit test results.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-12 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52757/#review152307
---


Ship it!




Ship It!

- Sumit Mohanty


On Oct. 11, 2016, 11:17 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52757/
> ---
> 
> (Updated Oct. 11, 2016, 11:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18575
> https://issues.apache.org/jira/browse/AMBARI-18575
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue: 
> 
> **Current time taken:**
> ==
> 
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.upgrade.UpgradeCatalog221Test   |13|36.586|
> |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|
> 
> 
> **Individual tests time taken is as follows:**
> ==
> 
> **UpgradeCatalog221Test:**
> 
> - init() function takes most of the time.
> 
> ||Test No.||Test||Time (micro secs)||
> | |init()|10197|
> |1|testUpdateAmsHbaseSiteConfigs| 198|
> | |init()|3140|
> |2|testExecuteDDLUpdates| 17|
> | |init()|2377|
> |3|test_AddCheckCommandTimeoutParam_ParamsNotAvailable| 6|
> | |init()|2396|
> |4|testExecuteDMLUpdates| 18|
> | |init()|2203|
> |5|testUpdateTezConfigs| 11|
> | |init()|2011|
> |6|testUpdateAmsHbaseEnvContent| 0|
> | |init()|1953|
> |7|test_AddCheckCommandTimeoutParam_NeededParamAlreadyAdded| 0|
> | |init()|1882|
> |8|testUpdateOozieConfigs| 2|
> | |init()|1871|
> |9|testUpdateAmsEnvContent| 0|
> | |init()|1801|
> |10|testUpdateRangerKmsDbksConfigs| 2|
> | |init()|1735|
> |11|test_AddCheckCommandTimeoutParam_ParamsAvailable| 0|
> | |init()|1693|
> |12|testUpdateAmsHbaseSecuritySiteConfigs| 5|
> | |init()|1626|
> |13|testUpdateAlertDefinitions| 19|
> 
> 
> *ExecutionScheduleManagerTest:*
> - setup() function takes most of the time.
> 
> ||Test No.||Test||Time (micro secs)||
> | |setup()|10111|
> |1|testUpdateBatchRequest| 249|
> | |after()|2|
> | |setup()|3234|
> |2|testExecuteBatchRequest| 59|
> | |after()|1|
> | |setup()|2480|
> |3|testScheduleBatch| 40|
> | |after()|1|
> | |setup()|2381|
> |4|testFinalizeBeforeExit| 28|
> | |after()|1|
> | |setup()|2312|
> |5|testDeleteAllJobs| 17|
> | |after()|1|
> | |setup()|2141|
> |6|testFinalizeBatch| 64|
> | |after()|1|
> | |setup()|1970|
> |7|testPointInTimeExecutionJob| 18|
> | |after()|2|
> | |setup()|1944|
> |8|testHasToleranceThresholdExceeded| 68|
> | |after()|1|
> | |setup()|1994|
> |9|testGetBatchRequestResponse| 59|
> | |after()|1|
> 
> 
> **Fix:** 
> 
> 
> Make test's before and after functions as @BeforeClass @AfterClass methods.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
>  f2fe3b8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java
>  e754a41 
> 
> Diff: https://reviews.apache.org/r/52757/diff/
> 
> 
> Testing
> ---
> 
> - Locally: Passes
> - Jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-12 Thread Jonathan Hurley 


> On Oct. 7, 2016, 2:53 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/logging/LockFactory.java,
> >  line 50
> > 
> >
> > There should be a default prefix
> 
> Attila Doroszlai wrote:
> What should be the default prefix?

Could be the simple name of the invoking class?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52636/#review151839
---


On Oct. 7, 2016, 4:21 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52636/
> ---
> 
> (Updated Oct. 7, 2016, 4:21 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Create `Lock` and `ReadWriteLock` implementation for profiling and logging 
> lock usage
> 2. Introduce `LockFactory` that creates regular or instrumented locks based 
> on Ambari Server configuration
> 3. As sample usage, replace locks in `ClusterImpl` with the ones created by 
> `LockFactory`
> 4. Allows on-demand dump of lock profiler summary stats as part of the debug 
> log for `/api/v1/clusters` requests (This is a temporary solution.  Once the 
> factory is used in more places, the dump should be triggered by some other 
> request unrelated to the clusters.)
> 
> Configuration:
> 
>  * `server.locks.profiling=true` enables usage of instrumented locks instead 
> of regular ones (goes in `ambari.properties`)
>  * 
> `log4j.logger.org.apache.ambari.server.controller.AmbariManagementControllerImpl=DEBUG`
>  required for the on-demand dump (goes in `log4j.properties`)
>  * `log4j.logger.org.apache.ambari.server.logging=DEBUG` enables logging of 
> individual "requested", "acquired", "released" events. Only the outermost 
> lock/unlock call is logged, reentrant calls are ignored (goes in 
> `log4j.properties`)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/logging/LockFactory.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/logging/LockProfileDelegate.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/logging/ProfiledLock.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/logging/ProfiledReentrantLock.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/logging/ProfiledReentrantReadWriteLock.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  2f7d6b9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  a56ace5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/logging/LockFactoryTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/logging/ProfiledReentrantReadWriteLockTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52636/diff/
> 
> 
> Testing
> ---
> 
> * Manual testing: cluster creation via blueprint both with and without 
> `server.locks.profiling=true` setting
>  * Unit tests:
>Tests run: 56, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.968 sec 
> - in org.apache.ambari.server.configuration.ConfigurationTest
>Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec 
> - in org.apache.ambari.server.logging.DelegatingLockTest
>Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.279 sec 
> - in org.apache.ambari.server.logging.LockFactoryTest
>Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.168 sec 
> - in org.apache.ambari.server.logging.ProfiledReentrantReadWriteLockTest
>  * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 5012 licence.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

2016-10-12 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52636/#review152312
---



Which branch are you developing this against? The reason I ask is that I think 
this should go alongside the other changes for AMBARI-18456 in 
branch-feature-AMBARI-18456.

- Jonathan Hurley


On Oct. 7, 2016, 4:21 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52636/
> ---
> 
> (Updated Oct. 7, 2016, 4:21 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, 
> and Sebastian Toader.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Create `Lock` and `ReadWriteLock` implementation for profiling and logging 
> lock usage
> 2. Introduce `LockFactory` that creates regular or instrumented locks based 
> on Ambari Server configuration
> 3. As sample usage, replace locks in `ClusterImpl` with the ones created by 
> `LockFactory`
> 4. Allows on-demand dump of lock profiler summary stats as part of the debug 
> log for `/api/v1/clusters` requests (This is a temporary solution.  Once the 
> factory is used in more places, the dump should be triggered by some other 
> request unrelated to the clusters.)
> 
> Configuration:
> 
>  * `server.locks.profiling=true` enables usage of instrumented locks instead 
> of regular ones (goes in `ambari.properties`)
>  * 
> `log4j.logger.org.apache.ambari.server.controller.AmbariManagementControllerImpl=DEBUG`
>  required for the on-demand dump (goes in `log4j.properties`)
>  * `log4j.logger.org.apache.ambari.server.logging=DEBUG` enables logging of 
> individual "requested", "acquired", "released" events. Only the outermost 
> lock/unlock call is logged, reentrant calls are ignored (goes in 
> `log4j.properties`)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/logging/LockFactory.java 
> PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/logging/LockProfileDelegate.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/logging/ProfiledLock.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/logging/ProfiledReentrantLock.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/logging/ProfiledReentrantReadWriteLock.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  2f7d6b9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
>  a56ace5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/logging/LockFactoryTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/logging/ProfiledReentrantReadWriteLockTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52636/diff/
> 
> 
> Testing
> ---
> 
> * Manual testing: cluster creation via blueprint both with and without 
> `server.locks.profiling=true` setting
>  * Unit tests:
>Tests run: 56, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.968 sec 
> - in org.apache.ambari.server.configuration.ConfigurationTest
>Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec 
> - in org.apache.ambari.server.logging.DelegatingLockTest
>Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.279 sec 
> - in org.apache.ambari.server.logging.LockFactoryTest
>Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.168 sec 
> - in org.apache.ambari.server.logging.ProfiledReentrantReadWriteLockTest
>  * Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 5012 licence.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 52788: Grafana fails to start after deployment

2016-10-12 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52788/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-18579
https://issues.apache.org/jira/browse/AMBARI-18579


Repository: ambari


Description
---

Noticed this issue in Ambari system tests clusters that run on YCloud, that
Grafana fails to start after deployment with the below error




"stderr" : "Traceback (most recent call last):\n  File 
\"/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py\",
 line 67, in \nAmsGrafana().execute()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
 line 280, in execute\nmethod(env)\n  File 
\"/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py\",
 line 46, in start\nuser=params.ams_user\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/base.py\", line 
155, in __init__\nself.env.run()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 160, in run\nself.run_action(resource, action)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
line 124, in run_action\nprovider_action()\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py\",
 line 2
 73, in action_run\ntries=self.resource.tries, 
try_sleep=self.resource.try_sleep)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
71, in inner\nresult = function(command, **kwargs)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
93, in checked_call\ntries=tries, try_sleep=try_sleep)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
141, in _call_wrapper\nresult = _call(command, **kwargs_copy)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
294, in _call\nraise 
Fail(err_msg)\nresource_management.core.exceptions.Fail: Execution of 
'/usr/sbin/ambari-metrics-grafana start' returned 1.  Hortonworks 
#\nThis is MOTD message, added for testing in qe infra\nStarting 
Ambari Metrics Grafana:  FAILED",



Please find the artifacts for the run [here](http://qelog.hortonworks.com/log
/nat-yc-ambari-2-4-2-0-amb-r7-dmyu-ambari-config-6/test-logs/ambari-config/art
ifacts/screenshots/com.hw.ambari.ui.tests.installer.InstallHadoop/install/_8_2
3_23_7_Component__Phoenix_Query_Server__is_not__STARTED__on_host__ctr_e45_1475
874954070_0581_01_/lastAvailableRequests.txt)


Diffs
-

  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py
 ae2a635 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
 4ef719c 
  
ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py
 2e24d82 
  ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
ceedb67 

Diff: https://reviews.apache.org/r/52788/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52788: Grafana fails to start after deployment

2016-10-12 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52788/#review152346
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Жов. 12, 2016, 4:52 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52788/
> ---
> 
> (Updated Жов. 12, 2016, 4:52 після полудня)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-18579
> https://issues.apache.org/jira/browse/AMBARI-18579
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Noticed this issue in Ambari system tests clusters that run on YCloud, that
> Grafana fails to start after deployment with the below error
> 
> 
> 
> 
> "stderr" : "Traceback (most recent call last):\n  File 
> \"/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py\",
>  line 67, in \nAmsGrafana().execute()\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py\",
>  line 280, in execute\nmethod(env)\n  File 
> \"/var/lib/ambari-agent/cache/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py\",
>  line 46, in start\nuser=params.ams_user\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/base.py\", line 
> 155, in __init__\nself.env.run()\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
> line 160, in run\nself.run_action(resource, action)\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/environment.py\", 
> line 124, in run_action\nprovider_action()\n  File 
> \"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py\",
>  line
  273, in action_run\ntries=self.resource.tries, 
try_sleep=self.resource.try_sleep)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
71, in inner\nresult = function(command, **kwargs)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
93, in checked_call\ntries=tries, try_sleep=try_sleep)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
141, in _call_wrapper\nresult = _call(command, **kwargs_copy)\n  File 
\"/usr/lib/python2.6/site-packages/resource_management/core/shell.py\", line 
294, in _call\nraise 
Fail(err_msg)\nresource_management.core.exceptions.Fail: Execution of 
'/usr/sbin/ambari-metrics-grafana start' returned 1.  Hortonworks 
#\nThis is MOTD message, added for testing in qe infra\nStarting 
Ambari Metrics Grafana:  FAILED",
> 
> 
> 
> Please find the artifacts for the run [here](http://qelog.hortonworks.com/log
> /nat-yc-ambari-2-4-2-0-amb-r7-dmyu-ambari-config-6/test-logs/ambari-config/art
> ifacts/screenshots/com.hw.ambari.ui.tests.installer.InstallHadoop/install/_8_2
> 3_23_7_Component__Phoenix_Query_Server__is_not__STARTED__on_host__ctr_e45_1475
> 874954070_0581_01_/lastAvailableRequests.txt)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana.py
>  ae2a635 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params_linux.py
>  4ef719c 
>   
> ambari-server/src/test/python/stacks/2.0.6/AMBARI_METRICS/test_metrics_grafana.py
>  2e24d82 
>   
> ambari-server/src/test/python/stacks/2.0.6/configs/default_ams_embedded.json 
> ceedb67 
> 
> Diff: https://reviews.apache.org/r/52788/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 52791: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-12 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52791/
---

Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit 
Mohanty.


Bugs: AMBARI-18532
https://issues.apache.org/jira/browse/AMBARI-18532


Repository: ambari


Description
---

Add related code to UpgradeCatalog. And change all blueprint_name fields to 
varchar(100).


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 ebfb267 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
 PRE-CREATION 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f84129c 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/52791/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-12 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52757/#review152353
---


Ship it!




How much was the improvement?

- Alejandro Fernandez


On Oct. 11, 2016, 11:17 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52757/
> ---
> 
> (Updated Oct. 11, 2016, 11:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18575
> https://issues.apache.org/jira/browse/AMBARI-18575
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue: 
> 
> **Current time taken:**
> ==
> 
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.upgrade.UpgradeCatalog221Test   |13|36.586|
> |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|
> 
> 
> **Individual tests time taken is as follows:**
> ==
> 
> **UpgradeCatalog221Test:**
> 
> - init() function takes most of the time.
> 
> ||Test No.||Test||Time (micro secs)||
> | |init()|10197|
> |1|testUpdateAmsHbaseSiteConfigs| 198|
> | |init()|3140|
> |2|testExecuteDDLUpdates| 17|
> | |init()|2377|
> |3|test_AddCheckCommandTimeoutParam_ParamsNotAvailable| 6|
> | |init()|2396|
> |4|testExecuteDMLUpdates| 18|
> | |init()|2203|
> |5|testUpdateTezConfigs| 11|
> | |init()|2011|
> |6|testUpdateAmsHbaseEnvContent| 0|
> | |init()|1953|
> |7|test_AddCheckCommandTimeoutParam_NeededParamAlreadyAdded| 0|
> | |init()|1882|
> |8|testUpdateOozieConfigs| 2|
> | |init()|1871|
> |9|testUpdateAmsEnvContent| 0|
> | |init()|1801|
> |10|testUpdateRangerKmsDbksConfigs| 2|
> | |init()|1735|
> |11|test_AddCheckCommandTimeoutParam_ParamsAvailable| 0|
> | |init()|1693|
> |12|testUpdateAmsHbaseSecuritySiteConfigs| 5|
> | |init()|1626|
> |13|testUpdateAlertDefinitions| 19|
> 
> 
> *ExecutionScheduleManagerTest:*
> - setup() function takes most of the time.
> 
> ||Test No.||Test||Time (micro secs)||
> | |setup()|10111|
> |1|testUpdateBatchRequest| 249|
> | |after()|2|
> | |setup()|3234|
> |2|testExecuteBatchRequest| 59|
> | |after()|1|
> | |setup()|2480|
> |3|testScheduleBatch| 40|
> | |after()|1|
> | |setup()|2381|
> |4|testFinalizeBeforeExit| 28|
> | |after()|1|
> | |setup()|2312|
> |5|testDeleteAllJobs| 17|
> | |after()|1|
> | |setup()|2141|
> |6|testFinalizeBatch| 64|
> | |after()|1|
> | |setup()|1970|
> |7|testPointInTimeExecutionJob| 18|
> | |after()|2|
> | |setup()|1944|
> |8|testHasToleranceThresholdExceeded| 68|
> | |after()|1|
> | |setup()|1994|
> |9|testGetBatchRequestResponse| 59|
> | |after()|1|
> 
> 
> **Fix:** 
> 
> 
> Make test's before and after functions as @BeforeClass @AfterClass methods.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
>  f2fe3b8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java
>  e754a41 
> 
> Diff: https://reviews.apache.org/r/52757/diff/
> 
> 
> Testing
> ---
> 
> - Locally: Passes
> - Jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 52791: Getting errors with max length 1000byte, when using Mysql db with charset UTF8

2016-10-12 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52791/#review152355
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 12, 2016, 5:41 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52791/
> ---
> 
> (Updated Oct. 12, 2016, 5:41 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-18532
> https://issues.apache.org/jira/browse/AMBARI-18532
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add related code to UpgradeCatalog. And change all blueprint_name fields to 
> varchar(100).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
>  ebfb267 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog242.java
>  PRE-CREATION 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql f84129c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog242Test.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52791/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 52792: AMBARI-18581 Oozie start script ignores sysprep_skip_copy_oozie_share_lib_to_hdfs flag

2016-10-12 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52792/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Laszlo Puskas, 
Sandor Magyari, and Sebastian Toader.


Bugs: AMBARI-18581
https://issues.apache.org/jira/browse/AMBARI-18581


Repository: ambari


Description
---

Added missing `/configurations` prefix.


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py
 e5d674a 

Diff: https://reviews.apache.org/r/52792/diff/


Testing
---

Manual testing:
 * create sysprepped cluster
 * submit blueprint with WebHDFS disabled and 
sysprep_skip_copy_oozie_share_lib_to_hdfs enabled
 * submit START_ONLY cluster creation request
 * verify Oozie is started (see 
https://issues.apache.org/jira/browse/AMBARI-18567)
 * verify Oozie skipped steps: "Skipping creation of oozie sharelib as host is 
sys prepped"


Thanks,

Attila Doroszlai

Re: Review Request 52792: AMBARI-18581 Oozie start script ignores sysprep_skip_copy_oozie_share_lib_to_hdfs flag

2016-10-12 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52792/#review152357
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 12, 2016, 5:51 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52792/
> ---
> 
> (Updated Oct. 12, 2016, 5:51 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Laszlo 
> Puskas, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18581
> https://issues.apache.org/jira/browse/AMBARI-18581
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added missing `/configurations` prefix.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params.py
>  e5d674a 
> 
> Diff: https://reviews.apache.org/r/52792/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>  * create sysprepped cluster
>  * submit blueprint with WebHDFS disabled and 
> sysprep_skip_copy_oozie_share_lib_to_hdfs enabled
>  * submit START_ONLY cluster creation request
>  * verify Oozie is started (see 
> https://issues.apache.org/jira/browse/AMBARI-18567)
>  * verify Oozie skipped steps: "Skipping creation of oozie sharelib as host 
> is sys prepped"
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 52757: AMBARI-18575. Fix for improving time taken by 'ExecutionScheduleManagerTest' and 'UpgradeCatalog221Test' java tests.

2016-10-12 Thread Swapan Shridhar 


> On Oct. 12, 2016, 5:42 p.m., Alejandro Fernandez wrote:
> > How much was the improvement?

After the fix, improved timings are as follows:

*ExecutionScheduleManagerTest :*

After Improvements - ~11.3 secs
Before Improvement - ~30.6 secs

*UpgradeCatalog221Test :* 

After Improvements - ~11.0 secs
Before Improvement - ~30.5 secs


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52757/#review152353
---


On Oct. 11, 2016, 11:17 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52757/
> ---
> 
> (Updated Oct. 11, 2016, 11:17 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18575
> https://issues.apache.org/jira/browse/AMBARI-18575
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Issue: 
> 
> **Current time taken:**
> ==
> 
> ||Test||Count||Time (s)||
> |org.apache.ambari.server.upgrade.UpgradeCatalog221Test   |13|36.586|
> |org.apache.ambari.server.scheduler.ExecutionScheduleManagerTest|9|30.685|
> 
> 
> **Individual tests time taken is as follows:**
> ==
> 
> **UpgradeCatalog221Test:**
> 
> - init() function takes most of the time.
> 
> ||Test No.||Test||Time (micro secs)||
> | |init()|10197|
> |1|testUpdateAmsHbaseSiteConfigs| 198|
> | |init()|3140|
> |2|testExecuteDDLUpdates| 17|
> | |init()|2377|
> |3|test_AddCheckCommandTimeoutParam_ParamsNotAvailable| 6|
> | |init()|2396|
> |4|testExecuteDMLUpdates| 18|
> | |init()|2203|
> |5|testUpdateTezConfigs| 11|
> | |init()|2011|
> |6|testUpdateAmsHbaseEnvContent| 0|
> | |init()|1953|
> |7|test_AddCheckCommandTimeoutParam_NeededParamAlreadyAdded| 0|
> | |init()|1882|
> |8|testUpdateOozieConfigs| 2|
> | |init()|1871|
> |9|testUpdateAmsEnvContent| 0|
> | |init()|1801|
> |10|testUpdateRangerKmsDbksConfigs| 2|
> | |init()|1735|
> |11|test_AddCheckCommandTimeoutParam_ParamsAvailable| 0|
> | |init()|1693|
> |12|testUpdateAmsHbaseSecuritySiteConfigs| 5|
> | |init()|1626|
> |13|testUpdateAlertDefinitions| 19|
> 
> 
> *ExecutionScheduleManagerTest:*
> - setup() function takes most of the time.
> 
> ||Test No.||Test||Time (micro secs)||
> | |setup()|10111|
> |1|testUpdateBatchRequest| 249|
> | |after()|2|
> | |setup()|3234|
> |2|testExecuteBatchRequest| 59|
> | |after()|1|
> | |setup()|2480|
> |3|testScheduleBatch| 40|
> | |after()|1|
> | |setup()|2381|
> |4|testFinalizeBeforeExit| 28|
> | |after()|1|
> | |setup()|2312|
> |5|testDeleteAllJobs| 17|
> | |after()|1|
> | |setup()|2141|
> |6|testFinalizeBatch| 64|
> | |after()|1|
> | |setup()|1970|
> |7|testPointInTimeExecutionJob| 18|
> | |after()|2|
> | |setup()|1944|
> |8|testHasToleranceThresholdExceeded| 68|
> | |after()|1|
> | |setup()|1994|
> |9|testGetBatchRequestResponse| 59|
> | |after()|1|
> 
> 
> **Fix:** 
> 
> 
> Make test's before and after functions as @BeforeClass @AfterClass methods.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/test/java/org/apache/ambari/server/scheduler/ExecutionScheduleManagerTest.java
>  f2fe3b8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog221Test.java
>  e754a41 
> 
> Diff: https://reviews.apache.org/r/52757/diff/
> 
> 
> Testing
> ---
> 
> - Locally: Passes
> - Jenkins pending.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Aleksandr Kovalenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/
---

(Updated Окт. 12, 2016, 7:05 п.п.)


Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
and Yusaku Sako.


Changes
---

Uploaded updated patch


Bugs: AMBARI-18573
https://issues.apache.org/jira/browse/AMBARI-18573


Repository: ambari


Description
---

Migrate from Bootstrap2 to Bootstrap3 framework.


Diffs (updated)
-

  ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
  ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
  ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
  ambari-web/app/controllers/application.js 
dca689f949dfa3583fac3e2d181e2d876716664d 
  ambari-web/app/controllers/main/admin/service_auto_start.js 
b425c785770ef05c4b7b519d50645be0f1b655ea 
  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
d00a652f8da42fba20fb86394e06dcedba18edfc 
  ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
f05d366057d75ca47418891c86504f18e8e3f1c4 
  
ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js 
43e25c8c5338d9c264aa8346cce1b12d195f64f0 
  
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
  ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
5913070d3ba799b6d2415361381aea781b1f313d 
  ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
6ba595738234aa840de8bdbca47884a5d699b843 
  ambari-web/app/controllers/main/charts/heatmap.js 
73d18005202e956b2af4732abf3467a72a7d96f2 
  ambari-web/app/controllers/main/service/info/summary.js 
c16bb3fc728fe89743d308e0ab96b073e5a8845f 
  ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
  ambari-web/app/controllers/wizard/step10_controller.js 
8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
  ambari-web/app/controllers/wizard/step1_controller.js 
a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
  ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
399000eaac97dc4bcfa121b5b3906db7bf71013f 
  ambari-web/app/data/host/categories.js 
7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
  ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
  ambari-web/app/mixins/common/configs/configs_saver.js 
6592203d614d55c7940657e56e119d4a2f2809bd 
  ambari-web/app/mixins/common/widgets/widget_mixin.js 
5ec4dd6cad9320220da375891894bc41ece71908 
  ambari-web/app/mixins/main/dashboard/widgets/editable.js 
c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
  ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
b10d386ebfb6624dad507f63904edc6d03665fe3 
  ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
cbb81b369b98baafe5c7962242812522f53ab823 
  ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
38d5b1770a53704c650008afc6ab6a1bbda08d1d 
  ambari-web/app/mixins/main/service/configs/config_overridable.js 
a8bd273e2ebc25834559224cd0f9d2e78f91 
  ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
96a25781e27d2be364454aa0337ffec21b85aaf1 
  ambari-web/app/mixins/wizard/wizardProgressPageView.js 
81970866b4e9dd158e0a6821c4f53c01df845855 
  ambari-web/app/models/alerts/alert_config.js 
efbfebff5840dcdafea7657ff44ba0c7206b05bb 
  ambari-web/app/models/alerts/alert_definition.js 
4da7199320bc925977071b41d2a0ee1c0b03bcbe 
  ambari-web/app/models/alerts/alert_instance.js 
b366802acfe56eac234abbe130198c9ae6bc8e00 
  ambari-web/app/models/authentication.js 
436c18410c79928edd33367c99fe9ec94d8454d8 
  ambari-web/app/models/host_component.js 
11ea659089742d261ceb9f31aaecfd668b553bfa 
  ambari-web/app/models/hosts.js 9275b3e320136d6932e91b18d9f832eeb7d93e4b 
  ambari-web/app/models/repository.js 0b7ee69d0f108132c9a6b694b3b8918864d784c4 
  ambari-web/app/router.js 02707711b8c132d2815854a7bc902ac39a034aae 
  ambari-web/app/routes/activate_hawq_standby_routes.js 
8ab19dba452a33d389f66b030626c87afa2f9489 
  ambari-web/app/routes/add_alert_definition_routes.js 
15d010394e81fae48b63964f3d5e18e02f2e6f03 
  ambari-web/app/routes/add_hawq_standby_routes.js 
d802808e91c99523e166639311b533fe16c87629 
  ambari-web/app/routes/add_host_routes.js 
c733a6665637cd9a8c749a844d531a530abe071b 
  ambari-web/app/routes/add_kerberos_routes.js 
1568577b3a2591c3ac1059c3625d6c64cf0f7913 
  ambari-web/app/routes/add_service_routes.js 
692d186d8a941409b5127fe02115e072d33d016

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread Xi Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52183/#review152389
---



This will
not impact the new "create alert wizard" because this is part of alert 
notifications management.

- Xi Wang


On Sept. 22, 2016, 7:24 p.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52183/
> ---
> 
> (Updated Sept. 22, 2016, 7:24 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Zhe (Joe) Wang, and Oleg Tikhonov.
> 
> 
> Bugs: AMBARI-18423
> https://issues.apache.org/jira/browse/AMBARI-18423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari now only support creating/editing alert notifications of type 
> EMAIL/SNMP in web client.
> This patch aims to support another notification type  ALERT_SCRIPT
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  10a7918 
>   ambari-web/app/messages.js 2c819e5 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs a248e57 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  a0a4ce4 
> 
> Diff: https://reviews.apache.org/r/52183/diff/
> 
> 
> Testing
> ---
> 
> ambari-web/mvn test
> 
> 
> 30365 tests complete (43 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 52555: AMBARI-18535 Ambari is not picking up the latest repo for HDP-2.4

2016-10-12 Thread Richard Zang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52555/#review152392
---


Ship it!




Ship It!

- Richard Zang


On Oct. 5, 2016, 3:25 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52555/
> ---
> 
> (Updated Oct. 5, 2016, 3:25 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
> Subramanian, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18535
> https://issues.apache.org/jira/browse/AMBARI-18535
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During fresh deployment, if HDP-2.4 is chosen then Ambari does not default to 
> the latest 2.4 release, HDP-2.4.2. This is likely because VDF files do not 
> exist for HDP-2.4 release and the older mechanism of picking the latest repo 
> URL form the hdp_urlinfo.json does not work. HDP-2.4.0 is chosen where as the 
> latest is HDP-2.4.2
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/installer.js f8f70a0 
> 
> Diff: https://reviews.apache.org/r/52555/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 30374 tests complete (27 seconds)
> 151 tests pending
> Manual testing done
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Yusaku Sako 


> On Oct. 11, 2016, 7:42 p.m., Yusaku Sako wrote:
> > ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js,
> >  line 44
> > 
> >
> > glyphicon is duplicated.  This probably has no material impact, but 
> > let's remove this.

I didn't see this fixed in the new patch.


> On Oct. 11, 2016, 7:42 p.m., Yusaku Sako wrote:
> > ambari-web/app/templates/common/configs/widgets/textfield_config_widget.hbs,
> >  line 19
> > 
> >
> > Need to fix this typo

I didn't see this fixed in the new patch.


- Yusaku


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152182
---


On Oct. 12, 2016, 7:05 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52747/
> ---
> 
> (Updated Oct. 12, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18573
> https://issues.apache.org/jira/browse/AMBARI-18573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate from Bootstrap2 to Bootstrap3 framework.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
>   ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
>   ambari-web/app/controllers/application.js 
> dca689f949dfa3583fac3e2d181e2d876716664d 
>   ambari-web/app/controllers/main/admin/service_auto_start.js 
> b425c785770ef05c4b7b519d50645be0f1b655ea 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> d00a652f8da42fba20fb86394e06dcedba18edfc 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> f05d366057d75ca47418891c86504f18e8e3f1c4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  43e25c8c5338d9c264aa8346cce1b12d195f64f0 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
>   ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
> 5913070d3ba799b6d2415361381aea781b1f313d 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 6ba595738234aa840de8bdbca47884a5d699b843 
>   ambari-web/app/controllers/main/charts/heatmap.js 
> 73d18005202e956b2af4732abf3467a72a7d96f2 
>   ambari-web/app/controllers/main/service/info/summary.js 
> c16bb3fc728fe89743d308e0ab96b073e5a8845f 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
>   ambari-web/app/controllers/wizard/step10_controller.js 
> 8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
>   ambari-web/app/controllers/wizard/step1_controller.js 
> a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
> 399000eaac97dc4bcfa121b5b3906db7bf71013f 
>   ambari-web/app/data/host/categories.js 
> 7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
>   ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
>   ambari-web/app/mixins/common/configs/configs_saver.js 
> 6592203d614d55c7940657e56e119d4a2f2809bd 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 
> 5ec4dd6cad9320220da375891894bc41ece71908 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js 
> c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
> b10d386ebfb6624dad507f63904edc6d03665fe3 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> cbb81b369b98baafe5c7962242812522f53ab823 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 38d5b1770a53704c650008afc6ab6a1bbda08d1d 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 
> a8bd273e2ebc25834559224cd0f9d2e78f91 
>   ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
> 96a25781e27d2be364454aa0337ffec21b85aaf1 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js 
> 81970866b4e9dd158e0a6821c4f53c01df845855 
>   ambari-web/app/models/alerts/alert_config.js 
> efbfebff5840dcdafea7657ff44ba0c7206b05bb 
>   ambari-web/app/models/al

Re: Review Request 52747: Migration to Bootstrap3 framework

2016-10-12 Thread Yusaku Sako 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52747/#review152395
---



Thanks for moving the ambari bootstrap override as unminified, non-vendor style.
Can we move the Roboto font files back to vendor, though?


LICENSE.txt (line 348)


This should not have been reverted.


- Yusaku Sako


On Oct. 12, 2016, 7:05 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52747/
> ---
> 
> (Updated Oct. 12, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Zhe (Joe) Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18573
> https://issues.apache.org/jira/browse/AMBARI-18573
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Migrate from Bootstrap2 to Bootstrap3 framework.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/app.js 53394a055bb5997c3589b0e18413e2f984b6 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.eot PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.svg PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.ttf PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff PRE-CREATION 
>   ambari-web/app/assets/fonts/glyphicons-halflings-regular.woff2 PRE-CREATION 
>   ambari-web/app/config.js 4550eb8905d6064f44a194d31ee3727c55e9bfb5 
>   ambari-web/app/controllers/application.js 
> dca689f949dfa3583fac3e2d181e2d876716664d 
>   ambari-web/app/controllers/main/admin/service_auto_start.js 
> b425c785770ef05c4b7b519d50645be0f1b655ea 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 
> d00a652f8da42fba20fb86394e06dcedba18edfc 
>   ambari-web/app/controllers/main/admin/stack_upgrade_history_controller.js 
> f05d366057d75ca47418891c86504f18e8e3f1c4 
>   
> ambari-web/app/controllers/main/alerts/add_alert_definition/step1_controller.js
>  43e25c8c5338d9c264aa8346cce1b12d195f64f0 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  6ca3e786d65cfe515615e10aa141a3d5dca2fbd5 
>   ambari-web/app/controllers/main/alerts/alert_instances_controller.js 
> 5913070d3ba799b6d2415361381aea781b1f313d 
>   ambari-web/app/controllers/main/alerts/manage_alert_groups_controller.js 
> 6ba595738234aa840de8bdbca47884a5d699b843 
>   ambari-web/app/controllers/main/charts/heatmap.js 
> 73d18005202e956b2af4732abf3467a72a7d96f2 
>   ambari-web/app/controllers/main/service/info/summary.js 
> c16bb3fc728fe89743d308e0ab96b073e5a8845f 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js 
> 539d03eb3d0c5b0e7ea8e5284b5a1c796d3af3cc 
>   ambari-web/app/controllers/wizard/step10_controller.js 
> 8c4b5dbe371e78fd5cb0bc7e87e0a7a965486f2d 
>   ambari-web/app/controllers/wizard/step1_controller.js 
> a1ebad83cbe9e5082c4cc56b391c7d1a25108e00 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 
> 399000eaac97dc4bcfa121b5b3906db7bf71013f 
>   ambari-web/app/data/host/categories.js 
> 7e010d5fb117bcb9e1c633484748b8b4aaf35f97 
>   ambari-web/app/messages.js 71500810a0993c5c02102bfd0ffa15028f78d842 
>   ambari-web/app/mixins/common/configs/configs_saver.js 
> 6592203d614d55c7940657e56e119d4a2f2809bd 
>   ambari-web/app/mixins/common/widgets/widget_mixin.js 
> 5ec4dd6cad9320220da375891894bc41ece71908 
>   ambari-web/app/mixins/main/dashboard/widgets/editable.js 
> c5d3bb4967d02f7193c32a0212550acf69ae8b5a 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 
> b10d386ebfb6624dad507f63904edc6d03665fe3 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> cbb81b369b98baafe5c7962242812522f53ab823 
>   ambari-web/app/mixins/main/host/details/host_components/decommissionable.js 
> 38d5b1770a53704c650008afc6ab6a1bbda08d1d 
>   ambari-web/app/mixins/main/service/configs/config_overridable.js 
> a8bd273e2ebc25834559224cd0f9d2e78f91 
>   ambari-web/app/mixins/main/service/configs/widget_popover_support.js 
> 96a25781e27d2be364454aa0337ffec21b85aaf1 
>   ambari-web/app/mixins/wizard/wizardProgressPageView.js 
> 81970866b4e9dd158e0a6821c4f53c01df845855 
>   ambari-web/app/models/alerts/alert_config.js 
> efbfebff5840dcdafea7657ff44ba0c7206b05bb 
>   ambari-web/app/models/alerts/alert_definition.js 
> 4da7199320bc925977071b41d2a0ee1c0b03bcbe 
>   ambari-web/app/models/alerts/alert_instance.js 
> b366802acfe56eac234abbe130198c9ae6bc8e00 
>   ambari-web/app/models/authentication.js 
> 436c18410c79928edd33367c99fe9ec94d8454d8 
>   ambari-web/app/models/host_component.js 
> 11ea659089742d261ceb9f31aaecfd668b553bfa 
>   ambari-web/app/models/hosts.js 9275b3e320136d6932e91b18d9f832eeb7d9

Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

2016-10-12 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52758/
---

(Updated Oct. 12, 2016, 9:04 p.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
Hurley, Nate Cole, and Sid Wagle.


Bugs: AMBARI-18576
https://issues.apache.org/jira/browse/AMBARI-18576


Repository: ambari


Description
---

STR:

* Install Ambari 2.4.0.1 with any HDP stack (e.g., 2.5) and HDFS, YARN, ZK
* Run multiple commands in parallel (such as service checks)
* Attempt to abort any one of them

Instead of aborting just the desired one, it will abort all requests.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
 0e78cbc 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
 c31ca7e 
  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 e380ae4 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
8ef4a1b 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
 7659a23 
  
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
 9f12a94 

Diff: https://reviews.apache.org/r/52758/diff/


Testing
---

Verified on live cluster.
Waiting for unit test results.


Thanks,

Alejandro Fernandez

Re: Review Request 52758: When multiple requests are running, aborting any will incorrectly abort all requests instead the desired one

2016-10-12 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52758/#review152405
---


Ship it!




Ship It!

- Sid Wagle


On Oct. 12, 2016, 9:04 p.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52758/
> ---
> 
> (Updated Oct. 12, 2016, 9:04 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan 
> Hurley, Nate Cole, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18576
> https://issues.apache.org/jira/browse/AMBARI-18576
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> * Install Ambari 2.4.0.1 with any HDP stack (e.g., 2.5) and HDFS, YARN, ZK
> * Run multiple commands in parallel (such as service checks)
> * Attempt to abort any one of them
> 
> Instead of aborting just the desired one, it will abort all requests.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessor.java
>  0e78cbc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
>  c31ca7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  e380ae4 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 
> 8ef4a1b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  7659a23 
>   
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
>  9f12a94 
> 
> Diff: https://reviews.apache.org/r/52758/diff/
> 
> 
> Testing
> ---
> 
> Verified on live cluster.
> Waiting for unit test results.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

2016-10-12 Thread Amruta Borkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51815/
---

(Updated Oct. 12, 2016, 11:42 p.m.)


Review request for Ambari, Shantanu Mundkur, Di Li, Jayush Luniya, Juanjo  
Marron, Laszlo Puskas, Nate Cole, and Robert Nettleton.


Changes
---

Hello Nate, I have modified the patch according to your comments. Could you 
please take a look? Thank you


Bugs: AMBARI-18355
https://issues.apache.org/jira/browse/AMBARI-18355


Repository: ambari


Description
---

Currently stack definitions do not list conditional dependencies, adding those 
to the stack definitions would make it easy to validate errors in case of 
blueprint deployment. Please refer to document attached to Jira


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionAdapter.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyConditionInfo.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/DependencyInfo.java 
e3db662 
  
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
 a5f33ff 
  ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/metainfo.xml 
65d166a 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
 ff9af17 
  
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintValidatorImplTest.java
 b1de8ef 

Diff: https://reviews.apache.org/r/51815/diff/


Testing
---

Written Junit test cases. Perfomred manual testing to check the Namenode HA 
component dependency. Was able to proceed with the installation for valid 
blueprint. and got validation error message while registering blueprint when 
the Blueprint did not satisfy the conditional dependencies.


Thanks,

Amruta Borkar

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

2016-10-12 Thread Vivek Ratnavel Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated Oct. 13, 2016, 12:35 a.m.)


Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, Zhe 
(Joe) Wang, Richard Zang, Xi Wang, and Yusaku Sako.


Changes
---

The patch fixes scrollbars visibility in all browsers across all the platforms. 

Verified manually.
Ambari-web unit tests pass.

30374 tests complete (30 seconds)
151 tests pending


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs (updated)
-

  ambari-web/app/styles/config_history_flow.less 0b6dc3f 
  ambari-web/app/templates/common/configs/config_history_flow.hbs fa67786 
  ambari-web/app/views/common/configs/config_history_flow.js 5ad65ac 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.

Local Ambari-web tests pass.
30364 tests complete (27 seconds)
151 tests pending
Verified manually


File Attachments


Gif of latest changes
  
https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread yao lei 


> On 十月 12, 2016, 1:48 p.m., Jonathan Hurley wrote:
> > I can't really comment on the front-end work since that's not an area I'm 
> > familiar with. However, I do believe there are Jiras scoping a new "wizard" 
> > workflow for alerts in Ambari 3.0 which this may impact.

Thanks for your comment.


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52183/#review152301
---


On 九月 23, 2016, 2:24 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52183/
> ---
> 
> (Updated 九月 23, 2016, 2:24 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Zhe (Joe) Wang, and Oleg Tikhonov.
> 
> 
> Bugs: AMBARI-18423
> https://issues.apache.org/jira/browse/AMBARI-18423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari now only support creating/editing alert notifications of type 
> EMAIL/SNMP in web client.
> This patch aims to support another notification type  ALERT_SCRIPT
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  10a7918 
>   ambari-web/app/messages.js 2c819e5 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs a248e57 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  a0a4ce4 
> 
> Diff: https://reviews.apache.org/r/52183/diff/
> 
> 
> Testing
> ---
> 
> ambari-web/mvn test
> 
> 
> 30365 tests complete (43 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread yao lei 


> On 十月 12, 2016, 8:15 p.m., Xi Wang wrote:
> > This will
> > not impact the new "create alert wizard" because this is part of alert 
> > notifications management.

Thanks for your comment.
But I wonder whether I need to mark this jira as duplicatie if some relevent 
jiras have existed


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52183/#review152389
---


On 九月 23, 2016, 2:24 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52183/
> ---
> 
> (Updated 九月 23, 2016, 2:24 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Zhe (Joe) Wang, and Oleg Tikhonov.
> 
> 
> Bugs: AMBARI-18423
> https://issues.apache.org/jira/browse/AMBARI-18423
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari now only support creating/editing alert notifications of type 
> EMAIL/SNMP in web client.
> This patch aims to support another notification type  ALERT_SCRIPT
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java
>  907588d 
>   
> ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js
>  10a7918 
>   ambari-web/app/messages.js 2c819e5 
>   ambari-web/app/templates/main/alerts/create_alert_notification.hbs a248e57 
>   
> ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js
>  a0a4ce4 
> 
> Diff: https://reviews.apache.org/r/52183/diff/
> 
> 
> Testing
> ---
> 
> ambari-web/mvn test
> 
> 
> 30365 tests complete (43 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> yao lei
> 
>