Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-11-29 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Nov. 29, 2016, 1:40 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54086/#review157348 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 29, 2016,

Re: Review Request 54187: Perf: Simulate alerts for multiple Ambari Agents running on single Host

2016-11-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54187/#review157350 ---

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-11-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/ --- (Updated Nov. 29, 2016, 11:29 p.m.) Review request for Ambari, Di Li, Jonathan

Re: Review Request 54187: Perf: Simulate alerts for multiple Ambari Agents running on single Host

2016-11-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54187/#review157353 ---

Review Request 54187: Perf: Simulate alerts for multiple Ambari Agents running on single Host

2016-11-29 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54187/ --- Review request for Ambari, Alejandro Fernandez and Sid Wagle. Bugs:

Re: Review Request 54144: AMBARI-19005. 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

2016-11-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54144/#review157354 --- Ship it! Ship It! - Alejandro Fernandez On Nov. 30, 2016,

Re: Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

2016-11-29 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54002/ --- (Updated Nov. 30, 2016, 12:02 a.m.) Review request for Ambari, Laszlo Puskas,

Review Request 54186: AMBARI-19022: Ambari-server: Remove credential store from KNOX stack definition since it does not support credential store

2016-11-29 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54186/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-19022

Re: Review Request 54144: AMBARI-19005. 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

2016-11-29 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54144/ --- (Updated Nov. 30, 2016, 12:11 a.m.) Review request for Ambari, Alejandro

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-29 Thread Di Li
> On Nov. 29, 2016, 2:08 p.m., Nate Cole wrote: > > Can you confirm that this will not be changing existing clusters where > > services are missing? That is, if I install a ZK only cluster, but HDFS is > > specified for a check that it won't result in a failure? > > > > In addition, you

Review Request 54171: AMBARI-19018 - Services should be able to specify their own resources subdirs for sync'ing to agents

2016-11-29 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54171/ --- Review request for Ambari, Di Li, Jayush Luniya, and Sumit Mohanty. Bugs:

Review Request 54175: AMBARI-19020 Ubuntu14/16 Add Support for Zookeeper on HDP 2.5

2016-11-29 Thread Duc Le
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54175/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-29 Thread Di Li
> On Nov. 29, 2016, 2:08 p.m., Nate Cole wrote: > > Can you confirm that this will not be changing existing clusters where > > services are missing? That is, if I install a ZK only cluster, but HDFS is > > specified for a check that it won't result in a failure? > > > > In addition, you

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-29 Thread Di Li
> On Nov. 28, 2016, 10:32 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicePresenceCheck.java, > > line 83 > > > > > > Why does this have to convert to

Re: Review Request 54144: AMBARI-19005. 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

2016-11-29 Thread Swapan Shridhar
> On Nov. 29, 2016, 1:27 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py, > > line 115 > > > > > > Just calculate the mode once.

Re: Review Request 54144: AMBARI-19005. 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

2016-11-29 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54144/ --- (Updated Nov. 29, 2016, 9:05 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-29 Thread Nate Cole
> On Nov. 29, 2016, 9:08 a.m., Nate Cole wrote: > > Can you confirm that this will not be changing existing clusters where > > services are missing? That is, if I install a ZK only cluster, but HDFS is > > specified for a check that it won't result in a failure? > > > > In addition, you

Re: Review Request 54171: AMBARI-19018 - Services should be able to specify their own resources subdirs for sync'ing to agents

2016-11-29 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54171/#review157321 --- Ship it! Ship It! - Di Li On Nov. 29, 2016, 7 p.m., Tim

Re: Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

2016-11-29 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54002/#review157330 --- ambari-server/checkstyle.xml (line 16)

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-29 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54086/ --- (Updated Nov. 29, 2016, 9:32 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54080: Preview: Auto-fix common issues found by the DB consistency checker

2016-11-29 Thread Dmitro Lisnichenko
> On Nov. 28, 2016, 7:28 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, > > lines 518-523 > > > > > > Is this a different check

Re: Review Request 54137: Ambari widgets and service checks to honor LLAP clusters with 100% allocation to LLAP daemons

2016-11-29 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54137/ --- (Updated Nov. 29, 2016, 10:21 a.m.) Review request for Ambari, Aleksandr

Re: Review Request 54137: Ambari widgets and service checks to honor LLAP clusters with 100% allocation to LLAP daemons

2016-11-29 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54137/#review157222 --- Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 29, 2016,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-11-29 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Nov. 29, 2016, 8:29 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 54186: AMBARI-19022: Ambari-server: Remove credential store from KNOX stack definition since it does not support credential store

2016-11-29 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54186/#review157368 --- Ship it! Ship It! - Sumit Mohanty On Nov. 29, 2016, 10:47

Review Request 54189: After adding an Atlas server the first restart command fails since stop doesn't have any configs; if no pid dir exists during stop, perform no-op

2016-11-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54189/ --- Review request for Ambari, Mugdha Varadkar, Sumit Mohanty, and Swapan Shridhar.

Re: Review Request 54189: After adding an Atlas server the first restart command fails since stop doesn't have any configs; if no pid dir exists during stop, perform no-op

2016-11-29 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54189/#review157356 --- Ship it! Ship It! - Swapan Shridhar On Nov. 30, 2016, 1:15

Re: Review Request 54121: AMBARI-18929 : Yarn service check fails when either resource manager is down in HA enabled cluster

2016-11-29 Thread Weiwei Yang
> On 十一月 28, 2016, 7:07 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py, > > line 134 > > > > > > Please put this into its own

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-11-29 Thread Mugdha Varadkar
> On Nov. 28, 2016, 7:57 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml, > > line 24 > > > > > > Existing clusters

Re: Review Request 54159: Log Search external login credential let every user in

2016-11-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54159/#review157232 --- Ship it! Ship It! - Miklos Gergely On Nov. 29, 2016, 12:25

Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

2016-11-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54161/ --- Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.

Review Request 54162: Fix markup for widgets browser

2016-11-29 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54162/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-19011

Re: Review Request 54159: Log Search external login credential let every user in

2016-11-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54159/ --- (Updated Nov. 29, 2016, 1:42 p.m.) Review request for Ambari, Attila

Review Request 54155: Fix input height in filters with dropdown

2016-11-29 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54155/ --- Review request for Ambari and Oleg Nechiporenko. Bugs: AMBARI-19008

Re: Review Request 54125: Abillity to enable SPNEGO on Log Search Portal UI from Ambari

2016-11-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54125/ --- (Updated Nov. 29, 2016, 12:49 p.m.) Review request for Ambari, Miklos Gergely

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread wang yaoxin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/ --- (Updated 十一月 29, 2016, 12:16 p.m.) Review request for Ambari, Alejandro

Re: Review Request 54132: Support configurable grok filters (output + ambari)

2016-11-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54132/#review157233 ---

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-11-29 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/#review157242 ---

Review Request 54159: Log Search external login credential let every user in

2016-11-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54159/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs:

Re: Review Request 54132: Support configurable grok filters (output + ambari)

2016-11-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54132/#review157236 --- Ship it! Ship It! - Miklos Gergely On Nov. 29, 2016, 12:46

Re: Review Request 54159: Log Search external login credential let every user in

2016-11-29 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54159/#review157240 --- Fix it, then Ship it!

Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

2016-11-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54161/ --- (Updated Nov. 29, 2016, 1:36 p.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread wang yaoxin
> On 十一月 29, 2016, 11:55 a.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > line 87 > > > > > > unnecessary space before `;` Thanks Attila, I have

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157239 --- Ship it! Ship It! - Attila Doroszlai On Nov. 29, 2016, 1:16

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread Attila Doroszlai
> On Nov. 29, 2016, 12:55 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > line 87 > > > > > > unnecessary space before `;` > > wang yaoxin wrote:

Re: Review Request 54162: Fix markup for widgets browser

2016-11-29 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54162/#review157241 --- Ship it! Ship It! - Andrii Tkach On Nov. 29, 2016, 1:09

Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

2016-11-29 Thread Miklos Gergely
> On Nov. 29, 2016, 1:19 p.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, > > line 132 > > > > > > I think stack advisor changes are missing.

Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

2016-11-29 Thread Oliver Szabo
> On Nov. 29, 2016, 1:19 p.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, > > line 132 > > > > > > I think stack advisor changes are missing.

Review Request 54164: RegionServer Restart During Upgrade Fails Because of Missing Import When Formatting PID

2016-11-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54164/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-19015

Re: Review Request 54164: RegionServer Restart During Upgrade Fails Because of Missing Import When Formatting PID

2016-11-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54164/ --- (Updated Nov. 29, 2016, 8:50 a.m.) Review request for Ambari, Nate Cole and

Re: Review Request 54155: Fix input height in filters with dropdown

2016-11-29 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54155/#review157225 --- Ship it! Ship It! - Oleg Nechiporenko On Nov. 29, 2016,

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157224 ---

Re: Review Request 54132: Support configurable grok filters (output + ambari)

2016-11-29 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54132/ --- (Updated Nov. 29, 2016, 12:46 p.m.) Review request for Ambari, Miklos Gergely

Re: Review Request 54125: Abillity to enable SPNEGO on Log Search Portal UI from Ambari

2016-11-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54125/#review157234 --- Fix it, then Ship it!

Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

2016-11-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54161/ --- (Updated Nov. 29, 2016, 2:10 p.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 54086: AMBARI-18987 A general preupgrade check on if services cannot be upgrade are installed

2016-11-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54086/#review157246 --- Can you confirm that this will not be changing existing clusters

Re: Review Request 54163: Add Service Wizard: error thrown during transition on deploy step

2016-11-29 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54163/#review157245 --- Ship it! Ship It! - Alexandr Antonenko On Nov. 29, 2016,

Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

2016-11-29 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54161/ --- (Updated Nov. 29, 2016, 2:25 p.m.) Review request for Ambari, Oliver Szabo,

Re: Review Request 54164: RegionServer Restart During Upgrade Fails Because of Missing Import When Formatting PID

2016-11-29 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54164/#review157252 --- Ship it! Ship It! - Robert Levas On Nov. 29, 2016, 8:50

Re: Review Request 53943: Improve remoteIp in audit log

2016-11-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53943/#review157255 --- Fix it, then Ship it!

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-11-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/#review157256 ---

Re: Review Request 54080: Preview: Auto-fix common issues found by the DB consistency checker

2016-11-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/#review157258 ---

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/ --- (Updated Ноя. 29, 2016, 3:54 п.п.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/#review157263 --- ambari-server/src/main/python/ambari_server_main.py (line 105)

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review157270 --- Ping. This looks like it was submitted. Can you close the review?

Re: Review Request 54164: RegionServer Restart During Upgrade Fails Because of Missing Import When Formatting PID

2016-11-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54164/#review157260 --- Ship it! Ship It! - Nate Cole On Nov. 29, 2016, 8:50 a.m.,

Re: Review Request 54080: Preview: Auto-fix common issues found by the DB consistency checker

2016-11-29 Thread Dmitro Lisnichenko
> On Nov. 29, 2016, 5:42 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, > > lines 518-523 > > > > > > Really? They both are

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-11-29 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/#review157257 ---

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/ --- (Updated Ноя. 29, 2016, 4:53 п.п.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Dmytro Sen
> On Ноя. 29, 2016, 4:02 п.п., Sumit Mohanty wrote: > > ambari-server/src/main/python/ambari_server_main.py, line 107 > > > > > > Nit - remove #seconds Fixed - Dmytro

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-11-29 Thread Nahappan Somasundaram
> On Nov. 29, 2016, 8:42 a.m., Nate Cole wrote: > > What's the state of this review? There is a small change to the patch that I'm testing out. Will publish that and submit it today. Thank you. - Nahappan --- This is an automatically

Re: Review Request 54159: Log Search external login credential let every user in

2016-11-29 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54159/#review157275 --- Ship it! Ship It! - Robert Nettleton On Nov. 29, 2016, 1:42

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/ --- (Updated Ноя. 29, 2016, 5:04 п.п.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/#review157278 --- ambari-server/src/main/python/ambari_server/utils.py (line 163)

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Sid Wagle
> On Nov. 29, 2016, 5:26 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/python/ambari_server/utils.py, lines 168-170 > > > > > > Removing initialization of `tstart` would cause `local variable > >

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/#review157283 --- Ship it! Ship It! - Sid Wagle On Nov. 29, 2016, 5:04 p.m.,

Re: Review Request 54161: Abillity to use external Solr for Log Search instead of AMBARI_INFRA_SOLR

2016-11-29 Thread Oliver Szabo
> On Nov. 29, 2016, 1:19 p.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, > > line 132 > > > > > > I think stack advisor changes are missing.

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-11-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157285 --- ambari-agent/pom.xml (lines 671 - 680)

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Dmytro Sen
> On Ноя. 29, 2016, 5:26 п.п., Attila Doroszlai wrote: > > ambari-server/src/main/python/ambari_server/utils.py, lines 168-170 > > > > > > Removing initialization of `tstart` would cause `local variable > >

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-11-29 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157271 --- What's the state of this review? - Nate Cole On Nov. 14, 2016,

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/ --- (Updated Ноя. 29, 2016, 5:04 п.п.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-11-29 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Nov. 29, 2016, 9:07 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 53588: Allow acceptor / seclector configuration for API and agent connectors

2016-11-29 Thread Sid Wagle
> On Nov. 29, 2016, 4:29 p.m., Jonathan Hurley wrote: > > Ping. This looks like it was submitted. Can you close the review? Done. Thanks for the reminder. - Sid --- This is an automatically generated e-mail. To reply, visit:

Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster

2016-11-29 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54169/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj,

Re: Review Request 54124: ambari-server.pid might not be created on slow hardware

2016-11-29 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54124/ --- (Updated Ноя. 29, 2016, 6:14 п.п.) Review request for Ambari, Sumit Mohanty,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-11-29 Thread Nahappan Somasundaram
> On Nov. 29, 2016, 10:16 a.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 165-170 > > > > > > The problem with the Orchestrator doing this is that the

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-11-29 Thread Nate Cole
> On Nov. 29, 2016, 1:16 p.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 165-170 > > > > > > The problem with the Orchestrator doing this is that the

Re: Review Request 54169: AMBARI-19007 Atlas to support configuration of hooks from separate cluster

2016-11-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54169/#review157296 ---