Re: Review Request 54187: Perf: Simulate alerts for multiple Ambari Agents running on single Host

2016-12-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54187/ --- (Updated Гру. 1, 2016, 1:51 після полудня) Review request for Ambari,

Re: Review Request 54254: Delete service action should show the config recommendation popup

2016-12-01 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54254/#review157589 --- Ship it! Ship It! - Andrii Tkach On Dec. 1, 2016, 2 p.m.,

Re: Review Request 54207: HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has no attribute 'split'"

2016-12-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54207/ --- (Updated Дек. 1, 2016, 2:30 п.п.) Review request for Ambari, Aravindan Vijayan

Re: Review Request 54249: Remove unnecessary Log Feeder Date Mapper tests

2016-12-01 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54249/#review157590 --- Ship it! Ship It! - Robert Nettleton On Dec. 1, 2016, 10:16

Re: Review Request 52155: ambari server upgrade ambari to 2.1.1 duplicate key error

2016-12-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52155/#review157597 --- Ship it! Ship It! - Jonathan Hurley On Nov. 21, 2016, 2:52

Review Request 54254: Delete service action should show the config recommendation popup

2016-12-01 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54254/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-19048

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-01 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/ --- (Updated Dec. 1, 2016, 2:25 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 54187: Perf: Simulate alerts for multiple Ambari Agents running on single Host

2016-12-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54187/#review157587 --- Ship it! Ship It! - Dmytro Sen On Дек. 1, 2016, 1:53 п.п.,

Re: Review Request 54080: Preview: Auto-fix common issues found by the DB consistency checker

2016-12-01 Thread Dmitro Lisnichenko
> On Nov. 29, 2016, 5:42 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, > > lines 518-523 > > > > > > Really? They both are

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-12-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/#review157602 --- Ship it! Ship It! - Jonathan Hurley On Nov. 30, 2016, 6:54

Re: Review Request 54080: Preview: Auto-fix common issues found by the DB consistency checker

2016-12-01 Thread Jonathan Hurley
> On Nov. 29, 2016, 10:42 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, > > lines 518-523 > > > > > > Really? They both are

Re: Review Request 54224: Upgrade History Displays Wrong Upgrade Type

2016-12-01 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54224/#review157599 --- Ship it! Ship It! - Di Li On Dec. 1, 2016, 10:13 a.m.,

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157607 ---

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-12-01 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/#review157600 --- Ship it! Ship It! - Di Li On Nov. 30, 2016, 11:54 p.m.,

Re: Review Request 54207: HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has no attribute 'split'"

2016-12-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54207/ --- (Updated Дек. 1, 2016, 4:01 п.п.) Review request for Ambari, Aravindan Vijayan

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-01 Thread Nahappan Somasundaram
> On Dec. 1, 2016, 9:04 a.m., Jonathan Hurley wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 150-154 > > > > > > If you use the temp directory, don't you run the risk

Review Request 54257: Re-arrange "Role Based Access Control" info table

2016-12-01 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54257/ --- Review request for Ambari and Andriy Babiichuk. Bugs: AMBARI-19052

Re: Review Request 54207: HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has no attribute 'split'"

2016-12-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54207/ --- (Updated Дек. 1, 2016, 4:44 п.п.) Review request for Ambari, Aravindan Vijayan

Review Request 54259: In stack version, build number should not be mandatory

2016-12-01 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54259/ --- Review request for Ambari, Alejandro Fernandez and Di Li. Bugs: AMBARI-19039

Re: Review Request 54259: In stack version, build number should not be mandatory

2016-12-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54259/#review157628 ---

Re: Review Request 54207: HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has no attribute 'split'"

2016-12-01 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54207/#review157625 --- Ship it! Ship It! - Aravindan Vijayan On Dec. 1, 2016, 4:44

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/#review157631 --- Fix it, then Ship it!

Review Request 54267: RU: wrong version exposed when Downgrade is going

2016-12-01 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54267/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs:

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-01 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53747/ --- (Updated Dec. 1, 2016, 1:50 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/ --- Review request for Ambari, Nate Cole and Robert Levas. Bugs: AMBARI-19055

Re: Review Request 54265: AMBARI-19056. Add two new options from Ambari to LlapServiceDriver. (1). --skiphadoopversion (2). --skiphbasecp.

2016-12-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54265/#review157655 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 1, 2016,

Review Request 54265: AMBARI-19056. Add two new options from Ambari to LlapServiceDriver. (1). --skiphadoopversion (2). --skiphbasecp.

2016-12-01 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54265/ --- Review request for Ambari, Alejandro Fernandez, Sergey Shelukhin, and Sumit

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-01 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/#review157638 ---

Re: Review Request 53747: AMBARI-18888: Ambari-agent: Create configuration files with JCEKS information

2016-12-01 Thread Nahappan Somasundaram
> On Dec. 1, 2016, 11:44 a.m., Nate Cole wrote: > > ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py, > > lines 226-227 > > > > > > The default password of the keystore file from

Re: Review Request 54267: RU: wrong version exposed when Downgrade is going

2016-12-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54267/#review157666 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 1, 2016,

Re: Review Request 54267: RU: wrong version exposed when Downgrade is going

2016-12-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54267/#review157672 --- Ship it! Ship It! - Jonathan Hurley On Dec. 1, 2016, 4:45

Review Request 54270: Perf: Deploy 3000 Agent cluster and find perf bugs

2016-12-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54270/ --- Review request for Ambari, Alejandro Fernandez, Dmytro Sen, and Sid Wagle.

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/ --- (Updated Dec. 1, 2016, 5:45 p.m.) Review request for Ambari, Nate Cole and

Re: Review Request 54264: Removing Tasks From host_role_command Causes Upgrades To Show As PENDING

2016-12-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54264/#review157663 ---

Review Request 54276: AMBARI-19038: Support migration of LDAP users & groups to PAM

2016-12-01 Thread Vishal Ghugare
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54276/ --- Review request for Ambari, Alejandro Fernandez and Di Li. Bugs: AMBARI-19038

Re: Review Request 54257: Re-arrange "Role Based Access Control" info table

2016-12-01 Thread Andriy Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54257/#review157613 --- Ship it! Ship It! - Andriy Babiichuk On Гру. 1, 2016, 5:29

Re: Review Request 54270: Perf: Deploy 3000 Agent cluster and find perf bugs

2016-12-01 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54270/ --- (Updated Гру. 2, 2016, 12:57 до полудня) Review request for Ambari, Alejandro

Re: Review Request 54277: AMBARI-19060. Update the HiveServer config values if Security Authorization chosen is None.

2016-12-01 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54277/#review157681 --- Ship it! Ship It! - Thejas Nair On Dec. 2, 2016, 12:59

Re: Review Request 54277: AMBARI-19060. Update the HiveServer config values if Security Authorization chosen is None.

2016-12-01 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54277/#review157691 --- Ship it! Ship It! - Sumit Mohanty On Dec. 2, 2016, 12:59

Review Request 54277: AMBARI-19060. Update the HiveServer config values if Security Authorization chosen is None.

2016-12-01 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54277/ --- Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Thejas Nair.

Re: Review Request 54244: CAPACITY-SCHEDULER & PIG View not loading for Ambari-2.5.0

2016-12-01 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54244/#review157578 --- Ship it! Ship It! - Nitiraj Rathore On Dec. 1, 2016, 6:47

Review Request 54253: Select Versions page: 'Remove' tooltip does not disappear

2016-12-01 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54253/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-19047

Re: Review Request 54253: Select Versions page: 'Remove' tooltip does not disappear

2016-12-01 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54253/#review157581 --- Ship it! Ship It! - Andrii Tkach On Dec. 1, 2016, 12:22

Re: Review Request 53943: Improve remoteIp in audit log

2016-12-01 Thread wang yaoxin
> On 十一月 29, 2016, 3:26 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/utils/RequestUtils.java, > > lines 53-55 > > > > > > This would actually do indexOf twice in cases where

Re: Review Request 54207: HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has no attribute 'split'"

2016-12-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54207/ --- (Updated Дек. 1, 2016, 11:14 д.п.) Review request for Ambari, Aravindan

Re: Review Request 54207: HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has no attribute 'split'"

2016-12-01 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54207/ --- (Updated Дек. 1, 2016, 11:16 д.п.) Review request for Ambari, Aravindan

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-01 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54252/ --- (Updated Dec. 1, 2016, 11:15 a.m.) Review request for Ambari, Attila

Re: Review Request 54207: HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has no attribute 'split'"

2016-12-01 Thread Dmytro Sen
> On Ноя. 30, 2016, 8:10 п.п., Aravindan Vijayan wrote: > > ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py, line > > 31 > > > > > > Do we need an empty check for "all_collectors_string" here ?

Re: Review Request 54249: Remove unnecessary Log Feeder Date Mapper tests

2016-12-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54249/#review157566 --- Ship it! Ship It! - Oliver Szabo On Dec. 1, 2016, 10:16

Re: Review Request 54031: Remove Zeppelin View from Ambari

2016-12-01 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54031/ --- (Updated Dec. 1, 2016, 10:54 a.m.) Review request for Ambari, Alejandro

Re: Review Request 54031: Remove Zeppelin View from Ambari

2016-12-01 Thread Renjith Kamath
> On Nov. 30, 2016, 7:18 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 183 > > > > > > Do these tables also need to delete the

Re: Review Request 54031: Remove Zeppelin View from Ambari

2016-12-01 Thread Renjith Kamath
> On Nov. 30, 2016, 7:18 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 183 > > > > > > Do these tables also need to delete the

Re: Review Request 54224: Upgrade History Displays Wrong Upgrade Type

2016-12-01 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54224/ --- (Updated Dec. 1, 2016, 10:13 a.m.) Review request for Ambari and Aleksandr

Re: Review Request 54208: Log Search: Cannot increase the number of shards per node for solr collections

2016-12-01 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54208/ --- (Updated Dec. 1, 2016, 10:32 a.m.) Review request for Ambari, Miklos Gergely,

Re: Review Request 54145: EU to message users to start YARN queues if work preserving recovery is disabled

2016-12-01 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/#review157583 --- Ship it! Ship It! - Tim Thorpe On Nov. 30, 2016, 11:54

Re: Review Request 54270: Perf: Deploy 3000 Agent cluster and find perf bugs

2016-12-01 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54270/#review157701 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 2, 2016,