Re: Review Request 55485: Log Search Troubleshooting tab should allow to multi select services

2017-01-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55485/#review161545 --- Ship it! Ship It! - Robert Nettleton On Jan. 13, 2017, 9:51

Re: Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

2017-01-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55513/#review161554 ---

Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records

2017-01-13 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55516/ --- Review request for Ambari, DIPAYAN BHOWMICK and Nitiraj Rathore. Bugs:

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file

2017-01-13 Thread Alejandro Fernandez
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, > > line 246 > > > > > > -1. If the config doesn't

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file

2017-01-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55387/#review161594 --- Ship it! Ship It! - Alejandro Fernandez On Jan. 13, 2017,

Review Request 55524: Add log rotation settings to Hive, Druid, Storm

2017-01-13 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55524/ --- Review request for Ambari and Sumit Mohanty. Bugs: AMBARI-19538

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file

2017-01-13 Thread Alejandro Fernandez
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, > > line 246 > > > > > > -1. If the config doesn't

Review Request 55523: When viewing details of a group, the group type is sometimes empty

2017-01-13 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55523/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-19535

Re: Review Request 55522: Incorrect error message when trying to add a group to multiple roles

2017-01-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55522/#review161599 --- Ship it! Ship It! - Di Li On Jan. 13, 2017, 9:35 p.m.,

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is

2017-01-13 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55482/#review161592 --- Looked at the changes in stack-advisor. Mostly look good to me.

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file

2017-01-13 Thread Alejandro Fernandez
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, > > line 246 > > > > > > -1. If the config doesn't

Re: Review Request 55387: AMBARI-19446: Able to skip writing configuration files when the config type doesn't exist in the command JSON file

2017-01-13 Thread Di Li
> On Jan. 10, 2017, 7:11 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py, > > line 246 > > > > > > -1. If the config doesn't

Review Request 55518: When defining yarn.scheduler.capacity..accessible-node-labels with space, Yarn Queue Manager shows error for the queue

2017-01-13 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55518/ --- Review request for Ambari, Di Li and Gaurav Nagar. Bugs: AMBARI-19451

Review Request 55522: Incorrect error message when trying to add a group to multiple roles

2017-01-13 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55522/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-19476

Re: Review Request 55518: When defining yarn.scheduler.capacity..accessible-node-labels with space, Yarn Queue Manager shows error for the queue

2017-01-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55518/#review161597 --- Ship it! Ship It! - Di Li On Jan. 13, 2017, 7:53 p.m.,

Review Request 55511: Ambari views : Adding new FileSystem support to views should work without code changes

2017-01-13 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55511/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha,

Review Request 55515: Perf: Create Rolling and Express Upgrade Packs

2017-01-13 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55515/ --- Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and

Re: Review Request 55508: Host-Ordered Upgrade packs are named incorrectly

2017-01-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55508/#review161548 --- Ship it! Ship It! - Jonathan Hurley On Jan. 13, 2017, 12:15

Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

2017-01-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55513/ --- Review request for Ambari, Alejandro Fernandez, Attila Magyar, Eugene

Re: Review Request 55511: Ambari views : Adding new FileSystem support to views should work without code changes

2017-01-13 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55511/#review161558 --- Ship it! Ship It! - Gaurav Nagar On Jan. 13, 2017, 5:57

Re: Review Request 55514: Improve "Install Wizard step 2-10" after new guidelines

2017-01-13 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55514/#review161562 --- Ship it! Ship It! - Vivek Ratnavel Subramanian On Jan. 13,

Review Request 55514: Improve "Install Wizard step 2-10" after new guidelines

2017-01-13 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55514/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel

Re: Review Request 55486: AMBARI-19417. Enable hiveContext in Livy

2017-01-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55486/#review161561 --- Fix it, then Ship it!

Re: Review Request 55493: Log Search Add 'last 24 hours' to the time picker buttons

2017-01-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55493/#review161547 --- Ship it! - Robert Nettleton On Jan. 13, 2017, 10:36 a.m.,

Re: Review Request 55493: Log Search Add 'last 24 hours' to the time picker buttons

2017-01-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55493/#review161546 --- Ship it! Ship It! - Robert Nettleton On Jan. 13, 2017,

Re: Review Request 55481: Downgrade executes section if is not defined

2017-01-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55481/ --- (Updated Jan. 13, 2017, 12:44 p.m.) Review request for Ambari, Alejandro

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is

2017-01-13 Thread Sumit Mohanty
> On Jan. 13, 2017, 10:06 p.m., Siddharth Seth wrote: > > Looked at the changes in stack-advisor. Mostly look good to me. > > Was a little confused by the change to minContainerSize based on whether > > the used change the yarn min-allocation-mb property. So the scenarios that I am trying to

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is

2017-01-13 Thread Sumit Mohanty
> On Jan. 14, 2017, 12:42 a.m., Siddharth Seth wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py, > > line 1044 > > > > > > If we leave minContainerSize unchanged here - the

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is

2017-01-13 Thread Sumit Mohanty
> On Jan. 13, 2017, 10:06 p.m., Siddharth Seth wrote: > > Looked at the changes in stack-advisor. Mostly look good to me. > > Was a little confused by the change to minContainerSize based on whether > > the used change the yarn min-allocation-mb property. > > Sumit Mohanty wrote: > So the

Re: Review Request 55524: Add log rotation settings to Hive, Druid, Storm

2017-01-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55524/#review161605 --- Ship it! Ship It! - Sumit Mohanty On Jan. 13, 2017, 9:48

Re: Review Request 55528: Re-order rows in HDFS-TopN Grafana Dashboard

2017-01-13 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55528/#review161633 --- Ship it! Ship It! - Yusaku Sako On Jan. 14, 2017, 1:11

Review Request 55527: Possibly too frequent calls to stack advisor as user changes sliders

2017-01-13 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55527/ --- Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako. Bugs:

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is

2017-01-13 Thread Siddharth Seth
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55482/#review161628 ---

Re: Review Request 55486: AMBARI-19417. Enable hiveContext in Livy

2017-01-13 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55486/ --- (Updated Jan. 14, 2017, 12:51 a.m.) Review request for Ambari and Alejandro

Re: Review Request 55529: PREVIEW. HDP 3.0 TP - create Service Advisor for HDFS

2017-01-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55529/#review161632 ---

Re: Review Request 55482: AM sizing for LLAP - modify YARN min container size to a smaller value leaving all other properties as is

2017-01-13 Thread Siddharth Seth
> On Jan. 13, 2017, 10:06 p.m., Siddharth Seth wrote: > > Looked at the changes in stack-advisor. Mostly look good to me. > > Was a little confused by the change to minContainerSize based on whether > > the used change the yarn min-allocation-mb property. > > Sumit Mohanty wrote: > So the

Review Request 55528: Re-order rows in HDFS-TopN Grafana Dashboard

2017-01-13 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55528/ --- Review request for Ambari, Jaimin Jetly, Xi Wang, and Yusaku Sako. Bugs:

Re: Review Request 55527: Possibly too frequent calls to stack advisor as user changes sliders

2017-01-13 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55527/ --- (Updated Jan. 14, 2017, 12:41 a.m.) Review request for Ambari, Jaimin Jetly,

Review Request 55529: PREVIEW. HDP 3.0 TP - create Service Advisor for HDFS

2017-01-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55529/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Sumit Mohanty,

Re: Review Request 55308: AMBARI-19414. Cannot install Accumulo via blueprint with default settings

2017-01-13 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55308/#review161540 --- Ship it! Ship It! - Laszlo Puskas On Jan. 11, 2017, 9:28

Re: Review Request 55308: AMBARI-19414. Cannot install Accumulo via blueprint with default settings

2017-01-13 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55308/#review161541 --- Ship it! Ship It! - Sandor Magyari On Jan. 11, 2017, 9:28

Re: Review Request 55523: When viewing details of a group, the group type is sometimes empty

2017-01-13 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55523/#review161640 --- Ship it! Ship It! - Alexandr Antonenko On Jan. 13, 2017,

Re: Review Request 55518: When defining yarn.scheduler.capacity..accessible-node-labels with space, Yarn Queue Manager shows error for the queue

2017-01-13 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55518/#review161639 --- Ship it! Ship It! - Gaurav Nagar On Jan. 13, 2017, 7:53

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-13 Thread Madhuvanthi Radhakrishnan
> On Jan. 13, 2017, 1:56 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigUpgradeChangeDefinition.java, > > line 226 > > > > > > I don't think you want

Re: Review Request 55083: AMBARI-19029 : Atlas web UI inaccessible alert after enabling Namenode-HA.

2017-01-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55083/#review161638 --- Ship it! Ship It! - Sumit Mohanty On Jan. 13, 2017, 1:42

Re: Review Request 55501: Hive View 2.0: Saving worksheet as saved query

2017-01-13 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55501/ --- (Updated Jan. 14, 2017, 3:35 a.m.) Review request for Ambari, DIPAYAN

Review Request 55502: AMBARI-19525: Unit Test failure during schema verification of configuration files

2017-01-13 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55502/ --- Review request for Ambari, Dmytro Grinenko, Sumit Mohanty, and Yusaku Sako.

Re: Review Request 55502: AMBARI-19525: Unit Test failure during schema verification of configuration files

2017-01-13 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55502/#review161527 --- Ship it! Ship It! - Nate Cole On Jan. 13, 2017, 9:15 a.m.,

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-13 Thread Madhuvanthi Radhakrishnan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55478/ --- (Updated Jan. 14, 2017, 5:06 a.m.) Review request for Ambari, Alejandro

Review Request 55484: Two SelectBoxes don't have class `form-control`

2017-01-13 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55484/ --- Review request for Ambari and Denys Buzhor. Bugs: ambari-19517

Re: Review Request 55007: AMBARI-19288 : Do not install hive-hook from Ambari if falcon client is installed

2017-01-13 Thread Vishal Suvagia
> On Jan. 11, 2017, 7:26 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py, > > line 126 > > > > > > Extra closing parenthesis.

Re: Review Request 55007: AMBARI-19288 : Do not install hive-hook from Ambari if falcon client is installed

2017-01-13 Thread Vishal Suvagia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55007/ --- (Updated Jan. 13, 2017, 9:32 a.m.) Review request for Ambari, Alejandro

Re: Review Request 55444: AMBARI-19478: Need to handle unsupported configurations gracefully in workflow actions.

2017-01-13 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55444/#review161497 --- Ship it! Ship It! - Gaurav Nagar On Jan. 12, 2017, 6:49

Re: Review Request 55484: Two SelectBoxes don't have class `form-control`

2017-01-13 Thread Denys Buzhor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55484/#review161492 --- Ship it! Ship It! - Denys Buzhor On Jan. 13, 2017, 9:15

Re: Review Request 55481: Downgrade executes section if is not defined

2017-01-13 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55481/#review161495 --- Ship it! Ship It! - Dmitro Lisnichenko On Jan. 13, 2017,

Review Request 55492: Log Feeder should store keystore / truststore passwords in files

2017-01-13 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55492/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs:

Re: Review Request 55494: Ambari agents not recovering from heart beat lost state immediately after successful re-registering with server

2017-01-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55494/#review161502 --- Ship it! Ship It! - Attila Doroszlai On Jan. 13, 2017,

Review Request 55486: AMBARI-19417. Enable hiveContext in Livy

2017-01-13 Thread Jeff Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55486/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-19417

Review Request 55494: Ambari agents not recovering from heart beat lost state immediately after successful re-registering with server

2017-01-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55494/ --- Review request for Ambari, Attila Doroszlai, Andrew Onischuk, and Sandor

Review Request 55493: Log Search Add 'last 24 hours' to the time picker buttons

2017-01-13 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55493/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs:

Re: Review Request 55492: Log Feeder should store keystore / truststore passwords in files

2017-01-13 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55492/ --- (Updated Jan. 13, 2017, 10:52 a.m.) Review request for Ambari, Oliver Szabo

Review Request 55485: Log Search Troubleshooting tab should allow to multi select services

2017-01-13 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55485/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs:

Re: Review Request 55493: Log Search Add 'last 24 hours' to the time picker buttons

2017-01-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55493/#review161511 --- Ship it! Ship It! - Oliver Szabo On Jan. 13, 2017, 10:36

Re: Review Request 55492: Log Feeder should store keystore / truststore passwords in files

2017-01-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55492/#review161510 --- Ship it! Ship It! - Oliver Szabo On Jan. 13, 2017, 10:52

Review Request 55501: Hive View 2.0: Saving worksheet as saved query

2017-01-13 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55501/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and

Re: Review Request 55469: Hive Metastore process cannot be determined to be up and listening on the network

2017-01-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55469/#review161521 --- Ship it! Ship It! - Jonathan Hurley On Jan. 12, 2017, 4:55

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55478/#review161523 ---

Re: Review Request 55481: Downgrade executes section if is not defined

2017-01-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55481/#review161525 --- Ship it! Sweet! This should really help prevent unwanted

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2017-01-13 Thread ping wang
> On 一月 3, 2017, 4:09 p.m., Di Li wrote: > > Ship It! Hi Di, could you please help commit the code? Thanks! - ping --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54970/#review160392

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2017-01-13 Thread ping wang
> On 一月 11, 2017, 7:18 p.m., Alejandro Fernandez wrote: > > Ship It! Hi Alejandro, thank you very much for your approval! - ping --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 55481: Downgrade executes section if is not defined

2017-01-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55481/#review161508 --- Ship it! Ship It! - Tim Thorpe On Jan. 13, 2017, 1:42 a.m.,

Re: Review Request 55501: Hive View 2.0: Saving worksheet as saved query

2017-01-13 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55501/ --- (Updated Jan. 13, 2017, 1:42 p.m.) Review request for Ambari, DIPAYAN

Re: Review Request 55429: Run ZK operations in logsearch internally and enable ACL security for LogSearch/Solr

2017-01-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55429/ --- (Updated Jan. 13, 2017, 12:40 p.m.) Review request for Ambari, Miklos Gergely

Re: Review Request 55485: Log Search Troubleshooting tab should allow to multi select services

2017-01-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55485/#review161513 --- Ship it! Ship It! - Oliver Szabo On Jan. 13, 2017, 9:51

Re: Review Request 55478: Add log rotation settings - handle upgrade scenario

2017-01-13 Thread Jonathan Hurley
> On Jan. 12, 2017, 8:20 p.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml, > > line 173 > > > > > > INFRA_SOLR is not part of the HDP upgrade (instead of

Re: Review Request 55083: AMBARI-19029 : Atlas web UI inaccessible alert after enabling Namenode-HA.

2017-01-13 Thread Vishal Suvagia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55083/ --- (Updated Jan. 13, 2017, 1:42 p.m.) Review request for Ambari, Alejandro

Review Request 55503: AMBARI-19526 : Ambari should mark oozie servers to be restarted when atlas hook configs or jars change.

2017-01-13 Thread Vishal Suvagia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55503/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Madhan Neethiraj,

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-13 Thread Mugdha Varadkar
> On Jan. 12, 2017, 10:53 p.m., Jayush Luniya wrote: > > ambari-web/app/controllers/wizard/step7_controller.js, line 539 > > > > > > Is this supposed to be part of the fix? Yes we need to revert the earlier UI

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-13 Thread Mugdha Varadkar
> On Jan. 12, 2017, 10:53 p.m., Jayush Luniya wrote: > > ambari-web/app/controllers/main/service/info/configs.js, line 518 > > > > > > Is this supposed to be part of the fix? Yes we need to revert the earlier UI

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2017-01-13 Thread Di Li
> On Jan. 3, 2017, 4:09 p.m., Di Li wrote: > > Ship It! > > ping wang wrote: > Hi Di, could you please help commit the code? Thanks! Done. Please close this RB request. - Di --- This is an automatically generated e-mail. To reply,

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-13 Thread Mugdha Varadkar
> On Jan. 12, 2017, 10:57 p.m., Jayush Luniya wrote: > > Patch doesnt apply cleanly on latest trunk. Can you update the patch? @Jayush I have attached the latest patch for trunk on https://issues.apache.org/jira/secure/attachment/12847349/AMBARI-19044.2.trunk.patch - Mugdha

Re: Review Request 55503: AMBARI-19526 : Ambari should mark oozie servers to be restarted when atlas hook configs or jars change.

2017-01-13 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55503/#review161535 --- Ship it! Ship It! - Mugdha Varadkar On Jan. 13, 2017, 3:28

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-13 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/ --- (Updated Jan. 13, 2017, 3:33 p.m.) Review request for Ambari, Alejandro

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-13 Thread Mugdha Varadkar
> On Jan. 12, 2017, 10:55 p.m., Jayush Luniya wrote: > > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py, line > > 1551 > > > > > > Please run without -DskipPythonTests flag Updated unit

Re: Review Request 55502: AMBARI-19525: Unit Test failure during schema verification of configuration files

2017-01-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55502/#review161538 --- Ship it! Ship It! - Robert Levas On Jan. 13, 2017, 9:15