Re: Review Request 57610: Tokenize kerberos principal name appearing in kerberos rules in exported blueprint

2017-04-13 Thread Amruta Borkar
> On April 10, 2017, 8:54 p.m., Sandor Magyari wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java > > Lines 3042 (patched) > > > > > > Caching

Re: Review Request 58431: Update zookeeper.connect description

2017-04-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58431/#review171929 --- Ship it! Ship It! - Di Li On April 13, 2017, 8:11 p.m.,

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

2017-04-13 Thread Bharat Viswanadham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56677/ --- (Updated April 13, 2017, 8:44 p.m.) Review request for Ambari, Alejandro

Re: Review Request 56673: Perform Kinit on Kafka Start

2017-04-13 Thread Di Li
> On April 7, 2017, 12:48 p.m., Di Li wrote: > > Ship It! > > Bharat Viswanadham wrote: > Hi Di, > Could you please help in commit these changes. Please close this request, as it has been pushed to trunk as

Re: Review Request 58429: After pam setup- Hive View user home test fails

2017-04-13 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58429/ --- (Updated April 13, 2017, 6:45 p.m.) Review request for Ambari, Attila

Re: Review Request 58244: Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin

2017-04-13 Thread Di Li
> On April 7, 2017, 4:57 p.m., Di Li wrote: > > Ship It! > > Bharat Viswanadham wrote: > Hi Di, > Could you please help in commit these changes. Please close this RB request as it has been pushed to trunk as

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Sid Wagle
> On April 13, 2017, 5:31 p.m., Aravindan Vijayan wrote: > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > > Line 153 (original), 157 (patched) > >

Re: Review Request 58417: Update docker volumes for Ambari logsearch integration test module

2017-04-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58417/#review171930 --- Ship it! Ship It! - Robert Nettleton On April 13, 2017,

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58423/ --- (Updated April 13, 2017, 6:19 p.m.) Review request for Ambari, Di Li and

Re: Review Request 58346: AMBARI-20733 /var/log/krb5kdc.log is growing rapidly on the KDC server

2017-04-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58346/#review171912 --- Ship it! Ship It! - Robert Levas On April 13, 2017, 8:29

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

2017-04-13 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58356/#review171939 --- Ship it! Ship It! - Jayush Luniya On April 13, 2017, 3:44

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58423/ --- (Updated April 13, 2017, 6:07 p.m.) Review request for Ambari, Di Li and

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

2017-04-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58415/#review171869 --- Fix it, then Ship it!

Re: Review Request 58429: After pam setup- Hive View user home test fails

2017-04-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58429/#review171916 --- Can you add Vishal Ghugare to the review? - Robert Levas On

Re: Review Request 58431: Update zookeeper.connect description

2017-04-13 Thread Bharat Viswanadham
> On April 13, 2017, 8:26 p.m., Di Li wrote: > > Ship It! Hi Di, Could you please help in commit these changes. - Bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58431/#review171929

Re: Review Request 58244: Stack advisor code in 2.3 refactor logic for ranger Kafka Plugin

2017-04-13 Thread Bharat Viswanadham
> On April 7, 2017, 4:57 p.m., Di Li wrote: > > Ship It! Hi Di, Could you please help in commit these changes. - Bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58244/#review171367

Re: Review Request 58431: Update zookeeper.connect description

2017-04-13 Thread Bharat Viswanadham
> On April 13, 2017, 7:54 p.m., Di Li wrote: > > hello Bharat, > > > > Could you please update the review board request with the Ambari JIRA ID , > > branch the issue applies, tests done, etc ? Updated fields required. - Bharat ---

Review Request 58433: Add more database options for beacon in stack advisor

2017-04-13 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58433/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

2017-04-13 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58423/#review171908 --- Ship it! Ship It! - Sangeeta Ravindran On April 13, 2017,

Re: Review Request 58431: Update zookeeper.connect description

2017-04-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58431/#review171925 --- hello Bharat, Could you please update the review board request

Re: Review Request 58431: Update zookeeper.connect description

2017-04-13 Thread Bharat Viswanadham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58431/ --- (Updated April 13, 2017, 8:11 p.m.) Review request for Ambari, Alejandro

Review Request 58411: AMBARI-20726: Aggregate alert does not show status properly at Maintenance Mode change

2017-04-13 Thread Qin Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58411/ --- Review request for Ambari. Bugs: AMBARI-20726

Review Request 58416: Need to show decision conditions for decision node in Flow Graph tab

2017-04-13 Thread Madhan Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58416/ --- Review request for Ambari, belliraj hb, Gaurav Nagar, Padma Priya N, Pallav

Review Request 58415: Topology configuration type validation prior to cluster creation

2017-04-13 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58415/ --- Review request for Ambari, Attila Doroszlai, Robert Levas, Sandor Magyari, and

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

2017-04-13 Thread Bharat Viswanadham
> On April 13, 2017, 9:49 p.m., Alejandro Fernandez wrote: > > Ship It! Hi Alejandro Fernandez Could you please help me in commiting this. - Bharat --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 58409: get_value_from_jmx constantly prints exception message in retry mechanism, which brings bad user experience

2017-04-13 Thread Yuanbo Liu
> On April 13, 2017, 1:37 p.m., Di Li wrote: > > Hello Yuan Bo, > > > > Could you please > > 1. Also attach the patch to your JIRA > > 2. Click Submit Patch button on your JIRA so HadoopQA can run a round of > > integration test ? Sure - Yuanbo

Re: Review Request 58433: Add more database options for beacon in stack advisor

2017-04-13 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58433/ --- (Updated April 13, 2017, 3:08 p.m.) Review request for Ambari, Jaimin Jetly,

Re: Review Request 58437: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

2017-04-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58437/#review171957 --- Ship it! Ship It! - Sumit Mohanty On April 13, 2017, 10:21

Re: Review Request 56677: Kafka still showing deprecated property log.cleanup.interval.mins in Config Section of Kafka on Ambari

2017-04-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56677/#review171943 --- Ship it! Ship It! - Alejandro Fernandez On April 13, 2017,

Review Request 58437: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

2017-04-13 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58437/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 58433: Add more database options for beacon in stack advisor

2017-04-13 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58433/#review171951 --- Ship it! Ship It! - Jaimin Jetly On April 13, 2017, 10:08

Re: Review Request 58431: Update zookeeper.connect description

2017-04-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58431/#review171944 --- Ship it! Ship It! - Alejandro Fernandez On April 13, 2017,

Review Request 58438: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

2017-04-13 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58438/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs:

Re: Review Request 58438: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

2017-04-13 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58438/ --- (Updated April 13, 2017, 11:08 p.m.) Review request for Ambari, Alejandro

Re: Review Request 58437: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

2017-04-13 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58437/ --- (Updated April 13, 2017, 11:08 p.m.) Review request for Ambari, Alejandro

Review Request 58444: Log Feeder fill cluster name if it is not set

2017-04-13 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58444/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs:

Re: Review Request 57610: Tokenize kerberos principal name appearing in kerberos rules in exported blueprint

2017-04-13 Thread Amruta Borkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57610/ --- (Updated April 13, 2017, 6:09 p.m.) Review request for Ambari, Di Li, Robert

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

2017-04-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58423/#review171909 --- Ship it! Ship It! - Di Li On April 13, 2017, 6:19 p.m., Tim

Review Request 58431: Update zookeeper.connect description

2017-04-13 Thread Bharat Viswanadham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58431/ --- Review request for Ambari, Alejandro Fernandez and Di Li. Repository: ambari

Re: Review Request 56673: Perform Kinit on Kafka Start

2017-04-13 Thread Bharat Viswanadham
> On April 7, 2017, 12:48 p.m., Di Li wrote: > > Ship It! Hi Di, Could you please help in commit these changes. - Bharat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56673/#review171333

Re: Review Request 58429: After pam setup- Hive View user home test fails

2017-04-13 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58429/ --- (Updated April 13, 2017, 6:45 p.m.) Review request for Ambari, Attila

Review Request 58429: After pam setup- Hive View user home test fails

2017-04-13 Thread Anita Jebaraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58429/ --- Review request for Ambari, Attila Doroszlai, Henning Kropp, and Robert Levas.

Re: Review Request 58425: Remove Server attribute from the HTTP response headers

2017-04-13 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58425/#review171914 --- Ship it! Ship It! - Robert Levas On April 13, 2017, 1:16

Re: Review Request 58409: get_value_from_jmx constantly prints exception message in retry mechanism, which brings bad user experience

2017-04-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58409/#review171872 --- Hello Yuan Bo, Could you please 1. Also attach the patch to

Re: Review Request 58208: Wait For DataNodes To Shutdown During a Rolling Upgrade

2017-04-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58208/#review171876 --- Ship it! Ship It! - Jonathan Hurley On April 12, 2017, 8:57

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

2017-04-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58356/#review171877 ---

Re: Review Request 58417: Update docker volumes for Ambari logsearch integration test module

2017-04-13 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58417/#review171867 --- Ship it! Ship It! - Miklos Gergely On April 13, 2017, 12:11

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

2017-04-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58415/#review171873 ---

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

2017-04-13 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58415/#review171871 --- Ship it! Ship It! - Sandor Magyari On April 13, 2017, 10:33

Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

2017-04-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58356/ --- Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jayush Luniya,

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

2017-04-13 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58415/ --- (Updated April 13, 2017, 2:13 p.m.) Review request for Ambari, Attila

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-13 Thread zhangxiaolu zhangxiaolu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57451/ --- (Updated 四月 14, 2017, 4:52 a.m.) Review request for Ambari, Dmytro Sen, Jaimin

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-13 Thread zhangxiaolu zhangxiaolu
> On 四月 12, 2017, 4:35 p.m., Alejandro Fernandez wrote: > > In the trunk,the relative code about hadoop_conf_dir has been removed,and there is no problem , and I will cancle this jira. - zhangxiaolu --- This is an automatically

Review Request 58445: AMBARI-20738 - Cannot add repo for additional OS to an existing HDP version

2017-04-13 Thread Richard Zang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58445/ --- Review request for Ambari, Jaimin Jetly and Xi Wang. Bugs: AMBARI-20738

Re: Review Request 58416: Need to show decision conditions for decision node in Flow Graph tab

2017-04-13 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58416/#review171855 --- Ship it! Ship It! - venkat sairam On April 13, 2017, 10:42

Re: Review Request 57451: The Installation of hbase-client failed

2017-04-13 Thread zhangxiaolu zhangxiaolu
> On 四月 12, 2017, 4:35 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py > > Lines 67 (patched) > > > > > > I've actually never seen this,

Re: Review Request 58416: Need to show decision conditions for decision node in Flow Graph tab

2017-04-13 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58416/#review171853 --- Ship it! Ship It! - belliraj hb On April 13, 2017, 10:42

Re: Review Request 58409: get_value_from_jmx constantly prints exception message in retry mechanism, which brings bad user experience

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58409/#review171856 --- Ship it! Ship It! - Tim Thorpe On April 13, 2017, 4:16

Review Request 58417: Update docker volumes for Ambari logsearch integration test module

2017-04-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58417/ --- Review request for Ambari, Attila Doroszlai, Miklos Gergely, and Robert

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

2017-04-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58415/#review171866 --- Ship it! Ship It! - Sebastian Toader On April 13, 2017,

Re: Review Request 58417: Update docker volumes for Ambari logsearch integration test module

2017-04-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58417/ --- (Updated April 13, 2017, 12:11 p.m.) Review request for Ambari, Attila

Re: Review Request 58346: AMBARI-20733 /var/log/krb5kdc.log is growing rapidly on the KDC server

2017-04-13 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58346/ --- (Updated April 13, 2017, 12:29 p.m.) Review request for Ambari, Dmitro

Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58152/ --- Review request for Ambari, Alejandro Fernandez and Di Li. Bugs: AMBARI-20666

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

2017-04-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58356/#review171882 --- Ship it! Ship It! - Sebastian Toader On April 13, 2017,

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

2017-04-13 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58415/ --- (Updated April 13, 2017, 3:33 p.m.) Review request for Ambari, Attila

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

2017-04-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58356/ --- (Updated April 13, 2017, 5:44 p.m.) Review request for Ambari, Balázs Bence

Review Request 58420: AMBARI-20746 Change to warning log if Ambari doesn't have baseurls for Install Packages step before EU/RU

2017-04-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58420/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-20746

Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/ --- Review request for Ambari, Aravindan Vijayan and Sid Wagle. Bugs: AMBARI-20758

Re: Review Request 58371: AMBARI-20737 Able to hide the Use Public Repository option on Register Version page on Ambari Admin View

2017-04-13 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58371/#review171898 --- Ship it! Ship It! - Sangeeta Ravindran On April 11, 2017,

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

2017-04-13 Thread Jaimin Jetly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58356/#review171884 --- Ship it! Ship It! - Jaimin Jetly On April 13, 2017, 3:44

Re: Review Request 58420: AMBARI-20746 Change to warning log if Ambari doesn't have baseurls for Install Packages step before EU/RU

2017-04-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58420/ --- (Updated April 13, 2017, 3:59 p.m.) Review request for Ambari and Tim Thorpe.

Re: Review Request 58322: Small fixes in Log Search

2017-04-13 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58322/ --- (Updated April 13, 2017, 4:23 p.m.) Review request for Ambari, Oliver Szabo

Re: Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

2017-04-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58152/#review171887 --- Ship it! Ship It! - Di Li On April 13, 2017, 3:21 p.m., Tim

Re: Review Request 58415: Topology configuration type validation prior to cluster creation

2017-04-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58415/#review171888 --- Ship it! Ship It! - Attila Doroszlai On April 13, 2017,

Re: Review Request 58420: AMBARI-20746 Change to warning log if Ambari doesn't have baseurls for Install Packages step before EU/RU

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58420/#review171889 --- Ship it! Ship It! - Tim Thorpe On April 13, 2017, 3:59

Re: Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

2017-04-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58152/#review171891 --- Ship it! Might want to apply the same change to

Re: Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58152/ --- (Updated April 13, 2017, 4:20 p.m.) Review request for Ambari, Alejandro

Re: Review Request 58152: AMBARI-20666 - beginning or ending commas in dfs.cluster.administrators cause trouble for starting services

2017-04-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58152/#review171893 --- Ship it! Ship It! - Di Li On April 13, 2017, 4:20 p.m., Tim

Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58423/ --- Review request for Ambari, Di Li and Sangeeta Ravindran. Bugs: AMBARI-20757

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review171899 ---

Review Request 58426: AMBARI-19149. Code cleanup: unresolved references in javadoc

2017-04-13 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58426/ --- Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor

Review Request 58425: Remove Server attribute from the HTTP response headers

2017-04-13 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58425/ --- Review request for Ambari, Di Li, Robert Levas, and Tim Thorpe. Bugs:

Re: Review Request 58425: Remove Server attribute from the HTTP response headers

2017-04-13 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58425/#review171902 --- Ship it! Ship It! - Di Li On April 13, 2017, 5:16 p.m.,

Re: Review Request 58425: Remove Server attribute from the HTTP response headers

2017-04-13 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58425/#review171903 --- Ship it! Ship It! - Tim Thorpe On April 13, 2017, 5:16

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review171904 ---

Re: Review Request 58424: Aggregate local metrics for minute aggregation time window

2017-04-13 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58424/#review171905 ---