Re: Review Request 61856: Auto fix service config mapping issue discovered during ambari-upgrade

2017-08-25 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61856/
---

(Updated Сер. 25, 2017, 6:33 після полудня)


Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-21795
https://issues.apache.org/jira/browse/AMBARI-21795


Repository: ambari


Description
---

If user has deleted services, after upgrade db consistency check will throw 
warnings about unmapped configs.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 9592209 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
 34f3034 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
319bf53 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 cee05ef 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7348d4f 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 28ac59e 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f31b308 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8ed9da5 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 2a45476 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql c5d2e90 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
 2e38686 


Diff: https://reviews.apache.org/r/61856/diff/5/

Changes: https://reviews.apache.org/r/61856/diff/4-5/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

2017-08-25 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review183863
---




ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
Lines 30 (patched)


rename the script name here as well (or remove it)


- Oliver Szabo


On Aug. 25, 2017, 4:20 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> ---
> 
> (Updated Aug. 25, 2017, 4:20 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
> https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This script allows the user to set an end date, and save all the previous log 
> entries into HDFS or S3
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
>  PRE-CREATION 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 61856: Auto fix service config mapping issue discovered during ambari-upgrade

2017-08-25 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61856/#review183864
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
Lines 166 (patched)


Does this comment still apply?


- Sid Wagle


On Aug. 25, 2017, 3:34 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61856/
> ---
> 
> (Updated Aug. 25, 2017, 3:34 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-21795
> https://issues.apache.org/jira/browse/AMBARI-21795
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If user has deleted services, after upgrade db consistency check will throw 
> warnings about unmapped configs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  9592209 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
>  34f3034 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 319bf53 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  cee05ef 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7348d4f 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 28ac59e 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f31b308 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8ed9da5 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 2a45476 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql c5d2e90 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  2e38686 
> 
> 
> Diff: https://reviews.apache.org/r/61856/diff/4/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

2017-08-25 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review183860
---


Ship it!




Ship It!

- Oliver Szabo


On Aug. 25, 2017, 4:20 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> ---
> 
> (Updated Aug. 25, 2017, 4:20 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
> https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This script allows the user to set an end date, and save all the previous log 
> entries into HDFS or S3
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
>  PRE-CREATION 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/2/
> 
> 
> Testing
> ---
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

2017-08-25 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/
---

(Updated Aug. 25, 2017, 4:20 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

- Renamed script
- Added delete mode
- added flag to run verbose


Bugs: AMBARI-21810
https://issues.apache.org/jira/browse/AMBARI-21810


Repository: ambari


Description
---

This script allows the user to set an end date, and save all the previous log 
entries into HDFS or S3


Diffs (updated)
-

  ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
  ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
  
ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
 PRE-CREATION 
  ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py 
PRE-CREATION 


Diff: https://reviews.apache.org/r/61898/diff/2/

Changes: https://reviews.apache.org/r/61898/diff/1-2/


Testing
---

Tested on local cluster with
- SSL
- kerberos
- interrupted, then restarted script
- HDFS
- S3
- the combinations of the above


Thanks,

Miklos Gergely

Re: Review Request 61856: Auto fix service config mapping issue discovered during ambari-upgrade

2017-08-25 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61856/
---

(Updated Сер. 25, 2017, 3:34 після полудня)


Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-21795
https://issues.apache.org/jira/browse/AMBARI-21795


Repository: ambari


Description
---

If user has deleted services, after upgrade db consistency check will throw 
warnings about unmapped configs.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 9592209 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterConfigEntity.java
 34f3034 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
319bf53 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 cee05ef 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7348d4f 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 28ac59e 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f31b308 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 8ed9da5 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 2a45476 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql c5d2e90 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
 2e38686 


Diff: https://reviews.apache.org/r/61856/diff/4/

Changes: https://reviews.apache.org/r/61856/diff/3-4/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 61914: Force Regeneration of Cached RCO After Upgrade

2017-08-25 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61914/#review183856
---


Ship it!




Ship It!

- Nate Cole


On Aug. 25, 2017, 11:12 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61914/
> ---
> 
> (Updated Aug. 25, 2017, 11:12 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-21820
> https://issues.apache.org/jira/browse/AMBARI-21820
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After the stack upgrade has completed, force the RCO to clear and 
> reinitialize.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
>  7dd9754b76 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
>  4021574f29 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
>  ef9e1fa581 
> 
> 
> Diff: https://reviews.apache.org/r/61914/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Upgrade test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 61914: Force Regeneration of Cached RCO After Upgrade

2017-08-25 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61914/
---

Review request for Ambari and Nate Cole.


Bugs: AMBARI-21820
https://issues.apache.org/jira/browse/AMBARI-21820


Repository: ambari


Description
---

After the stack upgrade has completed, force the RCO to clear and reinitialize.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java
 7dd9754b76 
  
ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
 4021574f29 
  
ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
 ef9e1fa581 


Diff: https://reviews.apache.org/r/61914/diff/1/


Testing
---

Manual Upgrade test


Thanks,

Jonathan Hurley

Re: Review Request 61911: Installing mpack with .tgz extension fails with global name 'path' is not defined

2017-08-25 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61911/#review183852
---


Ship it!




Ship It!

- Robert Levas


On Aug. 25, 2017, 5:51 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61911/
> ---
> 
> (Updated Aug. 25, 2017, 5:51 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jayush Luniya, and Robert Levas.
> 
> 
> Bugs: AMBARI-21812
> https://issues.apache.org/jira/browse/AMBARI-21812
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Running: ambari-server install-mpack --mpack=/path/to/mympack.tgz --verbose
> Fails with:
> 
> Traceback (most recent call last):
>   File "/usr/sbin/ambari-server.py", line 754, in 
> mainBody()
>   File "/usr/sbin/ambari-server.py", line 725, in mainBody
> main(options, args, parser)
>   File "/usr/sbin/ambari-server.py", line 678, in main
> action_obj.execute()
>   File "/usr/sbin/ambari-server.py", line 69, in execute
> self.fn(*self.args, **self.kwargs)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 764, in install_mpack
> (mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
> mpack_archive_path) = _install_mpack(options, replay_mode)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 620, in _install_mpack
> tmp_root_dir = expand_mpack(tmp_archive_path)
>   File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
> 139, in expand_mpack
> archive_root_dir = get_archive_root_dir(archive_path)
>   File 
> "/usr/lib/python2.6/site-packages/resource_management/libraries/functions/tar_archive.py",
>  line 70, in get_archive_root_dir
> if archive.endswith('.tar.gz') or path.endswith('.tgz'):
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py
>  c682c3e 
> 
> 
> Diff: https://reviews.apache.org/r/61911/diff/2/
> 
> 
> Testing
> ---
> 
> - installed an mpack with tgz extension successfully
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 61886: AMBARI-21803. Implement STOMP endpoint for alert definitions

2017-08-25 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61886/#review183848
---


Ship it!




LGTM

- Andrew Onischuk


On Aug. 24, 2017, 12:56 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61886/
> ---
> 
> (Updated Aug. 24, 2017, 12:56 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-21803
> https://issues.apache.org/jira/browse/AMBARI-21803
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Added endpoint
> * Created data structure to match expected JSON format
> * Extracted some common logic to parent classes
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ClusterAlertDefinitionsCache.py 
> d3ab48e4da79cc7615bd5dedfec3754ffe5accc2 
>   ambari-agent/src/main/python/ambari_agent/Constants.py 
> e36eda577d0195055ebe89e3eeac5c63aa4a460b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentClusterDataHolder.java
>  0f0a4919ba7e1343c31c8397d5309542c2463287 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentConfigsHolder.java
>  0de686dfaad7a3c437fa5f9af5c1fa8abd4e61e8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentCurrentDataController.java
>  7035f38cfbb7a75bd4cb5721a542ef832a805c99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentDataHolder.java
>  635611bf6d325deb33cde671556647b9c264a716 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AgentHostDataHolder.java
>  792f10ef33363fd57579792f51901681ad83aa0b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/AlertDefinitionsHolder.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/HostLevelParamsHolder.java
>  db093f85a7f304e895bad098a3ca5a62d7a3859d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/MetadataHolder.java
>  b7e680627f3fd42e87b7152f9ab9de29f63a44fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/TopologyHolder.java
>  0da5d831d546da98e2284b048b914f972cacfc05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/AlertCluster.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/stomp/dto/MetadataCluster.java
>  3ee5ad6d00b4c4374cba48e80d1cb410500ee586 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AgentConfigsUpdateEvent.java
>  640be2d89bce55a9f58cbaf6b4e5296df9fc1a8c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionUpdateHolder.java
>  e820401d460bc672596a4ede60abcd39646be49e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/AlertDefinitionsUpdateEvent.java
>  cbe6e3703960ce0af9563f41b63d2a71427b4267 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/HostLevelParamsUpdateEvent.java
>  66ab38ea39bea2c100a2245ad422a4c6a037d7ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/MetadataUpdateEvent.java
>  239b5b8184a02a057c2dc9d4a53c671dc06d9806 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/TopologyAgentUpdateEvent.java
>  1fa4e6c20d0b2d31e376b7b8e563326a7cc1e06a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/TopologyUpdateEvent.java
>  1b5b90b562babe4cea18a1bd93104d72922d31fa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAO.java
>  25bc8136510574cc54fa2f3365c755e6a9426547 
> 
> 
> Diff: https://reviews.apache.org/r/61886/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested server/agent restarts, alert definition changes.
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 61890: Repository Entities Which Can't Be Removed Should Be Hide-able

2017-08-25 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61890/#review183847
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Aug. 24, 2017, 8:05 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61890/
> ---
> 
> (Updated Aug. 24, 2017, 8:05 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-21806
> https://issues.apache.org/jira/browse/AMBARI-21806
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Many tables have begun referencing {{repo_version}} since a simple 
> {{version}} string is no longer sufficient to properly identify a repository. 
> However, we allow a {{RepsitoryVersionEntity}} to be removed if it is in the 
> following states:
> 
> - {{INIT}}
> - {{INSTALL_FAILED}}
> - {{OUT_OF_SYNC}}
> 
> The issue with removing the entities is that this would also force us to 
> remove things like upgrades, service component versions, etc. Here are some 
> options:
> 
> # Allow repository versions in {{INIT}} and {{INSTALL_FAILED}} to be removed, 
> but for other states we'd need to keep it in the DB for history and perhaps 
> add a {{hidden}} column. This would keep the referential integrity.
> # Allow the removal of repository versions, but warn that it will also remove 
> things like upgrades.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
>  34b7b9263e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryVersionEntity.java
>  f84f3a433e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  7fc392d584 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 9cdf8e8bd3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql d616e778a8 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 0530651d39 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 1d16eb611c 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 
> da23e95ad3 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e410555149 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog260Test.java
>  44b5d914fd 
> 
> 
> Diff: https://reviews.apache.org/r/61890/diff/2/
> 
> 
> Testing
> ---
> 
> [WARNING] Tests run: 4848, Failures: 0, Errors: 0, Skipped: 35
> [INFO]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 27:45 min
> [INFO] Finished at: 2017-08-24T12:31:49-04:00
> [INFO] Final Memory: 59M/1210M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 61877: No Hosts are Targeted For MAINT VDF If Available Services is Empty

2017-08-25 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61877/#review183845
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Aug. 24, 2017, 5:15 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61877/
> ---
> 
> (Updated Aug. 24, 2017, 5:15 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-21801
> https://issues.apache.org/jira/browse/AMBARI-21801
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When trying to distribute a MAINT repository which doesn't have available 
> services, no hosts are targeted and the installation doesn't do anything.
> 
> The fix is to use the {{ClusterSummary}} from the VDF which includes a mashup 
> of the cluster's services and those listed in the VDF's manifest and 
> available services structure.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  3fb45ab3ff 
> 
> 
> Diff: https://reviews.apache.org/r/61877/diff/1/
> 
> 
> Testing
> ---
> 
> [WARNING] Tests run: 4848, Failures: 0, Errors: 0, Skipped: 35
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 61912: On installation of new services on Ambari, Zeppelin should configure new interpreters

2017-08-25 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61912/#review183842
---


Ship it!




Ship It!

- venkat sairam


On Aug. 25, 2017, 10:38 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61912/
> ---
> 
> (Updated Aug. 25, 2017, 10:38 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21814
> https://issues.apache.org/jira/browse/AMBARI-21814
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In current scenario, Ambari doesn't configure any interpreters that are 
> installed after installation. For example, if Livy was not present when 
> Zeppelin was installed, then Zeppelin's livy interpreter will never get 
> configured.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
>  13d726be97 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  7f506c5839 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  6912c3db8d 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
>  c0ce71146c 
> 
> 
> Diff: https://reviews.apache.org/r/61912/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 61912: On installation of new services on Ambari, Zeppelin should configure new interpreters

2017-08-25 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61912/
---

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-21814
https://issues.apache.org/jira/browse/AMBARI-21814


Repository: ambari


Description
---

In current scenario, Ambari doesn't configure any interpreters that are 
installed after installation. For example, if Livy was not present when 
Zeppelin was installed, then Zeppelin's livy interpreter will never get 
configured.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-config.xml
 13d726be97 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 7f506c5839 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 6912c3db8d 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-config.xml
 c0ce71146c 


Diff: https://reviews.apache.org/r/61912/diff/1/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

2017-08-25 Thread Oliver Szabo 


> On Aug. 25, 2017, 9:55 a.m., Oliver Szabo wrote:
> > ambari-infra/ambari-infra-solr-client/src/main/python/solr_collection_data_manager.py
> > Lines 1 (patched)
> > 
> >
> > i think we do not need the solr_collection prefix for the script name, 
> > it can be only data_manager or data_archiver (if we could only delete 
> > records without archiving, data_manager is the correct one, otherwise 
> > data_archiver can be enogh)

maybe the name should look like solrDataManager.py as the shell script names 
looks like that, so solrDataArchiver.py or solrDataManager.py would be better


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review183838
---


On Aug. 24, 2017, 11:42 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> ---
> 
> (Updated Aug. 24, 2017, 11:42 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
> https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This script allows the user to set an end date, and save all the previous log 
> entries into HDFS or S3
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-solr-client/src/main/python/solr_collection_data_manager.py
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

2017-08-25 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review183838
---




ambari-infra/ambari-infra-solr-client/src/main/python/solr_collection_data_manager.py
Lines 1 (patched)


i think we do not need the solr_collection prefix for the script name, it 
can be only data_manager or data_archiver (if we could only delete records 
without archiving, data_manager is the correct one, otherwise data_archiver can 
be enogh)


- Oliver Szabo


On Aug. 24, 2017, 11:42 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> ---
> 
> (Updated Aug. 24, 2017, 11:42 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
> https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This script allows the user to set an end date, and save all the previous log 
> entries into HDFS or S3
> 
> 
> Diffs
> -
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   
> ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java
>  PRE-CREATION 
>   
> ambari-infra/ambari-infra-solr-client/src/main/python/solr_collection_data_manager.py
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 61911: Installing mpack with .tgz extension fails with global name 'path' is not defined

2017-08-25 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61911/
---

(Updated Aug. 25, 2017, 9:51 a.m.)


Review request for Ambari, Balázs Bence Sári, Jayush Luniya, and Robert Levas.


Changes
---

+extract method, -duplication


Bugs: AMBARI-21812
https://issues.apache.org/jira/browse/AMBARI-21812


Repository: ambari


Description
---

Running: ambari-server install-mpack --mpack=/path/to/mympack.tgz --verbose
Fails with:

Traceback (most recent call last):
  File "/usr/sbin/ambari-server.py", line 754, in 
mainBody()
  File "/usr/sbin/ambari-server.py", line 725, in mainBody
main(options, args, parser)
  File "/usr/sbin/ambari-server.py", line 678, in main
action_obj.execute()
  File "/usr/sbin/ambari-server.py", line 69, in execute
self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
764, in install_mpack
(mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
mpack_archive_path) = _install_mpack(options, replay_mode)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
620, in _install_mpack
tmp_root_dir = expand_mpack(tmp_archive_path)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
139, in expand_mpack
archive_root_dir = get_archive_root_dir(archive_path)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/tar_archive.py",
 line 70, in get_archive_root_dir
if archive.endswith('.tar.gz') or path.endswith('.tgz'):


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py
 c682c3e 


Diff: https://reviews.apache.org/r/61911/diff/2/

Changes: https://reviews.apache.org/r/61911/diff/1-2/


Testing
---

- installed an mpack with tgz extension successfully


Thanks,

Attila Magyar

Review Request 61911: Installing mpack with .tgz extension fails with global name 'path' is not defined

2017-08-25 Thread Attila Magyar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61911/
---

Review request for Ambari, Balázs Bence Sári, Jayush Luniya, and Robert Levas.


Bugs: AMBARI-21812
https://issues.apache.org/jira/browse/AMBARI-21812


Repository: ambari


Description
---

Running: ambari-server install-mpack --mpack=/path/to/mympack.tgz --verbose
Fails with:

Traceback (most recent call last):
  File "/usr/sbin/ambari-server.py", line 754, in 
mainBody()
  File "/usr/sbin/ambari-server.py", line 725, in mainBody
main(options, args, parser)
  File "/usr/sbin/ambari-server.py", line 678, in main
action_obj.execute()
  File "/usr/sbin/ambari-server.py", line 69, in execute
self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
764, in install_mpack
(mpack_metadata, mpack_name, mpack_version, mpack_staging_dir, 
mpack_archive_path) = _install_mpack(options, replay_mode)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
620, in _install_mpack
tmp_root_dir = expand_mpack(tmp_archive_path)
  File "/usr/lib/python2.6/site-packages/ambari_server/setupMpacks.py", line 
139, in expand_mpack
archive_root_dir = get_archive_root_dir(archive_path)
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/functions/tar_archive.py",
 line 70, in get_archive_root_dir
if archive.endswith('.tar.gz') or path.endswith('.tgz'):


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py
 c682c3e 


Diff: https://reviews.apache.org/r/61911/diff/1/


Testing
---

- installed an mpack with tgz extension successfully


Thanks,

Attila Magyar

Review Request 61910: Hive query failing randomly with Null point exception status 500

2017-08-25 Thread Nitiraj Rathore 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61910/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav 
Kulshreshtha.


Bugs: AMBARI-21799
https://issues.apache.org/jira/browse/AMBARI-21799


Repository: ambari


Description
---

Null Pointer Exception is coming while getting message of original exception. 
Added a null check.


Diffs
-

  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/HdfsApi.java
 90fa483ef7 


Diff: https://reviews.apache.org/r/61910/diff/1/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore