Re: Review Request 62427: Add service wizard stuck at step 8

2017-09-19 Thread Vivek Ratnavel Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62427/#review185766
---


Ship it!




- Vivek Ratnavel Subramanian


On Sept. 20, 2017, 2:09 a.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62427/
> ---
> 
> (Updated Sept. 20, 2017, 2:09 a.m.)
> 
> 
> Review request for Ambari, Ishan Bhatt, Vivek Ratnavel Subramanian, and 
> Yusaku Sako.
> 
> 
> Bugs: AMBARI-22001
> https://issues.apache.org/jira/browse/AMBARI-22001
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> cherry-picking https://issues.apache.org/jira/browse/AMBARI-21932 commit from 
> branch-2.6 to trunk caused this issue as a referenced variable which was 
> defined in branch-2.6 bits was removed from trunk bits
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js b99c6e39d7 
> 
> 
> Diff: https://reviews.apache.org/r/62427/diff/1/
> 
> 
> Testing
> ---
> 
> ambari-web unit test:
> 
>   21334 passing (27s)
>   128 pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Review Request 62427: Add service wizard stuck at step 8

2017-09-19 Thread Jaimin Jetly 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62427/
---

Review request for Ambari, Ishan Bhatt, Vivek Ratnavel Subramanian, and Yusaku 
Sako.


Bugs: AMBARI-22001
https://issues.apache.org/jira/browse/AMBARI-22001


Repository: ambari


Description
---

cherry-picking https://issues.apache.org/jira/browse/AMBARI-21932 commit from 
branch-2.6 to trunk caused this issue as a referenced variable which was 
defined in branch-2.6 bits was removed from trunk bits


Diffs
-

  ambari-web/app/controllers/wizard/step8_controller.js b99c6e39d7 


Diff: https://reviews.apache.org/r/62427/diff/1/


Testing
---

ambari-web unit test:

  21334 passing (27s)
  128 pending


Thanks,

Jaimin Jetly

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62414/#review185754
---


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
Lines 1194-1201 (patched)


nit: formatting


- Nate Cole


On Sept. 19, 2017, 1:38 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62414/
> ---
> 
> (Updated Sept. 19, 2017, 1:38 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-21999
> https://issues.apache.org/jira/browse/AMBARI-21999
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> - Install a stack, such as HDP 2.3
> - Modify the {{cluster-env/stack_features}} structure
> - Upgrade to HDP 2.6
> 
> The auto-merge which happens can't properly merge 
> {{cluster-env/stack_features}} since it has deviated from the stock values of 
> HDP 2.3. This is dangerous since this is needed for proper operation.
> 
> Because it's defined as a read-only value, we should be able to detect this 
> in the auto-merge fro the upgrade and force it to the new stack's default 
> value...
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 9aa9e31a21 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  474eb50562 
> 
> 
> Diff: https://reviews.apache.org/r/62414/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Tests run: 4883, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:34 min
> [INFO] Finished at: 2017-09-19T14:04:35-04:00
> [INFO] Final Memory: 61M/898M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62413/#review185755
---


Ship it!




Needs a test.  Other than Jonathan's comment, LGTM.

- Nate Cole


On Sept. 19, 2017, 12:17 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62413/
> ---
> 
> (Updated Sept. 19, 2017, 12:17 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21998
> https://issues.apache.org/jira/browse/AMBARI-21998
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During  Ambari upgrade from 2.2.2 to 2.5 I discovered that some UNIQUE 
> constraints are definned without name in older Ambari versions, and then 
> altered by name in UpgadeCatalogs/newer DDLs.
> 
> For example:
> Ambari 2.2.2
> https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
> {code} UNIQUE (ldap_user, user_name));{code}
> Ambari-2.4.0
> https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
> {code}  CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type)){code}
> 
> As a result, during upgrade from Ambari 2.2.2 to Ambari 2.5.0, the stale 
> unique constraint with default name is not deleted.
> That will reproduce on Postgres for any upgrade path that includes these 
> versions.
> 
> {code}ambari=# \d+ users
> Table "ambari.users"
> Column |Type | Modifiers  
> | Storage  | Description
> ---+-++--+-
> user_id   | integer | not null
>| plain|
> principal_id  | bigint  | not null
>| plain|
> ldap_user | integer | not null default 0  
>| plain|
> user_name | character varying(255)  | not null
>| extended |
> create_time   | timestamp without time zone | default now()   
>| plain|
> user_password | character varying(255)  | 
>| extended |
> active| integer | not null default 1  
>| plain|
> active_widget_layouts | character varying(1024) | default NULL::character 
> varying| extended |
> user_type | character varying(255)  | default 
> 'LOCAL'::character varying | extended |
> Indexes:
> "users_pkey" PRIMARY KEY, btree (user_id)
> "unq_users_0" UNIQUE, btree (user_name, user_type)
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name)
> Foreign-key constraints:
> "fk_users_principal_id" FOREIGN KEY (principal_id) REFERENCES 
> adminprincipal(principal_id)
> Referenced by:
> TABLE "members" CONSTRAINT "fk_members_user_id" FOREIGN KEY (user_id) 
> REFERENCES users(user_id)
> Has OIDs: no
> 
> {code}
> 
> Now we have two constraints here
> "unq_users_0" UNIQUE, btree (user_name, user_type) 
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name) <- WRONG
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  afd3d1d6a5 
> 
> 
> Diff: https://reviews.apache.org/r/62413/diff/1/
> 
> 
> Testing
> ---
> 
> tests on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185653
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
Lines 90 (patched)


Can you make this work for relative path as well?


- venkat sairam


On Sept. 19, 2017, 5:06 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> ---
> 
> (Updated Sept. 19, 2017, 5:06 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21987
> https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, 
> helium.json, notebook-authorization.json, and credentials.json to store in 
> HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
>  bd6ad76bd5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
>  ba73d104d6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
>  ca6b295159 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
> 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62402: Multiple fixes into branch-3.0-perf

2017-09-19 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62402/#review185662
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Вер. 19, 2017, 8:53 до полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62402/
> ---
> 
> (Updated Вер. 19, 2017, 8:53 до полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-21989
> https://issues.apache.org/jira/browse/AMBARI-21989
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * restart triggered by server should gracefully finish operations
>   * if status command fails, exception should be logged.
>   * move configs logic from InitializerModule into AmbariConfig, where it 
> belongs
>   * fix typo (alert_def*E*nitions into alert_def*I*nitions)
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 94e72c2 
>   ambari-agent/src/main/python/ambari_agent/AlertStatusReporter.py 2bd2383 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py e1c40c8 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py c681550 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py 652574f 
>   ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py 
> f85ba42 
>   ambari-agent/src/main/python/ambari_agent/Constants.py 6a258d2 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py 0e598e9 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py b6e1aaf 
>   ambari-agent/src/main/python/ambari_agent/HostStatusReporter.py 09ce016 
>   ambari-agent/src/main/python/ambari_agent/InitializerModule.py 0126250 
>   ambari-agent/src/main/python/ambari_agent/Utils.py af70d77 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py
>  91ae5de 
>   ambari-agent/src/main/python/ambari_agent/main.py 05fc5ce 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
> 3c571ab 
> 
> 
> Diff: https://reviews.apache.org/r/62402/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185652
---


Ship it!




Ship It!

- venkat sairam


On Sept. 19, 2017, 5:06 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> ---
> 
> (Updated Sept. 19, 2017, 5:06 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21987
> https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, 
> helium.json, notebook-authorization.json, and credentials.json to store in 
> HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
>  bd6ad76bd5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
>  ba73d104d6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
>  ca6b295159 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
> 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/1/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 62402: Multiple fixes into branch-3.0-perf

2017-09-19 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62402/
---

Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-21989
https://issues.apache.org/jira/browse/AMBARI-21989


Repository: ambari


Description
---

* restart triggered by server should gracefully finish operations
  * if status command fails, exception should be logged.
  * move configs logic from InitializerModule into AmbariConfig, where it 
belongs
  * fix typo (alert_def*E*nitions into alert_def*I*nitions)


Diffs
-

  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 94e72c2 
  ambari-agent/src/main/python/ambari_agent/AlertStatusReporter.py 2bd2383 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py e1c40c8 
  ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py c681550 
  ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py 652574f 
  ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py f85ba42 
  ambari-agent/src/main/python/ambari_agent/Constants.py 6a258d2 
  ambari-agent/src/main/python/ambari_agent/FileCache.py 0e598e9 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py b6e1aaf 
  ambari-agent/src/main/python/ambari_agent/HostStatusReporter.py 09ce016 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py 0126250 
  ambari-agent/src/main/python/ambari_agent/Utils.py af70d77 
  
ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py
 91ae5de 
  ambari-agent/src/main/python/ambari_agent/main.py 05fc5ce 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 3c571ab 


Diff: https://reviews.apache.org/r/62402/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 62388: APPLICATION_TIMELINE_SERVER filed to start, coz were already started

2017-09-19 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62388/#review185654
---




ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/service.py
Lines 84 (patched)


We can use checked_call here. So we get more context from exception message 
if return code is non_zero.

In case if it is zero, but regex does not match. We need to also print 
output in exception text. To give debugging information for failures of ATS.


- Andrew Onischuk


On Sept. 18, 2017, 6 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62388/
> ---
> 
> (Updated Sept. 18, 2017, 6 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-21984
> https://issues.apache.org/jira/browse/AMBARI-21984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Sometimes scripts starting yarn services but they are already running. It is 
> rarely reproduced and hard to debug.
> This patch checks output of start command and ignore start failure in case 
> script reporting "service is running" and validates pid pile after that.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  7c59b60 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/service.py
>  1c612ef 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 6a99dfa 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 642043d 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 8a703df 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
> b352920 
> 
> 
> Diff: https://reviews.apache.org/r/62388/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 62388: APPLICATION_TIMELINE_SERVER filed to start, coz were already started

2017-09-19 Thread Andrew Onischuk 


> On Sept. 18, 2017, 6:34 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
> > Lines 88 (patched)
> > 
> >
> > Sounds like a very dirty hack. Does that reproduce in latest Ambari 
> > versions? Maybe it would be better to check status() before attempt to run 
> > start() ?
> 
> Andrew Onischuk wrote:
> +1. Checking output might break with a simple change to ats, also if they 
> decide to make multilingual output like some linux utils already done. Having 
> different locale it will break too.

I saw the same issues after QE reset their cluster but for some reason they 
didn't stop ATS. And pid was deleted. So ATS what just running without pid 
file. If that's the case we have it's QE issue. In other case as mentioned by 
Dmitro, we can check status before start.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62388/#review185594
---


On Sept. 18, 2017, 6 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62388/
> ---
> 
> (Updated Sept. 18, 2017, 6 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-21984
> https://issues.apache.org/jira/browse/AMBARI-21984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Sometimes scripts starting yarn services but they are already running. It is 
> rarely reproduced and hard to debug.
> This patch checks output of start command and ignore start failure in case 
> script reporting "service is running" and validates pid pile after that.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  7c59b60 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/service.py
>  1c612ef 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 6a99dfa 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 642043d 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 8a703df 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
> b352920 
> 
> 
> Diff: https://reviews.apache.org/r/62388/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Robert Levas 


> On Sept. 19, 2017, 2:32 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
> > Lines 1176 (patched)
> > 
> >
> > Unless this would be used for something else, wouldn't it be simpler if 
> > this method returned a boolean value rather than a Set?  You could then 
> > potentially save some time by not having to visit all of the properties
> 
> Jonathan Hurley wrote:
> We make this call once before traversing each service's properties. This 
> way, we have all of the read-only properties for that service ahead of time. 
> If we returned a boolean, wouldn't that mean that we'd need to iterate the 
> services properties more than once?

Yikes.. you are correct. I am not sure how I missed that. Sorry about about.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62414/#review185717
---


On Sept. 19, 2017, 1:38 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62414/
> ---
> 
> (Updated Sept. 19, 2017, 1:38 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-21999
> https://issues.apache.org/jira/browse/AMBARI-21999
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> - Install a stack, such as HDP 2.3
> - Modify the {{cluster-env/stack_features}} structure
> - Upgrade to HDP 2.6
> 
> The auto-merge which happens can't properly merge 
> {{cluster-env/stack_features}} since it has deviated from the stock values of 
> HDP 2.3. This is dangerous since this is needed for proper operation.
> 
> Because it's defined as a read-only value, we should be able to detect this 
> in the auto-merge fro the upgrade and force it to the new stack's default 
> value...
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 9aa9e31a21 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  474eb50562 
> 
> 
> Diff: https://reviews.apache.org/r/62414/diff/2/
> 
> 
> Testing
> ---
> 
> [INFO] Tests run: 4883, Failures: 0, Errors: 0, Skipped: 34
> [INFO]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:34 min
> [INFO] Finished at: 2017-09-19T14:04:35-04:00
> [INFO] Final Memory: 61M/898M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62413/#review185731
---



Do you plan to include the ability to extract constraint names from tables in 
this review? It's marked currently as preview...

- Jonathan Hurley


On Sept. 19, 2017, 12:17 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62413/
> ---
> 
> (Updated Sept. 19, 2017, 12:17 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21998
> https://issues.apache.org/jira/browse/AMBARI-21998
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During  Ambari upgrade from 2.2.2 to 2.5 I discovered that some UNIQUE 
> constraints are definned without name in older Ambari versions, and then 
> altered by name in UpgadeCatalogs/newer DDLs.
> 
> For example:
> Ambari 2.2.2
> https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
> {code} UNIQUE (ldap_user, user_name));{code}
> Ambari-2.4.0
> https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
> {code}  CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type)){code}
> 
> As a result, during upgrade from Ambari 2.2.2 to Ambari 2.5.0, the stale 
> unique constraint with default name is not deleted.
> That will reproduce on Postgres for any upgrade path that includes these 
> versions.
> 
> {code}ambari=# \d+ users
> Table "ambari.users"
> Column |Type | Modifiers  
> | Storage  | Description
> ---+-++--+-
> user_id   | integer | not null
>| plain|
> principal_id  | bigint  | not null
>| plain|
> ldap_user | integer | not null default 0  
>| plain|
> user_name | character varying(255)  | not null
>| extended |
> create_time   | timestamp without time zone | default now()   
>| plain|
> user_password | character varying(255)  | 
>| extended |
> active| integer | not null default 1  
>| plain|
> active_widget_layouts | character varying(1024) | default NULL::character 
> varying| extended |
> user_type | character varying(255)  | default 
> 'LOCAL'::character varying | extended |
> Indexes:
> "users_pkey" PRIMARY KEY, btree (user_id)
> "unq_users_0" UNIQUE, btree (user_name, user_type)
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name)
> Foreign-key constraints:
> "fk_users_principal_id" FOREIGN KEY (principal_id) REFERENCES 
> adminprincipal(principal_id)
> Referenced by:
> TABLE "members" CONSTRAINT "fk_members_user_id" FOREIGN KEY (user_id) 
> REFERENCES users(user_id)
> Has OIDs: no
> 
> {code}
> 
> Now we have two constraints here
> "unq_users_0" UNIQUE, btree (user_name, user_type) 
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name) <- WRONG
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  afd3d1d6a5 
> 
> 
> Diff: https://reviews.apache.org/r/62413/diff/1/
> 
> 
> Testing
> ---
> 
> tests on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/
---

(Updated Sept. 19, 2017, 3:18 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
venkat sairam.


Bugs: AMBARI-21987
https://issues.apache.org/jira/browse/AMBARI-21987


Repository: ambari


Description
---

With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, 
helium.json, notebook-authorization.json, and credentials.json to store in 
HDFS. This JIRA is to maintain its related Ambari side changes.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
 bd6ad76bd5 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
 ba73d104d6 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
 ca6b295159 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 ba73d104d6 
  ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
815b2c0993 
  ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
  ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
  
ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 


Diff: https://reviews.apache.org/r/62399/diff/2/

Changes: https://reviews.apache.org/r/62399/diff/1-2/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread Prabhjyot Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/
---

(Updated Sept. 19, 2017, 3:19 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
venkat sairam.


Bugs: AMBARI-21987
https://issues.apache.org/jira/browse/AMBARI-21987


Repository: ambari


Description
---

With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, 
helium.json, notebook-authorization.json, and credentials.json to store in 
HDFS. This JIRA is to maintain its related Ambari side changes.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
 bd6ad76bd5 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
 ba73d104d6 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
 ca6b295159 
  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
 ba73d104d6 
  ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
815b2c0993 
  ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
  ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
  
ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
PRE-CREATION 
  ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 


Diff: https://reviews.apache.org/r/62399/diff/3/

Changes: https://reviews.apache.org/r/62399/diff/2-3/


Testing
---

Manually


Thanks,

Prabhjyot Singh

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread Gaurav Nagar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185668
---


Ship it!




Ship It!

- Gaurav Nagar


On Sept. 19, 2017, 10:17 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> ---
> 
> (Updated Sept. 19, 2017, 10:17 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21987
> https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, 
> helium.json, notebook-authorization.json, and credentials.json to store in 
> HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
>  bd6ad76bd5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
>  ba73d104d6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
>  ca6b295159 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
> 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/4/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62402: Multiple fixes into branch-3.0-perf

2017-09-19 Thread Attila Doroszlai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62402/#review185670
---


Ship it!




Ship It!

- Attila Doroszlai


On Sept. 19, 2017, 10:53 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62402/
> ---
> 
> (Updated Sept. 19, 2017, 10:53 a.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-21989
> https://issues.apache.org/jira/browse/AMBARI-21989
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * restart triggered by server should gracefully finish operations
>   * if status command fails, exception should be logged.
>   * move configs logic from InitializerModule into AmbariConfig, where it 
> belongs
>   * fix typo (alert_def*E*nitions into alert_def*I*nitions)
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 94e72c2 
>   ambari-agent/src/main/python/ambari_agent/AlertStatusReporter.py 2bd2383 
>   ambari-agent/src/main/python/ambari_agent/AmbariConfig.py e1c40c8 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py c681550 
>   ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py 652574f 
>   ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py 
> f85ba42 
>   ambari-agent/src/main/python/ambari_agent/Constants.py 6a258d2 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py 0e598e9 
>   ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py b6e1aaf 
>   ambari-agent/src/main/python/ambari_agent/HostStatusReporter.py 09ce016 
>   ambari-agent/src/main/python/ambari_agent/InitializerModule.py 0126250 
>   ambari-agent/src/main/python/ambari_agent/Utils.py af70d77 
>   
> ambari-agent/src/main/python/ambari_agent/listeners/AlertDefinitionsEventListener.py
>  91ae5de 
>   ambari-agent/src/main/python/ambari_agent/main.py 05fc5ce 
>   ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py 
> 3c571ab 
> 
> 
> Diff: https://reviews.apache.org/r/62402/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 62399: Store Zeppelin's interpreter.json in HDFS

2017-09-19 Thread venkat sairam 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62399/#review185671
---


Ship it!




Ship It!

- venkat sairam


On Sept. 19, 2017, 10:17 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62399/
> ---
> 
> (Updated Sept. 19, 2017, 10:17 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN 
> BHOWMICK, Jaimin Jetly, Jayush Luniya, Rohit Choudhary, Sumit Mohanty, and 
> venkat sairam.
> 
> 
> Bugs: AMBARI-21987
> https://issues.apache.org/jira/browse/AMBARI-21987
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With ZEPPELIN-2742 there is a plan to store all of Note, interpreter.json, 
> helium.json, notebook-authorization.json, and credentials.json to store in 
> HDFS. This JIRA is to maintain its related Ambari side changes.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/configuration/zeppelin-config.xml
>  bd6ad76bd5 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0/package/scripts/master.py
>  ba73d104d6 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/configuration/zeppelin-config.xml
>  ca6b295159 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.7.0/package/scripts/master.py
>  ba73d104d6 
>   ambari-server/src/test/python/stacks/2.5/ZEPPELIN/test_zeppelin_master.py 
> 815b2c0993 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json 36a72822b4 
>   ambari-server/src/test/python/stacks/2.5/configs/secured.json b092b22ef5 
>   
> ambari-server/src/test/python/stacks/2.6/ZEPPELIN/interpreter_json_generated.py
>  PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/ZEPPELIN/test_zeppelin_070.py 
> PRE-CREATION 
>   ambari-server/src/test/python/stacks/2.6/configs/default.json 31f3dbde71 
> 
> 
> Diff: https://reviews.apache.org/r/62399/diff/4/
> 
> 
> Testing
> ---
> 
> Manually
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko 


> On Sept. 19, 2017, 11:44 p.m., Jonathan Hurley wrote:
> > Do you plan to include the ability to extract constraint names from tables 
> > in this review? It's marked currently as preview...

Yes. It's not a very simple thing, just wanted to make sure that we want it 
(otherwise, current patch would be enough)


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62413/#review185731
---


On Sept. 19, 2017, 7:17 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62413/
> ---
> 
> (Updated Sept. 19, 2017, 7:17 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21998
> https://issues.apache.org/jira/browse/AMBARI-21998
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During  Ambari upgrade from 2.2.2 to 2.5 I discovered that some UNIQUE 
> constraints are definned without name in older Ambari versions, and then 
> altered by name in UpgadeCatalogs/newer DDLs.
> 
> For example:
> Ambari 2.2.2
> https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
> {code} UNIQUE (ldap_user, user_name));{code}
> Ambari-2.4.0
> https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
> {code}  CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type)){code}
> 
> As a result, during upgrade from Ambari 2.2.2 to Ambari 2.5.0, the stale 
> unique constraint with default name is not deleted.
> That will reproduce on Postgres for any upgrade path that includes these 
> versions.
> 
> {code}ambari=# \d+ users
> Table "ambari.users"
> Column |Type | Modifiers  
> | Storage  | Description
> ---+-++--+-
> user_id   | integer | not null
>| plain|
> principal_id  | bigint  | not null
>| plain|
> ldap_user | integer | not null default 0  
>| plain|
> user_name | character varying(255)  | not null
>| extended |
> create_time   | timestamp without time zone | default now()   
>| plain|
> user_password | character varying(255)  | 
>| extended |
> active| integer | not null default 1  
>| plain|
> active_widget_layouts | character varying(1024) | default NULL::character 
> varying| extended |
> user_type | character varying(255)  | default 
> 'LOCAL'::character varying | extended |
> Indexes:
> "users_pkey" PRIMARY KEY, btree (user_id)
> "unq_users_0" UNIQUE, btree (user_name, user_type)
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name)
> Foreign-key constraints:
> "fk_users_principal_id" FOREIGN KEY (principal_id) REFERENCES 
> adminprincipal(principal_id)
> Referenced by:
> TABLE "members" CONSTRAINT "fk_members_user_id" FOREIGN KEY (user_id) 
> REFERENCES users(user_id)
> Has OIDs: no
> 
> {code}
> 
> Now we have two constraints here
> "unq_users_0" UNIQUE, btree (user_name, user_type) 
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name) <- WRONG
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  afd3d1d6a5 
> 
> 
> Diff: https://reviews.apache.org/r/62413/diff/1/
> 
> 
> Testing
> ---
> 
> tests on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 62388: APPLICATION_TIMELINE_SERVER filed to start, coz were already started

2017-09-19 Thread Andrew Onischuk 


> On Sept. 18, 2017, 6:34 p.m., Dmitro Lisnichenko wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
> > Lines 88 (patched)
> > 
> >
> > Sounds like a very dirty hack. Does that reproduce in latest Ambari 
> > versions? Maybe it would be better to check status() before attempt to run 
> > start() ?

+1. Checking output might break with a simple change to ats, also if they 
decide to make multilingual output like some linux utils already done. Having 
different locale it will break too.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62388/#review185594
---


On Sept. 18, 2017, 6 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62388/
> ---
> 
> (Updated Sept. 18, 2017, 6 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-21984
> https://issues.apache.org/jira/browse/AMBARI-21984
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Sometimes scripts starting yarn services but they are already running. It is 
> rarely reproduced and hard to debug.
> This patch checks output of start command and ignore start failure in case 
> script reporting "service is running" and validates pid pile after that.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  7c59b60 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/service.py
>  1c612ef 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> 6a99dfa 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 642043d 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 8a703df 
>   ambari-server/src/test/python/stacks/2.1/YARN/test_apptimelineserver.py 
> b352920 
> 
> 
> Diff: https://reviews.apache.org/r/62388/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/#review185711
---


Ship it!




The Jira is marked for 2.6 and trunk - should you only put this fix into 
branch-2.6? Trunk is JDK 8 compatible...

- Jonathan Hurley


On Sept. 19, 2017, 11:54 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62412/
> ---
> 
> (Updated Sept. 19, 2017, 11:54 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21997
> https://issues.apache.org/jira/browse/AMBARI-21997
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project ambari-server: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
> java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
> Unsupported major.minor version 52.0 -> [Help 1]
> ```
> 
> #Cause#
> com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
> unit tests to fail when using Java 1.7
> 
> #Solution#
> Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
> using either Java 1.7 or Java 1.8.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 4a896ad261 
> 
> 
> Diff: https://reviews.apache.org/r/62412/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests using Java7 and Java8
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62414/
---

Review request for Ambari, Nate Cole and Robert Levas.


Bugs: AMBARI-21999
https://issues.apache.org/jira/browse/AMBARI-21999


Repository: ambari


Description
---

STR:
- Install a stack, such as HDP 2.3
- Modify the {{cluster-env/stack_features}} structure
- Upgrade to HDP 2.6

The auto-merge which happens can't properly merge 
{{cluster-env/stack_features}} since it has deviated from the stock values of 
HDP 2.3. This is dangerous since this is needed for proper operation.

Because it's defined as a read-only value, we should be able to detect this in 
the auto-merge fro the upgrade and force it to the new stack's default value...


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
9aa9e31a21 


Diff: https://reviews.apache.org/r/62414/diff/1/


Testing
---

PENDING...


Thanks,

Jonathan Hurley

Re: Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62413/#review185701
---




ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
Lines 200 (patched)


This PK constraint has been given a name in DDL for 2.6



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
Lines 208 (patched)


That is a minimal hotfix for current issue. I have to hardcode generated 
constraint name, because we have no utility to extract existing constraints for 
table.
As a more general fix, I'm trying to implement utility methods that would 
fetch 
- name(s) of unique constraints that target given columns
- name of primary key constraint for table
- names of foreign key constraints for table


- Dmitro Lisnichenko


On Sept. 19, 2017, 7:17 p.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62413/
> ---
> 
> (Updated Sept. 19, 2017, 7:17 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21998
> https://issues.apache.org/jira/browse/AMBARI-21998
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> During  Ambari upgrade from 2.2.2 to 2.5 I discovered that some UNIQUE 
> constraints are definned without name in older Ambari versions, and then 
> altered by name in UpgadeCatalogs/newer DDLs.
> 
> For example:
> Ambari 2.2.2
> https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
> {code} UNIQUE (ldap_user, user_name));{code}
> Ambari-2.4.0
> https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
> {code}  CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type)){code}
> 
> As a result, during upgrade from Ambari 2.2.2 to Ambari 2.5.0, the stale 
> unique constraint with default name is not deleted.
> That will reproduce on Postgres for any upgrade path that includes these 
> versions.
> 
> {code}ambari=# \d+ users
> Table "ambari.users"
> Column |Type | Modifiers  
> | Storage  | Description
> ---+-++--+-
> user_id   | integer | not null
>| plain|
> principal_id  | bigint  | not null
>| plain|
> ldap_user | integer | not null default 0  
>| plain|
> user_name | character varying(255)  | not null
>| extended |
> create_time   | timestamp without time zone | default now()   
>| plain|
> user_password | character varying(255)  | 
>| extended |
> active| integer | not null default 1  
>| plain|
> active_widget_layouts | character varying(1024) | default NULL::character 
> varying| extended |
> user_type | character varying(255)  | default 
> 'LOCAL'::character varying | extended |
> Indexes:
> "users_pkey" PRIMARY KEY, btree (user_id)
> "unq_users_0" UNIQUE, btree (user_name, user_type)
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name)
> Foreign-key constraints:
> "fk_users_principal_id" FOREIGN KEY (principal_id) REFERENCES 
> adminprincipal(principal_id)
> Referenced by:
> TABLE "members" CONSTRAINT "fk_members_user_id" FOREIGN KEY (user_id) 
> REFERENCES users(user_id)
> Has OIDs: no
> 
> {code}
> 
> Now we have two constraints here
> "unq_users_0" UNIQUE, btree (user_name, user_type) 
> "users_ldap_user_key" UNIQUE, btree (ldap_user, user_name) <- WRONG
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
>  afd3d1d6a5 
> 
> 
> Diff: https://reviews.apache.org/r/62413/diff/1/
> 
> 
> Testing
> ---
> 
> tests on live cluster
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 62410: Revise log message for component version not found

2017-09-19 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62410/#review185693
---


Ship it!




Ship It!

- Jonathan Hurley


On Sept. 19, 2017, 10:53 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62410/
> ---
> 
> (Updated Sept. 19, 2017, 10:53 a.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21995
> https://issues.apache.org/jira/browse/AMBARI-21995
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> A confusing log message is being printed because it is executed from the 
> before-INSTALL hook.
> 
> Also fixed a NPE found in an unrelated check
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> db7e116c88 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  1d0c44c753 
> 
> 
> Diff: https://reviews.apache.org/r/62410/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 62413: (Preview) Ambari upgrade don't delete stale constraints

2017-09-19 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62413/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-21998
https://issues.apache.org/jira/browse/AMBARI-21998


Repository: ambari


Description
---

During  Ambari upgrade from 2.2.2 to 2.5 I discovered that some UNIQUE 
constraints are definned without name in older Ambari versions, and then 
altered by name in UpgadeCatalogs/newer DDLs.

For example:
Ambari 2.2.2
https://github.com/apache/ambari/blob/branch-2.2.2/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
{code} UNIQUE (ldap_user, user_name));{code}
Ambari-2.4.0
https://github.com/apache/ambari/blob/branch-2.4/ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql#L288
{code}  CONSTRAINT UNQ_users_0 UNIQUE (user_name, user_type)){code}

As a result, during upgrade from Ambari 2.2.2 to Ambari 2.5.0, the stale unique 
constraint with default name is not deleted.
That will reproduce on Postgres for any upgrade path that includes these 
versions.

{code}ambari=# \d+ users
Table "ambari.users"
Column |Type | Modifiers
  | Storage  | Description
---+-++--+-
user_id   | integer | not null  
 | plain|
principal_id  | bigint  | not null  
 | plain|
ldap_user | integer | not null default 0
 | plain|
user_name | character varying(255)  | not null  
 | extended |
create_time   | timestamp without time zone | default now() 
 | plain|
user_password | character varying(255)  |   
 | extended |
active| integer | not null default 1
 | plain|
active_widget_layouts | character varying(1024) | default NULL::character 
varying| extended |
user_type | character varying(255)  | default 
'LOCAL'::character varying | extended |
Indexes:
"users_pkey" PRIMARY KEY, btree (user_id)
"unq_users_0" UNIQUE, btree (user_name, user_type)
"users_ldap_user_key" UNIQUE, btree (ldap_user, user_name)
Foreign-key constraints:
"fk_users_principal_id" FOREIGN KEY (principal_id) REFERENCES 
adminprincipal(principal_id)
Referenced by:
TABLE "members" CONSTRAINT "fk_members_user_id" FOREIGN KEY (user_id) 
REFERENCES users(user_id)
Has OIDs: no

{code}

Now we have two constraints here
"unq_users_0" UNIQUE, btree (user_name, user_type) 
"users_ldap_user_key" UNIQUE, btree (ldap_user, user_name) <- WRONG


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java
 afd3d1d6a5 


Diff: https://reviews.apache.org/r/62413/diff/1/


Testing
---

tests on live cluster


Thanks,

Dmitro Lisnichenko

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/#review185702
---


Ship it!




Ship It!

- Robert Nettleton


On Sept. 19, 2017, 3:54 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62412/
> ---
> 
> (Updated Sept. 19, 2017, 3:54 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21997
> https://issues.apache.org/jira/browse/AMBARI-21997
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project ambari-server: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
> java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
> Unsupported major.minor version 52.0 -> [Help 1]
> ```
> 
> #Cause#
> com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
> unit tests to fail when using Java 1.7
> 
> #Solution#
> Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
> using either Java 1.7 or Java 1.8.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 4a896ad261 
> 
> 
> Diff: https://reviews.apache.org/r/62412/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests using Java7 and Java8
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/#review185708
---


Ship it!




Ship It!

- Nate Cole


On Sept. 19, 2017, 11:54 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62412/
> ---
> 
> (Updated Sept. 19, 2017, 11:54 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21997
> https://issues.apache.org/jira/browse/AMBARI-21997
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project ambari-server: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
> java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
> Unsupported major.minor version 52.0 -> [Help 1]
> ```
> 
> #Cause#
> com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
> unit tests to fail when using Java 1.7
> 
> #Solution#
> Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
> using either Java 1.7 or Java 1.8.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 4a896ad261 
> 
> 
> Diff: https://reviews.apache.org/r/62412/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests using Java7 and Java8
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-21997
https://issues.apache.org/jira/browse/AMBARI-21997


Repository: ambari


Description
---

```
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
project ambari-server: Execution default-test of goal 
org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
Unsupported major.minor version 52.0 -> [Help 1]
```

#Cause#
com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
unit tests to fail when using Java 1.7

#Solution#
Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
using either Java 1.7 or Java 1.8.


Diffs
-

  ambari-server/pom.xml 4a896ad261 


Diff: https://reviews.apache.org/r/62412/diff/1/


Testing
---

Ran unit tests using Java7 and Java8


Thanks,

Robert Levas

Review Request 62410: Revise log message for component version not found

2017-09-19 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62410/
---

Review request for Ambari and Jonathan Hurley.


Bugs: AMBARI-21995
https://issues.apache.org/jira/browse/AMBARI-21995


Repository: ambari


Description
---

A confusing log message is being printed because it is executed from the 
before-INSTALL hook.

Also fixed a NPE found in an unrelated check


Diffs
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
db7e116c88 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 1d0c44c753 


Diff: https://reviews.apache.org/r/62410/diff/1/


Testing
---

Manual.  Automated pending.


Thanks,

Nate Cole

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62414/#review185717
---


Ship it!




Ship It!


ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
Lines 1091-1092 (original), 1095-1099 (patched)


Only if you are making other changes, this can be simplified:

```
Set readOnlyPropertiesForType = 
readOnlyProperties.get(configurationType);
boolean readOnly = (null != readOnlyPropertiesForType && 
readOnlyPropertiesForType.contains(existingConfigurationKey));
```



ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
Lines 1176 (patched)


Unless this would be used for something else, wouldn't it be simpler if 
this method returned a boolean value rather than a Set?  You could then 
potentially save some time by not having to visit all of the properties


- Robert Levas


On Sept. 19, 2017, 1:38 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62414/
> ---
> 
> (Updated Sept. 19, 2017, 1:38 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-21999
> https://issues.apache.org/jira/browse/AMBARI-21999
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> - Install a stack, such as HDP 2.3
> - Modify the {{cluster-env/stack_features}} structure
> - Upgrade to HDP 2.6
> 
> The auto-merge which happens can't properly merge 
> {{cluster-env/stack_features}} since it has deviated from the stock values of 
> HDP 2.3. This is dangerous since this is needed for proper operation.
> 
> Because it's defined as a read-only value, we should be able to detect this 
> in the auto-merge fro the upgrade and force it to the new stack's default 
> value...
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 9aa9e31a21 
> 
> 
> Diff: https://reviews.apache.org/r/62414/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 62412: Unsupported major.minor version 52.0 when using com.networknt:json-schema-validator

2017-09-19 Thread Robert Levas 


> On Sept. 19, 2017, 12:58 p.m., Jonathan Hurley wrote:
> > The Jira is marked for 2.6 and trunk - should you only put this fix into 
> > branch-2.6? Trunk is JDK 8 compatible...

The previous depencency was version 0.1.7, which was older than the one in this 
patch, 0.1.10. I should have gone with the newer one anyways.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62412/#review185711
---


On Sept. 19, 2017, 11:54 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62412/
> ---
> 
> (Updated Sept. 19, 2017, 11:54 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-21997
> https://issues.apache.org/jira/browse/AMBARI-21997
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> ```
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test (default-test) on 
> project ambari-server: Execution default-test of goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20:test failed: 
> java.lang.UnsupportedClassVersionError: com/networknt/schema/JsonSchema : 
> Unsupported major.minor version 52.0 -> [Help 1]
> ```
> 
> #Cause#
> com.networknt:json-schema-validator:0.1.7 is compiled for Java 1.8, causing 
> unit tests to fail when using Java 1.7
> 
> #Solution#
> Use com.networknt:json-schema-validator:0.1.10, which appears to work when 
> using either Java 1.7 or Java 1.8.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml 4a896ad261 
> 
> 
> Diff: https://reviews.apache.org/r/62412/diff/1/
> 
> 
> Testing
> ---
> 
> Ran unit tests using Java7 and Java8
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 62324: AMBARI-21955: Port Storm View from React.js to Vue.js

2017-09-19 Thread Sriharsha Chintalapani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62324/#review185716
---


Ship it!




Looks good. Tested by installing in Ambari along with Storm.

- Sriharsha Chintalapani


On Sept. 14, 2017, 7:11 a.m., Sanket Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62324/
> ---
> 
> (Updated Sept. 14, 2017, 7:11 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Sumit Mohanty, and Sriharsha 
> Chintalapani.
> 
> 
> Bugs: AMBARI-21955
> https://issues.apache.org/jira/browse/AMBARI-21955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Apache Software Foundation Legal Affairs Committee has announced that the 
> so-called 'Facebook BSD+Patents License' is no longer allowed to be used as a 
> direct dependency in Apache projects.
> 
> Since Storm View is using React.js which is under the same Facebook's 
> license, needs to get rid of and use Vue.js instead.
> 
> 
> Diffs
> -
> 
>   .gitignore a40e61a 
>   contrib/views/storm/pom.xml cd92658 
>   contrib/views/storm/src/main/resources/images/icon-bolt.png  
>   contrib/views/storm/src/main/resources/images/icon-spout.png  
>   contrib/views/storm/src/main/resources/images/loader.gif  
>   contrib/views/storm/src/main/resources/index.html df94a76 
>   
> contrib/views/storm/src/main/resources/libs/Backbone-Paginator/js/backbone-paginator.min.js
>  d8ccc65 
>   contrib/views/storm/src/main/resources/libs/Backbone/js/Backbone.js f246b10 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-editable.css
>  50543a7 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-slider.min.css
>  d30595c 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap-switch.min.css
>  c63cfe2 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/css/bootstrap.css 
> 5a77806 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.eot
>  b93a4953fff68df523aa7656497ee339d6026d64 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.svg
>  94fb549 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.ttf
>  1413fc609ab6f21774de0cb7e01360095584f65b 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff
>  9e612858f802245ddcbf59788a0db942224bab35 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/fonts/glyphicons-halflings-regular.woff2
>  64539b54c3751a6d9adb44c8e3a45ba5a73b77f0 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/clear.png 
> 580b52a5be8a644f826def0c7ed6a13f90c0915c 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/images/loading.gif 
> 5b33f7e54f4e55b6b8774d86d96895db9af044b4 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-editable.min.js
>  b786a84 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-notify.min.js
>  01e7f30 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-slider.min.js
>  e61cd83 
>   
> contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap-switch.min.js
>  9849658 
>   contrib/views/storm/src/main/resources/libs/Bootstrap/js/bootstrap.min.js 
> e79c065 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/css/font-awesome.min.css
>  d0603cb 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/FontAwesome.otf
>  3ed7f8b48ad9bfab52eb03822fefcd6b77d2e680 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.eot
>  9b6afaedc0fd7aaf927a07f82da9c11022251b8b 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.svg
>  d05688e 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.ttf
>  26dea7951a73079223b50653c455c5adf46a4648 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff
>  dc35ce3c2cf688c89b0bd0d4a82bc4be82b14c40 
>   
> contrib/views/storm/src/main/resources/libs/Font-Awesome/fonts/fontawesome-webfont.woff2
>  500e5172534171f678e01f7569d66f9257036a09 
>   contrib/views/storm/src/main/resources/libs/Underscore/js/Underscore.js 
> dfd89b2 
>   contrib/views/storm/src/main/resources/libs/bootbox/js/bootbox.min.js 
> 0dc0cbd 
>   contrib/views/storm/src/main/resources/libs/d3/js/d3-tip.min.js 4767cc0 
>   contrib/views/storm/src/main/resources/libs/d3/js/d3.min.js 2856dd2 
>   contrib/views/storm/src/main/resources/libs/dagre-d3/dagre-d3.min.js 
> b4821d8 
>   contrib/views/storm/src/main/resources/libs/jQuery/js/jquery-2.2.3.min.js 
> b8c4187 
>

Re: Review Request 62414: Always Take Target Read-Only Properties On Stack Upgrade

2017-09-19 Thread Jonathan Hurley 


> On Sept. 19, 2017, 2:32 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
> > Lines 1091-1092 (original), 1095-1099 (patched)
> > 
> >
> > Only if you are making other changes, this can be simplified:
> > 
> > ```
> > Set readOnlyPropertiesForType = 
> > readOnlyProperties.get(configurationType);
> > boolean readOnly = (null != readOnlyPropertiesForType && 
> > readOnlyPropertiesForType.contains(existingConfigurationKey));
> > ```

Sure, will do ...


> On Sept. 19, 2017, 2:32 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java
> > Lines 1176 (patched)
> > 
> >
> > Unless this would be used for something else, wouldn't it be simpler if 
> > this method returned a boolean value rather than a Set?  You could then 
> > potentially save some time by not having to visit all of the properties

We make this call once before traversing each service's properties. This way, 
we have all of the read-only properties for that service ahead of time. If we 
returned a boolean, wouldn't that mean that we'd need to iterate the services 
properties more than once?


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62414/#review185717
---


On Sept. 19, 2017, 1:38 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62414/
> ---
> 
> (Updated Sept. 19, 2017, 1:38 p.m.)
> 
> 
> Review request for Ambari, Nate Cole and Robert Levas.
> 
> 
> Bugs: AMBARI-21999
> https://issues.apache.org/jira/browse/AMBARI-21999
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> - Install a stack, such as HDP 2.3
> - Modify the {{cluster-env/stack_features}} structure
> - Upgrade to HDP 2.6
> 
> The auto-merge which happens can't properly merge 
> {{cluster-env/stack_features}} since it has deviated from the stock values of 
> HDP 2.3. This is dangerous since this is needed for proper operation.
> 
> Because it's defined as a read-only value, we should be able to detect this 
> in the auto-merge fro the upgrade and force it to the new stack's default 
> value...
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeHelper.java 
> 9aa9e31a21 
> 
> 
> Diff: https://reviews.apache.org/r/62414/diff/1/
> 
> 
> Testing
> ---
> 
> PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>