Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

2017-10-04 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/#review187159 ---

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-04 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62757/#review187069 --- Ship it! Ship It! - Sebastian Toader On Oct. 3, 2017, 10:23

Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/ --- Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Jonathan

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-04 Thread Attila Magyar
> On Oct. 3, 2017, 5:34 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java > > Lines 20-21 (patched) > > > > > > This is a funny looking import. Use

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

2017-10-04 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/ --- (Updated Жов. 4, 2017, 8:26 до полудня) Review request for Ambari, Aravindan

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

2017-10-04 Thread Vitalyi Brodetskyi
> On Жов. 4, 2017, 12:54 до полудня, Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py > > Lines 21 (patched) > > > > > > Can we also remove the

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-04 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/ --- (Updated Oct. 4, 2017, 8:16 a.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-04 Thread Attila Magyar
> On Oct. 3, 2017, 5:34 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java > > Lines 20-21 (patched) > > > > > > This is a funny looking import. Use

Re: Review Request 62766: Log Search UI: add event bars for Components list item

2017-10-04 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62766/#review187082 --- Ship it! Ship It! - Oleg Nechiporenko On Окт. 4, 2017,

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-04 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62757/ --- (Updated Oct. 4, 2017, 9:19 a.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

2017-10-04 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/#review187081 --- Ship it! Ship It! - Dmytro Grinenko On Oct. 3, 2017, 9:11

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/#review187078 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 4, 2017,

Re: Review Request 62770: Log Search UI: reorganize classes structure

2017-10-04 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62770/#review187086 --- Ship it! Ship It! - Andrii Tkach On Oct. 4, 2017, 12:44

Re: Review Request 62770: Log Search UI: reorganize classes structure

2017-10-04 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62770/#review187085 --- Ship it! Ship It! - Andrii Tkach On Oct. 4, 2017, 12:44

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/#review187088 --- Ship it! Ship It! - Nate Cole On Oct. 3, 2017, 5:11 p.m.,

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-04 Thread Robert Levas
> On Oct. 3, 2017, 7:57 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 2775-2780 (patched) > > > > > > Can you also generate the new

Re: Review Request 62754: Adding Components On Patched Clusters Can Result In Symlink Issues With conf Directories

2017-10-04 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62754/#review187080 --- Ship it! Ship It! - Dmitro Lisnichenko On Oct. 4, 2017,

Review Request 62766: Log Search UI: add event bars for Components list item

2017-10-04 Thread Andrii Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62766/ --- Review request for Ambari and Oleg Nechiporenko. Bugs: AMBARI-22128

Review Request 62771: Agent UT fail on trunk

2017-10-04 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62771/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-22130

Review Request 62770: Log Search UI: reorganize classes structure

2017-10-04 Thread Andrii Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62770/ --- Review request for Ambari and Andrii Tkach. Bugs: AMBARI-22129

Re: Review Request 62757: Update Local Authentication process to work with improved user management facility

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62757/#review187096 --- Ship it! Ship It! - Nate Cole On Oct. 4, 2017, 9:19 a.m.,

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/#review187101 ---

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/#review187097 --- As part of this review, I think we need to change how the

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Jonathan Hurley
> On Oct. 4, 2017, 11:06 a.m., Jonathan Hurley wrote: > > As part of this review, I think we need to change how the > > AmbariServerAlertService creates its threadpool for the AlertRunnables: > > > > ``` > > /** > >* The executor to use to run all {@link Runnable} alert classes. > >

Re: Review Request 62656: When the cluster is kerberoed, the config's group of hbase and kafka is root, Maybe should be user.group be better.

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62656/#review187103 --- Are there any tests covering this? - Nate Cole On Sept. 28,

Re: Review Request 62656: When the cluster is kerberoed, the config's group of hbase and kafka is root, Maybe should be user.group be better.

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62656/#review187104 --- Ship it! Ship It! - Nate Cole On Sept. 28, 2017, 5:05 a.m.,

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62764/ --- (Updated Oct. 4, 2017, 4:32 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-04 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62744/#review187100 --- As part of this review, I think we need to change how the

Re: Review Request 62622: AMBARI-22016 - changeToSecureUid.sh might collide with existing user if it is not a local user

2017-10-04 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62622/#review187105 --- Ship it! Ship It! - Nate Cole On Sept. 27, 2017, 1:22 p.m.,

Re: Review Request 62744: Alerts for OneFS mpack

2017-10-04 Thread Attila Magyar
> On Oct. 3, 2017, 11:48 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/alerts/JmxServerSideAlert.java > > Lines 83 (patched) > > > > > > It's interesting to use the

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

2017-10-04 Thread Vitalyi Brodetskyi
> On Жов. 4, 2017, 12:49 до полудня, Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/ATLAS/0.7.0.3.0/service_advisor.py > > Line 77 (original), 77 (patched) > > > > > > Is this change to

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

2017-10-04 Thread Jayush Luniya
> On Oct. 4, 2017, 12:54 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py > > Lines 21 (patched) > > > > > > Can we also remove the duplicate

Re: Review Request 62764: AMBARI-22127. Installation of stack selector fails on Debian

2017-10-04 Thread Attila Doroszlai
> On Oct. 4, 2017, 5:18 p.m., Nate Cole wrote: > > ambari-common/src/main/python/resource_management/core/providers/package/__init__.py > > Lines 42-43 (original), 42-43 (patched) > > > > > > This type of change from

Review Request 62778: AMBARI-22137 - Different stack versions should be able to link to different extension versions

2017-10-04 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62778/ --- Review request for Ambari, Di Li, Jonathan Hurley, and Jayush Luniya. Bugs:

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

2017-10-04 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/ --- (Updated Жов. 4, 2017, 9:03 після полудня) Review request for Ambari,