Review Request 64214: Log Search UI: layout and behaviour changes for filtering

2017-11-30 Thread Andrii Babiichuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64214/ --- Review request for Ambari and Aleksandr Kovalenko. Bugs: AMBARI-22564

Re: Review Request 64216: . Repository validation fails for HDP-GPL

2017-11-30 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64216/#review192314 --- Ship it! Ship It! - Sid Wagle On Nov. 30, 2017, 5:14 p.m.,

Re: Review Request 64174: Upgrade from Ambari 2.5.2 to 2.6.0 fails.

2017-11-30 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64174/#review192315 --- Ship it! Ship It! - Sid Wagle On Nov. 29, 2017, 8:49 p.m.,

Re: Review Request 64216: . Repository validation fails for HDP-GPL

2017-11-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64216/#review192317 --- Fix it, then Ship it!

Re: Review Request 64216: . Repository validation fails for HDP-GPL

2017-11-30 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64216/ --- (Updated Лис. 30, 2017, 7:14 після полудня) Review request for Ambari, Andrew

Review Request 64216: . Repository validation fails for HDP-GPL

2017-11-30 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64216/ --- Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Sid Wagle.

Re: Review Request 64214: Log Search UI: layout and behaviour changes for filtering

2017-11-30 Thread Aleksandr Kovalenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64214/#review192303 --- Ship it! Ship It! - Aleksandr Kovalenko On Ноя. 30, 2017,

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
> On Nov. 30, 2017, 8:19 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/python/ambari_server/serverConfiguration.py > > Line 1162 (original), 1157 (patched) > > > > > > I think you might have broken silent

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
> On Nov. 30, 2017, 8:19 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/python/ambari_server/serverConfiguration.py > > Line 1162 (original), 1157 (patched) > > > > > > I think you might have broken silent

Re: Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64205/#review192320 --- Ship it! Ship It! - Nate Cole On Nov. 30, 2017, 10:04 a.m.,

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64186/ --- (Updated Nov. 30, 2017, 6:36 p.m.) Review request for Ambari, Andrew Onischuk,

Review Request 64221: AMBARI-22567 : Integrate Spark lifecycle management into AMS AD Manager.

2017-11-30 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64221/ --- Review request for Ambari, Jayush Luniya and Sid Wagle. Bugs: AMBARI-22567

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64186/ --- (Updated Nov. 30, 2017, 6:26 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64186/#review192331 --- Ship it! Ship It! - Andrew Onischuk On Nov. 30, 2017, 6:36

Re: Review Request 64216: . Repository validation fails for HDP-GPL

2017-11-30 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64216/ --- (Updated Лис. 30, 2017, 10:23 після полудня) Review request for Ambari, Andrew

Re: Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-11-30 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64223/#review192357 --- Fix it, then Ship it!

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-11-30 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192335 --- Ship it! Can you provide some notes on the manual testing

Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-11-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64223/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-11-30 Thread Sid Wagle
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user >

Re: Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-11-30 Thread Jonathan Hurley
> On Nov. 30, 2017, 3:35 p.m., Dmytro Grinenko wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > > Line 123 (original), 123 (patched) > > > > > > is coma needed here?

Re: Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-11-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64223/ --- (Updated Nov. 30, 2017, 4:18 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-11-30 Thread Nate Cole
> On Nov. 30, 2017, 4:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user >

Re: Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64205/ --- (Updated Nov. 30, 2017, 11:20 p.m.) Review request for Ambari, Dmytro

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-11-30 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192371 --- Ship it! Ship It! - Myroslav Papirkovskyy On Лис. 30, 2017,

Re: Review Request 64221: AMBARI-22567 : Integrate Spark lifecycle management into AMS AD Manager.

2017-11-30 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64221/ --- (Updated Nov. 30, 2017, 9:34 p.m.) Review request for Ambari, Jayush Luniya

Review Request 64227: AMBARI-22570. Repository Fields missing when register version is clicked

2017-11-30 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64227/ --- Review request for Ambari, Andrii Tkach, Jaimin Jetly, Jason Golieb, and Yusaku

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-11-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192365 --- This is making the agent-side do the logic. Shouldn't we check

Re: Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-11-30 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64223/#review192369 --- Ship it! Ship It! - Dmytro Grinenko On Nov. 30, 2017, 9:18

Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-11-30 Thread Jason Golieb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64225/ --- Review request for Ambari, Alexandr Antonenko, Andrii Tkach, Denys Buzhor,

Re: Review Request 64223: Oozie Fails To Restart During Upgrade Because of Missing ExtJS Library

2017-11-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64223/#review192364 --- Ship it! Ship It! - Nate Cole On Nov. 30, 2017, 3:28 p.m.,

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-11-30 Thread Sid Wagle
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? We would still need to make sure existing hosts get the changes if user denies license during setup and

Re: Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64205/#review192370 --- Ship it! Ship It! - Nate Cole On Nov. 30, 2017, 4:20 p.m.,

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-11-30 Thread Sid Wagle
> On Nov. 30, 2017, 9:12 p.m., Nate Cole wrote: > > This is making the agent-side do the logic. Shouldn't we check these > > things and not include GPL repos in the command to the agent? > > Sid Wagle wrote: > We would still need to make sure existing hosts get the changes if user >

Re: Review Request 64227: AMBARI-22570. Repository Fields missing when register version is clicked

2017-11-30 Thread Yusaku Sako
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64227/#review192382 --- Ship it! Ship It! - Yusaku Sako On Nov. 30, 2017, 10:15

Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

2017-11-30 Thread Vivek Ratnavel Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63847/ --- (Updated Nov. 30, 2017, 6:51 p.m.) Review request for Ambari, Ishan Bhatt and

Re: Review Request 64221: AMBARI-22567 : Integrate Spark lifecycle management into AMS AD Manager.

2017-11-30 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64221/ --- (Updated Dec. 1, 2017, 12:07 a.m.) Review request for Ambari, Jayush Luniya

Re: Review Request 64221: AMBARI-22567 : Integrate Spark lifecycle management into AMS AD Manager.

2017-11-30 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64221/#review192380 --- Fix it, then Ship it!

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64186/#review192244 --- Ship it! Ship It! - Andrew Onischuk On Nov. 30, 2017, 12:20

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64186/#review192245 ---

Re: Review Request 64186: Update server setup to deny GPL as default

2017-11-30 Thread Andrew Onischuk
> On Nov. 30, 2017, 8:19 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/python/ambari_server/serverConfiguration.py > > Line 1162 (original), 1157 (patched) > > > > > > I think you might have broken silent

Re: Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64205/ --- (Updated Nov. 30, 2017, 5:04 p.m.) Review request for Ambari, Dmytro Grinenko,

Review Request 64204: zkfc show no alerts when zkfc is down

2017-11-30 Thread zhangxiaolu zhangxiaolu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64204/ --- Review request for Ambari, Andrii Babiichuk, Alejandro Fernandez, Denys Buzhor,

Review Request 64206: Upgrade Ambari Infra to use Solr 5.5.5 for Ambari 2.6.1

2017-11-30 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64206/ --- Review request for Ambari, Attila Doroszlai, Attila Magyar, Krisztian Kasa, and

Review Request 64203: AMBARI-22476 Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types

2017-11-30 Thread Yussuf Shaikh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64203/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-22476

Re: Review Request 64174: Upgrade from Ambari 2.5.2 to 2.6.0 fails.

2017-11-30 Thread Myroslav Papirkovskyy
> On Лис. 29, 2017, 10:54 після полудня, Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog260.java > > Lines 350 (patched) > > > > > > Will this delete existing data?

Re: Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64205/#review192269 --- Ship it!

Re: Review Request 64118: Refactor internal code of handling info between kerberos wizard actions

2017-11-30 Thread Eugene Chekanskiy
> On Nov. 29, 2017, 5:40 p.m., Attila Magyar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java > > Lines 4017 (patched) > > > > > > what's the difference between

Re: Review Request 63945: AMBARI-22393: UI changes for prompting user during registration failure for new OS family

2017-11-30 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63945/#review192291 --- This has been pushed. Please close this review and appropriate

Re: Review Request 64204: zkfc show no alerts when zkfc is down

2017-11-30 Thread zhangxiaolu zhangxiaolu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64204/ --- (Updated 十一月 30, 2017, 11:40 a.m.) Review request for Ambari, Andrii

Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64205/ --- Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.

Re: Review Request 64206: Upgrade Ambari Infra to use Solr 5.5.5 for Ambari 2.6.1

2017-11-30 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64206/#review192278 --- Ship it! Ship It! - Attila Doroszlai On Nov. 30, 2017,

Re: Review Request 64206: Upgrade Ambari Infra to use Solr 5.5.5 for Ambari 2.6.1

2017-11-30 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64206/#review192280 --- Ship it! Ship It! - Krisztian Kasa On Nov. 30, 2017, 11:51

Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-11-30 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/ --- Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate Cole,

Re: Review Request 64206: Upgrade Ambari Infra to use Solr 5.5.5 for Ambari 2.6.1

2017-11-30 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64206/#review192279 --- Ship it! Ship It! - Attila Magyar On Nov. 30, 2017, 11:51

Re: Review Request 64205: Snapshot HBase task failed during IOP migration with TypeError

2017-11-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64205/#review192300 ---

Review Request 64242: AMBARI-22476: Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types

2017-11-30 Thread Sonia Garudi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64242/ --- Review request for Ambari and Nate Cole. Bugs: AMBARI-22476