Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-26 Thread Akhil PB
> On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js, > > line 32 > > > > > > Check use of this property else

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-26 Thread Akhil PB
> On Sept. 23, 2016, 9:58 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/javascripts/difflib.js, > > line 1 > > > > > > External files shouldnt be added like

Review Request 52289: Regression: krb5JAASLogin.conf is not updated during secure BP install

2016-09-26 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52289/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Nettleton, and

Re: Review Request 52232: Host delete should support a force option to delete all components

2016-09-26 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52232/#review150486 --- Ship it! Ship It! - Nahappan Somasundaram On Sept. 23,

Review Request 52282: RU/EU cannot start because ServiceCheckValidityCheck incorrectly calculates Service Checks that ran

2016-09-26 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52282/ --- Review request for Ambari, Dmitro Lisnichenko, Jonathan Hurley, and Nate Cole.

Review Request 52281: Fix custom jdbc functionality for ambari-server setup

2016-09-26 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52281/ --- Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-26 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52266/#review150459 ---

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-26 Thread Alejandro Fernandez
> On Sept. 26, 2016, 6:34 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/UpdateActiveRepoVersionOnStartup.java, > > line 103 > > > > > > This should be LOG.error in

Re: Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-26 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52266/#review150434 --- Fix it, then Ship it!

Review Request 52266: Ambari server does not come up after restart if cluster install fails

2016-09-26 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52266/ --- Review request for Ambari, Attila Doroszlai, Jayush Luniya, Oliver Szabo, and

Review Request 52264: AMBARI-18466 Component should be renamed to "Microsoft R Server Client"

2016-09-26 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52264/ --- Review request for Ambari, Balázs Bence Sári, Jayush Luniya, Sumit Mohanty, and

Re: Review Request 52223: AMBARI-18051 - Services should be able to provide their own pre-req checks by supplying a jar file

2016-09-26 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52223/#review150416 --- Ship it! Nice - Alejandro Fernandez On Sept. 23, 2016, 7:59

Re: Review Request 52261: Provide Warnings When ulimit Is High To Prevent Heartbeat Lost Issues

2016-09-26 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52261/#review150409 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 26, 2016,

Re: Review Request 52261: Provide Warnings When ulimit Is High To Prevent Heartbeat Lost Issues

2016-09-26 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52261/ --- (Updated Sept. 26, 2016, 3:53 p.m.) Review request for Ambari and Vitalyi

Re: Review Request 52262: Log results from shell commands run as user

2016-09-26 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52262/#review150405 --- Ship it! Ship It! - Vitalyi Brodetskyi On Вер. 26, 2016,

Review Request 52262: Log results from shell commands run as user

2016-09-26 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52262/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18465

Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart

2016-09-26 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51647/ --- (Updated Sept. 26, 2016, 2:32 p.m.) Review request for Ambari, DIPAYAN

Review Request 52261: Provide Warnings When ulimit Is High To Prevent Heartbeat Lost Issues

2016-09-26 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52261/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-18464

Review Request 52260: AMBARI-18459: Print error messages if bulkcommand section of a component includes non-existing component

2016-09-26 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52260/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-18459

Re: Review Request 52223: AMBARI-18051 - Services should be able to provide their own pre-req checks by supplying a jar file

2016-09-26 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52223/#review150399 --- Ship it! Ship It! - Di Li On Sept. 23, 2016, 7:59 p.m., Tim

Re: Review Request 52123: Microsoft-R service should be supported on SLES11

2016-09-26 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52123/#review150379 --- Ship it! Ship It! - Attila Doroszlai On Sept. 22, 2016,

Re: Review Request 52123: Microsoft-R service should be supported on SLES11

2016-09-26 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52123/#review150378 --- Ship it! Ship It! - Sebastian Toader On Sept. 22, 2016,