Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52839/#review153034
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (lines 950 - 951)


Whitespace: missing between `){`, and extra blank line at start of method.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (lines 953 - 954)


Variable names `monitor_delay` and `monitor_dealy_long` should be 
camelCase, ie. `monitorDelay`.

Also, `monitor_dealy_long` has typo, should be `monitorDelayLong`.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (line 958)


Whitespace



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 (line 962)


Whitespace


- Attila Doroszlai


On Oct. 18, 2016, 1:07 a.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52839/
> ---
> 
> (Updated Oct. 18, 2016, 1:07 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18592
> https://issues.apache.org/jira/browse/AMBARI-18592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ability to enable the DEBUG logs in Ambari-server without server restart
> 
> 1. PropertyConfigurator would check log4j.properties update every 5mins. if 
> there is any change in the file/timestamp it will reload the log4j 
> configurations.
> 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds
> 3. Have modified only for ambari-server
> 4.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c05840e 
> 
> Diff: https://reviews.apache.org/r/52839/diff/
> 
> 
> Testing
> ---
> 
> 1. Change the log4j.properties from INFO to DEBUG
> [Expected Result] server should start logging the DEBUG logs with in 5mins of 
> time.
> [Resutl] PASS
> 
> 2. Change the log4j.properties from DEBUG to INFO
> [Expected Result] server should reduce the logging to INFO mode with in 5mins 
> of time.
> [Resutl] PASS
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

[Attila Doroszlai]

> On Oct. 14, 2016, 10:59 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java,
> >  line 2430
> > 
> >
> > How about using `TimeUnit.MINUTES.toMillis(5)` instead of `30L`?
> 
> Amarnath reddy pappu wrote:
> not using this - because will loose option of setting in milliseconds in 
> ambari.properties

Using `TimeUnit.MINUTES.toMillis(5)` for the default value will not affect the 
ability to get the setting from `ambari.properties`.  It's just a more readable 
form of the same time length in milliseconds.


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52839/#review152643
---


On Oct. 18, 2016, 1:07 a.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52839/
> ---
> 
> (Updated Oct. 18, 2016, 1:07 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18592
> https://issues.apache.org/jira/browse/AMBARI-18592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ability to enable the DEBUG logs in Ambari-server without server restart
> 
> 1. PropertyConfigurator would check log4j.properties update every 5mins. if 
> there is any change in the file/timestamp it will reload the log4j 
> configurations.
> 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds
> 3. Have modified only for ambari-server
> 4.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c05840e 
> 
> Diff: https://reviews.apache.org/r/52839/diff/
> 
> 
> Testing
> ---
> 
> 1. Change the log4j.properties from INFO to DEBUG
> [Expected Result] server should start logging the DEBUG logs with in 5mins of 
> time.
> [Resutl] PASS
> 
> 2. Change the log4j.properties from DEBUG to INFO
> [Expected Result] server should reduce the logging to INFO mode with in 5mins 
> of time.
> [Resutl] PASS
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Re: Review Request 52971: Service Summary screen does not show hostname in tooltip pop-up for all services

[Yusaku Sako]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52971/#review153015
---


Ship it!




Ship It!

- Yusaku Sako


On Oct. 18, 2016, 1:39 a.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52971/
> ---
> 
> (Updated Oct. 18, 2016, 1:39 a.m.)
> 
> 
> Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18621
> https://issues.apache.org/jira/browse/AMBARI-18621
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> *STR:*
> # Install a cluster with more than 25 nodes
> # Add "Hive Metastore" hosts on nodes that are above first 25 nodes 
> lexicographically
> 
> *Expected Result:* On Service summary page while hovering on "Hive Metastore" 
> label links, all such links should display public host name in the tooltip
> *Actual Result:* "Hive Metastore" hosts that are running on hosts above first 
> 25 lexicographically does not display public host names on being hovered.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
>  4a07804 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
>  85b2b46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
>  bc3f632 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
>  586134c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  3b5ed28 
>   ambari-server/src/main/resources/properties.json eb27878 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  f0bddf8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
>  ef1b821 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
>  260ff92 
>   ambari-web/app/controllers/global/update_controller.js 68e6ba3 
>   ambari-web/app/mappers/component_config_mapper.js 860730e 
>   ambari-web/app/mappers/hosts_mapper.js 6850242 
>   ambari-web/app/mappers/service_metrics_mapper.js bf4fc91 
>   ambari-web/app/models/host_component.js dca7ff0 
>   ambari-web/app/templates/main/service/info/summary/master_components.hbs 
> 460b048 
> 
> Diff: https://reviews.apache.org/r/52971/diff/
> 
> 
> Testing
> ---
> 
> #Testing Done:
> 1. Verified on a cluster (> 25 nodes) that the patch resolves the issue
> 2. Verified that all unit tests for ambari-web passes with the patch
>   29243 tests complete (31 seconds)
>   154 tests pending
> 3. Modified and Verified ambari-server unit tests are not affected with the 
> patch
> Results :
> 
> Failed tests: 
>   UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1107 
>   Unexpected method call 
> AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface 
> org.apache.ambari.server.state.Cluster, EasyMock for interface 
> org.apache.ambari.server.state.Service):
> AmbariManagementController.getClusters(): expected: at least 0, actual: 1
> AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for 
> interface org.apache.ambari.server.state.Cluster, EasyMock for interface 
> org.apache.ambari.server.state.Service): expected: 1, actual: 0
>   DataStoreImplTest.testFind:526 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:475 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:357 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:426 
>   Expectation failure on verify:
> DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error: 
>   KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
> expected   KerberosCheckerTest.testCheckPassed:62 » ClassCast class 
> sun.security.provider...
>   AmbariAuthenticationFilterTest.testOnSuccessfulAuthentication:98 » Linkage 
> loa...
>   
> AmbariLdapAuthenticationProviderForDNWithSpaceTest.org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderForDNWithSpaceTest
>  » FileNotFound
>   
> AmbariLdapAuthenticationProviderForDuplicateUserTest.org.apache.ambari.server.security.authorization.AmbariLdapAuthenticationProviderForDuplicateUserTest
>  » FileNotFound
>   
> 

Review Request 52971: Service Summary screen does not show hostname in tooltip pop-up for all services

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52971/
---

Review request for Ambari, Mahadev Konar, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-18621
https://issues.apache.org/jira/browse/AMBARI-18621


Repository: ambari


Description
---

*STR:*
# Install a cluster with more than 25 nodes
# Add "Hive Metastore" hosts on nodes that are above first 25 nodes 
lexicographically

*Expected Result:* On Service summary page while hovering on "Hive Metastore" 
label links, all such links should display public host name in the tooltip
*Actual Result:* "Hive Metastore" hosts that are running on hosts above first 
25 lexicographically does not display public host names on being hovered.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostRequest.java
 4a07804 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceComponentHostResponse.java
 85b2b46 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
 bc3f632 
  
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentHost.java
 586134c 
  
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
 3b5ed28 
  ambari-server/src/main/resources/properties.json eb27878 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
 f0bddf8 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
 ef1b821 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
 260ff92 
  ambari-web/app/controllers/global/update_controller.js 68e6ba3 
  ambari-web/app/mappers/component_config_mapper.js 860730e 
  ambari-web/app/mappers/hosts_mapper.js 6850242 
  ambari-web/app/mappers/service_metrics_mapper.js bf4fc91 
  ambari-web/app/models/host_component.js dca7ff0 
  ambari-web/app/templates/main/service/info/summary/master_components.hbs 
460b048 

Diff: https://reviews.apache.org/r/52971/diff/


Testing
---

#Testing Done:
1. Verified on a cluster (> 25 nodes) that the patch resolves the issue
2. Verified that all unit tests for ambari-web passes with the patch
  29243 tests complete (31 seconds)
  154 tests pending
3. Modified and Verified ambari-server unit tests are not affected with the 
patch
Results :

Failed tests: 
  UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1107 
  Unexpected method call 
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface 
org.apache.ambari.server.state.Cluster, EasyMock for interface 
org.apache.ambari.server.state.Service):
AmbariManagementController.getClusters(): expected: at least 0, actual: 1
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for 
interface org.apache.ambari.server.state.Cluster, EasyMock for interface 
org.apache.ambari.server.state.Service): expected: 1, actual: 0
  DataStoreImplTest.testFind:526 expected: but was:
  DataStoreImplTest.testRemove:475 expected: but was:
  DataStoreImplTest.testStore_update:357 expected: but was:
  DataStoreImplTest.testStore_update_longStringValue:426 
  Expectation failure on verify:
DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error: 
  KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
expected

Re: Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52964/#review153002
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 (line 577)


This was the actual bug. It picked the first healthy host.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 (line 616)


Small optimization to prefer hosts with 0 active tasks.


- Alejandro Fernandez


On Oct. 18, 2016, 12:36 a.m., Alejandro Fernandez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52964/
> ---
> 
> (Updated Oct. 18, 2016, 12:36 a.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, 
> Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18619
> https://issues.apache.org/jira/browse/AMBARI-18619
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 
> * Deploy a 3-node cluster with Ambari 2.4 and HDP 2.5 with clients on every 
> host.
> * Run multiple service checks in parallel, but notice that they typically run 
> on the same 1 or 2 hosts.
> 
> Currently, Ambari relies on getting the list of candidate hosts from the DB 
> and excludes all hosts that are in maintenance mode. From that list, it picks 
> the first host that is healthy (i.e., heartbeating). This means that the 
> logic does not pick a random host.
> 
> Instead, Ambari should always pick a random host and prefer to schedule on 
> hosts that have 0 in-progress commands.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  a671f0c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  746bca4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5d8f279 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
>  17760c7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
>  e82900d 
> 
> Diff: https://reviews.apache.org/r/52964/diff/
> 
> 
> Testing
> ---
> 
> Waiting for unit test results.
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Review Request 52964: Optimize Service Checks to it picks a random host and prefers hosts with 0 active commands

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52964/
---

Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan 
Hurley, Nate Cole, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18619
https://issues.apache.org/jira/browse/AMBARI-18619


Repository: ambari


Description
---

STR:

* Deploy a 3-node cluster with Ambari 2.4 and HDP 2.5 with clients on every 
host.
* Run multiple service checks in parallel, but notice that they typically run 
on the same 1 or 2 hosts.

Currently, Ambari relies on getting the list of candidate hosts from the DB and 
excludes all hosts that are in maintenance mode. From that list, it picks the 
first host that is healthy (i.e., heartbeating). This means that the logic does 
not pick a random host.

Instead, Ambari should always pick a random host and prefer to schedule on 
hosts that have 0 in-progress commands.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 a671f0c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 746bca4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 5d8f279 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
 17760c7 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java
 e82900d 

Diff: https://reviews.apache.org/r/52964/diff/


Testing
---

Waiting for unit test results.


Thanks,

Alejandro Fernandez

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

[Amarnath reddy pappu]

> On Oct. 13, 2016, 7:35 p.m., Jonathan Hurley wrote:
> > Ship It!

thank you


- Amarnath reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52839/#review152562
---


On Oct. 17, 2016, 11:07 p.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52839/
> ---
> 
> (Updated Oct. 17, 2016, 11:07 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18592
> https://issues.apache.org/jira/browse/AMBARI-18592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ability to enable the DEBUG logs in Ambari-server without server restart
> 
> 1. PropertyConfigurator would check log4j.properties update every 5mins. if 
> there is any change in the file/timestamp it will reload the log4j 
> configurations.
> 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds
> 3. Have modified only for ambari-server
> 4.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c05840e 
> 
> Diff: https://reviews.apache.org/r/52839/diff/
> 
> 
> Testing
> ---
> 
> 1. Change the log4j.properties from INFO to DEBUG
> [Expected Result] server should start logging the DEBUG logs with in 5mins of 
> time.
> [Resutl] PASS
> 
> 2. Change the log4j.properties from DEBUG to INFO
> [Expected Result] server should reduce the logging to INFO mode with in 5mins 
> of time.
> [Resutl] PASS
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

[Amarnath reddy pappu]

> On Oct. 14, 2016, 8:59 a.m., Attila Doroszlai wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java,
> >  line 2430
> > 
> >
> > How about using `TimeUnit.MINUTES.toMillis(5)` instead of `30L`?

not using this - because will loose option of setting in milliseconds in 
ambari.properties


- Amarnath reddy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52839/#review152643
---


On Oct. 13, 2016, 6:01 p.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52839/
> ---
> 
> (Updated Oct. 13, 2016, 6:01 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18592
> https://issues.apache.org/jira/browse/AMBARI-18592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ability to enable the DEBUG logs in Ambari-server without server restart
> 
> 1. PropertyConfigurator would check log4j.properties update every 5mins. if 
> there is any change in the file/timestamp it will reload the log4j 
> configurations.
> 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds
> 3. Have modified only for ambari-server
> 4.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c05840e 
> 
> Diff: https://reviews.apache.org/r/52839/diff/
> 
> 
> Testing
> ---
> 
> 1. Change the log4j.properties from INFO to DEBUG
> [Expected Result] server should start logging the DEBUG logs with in 5mins of 
> time.
> [Resutl] PASS
> 
> 2. Change the log4j.properties from DEBUG to INFO
> [Expected Result] server should reduce the logging to INFO mode with in 5mins 
> of time.
> [Resutl] PASS
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Review Request 52958: Fix Log Search User Config bug

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52958/
---

Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-18616
https://issues.apache.org/jira/browse/AMBARI-18616


Repository: ambari


Description
---

Log Search User Config UI screen does not offer the chance to modify the filter 
settings for those logs which don't have any log entries loaded so far. For 
these logs the initial settings will be in effect until the first modification 
of the filters when all of these settings will be erased, and thus every log 
will be loaded for them without filtering.

The User Config UI should always show all the logs, first those which already 
have some log entries in the solr, then the rest.

Also some minor refactoring for cleaner code.


Diffs
-

  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 58337f7 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/common/LogFeederDataMap.java
 b09610c 
  
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/filter/CreateLogfeederFilterView.js
 9bdf0fa 

Diff: https://reviews.apache.org/r/52958/diff/


Testing
---

Done


Thanks,

Miklos Gergely

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/
---

(Updated Oct. 17, 2016, 9:50 p.m.)


Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, Zhe 
(Joe) Wang, Richard Zang, Xi Wang, and Yusaku Sako.


Changes
---

Resolved conflicts

Verified Manually.
Ambari-web unit tests pass.
30365 tests complete (3 minutes)
  151 tests pending


Bugs: AMBARI-17636
https://issues.apache.org/jira/browse/AMBARI-17636


Repository: ambari


Description
---

* Go to Service->Configs page (that have more than ~ 30 versions)
* Open versions dropdown

*Result:*
Number of visible versions limited by window height.


Diffs (updated)
-

  ambari-web/app/styles/config_history_flow.less e2806ea 
  ambari-web/app/templates/common/configs/config_history_flow.hbs 59d6491 
  ambari-web/app/views/common/configs/config_history_flow.js 0674231 

Diff: https://reviews.apache.org/r/49838/diff/


Testing
---

Local Ambari web test passed.
28944 tests complete (25 seconds)
154 tests pending
Manual testing done.

Local Ambari-web tests pass.
30364 tests complete (27 seconds)
151 tests pending
Verified manually


File Attachments


Gif of latest changes
  
https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52691/#review152962
---




ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 (line 870)


Shouldn't this be false initially? If it's not DEPENENCY_ORDERED, then this 
would always return true



ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 (lines 873 - 874)


Why check both here? Isn't it enough to simply check the stage's configure 
role ordering? 

Also - you can just return false immediately if it's not DEPENDENCY_ORDERED 
so you don't have to if-block out the entire logic of the method.



ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CommandExecutionType.java
 (line 21)


Documentation.



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (line 1829)


Can you make the description for the documentation a little more detailed?



ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
 (line 69)


This feels very wrong to hard-code into something like a scheduler. It 
should be declarative somehow. Same for the other components below...


- Jonathan Hurley


On Oct. 16, 2016, 4:33 a.m., Sandor Magyari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52691/
> ---
> 
> (Updated Oct. 16, 2016, 4:33 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo 
> Puskas, Nate Cole, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18553
> https://issues.apache.org/jira/browse/AMBARI-18553
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, the START commands stored in role_command_orders table are bound to 
> multiple stages created based on dependencies between components - a 
> component in the second stage can only begin its START after the entire first 
> stage is done as opposed to just its dependencies in the first stage. This 
> eventually increases the overall blueprint deployment time.
> The goal is to be able to configure a direct dependency based execution model 
> of commands, for now only for Blueprint based deployment commands.
> 
> Implementation:
> ---
> When creating stages we set the commandExecutionType to RoleGraph. In case 
> commandExecutionType is set to DEPENDENCY_ORDERED there's only one stage 
> created. commandExecutionType is persisted into Stage object / entity as 
> well, so ActionScheduler can decide based on commandExecutionType how to 
> execute the stage. In case commandExecutionType is set to DEPENDENCY_ORDERED 
> it will filter out commands having dependencies on other commands 
> IN_PROGRESS. By default commandExecutionType is STAGE_BASED which works as 
> before, creating one or more stages dependening on dependecies.
> DEPENDENCY_ORDERED commandExecutionType is set only in case of START commands 
> initiated by Blueprint deployment and if Ambari property 
> server.stage.command.execution_type = DEPENDENCY_ORDERED.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  8cbfb1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CommandExecutionType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> f03d8ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5d8f279 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  5afaba8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
>  bbdb808 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandPair.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  eaea913 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
>  c9ab6f9 
>   
> 

Re: Review Request 52850: Icons don't display in Windows 10 Microsoft Edge or Internet Explorer 11

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52850/#review152960
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On Oct. 14, 2016, 12:07 a.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52850/
> ---
> 
> (Updated Oct. 14, 2016, 12:07 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi 
> Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-18595
> https://issues.apache.org/jira/browse/AMBARI-18595
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Icons do not display in any page as shown in the screen-shot attached.
> 
> 
> Diffs
> -
> 
>   ambari-web/pom.xml 759b63e 
> 
> Diff: https://reviews.apache.org/r/52850/diff/
> 
> 
> Testing
> ---
> 
> Verified Manually in the latest versions of Google Chrome Mac OS X, Google 
> Chrome Windows 10, Microsoft Internet Explorer 11 and Microsoft Edge.
> Ambari web unit tests pass.
> 30374 tests complete (30 seconds)
> 151 tests pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 49838: AMBARI-17636 Service Configs page: can't see all config versions in dropdown

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49838/#review152958
---


Ship it!




Ship It!

- Zhe (Joe) Wang


On Oct. 13, 2016, 12:35 a.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49838/
> ---
> 
> (Updated Oct. 13, 2016, 12:35 a.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko, Andrii Tkach, Jaimin Jetly, 
> Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-17636
> https://issues.apache.org/jira/browse/AMBARI-17636
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Go to Service->Configs page (that have more than ~ 30 versions)
> * Open versions dropdown
> 
> *Result:*
> Number of visible versions limited by window height.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/config_history_flow.less 0b6dc3f 
>   ambari-web/app/templates/common/configs/config_history_flow.hbs fa67786 
>   ambari-web/app/views/common/configs/config_history_flow.js 5ad65ac 
> 
> Diff: https://reviews.apache.org/r/49838/diff/
> 
> 
> Testing
> ---
> 
> Local Ambari web test passed.
> 28944 tests complete (25 seconds)
> 154 tests pending
> Manual testing done.
> 
> Local Ambari-web tests pass.
> 30364 tests complete (27 seconds)
> 151 tests pending
> Verified manually
> 
> 
> File Attachments
> 
> 
> Gif of latest changes
>   
> https://reviews.apache.org/media/uploaded/files/2016/07/14/225a1346-1632-4471-bbf2-99bf05c5d275__bugfix.gif
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Re: Review Request 52932: Ambari MIB Should Be Included with Installation Bits

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52932/#review152957
---




ambari-server/pom.xml (line 44)


I think that perhaps we should now move this out of contrib and into 
resources directly since it's a first-class part of the product.


- Jonathan Hurley


On Oct. 17, 2016, 12:05 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52932/
> ---
> 
> (Updated Oct. 17, 2016, 12:05 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18611
> https://issues.apache.org/jira/browse/AMBARI-18611
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Ambari MIB located at 
> https://github.com/apache/ambari/blob/trunk/contrib/alert-snmp-mib/APACHE-AMBARI-MIB.txt
>  should be included on the file system when Ambari is installed.
> It's location should be alongside other resources at:
> /var/lib/ambari-server/resources
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml e02b7a5 
>   ambari-server/src/main/assemblies/server.xml 9252c56 
> 
> Diff: https://reviews.apache.org/r/52932/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 52839: Ability to enable the DEBUG/INFO logs in Ambari-server without server restart

[Jonathan Hurley]

> On Oct. 13, 2016, 7:10 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java,
> >  line 512
> > 
> >
> > I'm curious - why use the configuration property getDefaultValue()?  
> > Shouldn't there be a Configuration accessor that actually checks for the 
> > property being set?
> 
> Amarnath reddy pappu wrote:
> I am not sure if having a configurable value would be useful in this 
> case. 5mins default value would be good enough i feel.
> 
> do you think there may be customers who would want to enable the DEBUG 
> logs less than 5mins time? that is the only case i can think of.
> 
> please advise so that I can proceed accordingly.
> 
> Nate Cole wrote:
> Well, this requested feature didn't originate with me :)  It just seems 
> odd to have a configuration that could never be used.
> 
> Attila Doroszlai wrote:
> If it's not configurable, why define a `ConfigurationProperty` instead of 
> a plain `long` constant?

I didn't catch this, but I agree with Nate / Attila - we should actually expose 
it as a configuration property.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52839/#review152595
---


On Oct. 13, 2016, 2:01 p.m., Amarnath reddy pappu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52839/
> ---
> 
> (Updated Oct. 13, 2016, 2:01 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-18592
> https://issues.apache.org/jira/browse/AMBARI-18592
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ability to enable the DEBUG logs in Ambari-server without server restart
> 
> 1. PropertyConfigurator would check log4j.properties update every 5mins. if 
> there is any change in the file/timestamp it will reload the log4j 
> configurations.
> 2. have defined to LOG4JMONITOR_DELAY for 5mins - 30 milliseconds
> 3. Have modified only for ambari-server
> 4.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  c05840e 
> 
> Diff: https://reviews.apache.org/r/52839/diff/
> 
> 
> Testing
> ---
> 
> 1. Change the log4j.properties from INFO to DEBUG
> [Expected Result] server should start logging the DEBUG logs with in 5mins of 
> time.
> [Resutl] PASS
> 
> 2. Change the log4j.properties from DEBUG to INFO
> [Expected Result] server should reduce the logging to INFO mode with in 5mins 
> of time.
> [Resutl] PASS
> 
> 
> Thanks,
> 
> Amarnath reddy pappu
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

> On Oct. 17, 2016, 8:09 a.m., Robert Levas wrote:
> > It seems like there was a rebase issue with the last patch. Can you fix?

fixed. please ignore revision 5.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review152880
---


On Oct. 17, 2016, 1:50 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 17, 2016, 1:50 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml d507b82 
>   ambari-server/sbin/ambari-server 762ae19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2e850ef 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  1fc9dbf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
>  5e498f0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
>  ef28f61 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  e1aa5ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
>  bdd73a6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
> e4ed9c6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
>  00e233e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
>  26d4da7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
>  b20df8d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
>  aa9f3e0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  e547f05 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  185bd58 
>   ambari-server/src/main/python/ambari-server.py bb6bc0e 
>   ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
>   ambari-server/src/main/resources/properties.json eb27878 
>   ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
>  a80cd03 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  7b6c3ad 
> 
> Diff: https://reviews.apache.org/r/52369/diff/
> 
> 
> Testing
> ---
> 
> No test cases added at this point.
> 
> 
> File Attachments
> 
> 
> AMBARI-12263.patch_base
>   
> https://reviews.apache.org/media/uploaded/files/2016/10/17/5107a016-3a83-478c-b98c-2f35ecf6cbc5__AMBARI-12263.patch_base
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Vishal Ghugare]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/
---

(Updated Oct. 17, 2016, 1:50 p.m.)


Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.


Bugs: AMBARI-12263
https://issues.apache.org/jira/browse/AMBARI-12263


Repository: ambari


Description
---

Hello Robert,

How are you doing? 

We have been working on PAM support into Ambari and have something ready for 
review. Can you please take a look at the patch and documentation and provide 
your feedback.

Please let me know if you have any questions.

Note: I have added you as a reviewer as i see some authentication related 
commits under your name.

Thanks,
-Vishal


Diffs (updated)
-

  ambari-server/pom.xml d507b82 
  ambari-server/sbin/ambari-server 762ae19 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2e850ef 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 1fc9dbf 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 5e498f0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/GroupResponse.java
 ef28f61 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
 e1aa5ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProvider.java
 bdd73a6 
  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ResourceDAO.java 
e4ed9c6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java
 00e233e 
  
ambari-server/src/main/java/org/apache/ambari/server/security/ClientSecurityType.java
 26d4da7 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Group.java
 b20df8d 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/GroupType.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/PamAuthenticationException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/UserType.java
 aa9f3e0 
  
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
 e547f05 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 185bd58 
  ambari-server/src/main/python/ambari-server.py bb6bc0e 
  ambari-server/src/main/python/ambari_server/setupActions.py 697bc1d 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 119a7d8 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 1d55515 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 49f3e2f 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 7aa52ef 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0c95471 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 631b5c4 
  ambari-server/src/main/resources/properties.json eb27878 
  ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml 500c0bf 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProviderTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/security/authorization/TestUsers.java
 a80cd03 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 7b6c3ad 

Diff: https://reviews.apache.org/r/52369/diff/


Testing
---

No test cases added at this point.


File Attachments (updated)


AMBARI-12263.patch_base
  
https://reviews.apache.org/media/uploaded/files/2016/10/17/5107a016-3a83-478c-b98c-2f35ecf6cbc5__AMBARI-12263.patch_base


Thanks,

Vishal Ghugare

Review Request 52932: Ambari MIB Should Be Included with Installation Bits

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52932/
---

Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.


Bugs: AMBARI-18611
https://issues.apache.org/jira/browse/AMBARI-18611


Repository: ambari


Description
---

The Ambari MIB located at 
https://github.com/apache/ambari/blob/trunk/contrib/alert-snmp-mib/APACHE-AMBARI-MIB.txt
 should be included on the file system when Ambari is installed.
It's location should be alongside other resources at:
/var/lib/ambari-server/resources


Diffs
-

  ambari-server/pom.xml e02b7a5 
  ambari-server/src/main/assemblies/server.xml 9252c56 

Diff: https://reviews.apache.org/r/52932/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 52917: Improve Audit Log processing by Logfeeder

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52917/#review152885
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 15, 2016, 11:48 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52917/
> ---
> 
> (Updated Oct. 15, 2016, 11:48 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18606
> https://issues.apache.org/jira/browse/AMBARI-18606
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Logfeeder should be able to handle dynamic audit fields.
> Ambari Audit log has some information which should be indexed, searchable, 
> and present in the log table on the UI.
> 
> Also fixed:
> - If filter key value is based on parentheses then inner parentheses should 
> be handled appropriately - A(B(C)) --> A = B(C)
> - New Mapper introduced to copy a value, if it needs to be loaded into more 
> than one field ( both the original value and a derived )
> - dynamic field definition was added to the audit_logs collection
> - added some ambari-audit log and configuration to the docker test environment
> - fixed a typo in the falcon configuration
> - improved code quality by some minor changes
> 
> 
> Diffs
> -
> 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/filter/FilterKeyValue.java
>  5bb15ff 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/mapper/MapperFieldCopy.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/resources/alias_config.json
>  b15db63 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/test/java/org/apache/ambari/logfeeder/mapper/MapperFieldCopyTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
>  f77bec0 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/LogSearchConstants.java
>  b13768f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
>  959d6f4 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
>  1cbac31 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
>  f16dc41 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserDao.java
>  912442d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/graph/GraphDataGenerator.java
>  85b5fda 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ManagerBase.java
>  45d66cf 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java
>  d276769 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/manager/UserConfigManager.java
>  00ae332 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/model/response/CommonLogData.java
>  e2bba3f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/model/SolrAuditLogData.java
>  0fd65a3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/model/SolrCommonLogData.java
>  bac5080 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/model/SolrServiceLogData.java
>  1d4cecf 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SolrUtil.java
>  6369107 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchKRBAuthenticationFilter.java
>  29fd5b2 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LdapProperties.java
>  2a1b4ee 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/audit/AuditTabLayoutView.js
>  4e09e88 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/static/schema_fields.json
>  7b1a9a9 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties f930ec9 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-ambari.json
>  PRE-CREATION 
>   ambari-logsearch/docker/test-logs/ambari-server/ambari-audit.log 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
>  e2646ff 
>   
> 

Re: Review Request 52930: Ambari Metrics doesn't use SPNEGO to authenticate

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52930/#review152883
---


Fix it, then Ship it!




Ship It!


ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 (line 267)


Missing Javadoc


- Robert Levas


On Oct. 17, 2016, 10:28 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52930/
> ---
> 
> (Updated Oct. 17, 2016, 10:28 a.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Robert Levas, and Sid Wagle.
> 
> 
> Bugs: AMBARI-14384
> https://issues.apache.org/jira/browse/AMBARI-14384
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Kerberos enabled cluster
> * SPNEGO enabled on hadoop APIs
> 
> /var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
> 2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
> http://metrics-collector:6188/ws/v1/timeline/metrics
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
> server. HTTP Error 401: Authentication required
> 2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...
> 
> The same problem appears to be happening on the sinks:
> * 
> ambari/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
> ** No SPNEGO support
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 0e66a6d 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  efa5cba 
> 
> Diff: https://reviews.apache.org/r/52930/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 52369: AMBARI-12263: Support PAM as authentication mechanism for accessing Ambari UI/REST

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52369/#review152880
---



It seems like there was a rebase issue with the last patch. Can you fix?

- Robert Levas


On Oct. 13, 2016, 11:25 p.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52369/
> ---
> 
> (Updated Oct. 13, 2016, 11:25 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, and Robert Levas.
> 
> 
> Bugs: AMBARI-12263
> https://issues.apache.org/jira/browse/AMBARI-12263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hello Robert,
> 
> How are you doing? 
> 
> We have been working on PAM support into Ambari and have something ready for 
> review. Can you please take a look at the patch and documentation and provide 
> your feedback.
> 
> Please let me know if you have any questions.
> 
> Note: I have added you as a reviewer as i see some authentication related 
> commits under your name.
> 
> Thanks,
> -Vishal
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/groups/edit.html 
> 78a6884 
>   ambari-agent/conf/unix/ambari-agent 30897dd 
>   ambari-agent/conf/unix/ambari-agent.ini 1c39c24 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py c03ee4f 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py cca79a8 
>   ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py 
> b476671 
>   ambari-agent/src/main/python/ambari_agent/alerts/web_alert.py 6caf1d0 
>   ambari-agent/src/main/python/ambari_agent/apscheduler/scheduler.py f787a2d 
>   ambari-agent/src/main/python/ambari_agent/apscheduler/threadpool.py cb19888 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 32773b8 
>   ambari-agent/src/test/python/resource_management/TestDataStructureUtils.py 
> a4bdc1c 
>   ambari-agent/src/test/python/resource_management/TestPackageResource.py 
> 66227c6 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py b5cea75 
>   ambari-common/src/main/python/resource_management/core/exceptions.py 
> a59611d 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/__init__.py
>  21de183 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/apt.py
>  d095173 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py
>  ea10a86 
>   
> ambari-common/src/main/python/resource_management/core/providers/package/zypper.py
>  265c162 
>   ambari-common/src/main/python/resource_management/core/shell.py f8f056a 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/data_structure_utils.py
>  59e01aa 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_user_call_output.py
>  7b7acae 
>   
> ambari-common/src/main/python/resource_management/libraries/providers/hdfs_resource.py
>  f1aa3e1 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederAMSClient.java
>  133646a 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/solr/metrics/SolrAmsClient.java
>  0d4deab 
>   ambari-logsearch/pom.xml a1b6c9d 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  efa5cba 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  e7f7cfd 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHATest.java
>  3d00270 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/HandleConnectExceptionTest.java
>  36ec074 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/java/org/apache/hadoop/metrics2/sink/flume/FlumeTimelineMetricsSink.java
>  c1b684b 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  d81187e 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  3259c18 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  dab54c0 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  890d3ce 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> ba3f18e 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/main/java/org/apache/hadoop/metrics2/sink/kafka/KafkaTimelineMetricsReporter.java
>  fef1f24 
>   
> 

Re: Review Request 49484: Remove spark.yarn.max.executor.failures configuration in Spark Ambari definition

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49484/#review152878
---


Ship it!




Ship It!

- Sumit Mohanty


On Oct. 17, 2016, 6:40 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49484/
> ---
> 
> (Updated Oct. 17, 2016, 6:40 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17489
> https://issues.apache.org/jira/browse/AMBARI-17489
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove spark.yarn.max.executor.failures configuration in Spark Ambari 
> definition
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/SPARK/1.6.0/configuration/spark-defaults.xml
>  6465b72 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> e8a2e2f 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> e127dff 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  0a14581 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> fa1a555 
> 
> Diff: https://reviews.apache.org/r/49484/diff/
> 
> 
> Testing
> ---
> 
> Local verification.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Review Request 52930: Ambari Metrics doesn't use SPNEGO to authenticate

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52930/
---

Review request for Ambari, Aravindan Vijayan, Robert Levas, and Sid Wagle.


Bugs: AMBARI-14384
https://issues.apache.org/jira/browse/AMBARI-14384


Repository: ambari


Description
---

* Kerberos enabled cluster
* SPNEGO enabled on hadoop APIs

/var/log/ambari-metrics-monitor/ambari-metrics-monitor.out:
2015-12-15 13:26:30,663 [INFO] emitter.py:101 - server: 
http://metrics-collector:6188/ws/v1/timeline/metrics
2015-12-15 13:26:30,671 [WARNING] emitter.py:84 - Error sending metrics to 
server. HTTP Error 401: Authentication required
2015-12-15 13:26:30,671 [WARNING] emitter.py:90 - Retrying after 5 ...

The same problem appears to be happening on the sinks:
* 
ambari/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
** No SPNEGO support


Diffs
-

  ambari-metrics/ambari-metrics-common/pom.xml 0e66a6d 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 efa5cba 

Diff: https://reviews.apache.org/r/52930/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

[Nate Cole]

> On Oct. 14, 2016, 10:40 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql, line 359
> > 
> >
> > This could be an 'int' column and the values stored in it mapped to he 
> > CommandExecutionType enum.
> 
> Sandor Magyari wrote:
> Well, I've followed the same solution like in case of other enums like 
> TopologyRequest.provision_action, HostRoleCommand.role_command etc.

You have to use this as strings, unless you add a table for lookup.  If you use 
int, it will store the order value.  If someone comes and adds a new enum in 
the middle of the file, then the int order will result in the incorrect enum 
value.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52691/#review152677
---


On Oct. 16, 2016, 4:33 a.m., Sandor Magyari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52691/
> ---
> 
> (Updated Oct. 16, 2016, 4:33 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo 
> Puskas, Nate Cole, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18553
> https://issues.apache.org/jira/browse/AMBARI-18553
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, the START commands stored in role_command_orders table are bound to 
> multiple stages created based on dependencies between components - a 
> component in the second stage can only begin its START after the entire first 
> stage is done as opposed to just its dependencies in the first stage. This 
> eventually increases the overall blueprint deployment time.
> The goal is to be able to configure a direct dependency based execution model 
> of commands, for now only for Blueprint based deployment commands.
> 
> Implementation:
> ---
> When creating stages we set the commandExecutionType to RoleGraph. In case 
> commandExecutionType is set to DEPENDENCY_ORDERED there's only one stage 
> created. commandExecutionType is persisted into Stage object / entity as 
> well, so ActionScheduler can decide based on commandExecutionType how to 
> execute the stage. In case commandExecutionType is set to DEPENDENCY_ORDERED 
> it will filter out commands having dependencies on other commands 
> IN_PROGRESS. By default commandExecutionType is STAGE_BASED which works as 
> before, creating one or more stages dependening on dependecies.
> DEPENDENCY_ORDERED commandExecutionType is set only in case of START commands 
> initiated by Blueprint deployment and if Ambari property 
> server.stage.command.execution_type = DEPENDENCY_ORDERED.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  8cbfb1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CommandExecutionType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> f03d8ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5d8f279 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  5afaba8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
>  bbdb808 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandPair.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  eaea913 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
>  c9ab6f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactory.java
>  625b168 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactoryImpl.java
>  5ca4d88 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  34331ee 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 4b64955 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 15a84cd 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6c3c036 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 570b684 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 170e430 
>   

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52691/#review152841
---


Fix it, then Ship it!




Has this been tested using both models while enabling Kerberos?


ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
 (line 516)


If you are fixing anything, also fix the space in "will".



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 (line 3075)


would it be worth doing a `toUpperCase` on the result from `getProperty` 
(if not null) to ensure the case of the property does not cause a failure?



ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
 (line 34)


Missing JavaDoc



ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandPair.java
 (lines 25 - 26)


These should be `private` and possibly `private final`



ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 (line 111)


Why is the length here 45 where the field in VARCHAR(32) in the DDL files?


- Robert Levas


On Oct. 16, 2016, 4:33 a.m., Sandor Magyari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52691/
> ---
> 
> (Updated Oct. 16, 2016, 4:33 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo 
> Puskas, Nate Cole, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18553
> https://issues.apache.org/jira/browse/AMBARI-18553
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, the START commands stored in role_command_orders table are bound to 
> multiple stages created based on dependencies between components - a 
> component in the second stage can only begin its START after the entire first 
> stage is done as opposed to just its dependencies in the first stage. This 
> eventually increases the overall blueprint deployment time.
> The goal is to be able to configure a direct dependency based execution model 
> of commands, for now only for Blueprint based deployment commands.
> 
> Implementation:
> ---
> When creating stages we set the commandExecutionType to RoleGraph. In case 
> commandExecutionType is set to DEPENDENCY_ORDERED there's only one stage 
> created. commandExecutionType is persisted into Stage object / entity as 
> well, so ActionScheduler can decide based on commandExecutionType how to 
> execute the stage. In case commandExecutionType is set to DEPENDENCY_ORDERED 
> it will filter out commands having dependencies on other commands 
> IN_PROGRESS. By default commandExecutionType is STAGE_BASED which works as 
> before, creating one or more stages dependening on dependecies.
> DEPENDENCY_ORDERED commandExecutionType is set only in case of START commands 
> initiated by Blueprint deployment and if Ambari property 
> server.stage.command.execution_type = DEPENDENCY_ORDERED.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  8cbfb1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CommandExecutionType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> f03d8ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5d8f279 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  5afaba8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
>  bbdb808 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandPair.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  eaea913 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
>  c9ab6f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactory.java
>  625b168 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactoryImpl.java
>  

Re: Review Request 52928: Give a reasonable error message when oozie service_check fails due to nodocs docker option

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52928/#review152864
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Oct. 17, 2016, 3:35 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52928/
> ---
> 
> (Updated Oct. 17, 2016, 3:35 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-18608
> https://issues.apache.org/jira/browse/AMBARI-18608
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This issue aims to give an informative error message for a bug where with
> default docker configuration on centos Oozie service check fails.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py
>  3710117 
> 
> Diff: https://reviews.apache.org/r/52928/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 52928: Give a reasonable error message when oozie service_check fails due to nodocs docker option

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52928/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-18608
https://issues.apache.org/jira/browse/AMBARI-18608


Repository: ambari


Description
---

This issue aims to give an informative error message for a bug where with
default docker configuration on centos Oozie service check fails.


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/service_check.py
 3710117 

Diff: https://reviews.apache.org/r/52928/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52691/#review152833
---


Ship it!




Ship It!

- Sebastian Toader


On Oct. 16, 2016, 10:33 a.m., Sandor Magyari wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52691/
> ---
> 
> (Updated Oct. 16, 2016, 10:33 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Laszlo 
> Puskas, Nate Cole, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18553
> https://issues.apache.org/jira/browse/AMBARI-18553
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Today, the START commands stored in role_command_orders table are bound to 
> multiple stages created based on dependencies between components - a 
> component in the second stage can only begin its START after the entire first 
> stage is done as opposed to just its dependencies in the first stage. This 
> eventually increases the overall blueprint deployment time.
> The goal is to be able to configure a direct dependency based execution model 
> of commands, for now only for Blueprint based deployment commands.
> 
> Implementation:
> ---
> When creating stages we set the commandExecutionType to RoleGraph. In case 
> commandExecutionType is set to DEPENDENCY_ORDERED there's only one stage 
> created. commandExecutionType is persisted into Stage object / entity as 
> well, so ActionScheduler can decide based on commandExecutionType how to 
> execute the stage. In case commandExecutionType is set to DEPENDENCY_ORDERED 
> it will filter out commands having dependencies on other commands 
> IN_PROGRESS. By default commandExecutionType is STAGE_BASED which works as 
> before, creating one or more stages dependening on dependecies.
> DEPENDENCY_ORDERED commandExecutionType is set only in case of START commands 
> initiated by Blueprint deployment and if Ambari property 
> server.stage.command.execution_type = DEPENDENCY_ORDERED.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
>  8cbfb1e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/CommandExecutionType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> f03d8ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  378db18 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5d8f279 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  5afaba8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/CachedRoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
>  bbdb808 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrderProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandPair.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
>  eaea913 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
>  c9ab6f9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactory.java
>  625b168 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraphFactoryImpl.java
>  5ca4d88 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  34331ee 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 4b64955 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 15a84cd 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 6c3c036 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 570b684 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 170e430 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 1501143 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  bd23e00 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProviderTest.java
>  d38108f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackUpgradeConfigurationMergeTest.java
>  4f2580a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java
>  2ccbcda 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java
>  d96e7b5 
>   
> 

Re: Review Request 49484: Remove spark.yarn.max.executor.failures configuration in Spark Ambari definition

[Saisai Shao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49484/
---

(Updated Oct. 17, 2016, 6:40 a.m.)


Review request for Ambari, Jayush Luniya and Sumit Mohanty.


Bugs: AMBARI-17489
https://issues.apache.org/jira/browse/AMBARI-17489


Repository: ambari


Description
---

Remove spark.yarn.max.executor.failures configuration in Spark Ambari definition


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/SPARK/1.6.0/configuration/spark-defaults.xml
 6465b72 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
e8a2e2f 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
e127dff 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 0a14581 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
fa1a555 

Diff: https://reviews.apache.org/r/49484/diff/


Testing
---

Local verification.


Thanks,

Saisai Shao