Re: Review Request 55340: Hive View 2.0: Introduction of worksheets for query editor

2017-01-09 Thread Rohit Choudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55340/#review161044 --- Ship it! Ship It! - Rohit Choudhary On Jan. 9, 2017, 12:46 p

Re: Review Request 55340: Hive View 2.0: Introduction of worksheets for query editor

2017-01-09 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55340/#review161043 --- Ship it! Ship It! - Nitiraj Rathore On Jan. 9, 2017, 12:46 p

Re: Review Request 55338: Save workflows via save mechanism instead of submission button

2017-01-09 Thread Nitiraj Rathore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55338/#review161041 --- contrib/views/wfmanager/src/main/resources/ui/tests/integration/c

Re: Review Request 55338: Save workflows via save mechanism instead of submission button

2017-01-09 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55338/ --- (Updated Jan. 10, 2017, 7:39 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Review Request 55372: AMBARI-19437 Remove anonymous bind option for Ranger User sync for LDAP/AD

2017-01-09 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55372/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley, a

Review Request 55371: AMBARI-19436: Need ability to upload a file in HDFS browser.

2017-01-09 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55371/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and

Re: Review Request 55338: Save workflows via save mechanism instead of submission button

2017-01-09 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55338/#review161039 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 9, 2017, 11:

Review Request 55369: Network interface check returns no value if there is no `ifconfig` command

2017-01-09 Thread Masahiro Tanaka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55369/ --- Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver Szabo, S

Re: Review Request 55336: AMBARI-19420: Import from local file system doesn't work if the same file is selected again.

2017-01-09 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55336/#review161037 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 9, 2017, 9:0

Re: Review Request 55173: Flume metrics can't show if hostname of flume agent is not lowercase

2017-01-09 Thread yao lei
> On 一月 6, 2017, 9:16 p.m., Aravindan Vijayan wrote: > > The hostname sent to AMS must match the hostname managed in Ambari Server. > > If we make this change in Flume sink, and the hostname is mixed case or > > upper case in Ambari Server, then the metrics not will be displayed. > > > > Did

Review Request 55367: Improve "Install Wizard step 1" after new guidelines

2017-01-09 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55367/ --- Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel Subramania

Re: Review Request 55009: HDFS Service check fails if previous active NN is down

2017-01-09 Thread Weiwei Yang
> On 一月 9, 2017, 7:30 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py, > > line 40 > > > > > > Please also include in HDFS 3.0.0.3

Re: Review Request 55009: HDFS Service check fails if previous active NN is down

2017-01-09 Thread Weiwei Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55009/ --- (Updated 一月 10, 2017, 2:25 a.m.) Review request for Ambari, Alejandro Fernandez

Re: Review Request 55364: NodeManager restart fails during HOU if it is on same host as RM

2017-01-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55364/#review161026 --- ambari-server/src/main/java/org/apache/ambari/server/stageplanner

Review Request 55364: NodeManager restart fails during HOU if it is on same host as RM

2017-01-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55364/ --- Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas. Bug

Re: Review Request 55173: Flume metrics can't show if hostname of flume agent is not lowercase

2017-01-09 Thread yao lei
> On 一月 6, 2017, 9:16 p.m., Aravindan Vijayan wrote: > > The hostname sent to AMS must match the hostname managed in Ambari Server. > > If we make this change in Flume sink, and the hostname is mixed case or > > upper case in Ambari Server, then the metrics not will be displayed. > > > > Did

Re: Review Request 55173: Flume metrics can't show if hostname of flume agent is not lowercase

2017-01-09 Thread yao lei
> On 一月 6, 2017, 9:16 p.m., Aravindan Vijayan wrote: > > The hostname sent to AMS must match the hostname managed in Ambari Server. > > If we make this change in Flume sink, and the hostname is mixed case or > > upper case in Ambari Server, then the metrics not will be displayed. > > > > Did

Re: Review Request 55361: LogSearch upgrade support 2.4 -> 2.5 addendum - add log4j properties

2017-01-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55361/#review161012 --- Ship it! Ship It! - Oliver Szabo On Jan. 9, 2017, 11:58 p.m.

Review Request 55361: LogSearch upgrade support 2.4 -> 2.5 addendum - add log4j properties

2017-01-09 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55361/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs: 19330 h

Re: Review Request 55341: Add secure znode command for ambari infra solr client

2017-01-09 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55341/#review160996 --- Ship it! Ship It! - Robert Nettleton On Jan. 9, 2017, 3:21 p

Re: Review Request 55291: AMBARI-19411: Atlas AMS support

2017-01-09 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55291/ --- (Updated Jan. 9, 2017, 9:55 p.m.) Review request for Ambari, Aravindan Vijayan

Re: Review Request 55173: Flume metrics can't show if hostname of flume agent is not lowercase

2017-01-09 Thread Aravindan Vijayan
> On Jan. 6, 2017, 9:16 p.m., Aravindan Vijayan wrote: > > The hostname sent to AMS must match the hostname managed in Ambari Server. > > If we make this change in Flume sink, and the hostname is mixed case or > > upper case in Ambari Server, then the metrics not will be displayed. > > > > Di

Re: Review Request 55278: AMBARI-17596 : Collect & Publish AmbariServer database metrics

2017-01-09 Thread Aravindan Vijayan
> On Jan. 9, 2017, 6:43 p.m., Jonathan Hurley wrote: > > ambari-server/conf/windows/metrics.properties, lines 45-46 > > > > > > Any reason some entities are excluded by default here? Things like > > Alert(.*)Entity

Re: Review Request 55291: AMBARI-19411: Atlas AMS support

2017-01-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55291/#review160960 --- ambari-metrics/ambari-metrics-atlas-sink/src/main/assemblies/jar-

Re: Review Request 55291: AMBARI-19411: Atlas AMS support

2017-01-09 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55291/ --- (Updated Jan. 9, 2017, 8:28 p.m.) Review request for Ambari, Aravindan Vijayan

Re: Review Request 55009: HDFS Service check fails if previous active NN is down

2017-01-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55009/#review160941 --- Fix it, then Ship it! ambari-server/src/main/resources/common-

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2017-01-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54970/#review160940 --- ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/

Re: Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-09 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/#review160934 --- Please be careful with on-ambari-upgrade settings. If the user is

Re: Review Request 55348: AMBARI-19427: Ambari-server - Annotate PASSWORD properties with an attribute to indicate that they are credential store aware properties

2017-01-09 Thread Nahappan Somasundaram
> On Jan. 9, 2017, 11:10 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java, > > lines 504-512 > > > > > > Do we have to restrict the property type to ONLY passwo

Re: Review Request 55348: AMBARI-19427: Ambari-server - Annotate PASSWORD properties with an attribute to indicate that they are credential store aware properties

2017-01-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55348/#review160932 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 55278: AMBARI-17596 : Collect & Publish AmbariServer database metrics

2017-01-09 Thread Jonathan Hurley
> On Jan. 9, 2017, 1:43 p.m., Jonathan Hurley wrote: > > ambari-server/conf/windows/metrics.properties, lines 45-46 > > > > > > Any reason some entities are excluded by default here? Things like > > Alert(.*)Entity

Re: Review Request 55278: AMBARI-17596 : Collect & Publish AmbariServer database metrics

2017-01-09 Thread Aravindan Vijayan
> On Jan. 9, 2017, 6:43 p.m., Jonathan Hurley wrote: > > ambari-server/conf/windows/metrics.properties, lines 45-46 > > > > > > Any reason some entities are excluded by default here? Things like > > Alert(.*)Entity

Re: Review Request 55278: AMBARI-17596 : Collect & Publish AmbariServer database metrics

2017-01-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55278/#review160924 --- Ship it! Just one more question about the metrics configured by

Review Request 55348: AMBARI-19427: Ambari-server - Annotate PASSWORD properties with an attribute to indicate that they are credential store aware properties

2017-01-09 Thread Nahappan Somasundaram
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55348/ --- Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and Sumit M

Re: Review Request 55278: AMBARI-17596 : Collect & Publish AmbariServer database metrics

2017-01-09 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55278/ --- (Updated Jan. 9, 2017, 6:20 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-09 Thread Jonathan Hurley
> On Jan. 9, 2017, 12:42 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py, > > lines 38-39 > > > > > > This pattern doesn't see

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-09 Thread Attila Doroszlai
> On Jan. 9, 2017, 6:42 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/accumulo_client.py, > > lines 38-39 > > > > > > This pattern doesn't seem

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-09 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55016/#review160911 --- -1 on this patch. If you are protecting against directory creatio

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-09 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55016/#review160909 --- Fix it, then Ship it! Changing every packages `install` functio

Re: Review Request 55344: AMBARI-19407: Provide default values for oozie nproc_limit and nofile_limit configuration

2017-01-09 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55344/#review160907 --- Ship it! Ship It! - Tim Thorpe On Jan. 9, 2017, 5:10 p.m., D

Re: Review Request 55345: AMBARI-19406: Provide default value for hbase java io tmp dir

2017-01-09 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55345/#review160906 --- Ship it! Ship It! - Tim Thorpe On Jan. 9, 2017, 5:12 p.m., D

Review Request 55345: AMBARI-19406: Provide default value for hbase java io tmp dir

2017-01-09 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55345/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-19406 https://issues

Review Request 55344: AMBARI-19407: Provide default values for oozie nproc_limit and nofile_limit configuration

2017-01-09 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55344/ --- Review request for Ambari and Tim Thorpe. Bugs: AMBARI-19407 https://issues

Re: Review Request 55249: Infra Solr Upgrade support 2.4 -> 2.5

2017-01-09 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55249/#review160898 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 55341: Add secure znode command for ambari infra solr client

2017-01-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55341/ --- (Updated Jan. 9, 2017, 3:21 p.m.) Review request for Ambari, Miklos Gergely and

Re: Review Request 55174: AMBARI-19288 : Ranger policies not syncing for storm, kafka and knox

2017-01-09 Thread Vishal Suvagia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55174/ --- (Updated Jan. 9, 2017, 3:12 p.m.) Review request for Ambari, Alejandro Fernande

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-09 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/ --- (Updated Jan. 9, 2017, 3:07 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 55341: Add secure znode command for ambari infra solr client

2017-01-09 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55341/#review160894 --- Fix it, then Ship it! Ship It! ambari-logsearch/ambari-logsea

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-09 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/ --- (Updated Jan. 9, 2017, 3 p.m.) Review request for Ambari, Attila Doroszlai, Las

Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-09 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/ --- Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, Sandor

Re: Review Request 55341: Add secure znode command for ambari infra solr client

2017-01-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55341/ --- (Updated Jan. 9, 2017, 2:28 p.m.) Review request for Ambari, Miklos Gergely and

Review Request 55341: Add secure znode command for ambari infra solr client

2017-01-09 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55341/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs: AMBARI-19

Review Request 46268: AMBARI-19044 Install & configure Ranger plugin components independently of Ranger admin components

2017-01-09 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46268/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, Jayu

Re: Review Request 55282: AMBARI-19405. Allow running a subset of Python unit tests in ambari-agent.

2017-01-09 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55282/#review160890 --- Ship it! Ship It! - Sandor Magyari On Jan. 6, 2017, 9:59 p.m

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55016/#review160887 --- Ship it! Ship It! - Sebastian Toader On Jan. 9, 2017, 11:51

Review Request 55340: Hive View 2.0: Introduction of worksheets for query editor

2017-01-09 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55340/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and

Re: Review Request 54888: Ambari capacity queue manager only accepts values in integers i.e not decimal values like 0.5

2017-01-09 Thread Akhil PB
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54888/ --- (Updated Jan. 9, 2017, 11:29 a.m.) Review request for Ambari, DIPAYAN BHOWMICK,

Re: Review Request 55310: AMBARI-13324 automate creating Flume Keytab and principal

2017-01-09 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55310/#review160884 --- Ship it! Ship It! - Robert Levas On Jan. 7, 2017, 11 p.m., S

Re: Review Request 55250: AMBARI-19384. Wrong placeholder in REST metrics error message

2017-01-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55250/#review160883 --- Ship it! Ship It! - Sebastian Toader On Jan. 9, 2017, 11:53

Review Request 55338: Save workflows via save mechanism instead of submission button

2017-01-09 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55338/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Pall

Re: Review Request 55325: Ambari agents remain in heartbeat lost state after ambari server restart

2017-01-09 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55325/#review160882 --- Ship it! Ship It! - Attila Doroszlai On Jan. 9, 2017, 11:02

Re: Review Request 55258: Workflow imported into Local FS cannot be imported into WFD

2017-01-09 Thread Renjith Kamath
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55258/#review160881 --- Ship it! Ship It! - Renjith Kamath On Jan. 6, 2017, 8:09 a.m

Re: Review Request 55260: Zeppelin stop failed during EU while deleting pid file with customized service user

2017-01-09 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55260/#review160880 --- Ship it! Ship It! - Prabhjyot Singh On Jan. 6, 2017, 9:45 a.

Re: Review Request 55325: Ambari agents remain in heartbeat lost state after ambari server restart

2017-01-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55325/ --- (Updated Jan. 9, 2017, 11:02 a.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 55336: AMBARI-19420: Import from local file system doesn't work if the same file is selected again.

2017-01-09 Thread DIPAYAN BHOWMICK
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55336/#review160879 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Jan. 9, 2017, 9:08 a

Review Request 55336: AMBARI-19420: Import from local file system doesn't work if the same file is selected again.

2017-01-09 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55336/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and

Re: Review Request 54888: Ambari capacity queue manager only accepts values in integers i.e not decimal values like 0.5

2017-01-09 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54888/#review160871 --- Fix it, then Ship it! Ship It! contrib/views/capacity-schedul

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

2017-01-09 Thread ping wang
> On 一月 6, 2017, 6:42 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml, > > line 22 > > > > > > HDP 2.5 and higher use Oozie 4.2.0.2.5

Re: Review Request 55325: Ambari agents remain in heartbeat lost state after ambari server restart

2017-01-09 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55325/#review160870 --- ambari-agent/src/main/python/ambari_agent/Controller.py (line 472