Re: Review Request 63666: AMBARI-22327 Allow different OS types and versions for Hybrid setup

[Yussuf Shaikh]

> On Nov. 9, 2017, 1:40 p.m., Nate Cole wrote:
> > ambari-server/src/main/python/os_check_type.py
> > Line 33 (original), 33 (patched)
> > 
> >
> > Previous message was a bit more informative.  We may want something 
> > more descriptive here other than just the os type

We want to use current_os value from stdout in bootstrap.py script as 
retcode["log"], let me know if descriptive message is necessary. We can make 
the print message as "OS type of current host is : redhat6" and split the log 
message in bootstrap.py based on ':'.


- Yussuf


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63666/#review190581
---


On Nov. 8, 2017, 2:27 p.m., Yussuf Shaikh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63666/
> ---
> 
> (Updated Nov. 8, 2017, 2:27 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-22327
> https://issues.apache.org/jira/browse/AMBARI-22327
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For setting up Ambari hybrid cluster we need to allow different OS types for 
> agent hosts as compared to the server OS type.
> The strict check during bootstrap needs to be changed in os_check_type.py
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/os_check_type.py 34de34b 
>   ambari-server/src/test/python/TestOSCheck.py 9aba78b 
> 
> 
> Diff: https://reviews.apache.org/r/63666/diff/1/
> 
> 
> Testing
> ---
> 
> test_os_type_check (TestOSCheck.TestOSCheck) ... ok
> 
> 
> Thanks,
> 
> Yussuf Shaikh
> 
>

Re: Review Request 63713: Restart all required services failed when running cluster with several patch upgrades applied

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63713/#review190669
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
Line 1280 (original), 1280 (patched)


I think Tez can go by itself...


- Jonathan Hurley


On Nov. 9, 2017, 8:43 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63713/
> ---
> 
> (Updated Nov. 9, 2017, 8:43 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22411
> https://issues.apache.org/jira/browse/AMBARI-22411
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Small refactor to pass StackID instead of RepositoryVersionEntity, negating 
> the check that made this call fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d8712f2c75 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5ea4bbdf3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  1ec790f7cc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  23c6d32dff 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  c80620f6a3 
> 
> 
> Diff: https://reviews.apache.org/r/63713/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.
> Unit tests pending.  Mostly verify that existing tests continue to work 
> without error.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 63713: Restart all required services failed when running cluster with several patch upgrades applied

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63713/#review190670
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 9, 2017, 8:43 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63713/
> ---
> 
> (Updated Nov. 9, 2017, 8:43 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-22411
> https://issues.apache.org/jira/browse/AMBARI-22411
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Small refactor to pass StackID instead of RepositoryVersionEntity, negating 
> the check that made this call fail.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d8712f2c75 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  5ea4bbdf3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  1ec790f7cc 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  23c6d32dff 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  c80620f6a3 
> 
> 
> Diff: https://reviews.apache.org/r/63713/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.
> Unit tests pending.  Mostly verify that existing tests continue to work 
> without error.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review190668
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 9, 2017, 4:58 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63516/
> ---
> 
> (Updated Nov. 9, 2017, 4:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22353
> https://issues.apache.org/jira/browse/AMBARI-22353
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Legacy/ancient ResourceProviders use the {{properties.json}} file to govern 
> which properties can be used with the provider. This seems like excessive 
> decoupling without any benefit and usually leads to runtime errors when new 
> or removed properties are forgotten.
> 
> This file should be removed and the providers should be registering the known 
> properties on their own.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  711ae10f7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java
>  a24c6394ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  1dc0841d19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java
>  953a2a7c77 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
>  4e618e7ff6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
>  389f0b2bf2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  32f1fd8f4f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
>  cf4e7475b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java
>  8d716eabe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java
>  8ffd596cfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
>  c71651e5ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  43ee7fe7c7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
>  4f4cc7070d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  73d24908ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  a2a49d7cb5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
>  2678d55975 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  54c83600b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  1a755590b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  737bfa4d46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java
>  0f260854f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java
>  79254c6d89 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  c3758b3f5e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java
>  db904bf714 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java
>  53e44e1888 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java
>  4aa357c0e3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java
>  f9d75fd353 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java
>  f9f838fe22 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
>  f051651e12 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java
>  2a25bc4d02 
>   
> 

Review Request 63713: Restart all required services failed when running cluster with several patch upgrades applied

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63713/
---

Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.


Bugs: AMBARI-22411
https://issues.apache.org/jira/browse/AMBARI-22411


Repository: ambari


Description
---

Small refactor to pass StackID instead of RepositoryVersionEntity, negating the 
check that made this call fail.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 d8712f2c75 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 5ea4bbdf3d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 1ec790f7cc 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
 23c6d32dff 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 c80620f6a3 


Diff: https://reviews.apache.org/r/63713/diff/1/


Testing
---

Manual.
Unit tests pending.


Thanks,

Nate Cole

Re: Review Request 63707: Simplify Ambari configuration tables from AMBARI-21307

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63707/
---

(Updated Nov. 9, 2017, 5:58 p.m.)


Review request for Ambari, Attila Magyar, Eugene Chekanskiy, Jonathan Hurley, 
Nate Cole, Robert Nettleton, and Swapan Shridhar.


Bugs: AMBARI-22347
https://issues.apache.org/jira/browse/AMBARI-22347


Repository: ambari


Description
---

Simplify Ambari configuration tables from AMBARI-21307.

configuration_base and ambari_configuration tables were introduced in 
AMBARI-21307; however, these tables are more complex than needed. Future 
architecture changes will eventually negate the need to have a shard 
configuration structure as proposed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
 5e8094e9c7 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
 38ae7669db 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
 b5cc9212da 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
 13f8835655 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
 4f4cc7070d 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
0f9ff52147 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariLdapConfigChangedEvent.java
 48799d793b 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java
 8b26cd3e29 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
 c88d420e9a 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/LdapConnectionTemplateFactory.java
 8467af08b6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAO.java
 83293efb82 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntity.java
 c9f4695469 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ConfigurationBaseEntity.java
 9ad30d7d1a 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 8812ef5bfc 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
 d3e924e66c 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7d634941d9 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql af17353ff3 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 89c7971303 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 3d2bd3a107 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 55a6c61017 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e5e8af59c3 
  ambari-server/src/main/resources/META-INF/persistence.xml 67eef705af 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProviderTest.java
 c2a14218e7 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAOTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
 bd8f5cbd57 


Diff: https://reviews.apache.org/r/63707/diff/1/


Testing (updated)
---

Manually tested

# Local test results: 

```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 26:56 min
[INFO] Finished at: 2017-11-09T17:32:37-05:00
[INFO] Final Memory: 98M/1957M
[INFO] 
```


# Jenkins test results: PENDING


Thanks,

Robert Levas

Review Request 63707: Simplify Ambari configuration tables from AMBARI-21307

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63707/
---

Review request for Ambari, Attila Magyar, Eugene Chekanskiy, Jonathan Hurley, 
Nate Cole, Robert Nettleton, and Swapan Shridhar.


Bugs: AMBARI-22347
https://issues.apache.org/jira/browse/AMBARI-22347


Repository: ambari


Description
---

Simplify Ambari configuration tables from AMBARI-21307.

configuration_base and ambari_configuration tables were introduced in 
AMBARI-21307; however, these tables are more complex than needed. Future 
architecture changes will eventually negate the need to have a shard 
configuration structure as proposed.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
 5e8094e9c7 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
 38ae7669db 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
 b5cc9212da 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
 13f8835655 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
 4f4cc7070d 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java 
0f9ff52147 
  
ambari-server/src/main/java/org/apache/ambari/server/events/AmbariLdapConfigChangedEvent.java
 48799d793b 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/domain/AmbariLdapConfiguration.java
 8b26cd3e29 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/AmbariLdapConfigurationProvider.java
 c88d420e9a 
  
ambari-server/src/main/java/org/apache/ambari/server/ldap/service/ads/LdapConnectionTemplateFactory.java
 8467af08b6 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAO.java
 83293efb82 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntity.java
 c9f4695469 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AmbariConfigurationEntityPK.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ConfigurationBaseEntity.java
 9ad30d7d1a 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java
 8812ef5bfc 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
 d3e924e66c 
  ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 7d634941d9 
  ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql af17353ff3 
  ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 89c7971303 
  ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 3d2bd3a107 
  ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 55a6c61017 
  ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e5e8af59c3 
  ambari-server/src/main/resources/META-INF/persistence.xml 67eef705af 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProviderTest.java
 c2a14218e7 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AmbariConfigurationDAOTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
 bd8f5cbd57 


Diff: https://reviews.apache.org/r/63707/diff/1/


Testing
---

Manually tested

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Re: Review Request 63573: AMBARI-22366. POST, GET and UPDATE API for cluster settings. (/clusters/{clusterName}/settings).

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63573/#review190640
---


Ship it!




Ship It!

- Attila Doroszlai


On Nov. 9, 2017, 7:54 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63573/
> ---
> 
> (Updated Nov. 9, 2017, 7:54 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22366
> https://issues.apache.org/jira/browse/AMBARI-22366
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-22366. POST, GET and UPDATE API for cluster settings. 
> (/clusters/{clusterName}/settings).
> 
> **Background:** AMBARI-22196 did the following : 
>  (1). Refactoring work of moving all cluster related configs/settings in 
> cluster-env to "cluster-settings" files.
>  (2). Implementing READ only API to access *cluster-settings* file 
> *setting(s)* : *http://:/api/v1/cluster_settings/ *
> 
> - This was done to separate cluster related configs from stack related 
> configs.
> 
> **This JIRA implements the following :**
> 
> - POST, GET, UPDATE and DELETE APIs for cluster settings with endpoint : 
>   *http://:/api/v1/clusters/[[clusterName]]/settings*, where 
>-- the cluster settings would be initially read from the above mentioned 
> read-only API : *http://:/api/v1/cluster_settings/*. 
> 
> - Further, added cluster *settings* as a sub-resource of *cluster* resource.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ClusterSettingNotFoundException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterResourceDefinition.java
>  e5680dd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ClusterSettingResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  6096fa5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
>  92f50f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterSettingService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  358b1bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  370f735 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ClusterSettingResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3db55d4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  20f4864 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupResponse.java
>  147650c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  9050e3d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterSettingResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  c219d23 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  bd6d7bb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/ClusterSettingEvent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ClusterSettingDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterEntity.java
>  abbf709 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterSettingEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  3b74e69 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 5ba61b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSetting.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingFactory.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ClusterSettingImpl.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  7737c0d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  e896d0e 

Re: Review Request 63684: Patch Upgrades Broken For Clients Due To Versioned LD Library

[Jonathan Hurley]

> On Nov. 9, 2017, 12:30 p.m., Nate Cole wrote:
> > Do we need to consider other upgrades, e.g. from HDP-2.5 to -2.6 as well?

It's not wrong to, but I don't think it's needed either. If you go from HDP 2.5 
to 2.6, and then start patching on 2.6, it'll get changed at that point...


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63684/#review190616
---


On Nov. 8, 2017, 4:22 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63684/
> ---
> 
> (Updated Nov. 8, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22386
> https://issues.apache.org/jira/browse/AMBARI-22386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When services are patched to different versions, jobs being run in containers 
> are unable to pickup the correct JARs from the {{LD_LIBRARY_PATH}} passed in 
> via the job. 
> 
> Consider the following situation:
> - Base cluster installed at 2.6.3.0-1
> - Enable some sort of codec, like snappy
> - YARN patched to 2.6.3.1-1
> - Hive patched to 2.6.3.2-1
> 
> When Hive goes to run jobs on Tez or when jobs are run on MapR, whatever is 
> sending the job is resolving the {{hdp.version}} to its own version. The box 
> that the job runs on, however, might not have that specific versioned 
> directory. 
> 
> The problem can only be solved externally by providing a way to ensure that 
> the native libraries are on every machine which could potentially run jobs. 
> We could install bits on every host, but that would defeat the space-saving 
> purposes of patch upgrades.
> 
> Another solution is to ensure that the Tez and MapR tarballs have the 
> required libraries and that those libraries are added to the classpath of 
> launched jobs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml
>  a7d8cd67bd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/configuration/tez-site.xml
>  1427a6faae 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration-mapred/mapred-site.xml
>  4ad08cebf9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 0df0334c53 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  b4e3745099 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 98223904c8 
> 
> 
> Diff: https://reviews.apache.org/r/63684/diff/2/
> 
> 
> Testing
> ---
> 
> Manual upgrade on patched cluster.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 63684: Patch Upgrades Broken For Clients Due To Versioned LD Library

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63684/#review190616
---


Ship it!




Do we need to consider other upgrades, e.g. from HDP-2.5 to -2.6 as well?

- Nate Cole


On Nov. 8, 2017, 4:22 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63684/
> ---
> 
> (Updated Nov. 8, 2017, 4:22 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22386
> https://issues.apache.org/jira/browse/AMBARI-22386
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When services are patched to different versions, jobs being run in containers 
> are unable to pickup the correct JARs from the {{LD_LIBRARY_PATH}} passed in 
> via the job. 
> 
> Consider the following situation:
> - Base cluster installed at 2.6.3.0-1
> - Enable some sort of codec, like snappy
> - YARN patched to 2.6.3.1-1
> - Hive patched to 2.6.3.2-1
> 
> When Hive goes to run jobs on Tez or when jobs are run on MapR, whatever is 
> sending the job is resolving the {{hdp.version}} to its own version. The box 
> that the job runs on, however, might not have that specific versioned 
> directory. 
> 
> The problem can only be solved externally by providing a way to ensure that 
> the native libraries are on every machine which could potentially run jobs. 
> We could install bits on every host, but that would defeat the space-saving 
> purposes of patch upgrades.
> 
> Another solution is to ensure that the Tez and MapR tarballs have the 
> required libraries and that those libraries are added to the classpath of 
> launched jobs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml
>  a7d8cd67bd 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/configuration/tez-site.xml
>  1427a6faae 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration-mapred/mapred-site.xml
>  4ad08cebf9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/config-upgrade.xml 
> 0df0334c53 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml
>  b4e3745099 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 
> 98223904c8 
> 
> 
> Diff: https://reviews.apache.org/r/63684/diff/2/
> 
> 
> Testing
> ---
> 
> Manual upgrade on patched cluster.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 63653: Add service group dependencies

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63653/#review190612
---


Ship it!




Ship It!

- Jayush Luniya


On Nov. 9, 2017, 12:16 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63653/
> ---
> 
> (Updated Nov. 9, 2017, 12:16 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, Madhuvanthi 
> Radhakrishnan, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added id column for service group dependency.
> Tested and fixed cross cluster mapping
> Did some code cleanup
> 
> P.S. I've added changes only for postgres .sql file. After First review, if 
> main part is ok, i will add changes and test other dbs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  0638a06 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java
>  e9cf937 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
>  78610d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/ServiceGroupDAO.java
>  63e78d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupDependencyEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  1bcdd80 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 2193c3a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 3d59c96 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  7737c0d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  881f172 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 36ff3b7 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 70a6543 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 7c5f0fd 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql dfef1ce 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 870555d 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 641b959 
>   ambari-server/src/main/resources/META-INF/persistence.xml 009ecd5 
> 
> 
> Diff: https://reviews.apache.org/r/63653/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63464: Beeline connection hangs for longer time when connection to HS2 with metastore DB down

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63464/#review190596
---



Doesn't the same problem affect Spark/Spark2 Thrift Server alert, which also 
uses Beeline?

- Attila Doroszlai


On Nov. 1, 2017, 1:43 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63464/
> ---
> 
> (Updated Nov. 1, 2017, 1:43 p.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22346
> https://issues.apache.org/jira/browse/AMBARI-22346
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM:  
> beeline connection to HS2 hangs when hive metastore Database is down.  
> Issue seen on HDP 2.5.3 and 2.6 version clusters, same test on HDP 2.4.2
> beeline doesn't hangs.
> 
> BUSINESS IMPACT:  
> Ambari spawning multiple beeline processes thats hanging causes unnecessary
> memory usage, resulting in master service failures.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py
>  3560bf82f5 
> 
> 
> Diff: https://reviews.apache.org/r/63464/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63698: Implement many-to-many relation between keytabs and principals

[Eugene Chekanskiy]

> On Nov. 9, 2017, 1:53 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
> > Lines 142 (patched)
> > 
> >
> > Will this prevent keytab files for headless principals from being 
> > regenerated when a regenerate all keytab files operation is being performed?

Thanks, that is an error, we need regenerate by default, but check for 
isService only if host filter is exists.


- Eugene


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63698/#review190583
---


On Nov. 9, 2017, 2:34 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63698/
> ---
> 
> (Updated Nov. 9, 2017, 2:34 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Dmitro Lisnichenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-22390
> https://issues.apache.org/jira/browse/AMBARI-22390
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Now it is possible to put mulitple different principals to same keytab:
> 
> * copy keytap entry from existant identity:
> 1. define principal with new unique name(identity1) and reference to 
> principal that you want to update(identity0)
>   2. redefine principal record of identity
>   3. Good luck, now principals from identity1 and identity0 will be located 
> in keytab file from identity0
> * just define new keytab entry in identity with same keytab file. If owners 
> are different for same keytab in different identities warning will be 
> printed, if owners and goups are different, or group does not have "r" 
> permission for file, error will be printed, so make sure that users that need 
> this keytab are in group that can access it
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  f91383117f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  1dc8ca8ec7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  59d532753d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  3491f18931 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
>  f66d273665 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json 
> 166adbd7d0 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
> f2dd9e7e3d 
>   ambari-server/src/main/resources/common-services/SPARK/2.2.0/kerberos.json 
> bf763de6d9 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> 95d735b972 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> b4e93ddc77 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> 575b9fa42f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
> 89f19d4927 
> 
> 
> Diff: https://reviews.apache.org/r/63698/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 63701: Upstart is not able to stop the ambari-agent

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63701/#review190587
---


Ship it!




Ship It!

- Dmytro Sen


On Nov. 9, 2017, 2:08 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63701/
> ---
> 
> (Updated Nov. 9, 2017, 2:08 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22398
> https://issues.apache.org/jira/browse/AMBARI-22398
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While starting ambari-agent using "service ambari-agent start" it works fine
> but when we used try to check status using "start ambari-agent" (upstart
> command) facing issue. But when we start ambari agent using "start ambari-
> agent" it's works but at this time when we checked status using service
> command facing issue.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariAgent.py 28b9528e47 
> 
> 
> Diff: https://reviews.apache.org/r/63701/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63701: Upstart is not able to stop the ambari-agent

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63701/#review190586
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Ноя. 9, 2017, 2:08 п.п., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63701/
> ---
> 
> (Updated Ноя. 9, 2017, 2:08 п.п.)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22398
> https://issues.apache.org/jira/browse/AMBARI-22398
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While starting ambari-agent using "service ambari-agent start" it works fine
> but when we used try to check status using "start ambari-agent" (upstart
> command) facing issue. But when we start ambari agent using "start ambari-
> agent" it's works but at this time when we checked status using service
> command facing issue.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariAgent.py 28b9528e47 
> 
> 
> Diff: https://reviews.apache.org/r/63701/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63464: Beeline connection hangs for longer time when connection to HS2 with metastore DB down

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63464/#review190585
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Ноя. 1, 2017, 12:43 п.п., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63464/
> ---
> 
> (Updated Ноя. 1, 2017, 12:43 п.п.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-22346
> https://issues.apache.org/jira/browse/AMBARI-22346
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PROBLEM:  
> beeline connection to HS2 hangs when hive metastore Database is down.  
> Issue seen on HDP 2.5.3 and 2.6 version clusters, same test on HDP 2.4.2
> beeline doesn't hangs.
> 
> BUSINESS IMPACT:  
> Ambari spawning multiple beeline processes thats hanging causes unnecessary
> memory usage, resulting in master service failures.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py
>  3560bf82f5 
> 
> 
> Diff: https://reviews.apache.org/r/63464/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63698: Implement many-to-many relation between keytabs and principals

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63698/
---

(Updated Nov. 9, 2017, 2:34 p.m.)


Review request for Ambari, Attila Magyar, Dmitro Lisnichenko, and Robert Levas.


Bugs: AMBARI-22390
https://issues.apache.org/jira/browse/AMBARI-22390


Repository: ambari


Description
---

Now it is possible to put mulitple different principals to same keytab:

* copy keytap entry from existant identity:
1. define principal with new unique name(identity1) and reference to principal 
that you want to update(identity0)
  2. redefine principal record of identity
  3. Good luck, now principals from identity1 and identity0 will be located in 
keytab file from identity0
* just define new keytab entry in identity with same keytab file. If owners are 
different for same keytab in different identities warning will be printed, if 
owners and goups are different, or group does not have "r" permission for file, 
error will be printed, so make sure that users that need this keytab are in 
group that can access it


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 f91383117f 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 1dc8ca8ec7 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 59d532753d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
 3491f18931 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
 f66d273665 
  ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json 
166adbd7d0 
  ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
f2dd9e7e3d 
  ambari-server/src/main/resources/common-services/SPARK/2.2.0/kerberos.json 
bf763de6d9 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
95d735b972 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
b4e93ddc77 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
575b9fa42f 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
89f19d4927 


Diff: https://reviews.apache.org/r/63698/diff/2/

Changes: https://reviews.apache.org/r/63698/diff/1-2/


Testing
---

mvn clean test, cluster deploy


Thanks,

Eugene Chekanskiy

Re: Review Request 63702: PERF stack: Deploy fails due to common hooks being used instead of one specific to PERF

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63702/#review190584
---


Ship it!




Ship It!

- Attila Doroszlai


On Nov. 9, 2017, 3:14 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63702/
> ---
> 
> (Updated Nov. 9, 2017, 3:14 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-22402
> https://issues.apache.org/jira/browse/AMBARI-22402
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hooks location should be customizible. Because perf stack uses different hooks
> folder.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
>  1bf67c3c24 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  aba4952603 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  2fd22d563a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  a1ec98afe7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
> eb6737adb2 
>   contrib/utils/perf/deploy-gce-perf-cluster.py 7431ae9d7a 
> 
> 
> Diff: https://reviews.apache.org/r/63702/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 63702: PERF stack: Deploy fails due to common hooks being used instead of one specific to PERF

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63702/
---

Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-22402
https://issues.apache.org/jira/browse/AMBARI-22402


Repository: ambari


Description
---

Hooks location should be customizible. Because perf stack uses different hooks
folder.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java
 1bf67c3c24 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 aba4952603 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 2fd22d563a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 a1ec98afe7 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
eb6737adb2 
  contrib/utils/perf/deploy-gce-perf-cluster.py 7431ae9d7a 


Diff: https://reviews.apache.org/r/63702/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 63701: Upstart is not able to stop the ambari-agent

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63701/
---

Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.


Bugs: AMBARI-22398
https://issues.apache.org/jira/browse/AMBARI-22398


Repository: ambari


Description
---

While starting ambari-agent using "service ambari-agent start" it works fine
but when we used try to check status using "start ambari-agent" (upstart
command) facing issue. But when we start ambari agent using "start ambari-
agent" it's works but at this time when we checked status using service
command facing issue.


Diffs
-

  ambari-agent/src/main/python/ambari_agent/AmbariAgent.py 28b9528e47 


Diff: https://reviews.apache.org/r/63701/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 63698: Implement many-to-many relation between keytabs and principals

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63698/#review190583
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
Lines 142 (patched)


Will this prevent keytab files for headless principals from being 
regenerated when a regenerate all keytab files operation is being performed?



ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json
Line 26 (original), 26 (patched)


This may not be a good idea since it opens up the keytab file to all users 
of the group - which is typically "hadoop".  

Assuming most of the the time {{spark-env/spark_user}} and 
{{spark2-env/spark_user}} are the same this should not be an issue.



ambari-server/src/main/resources/common-services/SPARK/2.2.0/kerberos.json
Line 26 (original), 26 (patched)


This may not be a good idea since it opens up the keytab file to all users 
of the group - which is typically "hadoop".  

Assuming most of the the time {{spark-env/spark_user}} and 
{{spark2-env/spark_user}} are the same this should not be an issue.



ambari-server/src/main/resources/common-services/SPARK/2.2.0/kerberos.json
Line 107 (original), 107 (patched)


This may not be a good idea since it opens up the keytab file to all users 
of the group - which is typically "hadoop".  

Assuming most of the the time {{livy-env/livy_user}} and 
{{livy2-env/livy_user}} are the same this should not be an issue.



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json
Line 26 (original), 26 (patched)


This may not be a good idea since it opens up the keytab file to all users 
of the group - which is typically "hadoop".  

Assuming most of the the time {{spark-env/spark_user}} and 
{{spark2-env/spark_user}} are the same this should not be an issue.



ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json
Line 26 (original), 26 (patched)


This may not be a good idea since it opens up the keytab file to all users 
of the group - which is typically "hadoop".  

Assuming most of the the time {{spark-env/spark_user}} and 
{{spark2-env/spark_user}} are the same this should not be an issue.



ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json
Line 26 (original), 26 (patched)


This may not be a good idea since it opens up the keytab file to all users 
of the group - which is typically "hadoop".  

Assuming most of the the time {{spark-env/spark_user}} and 
{{spark2-env/spark_user}} are the same this should not be an issue.



ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json
Line 106 (original), 106 (patched)


This may not be a good idea since it opens up the keytab file to all users 
of the group - which is typically "hadoop".  

Assuming most of the the time {{livy-env/livy_user}} and 
{{livy2-env/livy_user}} are the same this should not be an issue.



ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json
Line 26 (original), 26 (patched)


This may not be a good idea since it opens up the keytab file to all users 
of the group - which is typically "hadoop".  

Assuming most of the the time {{spark-env/spark_user}} and 
{{spark2-env/spark_user}} are the same this should not be an issue.



ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json
Line 106 (original), 106 (patched)


This may not be a good idea since it opens up the keytab file to all users 
of the group - which is typically "hadoop".  

Assuming most of the the time {{livy-env/livy_user}} and 
{{livy2-env/livy_user}} are the same this should not be an issue.


- Robert Levas


On Nov. 9, 2017, 7:53 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63698/
> ---
> 
> (Updated Nov. 9, 2017, 7:53 a.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Dmitro Lisnichenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-22390
> https://issues.apache.org/jira/browse/AMBARI-22390
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Now it is 

Re: Review Request 63698: Implement many-to-many relation between keytabs and principals

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63698/#review190582
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 9, 2017, 2:53 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63698/
> ---
> 
> (Updated Nov. 9, 2017, 2:53 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Dmitro Lisnichenko, and Robert 
> Levas.
> 
> 
> Bugs: AMBARI-22390
> https://issues.apache.org/jira/browse/AMBARI-22390
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Now it is possible to put mulitple different principals to same keytab:
> 
> * copy keytap entry from existant identity:
> 1. define principal with new unique name(identity1) and reference to 
> principal that you want to update(identity0)
>   2. redefine principal record of identity
>   3. Good luck, now principals from identity1 and identity0 will be located 
> in keytab file from identity0
> * just define new keytab entry in identity with same keytab file. If owners 
> are different for same keytab in different identities warning will be 
> printed, if owners and goups are different, or group does not have "r" 
> permission for file, error will be printed, so make sure that users that need 
> this keytab are in group that can access it
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  f91383117f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
>  1dc8ca8ec7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  59d532753d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
>  3491f18931 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
>  f66d273665 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json 
> 166adbd7d0 
>   ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
> f2dd9e7e3d 
>   ambari-server/src/main/resources/common-services/SPARK/2.2.0/kerberos.json 
> bf763de6d9 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> 95d735b972 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
> b4e93ddc77 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
> 575b9fa42f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
> 89f19d4927 
> 
> 
> Diff: https://reviews.apache.org/r/63698/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test, cluster deploy
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

[Nate Cole]

> On Nov. 2, 2017, 7:42 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
> > Lines 69-72 (patched)
> > 
> >
> > I don't think we ever change this map do we?  Can use 
> > ImmutableMap.builder().put()...build()
> > 
> > Or, simple ones like this can be Collections.singletonMap(key, value)
> 
> Dmitro Lisnichenko wrote:
> these changes would require a big patch. Should I fix all providers, or 
> only ones affected by a current patch?

Just affected by current patch.


> On Nov. 2, 2017, 7:42 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
> > Lines 77-87 (patched)
> > 
> >
> > Recommend Sets.newHashSet(String...) - it's much cleaner looking and 
> > avoids an added static{} block.
> 
> Dmitro Lisnichenko wrote:
> these changes would require a big patch. Should I fix all providers, or 
> only ones affected by a current patch?

Just affected by current patch.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review189988
---


On Nov. 9, 2017, 4:58 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63516/
> ---
> 
> (Updated Nov. 9, 2017, 4:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22353
> https://issues.apache.org/jira/browse/AMBARI-22353
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Legacy/ancient ResourceProviders use the {{properties.json}} file to govern 
> which properties can be used with the provider. This seems like excessive 
> decoupling without any benefit and usually leads to runtime errors when new 
> or removed properties are forgotten.
> 
> This file should be removed and the providers should be registering the known 
> properties on their own.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  711ae10f7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java
>  a24c6394ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  1dc0841d19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java
>  953a2a7c77 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
>  4e618e7ff6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
>  389f0b2bf2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  32f1fd8f4f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
>  cf4e7475b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java
>  8d716eabe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java
>  8ffd596cfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
>  c71651e5ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  43ee7fe7c7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
>  4f4cc7070d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  73d24908ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  a2a49d7cb5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
>  2678d55975 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  54c83600b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  1a755590b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  737bfa4d46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java
>  0f260854f8 
>   
> 

Re: Review Request 63695: Create a Pre-Upgrade Check Warning About LZO

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63695/#review190578
---



Should have a test.


ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
Lines 331 (patched)


Should be a cluster check - this isn't specific to any service (even though 
core-site is associated with HDFS)



ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
Lines 332 (patched)


"LZO Codec Check"



ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java
Lines 34-35 (patched)


Copy error :)



ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java
Lines 70-72 (patched)


Elsewhere in the code "io.compression.codecs" is checked to see if it 
contains "com.hadoop.compression.lzo"

We should check that one first as it's more consistent with the other 
checks.



ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java
Lines 76 (patched)


Not service-specific


- Nate Cole


On Nov. 9, 2017, 5:15 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63695/
> ---
> 
> (Updated Nov. 9, 2017, 5:15 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22387
> https://issues.apache.org/jira/browse/AMBARI-22387
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari has removed its native support of distributing and installing LZO when 
> the LZO codecs are enabled in {{core-site}}. For existing clusters where LZO 
> is enabled, this means that performing an upgrade will now require manual 
> user intervention to get the LZO packages installed.
> 
> A pre-upgrade check should be created which checks to see if LZO is enabled 
> in the cluster and then produces a {{WARNING}} to the user letting them know 
> that before upgrading, they'd need to distribute the appropriate LZO packages.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  f5e4ff9061 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63695/diff/2/
> 
> 
> Testing
> ---
> 
> checking
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 63695: Create a Pre-Upgrade Check Warning About LZO

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63695/#review190579
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 9, 2017, 5:15 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63695/
> ---
> 
> (Updated Nov. 9, 2017, 5:15 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22387
> https://issues.apache.org/jira/browse/AMBARI-22387
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari has removed its native support of distributing and installing LZO when 
> the LZO codecs are enabled in {{core-site}}. For existing clusters where LZO 
> is enabled, this means that performing an upgrade will now require manual 
> user intervention to get the LZO packages installed.
> 
> A pre-upgrade check should be created which checks to see if LZO is enabled 
> in the cluster and then produces a {{WARNING}} to the user letting them know 
> that before upgrading, they'd need to distribute the appropriate LZO packages.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  f5e4ff9061 
>   ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63695/diff/2/
> 
> 
> Testing
> ---
> 
> checking
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 63696: Exclude test scope jars from Log Search / Log Feeder rpm/deb packages

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63696/
---

(Updated Nov. 9, 2017, 1:21 p.m.)


Review request for Ambari, Attila Doroszlai, Attila Magyar, Aravindan Vijayan, 
Krisztian Kasa, Miklos Gergely, and Robert Nettleton.


Changes
---

swap branches + bug


Bugs: AMBARI-22389
https://issues.apache.org/jira/browse/AMBARI-22389


Repository: ambari


Description
---

dependency plugin include all jars in target/libs, so we need to remove those 
that has test scope


Diffs
-

  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml cf64a36 
  ambari-logsearch/ambari-logsearch-portal/pom.xml 53d6e8b 


Diff: https://reviews.apache.org/r/63696/diff/2/


Testing
---

UT done, target/libs folder does not contain easymock, checkstyle, 
utility,junit jars


Thanks,

Oliver Szabo

Re: Review Request 63696: Exclude test scope jars from Log Search / Log Feeder rpm/deb packages

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63696/#review190576
---


Ship it!




Ship It!

- Miklos Gergely


On Nov. 9, 2017, 12:53 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63696/
> ---
> 
> (Updated Nov. 9, 2017, 12:53 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Aravindan 
> Vijayan, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
> 
> 
> Bugs: branch-2.6 and trunk
> https://issues.apache.org/jira/browse/branch-2.6
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> dependency plugin include all jars in target/libs, so we need to remove those 
> that has test scope
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml cf64a36 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 53d6e8b 
> 
> 
> Diff: https://reviews.apache.org/r/63696/diff/2/
> 
> 
> Testing
> ---
> 
> UT done, target/libs folder does not contain easymock, checkstyle, 
> utility,junit jars
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63696: Exclude test scope jars from Log Search / Log Feeder rpm/deb packages

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63696/#review190575
---


Ship it!




Ship It!

- Attila Doroszlai


On Nov. 9, 2017, 1:53 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63696/
> ---
> 
> (Updated Nov. 9, 2017, 1:53 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Aravindan 
> Vijayan, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
> 
> 
> Bugs: branch-2.6 and trunk
> https://issues.apache.org/jira/browse/branch-2.6
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> dependency plugin include all jars in target/libs, so we need to remove those 
> that has test scope
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml cf64a36 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 53d6e8b 
> 
> 
> Diff: https://reviews.apache.org/r/63696/diff/2/
> 
> 
> Testing
> ---
> 
> UT done, target/libs folder does not contain easymock, checkstyle, 
> utility,junit jars
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63696: Exclude test scope jars from Log Search / Log Feeder rpm/deb packages

[Krisztian Kasa]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63696/#review190574
---


Ship it!




Ship It!

- Krisztian Kasa


On Nov. 9, 2017, 12:53 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63696/
> ---
> 
> (Updated Nov. 9, 2017, 12:53 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Aravindan 
> Vijayan, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.
> 
> 
> Bugs: branch-2.6 and trunk
> https://issues.apache.org/jira/browse/branch-2.6
> https://issues.apache.org/jira/browse/trunk
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> dependency plugin include all jars in target/libs, so we need to remove those 
> that has test scope
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/pom.xml cf64a36 
>   ambari-logsearch/ambari-logsearch-portal/pom.xml 53d6e8b 
> 
> 
> Diff: https://reviews.apache.org/r/63696/diff/2/
> 
> 
> Testing
> ---
> 
> UT done, target/libs folder does not contain easymock, checkstyle, 
> utility,junit jars
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63696: Exclude test scope jars from Log Search / Log Feeder rpm/deb packages

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63696/
---

(Updated Nov. 9, 2017, 12:53 p.m.)


Review request for Ambari, Attila Doroszlai, Attila Magyar, Aravindan Vijayan, 
Krisztian Kasa, Miklos Gergely, and Robert Nettleton.


Changes
---

remove artifactItems


Bugs: branch-2.6 and trunk
https://issues.apache.org/jira/browse/branch-2.6
https://issues.apache.org/jira/browse/trunk


Repository: ambari


Description
---

dependency plugin include all jars in target/libs, so we need to remove those 
that has test scope


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml cf64a36 
  ambari-logsearch/ambari-logsearch-portal/pom.xml 53d6e8b 


Diff: https://reviews.apache.org/r/63696/diff/2/

Changes: https://reviews.apache.org/r/63696/diff/1-2/


Testing
---

UT done, target/libs folder does not contain easymock, checkstyle, 
utility,junit jars


Thanks,

Oliver Szabo

Review Request 63698: Implement many-to-many relation between keytabs and principals

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63698/
---

Review request for Ambari, Attila Magyar, Dmitro Lisnichenko, and Robert Levas.


Bugs: AMBARI-22390
https://issues.apache.org/jira/browse/AMBARI-22390


Repository: ambari


Description
---

Now it is possible to put mulitple different principals to same keytab:

* copy keytap entry from existant identity:
1. define principal with new unique name(identity1) and reference to principal 
that you want to update(identity0)
  2. redefine principal record of identity
  3. Good luck, now principals from identity1 and identity0 will be located in 
keytab file from identity0
* just define new keytab entry in identity with same keytab file. If owners are 
different for same keytab in different identities warning will be printed, if 
owners and goups are different, or group does not have "r" permission for file, 
error will be printed, so make sure that users that need this keytab are in 
group that can access it


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 f91383117f 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 1dc8ca8ec7 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
 59d532753d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerAction.java
 3491f18931 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/stageutils/ResolvedKerberosKeytab.java
 f66d273665 
  ambari-server/src/main/resources/common-services/SPARK/1.2.1/kerberos.json 
166adbd7d0 
  ambari-server/src/main/resources/common-services/SPARK/1.4.1/kerberos.json 
f2dd9e7e3d 
  ambari-server/src/main/resources/common-services/SPARK/2.2.0/kerberos.json 
bf763de6d9 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
95d735b972 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK/kerberos.json 
b4e93ddc77 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK/kerberos.json 
575b9fa42f 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/kerberos.json 
89f19d4927 


Diff: https://reviews.apache.org/r/63698/diff/1/


Testing
---

mvn clean test, cluster deploy


Thanks,

Eugene Chekanskiy

Re: Review Request 63697: Log Search UI: restyle logs list

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63697/#review190569
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Ноя. 9, 2017, 11:25 д.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63697/
> ---
> 
> (Updated Ноя. 9, 2017, 11:25 д.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-22388
> https://issues.apache.org/jira/browse/AMBARI-22388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restyle logs list as table.
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 488437e 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-level/log-level.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-level/log-level.component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-level/log-level.component.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.html
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.less
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.spec.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.ts
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
>  1e0f49c 
>   
> ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less
>  67d0615 
>   ambari-logsearch/ambari-logsearch-web/webpack.config.js 7a60df2 
> 
> 
> Diff: https://reviews.apache.org/r/63697/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 140 of 140 SUCCESS (3.709 secs / 3.654 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 63696: Exclude test scope jars from Log Search / Log Feeder rpm/deb packages

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63696/
---

Review request for Ambari, Attila Doroszlai, Attila Magyar, Aravindan Vijayan, 
Krisztian Kasa, Miklos Gergely, and Robert Nettleton.


Bugs: branch-2.6 and trunk
https://issues.apache.org/jira/browse/branch-2.6
https://issues.apache.org/jira/browse/trunk


Repository: ambari


Description
---

dependency plugin include all jars in target/libs, so we need to remove those 
that has test scope


Diffs
-

  ambari-logsearch/ambari-logsearch-logfeeder/pom.xml cf64a36 
  ambari-logsearch/ambari-logsearch-portal/pom.xml 53d6e8b 


Diff: https://reviews.apache.org/r/63696/diff/1/


Testing
---

UT done, target/libs folder does not contain easymock, checkstyle, 
utility,junit jars


Thanks,

Oliver Szabo

Review Request 63697: Log Search UI: restyle logs list

[Andrii Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63697/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-22388
https://issues.apache.org/jira/browse/AMBARI-22388


Repository: ambari


Description
---

Restyle logs list as table.


Diffs
-

  ambari-logsearch/ambari-logsearch-web/src/app/app.module.ts 488437e 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-level/log-level.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-level/log-level.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-level/log-level.component.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.html
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.less
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.spec.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/log-message/log-message.component.ts
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.html
 1e0f49c 
  
ambari-logsearch/ambari-logsearch-web/src/app/components/logs-list/logs-list.component.less
 67d0615 
  ambari-logsearch/ambari-logsearch-web/webpack.config.js 7a60df2 


Diff: https://reviews.apache.org/r/63697/diff/1/


Testing
---

Executed 140 of 140 SUCCESS (3.709 secs / 3.654 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

[Dmitro Lisnichenko]

> On Nov. 3, 2017, 1:42 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
> > Lines 69-72 (patched)
> > 
> >
> > I don't think we ever change this map do we?  Can use 
> > ImmutableMap.builder().put()...build()
> > 
> > Or, simple ones like this can be Collections.singletonMap(key, value)

these changes would require a big patch. Should I fix all providers, or only 
ones affected by a current patch?


> On Nov. 3, 2017, 1:42 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
> > Lines 77-87 (patched)
> > 
> >
> > Recommend Sets.newHashSet(String...) - it's much cleaner looking and 
> > avoids an added static{} block.

these changes would require a big patch. Should I fix all providers, or only 
ones affected by a current patch?


- Dmitro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/#review189988
---


On Nov. 9, 2017, 11:58 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63516/
> ---
> 
> (Updated Nov. 9, 2017, 11:58 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-22353
> https://issues.apache.org/jira/browse/AMBARI-22353
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Legacy/ancient ResourceProviders use the {{properties.json}} file to govern 
> which properties can be used with the provider. This seems like excessive 
> decoupling without any benefit and usually leads to runtime errors when new 
> or removed properties are forgotten.
> 
> This file should be removed and the providers should be registering the known 
> properties on their own.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  711ae10f7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java
>  a24c6394ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  1dc0841d19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java
>  953a2a7c77 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
>  4e618e7ff6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
>  389f0b2bf2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
>  32f1fd8f4f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
>  cf4e7475b3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java
>  8d716eabe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java
>  8ffd596cfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
>  c71651e5ff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
>  43ee7fe7c7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
>  4f4cc7070d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
>  73d24908ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  a2a49d7cb5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
>  2678d55975 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
>  54c83600b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  1a755590b7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  737bfa4d46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java
>  0f260854f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java
>  79254c6d89 
>   
> 

Re: Review Request 63695: Create a Pre-Upgrade Check Warning About LZO

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63695/
---

(Updated Nov. 9, 2017, 12:15 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22387
https://issues.apache.org/jira/browse/AMBARI-22387


Repository: ambari


Description
---

Ambari has removed its native support of distributing and installing LZO when 
the LZO codecs are enabled in {{core-site}}. For existing clusters where LZO is 
enabled, this means that performing an upgrade will now require manual user 
intervention to get the LZO packages installed.

A pre-upgrade check should be created which checks to see if LZO is enabled in 
the cluster and then produces a {{WARNING}} to the user letting them know that 
before upgrading, they'd need to distribute the appropriate LZO packages.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 f5e4ff9061 
  ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/63695/diff/2/

Changes: https://reviews.apache.org/r/63695/diff/1-2/


Testing
---

checking


Thanks,

Dmitro Lisnichenko

Review Request 63695: Create a Pre-Upgrade Check Warning About LZO

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63695/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-22387
https://issues.apache.org/jira/browse/AMBARI-22387


Repository: ambari


Description
---

Ambari has removed its native support of distributing and installing LZO when 
the LZO codecs are enabled in {{core-site}}. For existing clusters where LZO is 
enabled, this means that performing an upgrade will now require manual user 
intervention to get the LZO packages installed.

A pre-upgrade check should be created which checks to see if LZO is enabled in 
the cluster and then produces a {{WARNING}} to the user letting them know that 
before upgrading, they'd need to distribute the appropriate LZO packages.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
 f5e4ff9061 
  ambari-server/src/main/java/org/apache/ambari/server/checks/LZOCheck.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/63695/diff/1/


Testing
---

checking


Thanks,

Dmitro Lisnichenko

Re: Review Request 63516: [Preview] Remove properties.json And Switch To Adding Properties to ResourceProviders Dynamically

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63516/
---

(Updated Nov. 9, 2017, 11:58 a.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
---

Current patch


Bugs: AMBARI-22353
https://issues.apache.org/jira/browse/AMBARI-22353


Repository: ambari


Description
---

Legacy/ancient ResourceProviders use the {{properties.json}} file to govern 
which properties can be used with the provider. This seems like excessive 
decoupling without any benefit and usually leads to runtime errors when new or 
removed properties are forgotten.

This file should be removed and the providers should be registering the known 
properties on their own.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
 711ae10f7e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractAuthorizedResourceProvider.java
 a24c6394ac 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 1dc0841d19 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractDRResourceProvider.java
 953a2a7c77 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActionResourceProvider.java
 4e618e7ff6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ActiveWidgetLayoutResourceProvider.java
 389f0b2bf2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java
 32f1fd8f4f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProvider.java
 cf4e7475b3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertHistoryResourceProvider.java
 8d716eabe0 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertNoticeResourceProvider.java
 8ffd596cfa 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertResourceProvider.java
 c71651e5ff 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertTargetResourceProvider.java
 43ee7fe7c7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
 4f4cc7070d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintResourceProvider.java
 73d24908ea 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 a2a49d7cb5 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProvider.java
 2678d55975 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterResourceProvider.java
 54c83600b7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 1a755590b7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
 737bfa4d46 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java
 0f260854f8 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CredentialResourceProvider.java
 79254c6d89 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
 c3758b3f5e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionLinkResourceProvider.java
 db904bf714 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionResourceProvider.java
 53e44e1888 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ExtensionVersionResourceProvider.java
 4aa357c0e3 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/FeedResourceProvider.java
 f9d75fd353 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProvider.java
 f9f838fe22 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/GroupResourceProvider.java
 f051651e12 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentProcessResourceProvider.java
 2a25bc4d02 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
 6708560969 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProvider.java
 bfaf7b4a4f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
 5373ffe31c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java
 ba5fccc1dc