Review Request 59103: Pig and CapSched views are not loading in 2.4.3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59103/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and venkat sairam. Bugs: AMBARI-20968 https://issues.apache.org/jira/browse/AMBARI-20968 Repository: ambari Description --- After "ember-precompile-brunch" package has been changed from "1.5.1" to "0.1.0", ember fails to resolve view templates results in pig and capshed views fails to render. This patch adds custom resolver to fix the issue. Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 contrib/views/pig/src/main/resources/ui/pig-web/app/app.js 866b8a7 Diff: https://reviews.apache.org/r/59103/diff/1/ Testing --- Manual unit testing Thanks, Akhil PB
Re: Review Request 56379: AMBARI-19418: Support setup queue priority in Ambari - Capacity scheduler view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56379/ --- (Updated Feb. 10, 2017, 7:38 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Patch updated Bugs: AMBARI-19418 https://issues.apache.org/jira/browse/AMBARI-19418 Repository: ambari Description --- Feature to support queue priority config settings in YARN Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 589dcd0 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js 2f9f2fe contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 9198aa5 contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 940d0f8 contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js dce00c1 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 87f00d9 Diff: https://reviews.apache.org/r/56379/diff/ Testing --- Manunal Unit Testing Thanks, Akhil PB
Review Request 56379: AMBARI-19418: Support setup queue priority in Ambari - Capacity scheduler view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56379/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Sreenath Somarajapuram. Bugs: AMBARI-19418 https://issues.apache.org/jira/browse/AMBARI-19418 Repository: ambari Description --- Feature to support queue priority config settings in YARN Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 589dcd0 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js 2f9f2fe contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 9198aa5 contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 940d0f8 contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js dce00c1 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 87f00d9 Diff: https://reviews.apache.org/r/56379/diff/ Testing --- Manunal Unit Testing Thanks, Akhil PB
Review Request 55555: Ambari Yarn Queue Manager allows two same queue name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Sreenath Somarajapuram. Bugs: AMBARI-19556 https://issues.apache.org/jira/browse/AMBARI-19556 Repository: ambari Description --- This patch fixes the RM exception thrown for RM restart because of duplicate queue names. Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/pathInput.js e71d226 Diff: https://reviews.apache.org/r/5/diff/ Testing --- Manual unit testing Thanks, Akhil PB
Re: Review Request 54888: Ambari capacity queue manager only accepts values in integers i.e not decimal values like 0.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54888/ --- (Updated Jan. 10, 2017, 10:07 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Patch updated. Bugs: AMBARI-19251 https://issues.apache.org/jira/browse/AMBARI-19251 Repository: ambari Description --- Ambari yarn queue manager accepts only integer capacity values, not decimal capacities. This patch enables to accept decimal capacities. Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js 8f0246a contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js ee7bdd4 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less e24bf4e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capacityEditForm.hbs 78aca04 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs 5e1ae16 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs baa77db Diff: https://reviews.apache.org/r/54888/diff/ Testing --- Manual unit testing Thanks, Akhil PB
Re: Review Request 54888: Ambari capacity queue manager only accepts values in integers i.e not decimal values like 0.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54888/ --- (Updated Jan. 9, 2017, 11:29 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Removed comments Bugs: AMBARI-19251 https://issues.apache.org/jira/browse/AMBARI-19251 Repository: ambari Description --- Ambari yarn queue manager accepts only integer capacity values, not decimal capacities. This patch enables to accept decimal capacities. Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js 8f0246a contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js ee7bdd4 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less e24bf4e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capacityEditForm.hbs 78aca04 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs 5e1ae16 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs baa77db Diff: https://reviews.apache.org/r/54888/diff/ Testing --- Manual unit testing Thanks, Akhil PB
Re: Review Request 54888: Ambari capacity queue manager only accepts values in integers i.e not decimal values like 0.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54888/ --- (Updated Jan. 6, 2017, 10 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha. Changes --- Patch updated Bugs: AMBARI-19251 https://issues.apache.org/jira/browse/AMBARI-19251 Repository: ambari Description --- Ambari yarn queue manager accepts only integer capacity values, not decimal capacities. This patch enables to accept decimal capacities. Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js 8f0246a contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js ee7bdd4 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less e24bf4e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capacityEditForm.hbs 78aca04 Diff: https://reviews.apache.org/r/54888/diff/ Testing --- Manual unit testing Thanks, Akhil PB
Review Request 54888: Ambari capacity queue manager only accepts values in integers i.e not decimal values like 0.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54888/ --- Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav Kulshreshtha. Bugs: AMBARI-19251 https://issues.apache.org/jira/browse/AMBARI-19251 Repository: ambari Description --- Ambari yarn queue manager accepts only integer capacity values, not decimal capacities. This patch enables to accept decimal capacities. Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js 8f0246a contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js ee7bdd4 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less e24bf4e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capacityEditForm.hbs 78aca04 Diff: https://reviews.apache.org/r/54888/diff/ Testing --- Manual unit testing Thanks, Akhil PB
Re: Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart
> On Oct. 12, 2016, 8:35 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js, > > line 120 > > <https://reviews.apache.org/r/52688/diff/1/?file=1529629#file1529629line120> > > > > Why is this conditional operator required? Not really required, could be avoided. > On Oct. 12, 2016, 8:35 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js, > > line 252 > > <https://reviews.apache.org/r/52688/diff/1/?file=1529630#file1529630line252> > > > > Is this conditional operator required? No, could be made simple as logical comparison. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52688/#review152284 ------- On Oct. 19, 2016, 11:42 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52688/ > --- > > (Updated Oct. 19, 2016, 11:42 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-18561 > https://issues.apache.org/jira/browse/AMBARI-18561 > > > Repository: ambari > > > Description > --- > > Calculating absolute capacity for node labels > Render sunburst chart based on node label capacity when selected > Read-only mode for non-operator users in preemption and queue mappings > Bug fixes > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > 032b2ec > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > 1d07351 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js > d5b19ae > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > af15fa5 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 631edbb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 9d84704 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > e7fba41 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > aa139b1 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > e2d67bd > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > d838958 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 1ab1740 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > 9973708 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs > 6d398f6 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs > 8fe627e > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs > f143911 > > Diff: https://reviews.apache.org/r/52688/diff/ > > > Testing > --- > > Manual Unit Testing > > > Thanks, > > Akhil PB > >
Re: Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52688/ --- (Updated Oct. 19, 2016, 11:42 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Updated Bugs: AMBARI-18561 https://issues.apache.org/jira/browse/AMBARI-18561 Repository: ambari Description --- Calculating absolute capacity for node labels Render sunburst chart based on node label capacity when selected Read-only mode for non-operator users in preemption and queue mappings Bug fixes Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js 032b2ec contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js 1d07351 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js d5b19ae contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js af15fa5 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 631edbb contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js 9d84704 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js e7fba41 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js aa139b1 contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js e2d67bd contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js d838958 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less 1ab1740 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs 9973708 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs 6d398f6 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs 8fe627e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs f143911 Diff: https://reviews.apache.org/r/52688/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52688/ --- (Updated Oct. 17, 2016, 5:23 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Patch upated with review comments. Bugs: AMBARI-18561 https://issues.apache.org/jira/browse/AMBARI-18561 Repository: ambari Description --- Calculating absolute capacity for node labels Render sunburst chart based on node label capacity when selected Read-only mode for non-operator users in preemption and queue mappings Bug fixes Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js 032b2ec contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js 1d07351 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js d5b19ae contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js af15fa5 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 631edbb contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js 9d84704 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js e7fba41 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js aa139b1 contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js e2d67bd contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js d838958 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less 1ab1740 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs 9973708 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs 6d398f6 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs 8fe627e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs f143911 Diff: https://reviews.apache.org/r/52688/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Review Request 52688: Capacity Scheduler View: Calculating absolute capacity for node labels and showing in sunburst chart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52688/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Bugs: AMBARI-18561 https://issues.apache.org/jira/browse/AMBARI-18561 Repository: ambari Description --- Calculating absolute capacity for node labels Render sunburst chart based on node label capacity when selected Read-only mode for non-operator users in preemption and queue mappings Bug fixes Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/app.js 4349538 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js 032b2ec contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js 1d07351 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js d5b19ae contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js af15fa5 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 631edbb contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js 9d84704 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js e7fba41 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js aa139b1 contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js e2d67bd contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js d838958 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less 1ab1740 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs 9973708 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs 6d398f6 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs 8fe627e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs f143911 Diff: https://reviews.apache.org/r/52688/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51647/ --- (Updated Sept. 28, 2016, 12:44 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Patch updated as per review comments. Bugs: AMBARI-18313 https://issues.apache.org/jira/browse/AMBARI-18313 Repository: ambari Description --- XML diff tool to show changes made. View capacity scheduler XML. Queue capacity chart - chart showing capacities of queue using sunburst chart. Bug fixes. Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 8dd7108 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js 7776452 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js f8978c2 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js 64a28343 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js 107b377 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js 2690c40 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js c079079 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 447cae0 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js 7c62ef0 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 6a6717a contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js 40e3e24 contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 0f68a10 contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js fd996ae contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less bd875ba contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 2c9609f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs 14625c1 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs 5a54d85 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs 922e27e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs 873fb6f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs d594c7e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs 608758f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs 809c1c0 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs 0c70ee5 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs 66ef1ad contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs fb34d51 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs 33540e9 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs a7ae9b0 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/sunburstChart.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/xmldiffViewer.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/bower.json 911856f Diff: https://reviews.apache.org/r/51647/diff/ Testing --- Manual unit testing Thanks, Akhil PB
Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart
> On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js, > > line 32 > > <https://reviews.apache.org/r/51647/diff/1/?file=1491562#file1491562line32> > > > > Check use of this property else remove. Used in queueHierarchy.hbs template file. > On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js, > > line 157 > > <https://reviews.apache.org/r/51647/diff/1/?file=1491563#file1491563line157> > > > > Please verify the use of this and following property and remove is not > > required. Usesd in queueMapping.hbs template. > On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js, > > line 51 > > <https://reviews.apache.org/r/51647/diff/1/?file=1491568#file1491568line51> > > > > Looks like this property is not used, please verify and remove if not > > required. Its a property observer. > On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js, > > line 59 > > <https://reviews.apache.org/r/51647/diff/1/?file=1491568#file1491568line59> > > > > Looks like this function is not used is the above property is not used, > > please verify and remove if not required. Will be called to recompute queue absolute capacity when queue capacity changes. Used in above property oberver 'queuesWatcher' in the same file. > On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js, > > line 142 > > <https://reviews.apache.org/r/51647/diff/1/?file=1491569#file1491569line142> > > > > Please check if this and the above computed properties are used. Else > > please remove the same. Used in queueCapacity.hbs template to show dynamic progressive bar for absolute capacity. > On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js, line > > 280 > > <https://reviews.apache.org/r/51647/diff/1/?file=1491573#file1491573line280> > > > > PLease check where this action is called from. Its an action that bubbles upto to the router. > On Sept. 23, 2016, 10:19 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/bower.json, line 16 > > <https://reviews.apache.org/r/51647/diff/1/?file=1491590#file1491590line16> > > > > Package versiosn must be fixed. Blob has no versions in bower. Bower itself added '*' as version. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51647/#review150166 --- On Sept. 26, 2016, 2:32 p.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51647/ > --- > > (Updated Sept. 26, 2016, 2:32 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-18313 > https://issues.apache.org/jira/browse/AMBARI-18313 > > > Repository: ambari > > > Description > --- > > XML diff tool to show changes made. > View capacity scheduler XML. > Queue capacity chart - chart showing capacities of queue using sunburst chart. > Bug fixes. > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 8dd7108 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > 7776452 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js > f8978c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js > 64a28343 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > 107b377 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 2690c40 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/c
Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart
> On Sept. 23, 2016, 9:58 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/javascripts/difflib.js, > > line 1 > > <https://reviews.apache.org/r/51647/diff/1/?file=1491557#file1491557line1> > > > > External files shouldnt be added like this. Better to add them as > > dependencies in bower/npm as follows. > > > > "jsdifflib": > > "https://github.com/cemerick/jsdifflib.git#ce74529f9d51943db440dbd7c15d515597cda2e1; Changed into as a bower dependency. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51647/#review150165 ------- On Sept. 26, 2016, 2:32 p.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51647/ > --- > > (Updated Sept. 26, 2016, 2:32 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-18313 > https://issues.apache.org/jira/browse/AMBARI-18313 > > > Repository: ambari > > > Description > --- > > XML diff tool to show changes made. > View capacity scheduler XML. > Queue capacity chart - chart showing capacities of queue using sunburst chart. > Bug fixes. > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 8dd7108 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > 7776452 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js > f8978c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js > 64a28343 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > 107b377 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 2690c40 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > c079079 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 447cae0 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 7c62ef0 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 6a6717a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > 40e3e24 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 0f68a10 > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > fd996ae > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > bd875ba > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 2c9609f > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > 14625c1 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > 5a54d85 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs > 922e27e > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs > 873fb6f > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs > d594c7e > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > 608758f > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs > 809c1c0 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > 0c70ee5 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs > 66ef1ad > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs > fb34d51 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs > 33540e9 > > contrib/views/capacity-sched
Re: Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51647/ --- (Updated Sept. 26, 2016, 2:32 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Patch updated with review comments. Bugs: AMBARI-18313 https://issues.apache.org/jira/browse/AMBARI-18313 Repository: ambari Description --- XML diff tool to show changes made. View capacity scheduler XML. Queue capacity chart - chart showing capacities of queue using sunburst chart. Bug fixes. Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 8dd7108 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js 7776452 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js f8978c2 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js 64a28343 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js 107b377 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js 2690c40 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js c079079 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 447cae0 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js 7c62ef0 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 6a6717a contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js 40e3e24 contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 0f68a10 contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js fd996ae contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less bd875ba contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 2c9609f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs 14625c1 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs 5a54d85 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs 922e27e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs 873fb6f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs d594c7e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs 608758f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs 809c1c0 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs 0c70ee5 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs 66ef1ad contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs fb34d51 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs 33540e9 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs a7ae9b0 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/sunburstChart.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/xmldiffViewer.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/bower.json 911856f Diff: https://reviews.apache.org/r/51647/diff/ Testing --- Manual unit testing Thanks, Akhil PB
Review Request 51647: AMBARI-18313: Capacity Scheduler View: Xml diff view tool to show changes made and queue capacity chart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51647/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Bugs: AMBARI-18313 https://issues.apache.org/jira/browse/AMBARI-18313 Repository: ambari Description --- XML diff tool to show changes made. View capacity scheduler XML. Queue capacity chart - chart showing capacities of queue using sunburst chart. Bug fixes. Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/index.html 2cdfe39 contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/javascripts/difflib.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/assets/stylesheets/diffview.css PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 8dd7108 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js 7776452 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js f8978c2 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js 64a28343 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js 107b377 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js 2690c40 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/sunburstChart.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components/xmldiffViewer.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js c079079 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 447cae0 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js 7c62ef0 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 6a6717a contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js 40e3e24 contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 0f68a10 contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js fd996ae contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less bd875ba contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 2c9609f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs 14625c1 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs 5a54d85 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs 922e27e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs 873fb6f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs d594c7e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs 608758f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs 809c1c0 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs 0c70ee5 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs 66ef1ad contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs fb34d51 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs 33540e9 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs a7ae9b0 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/sunburstChart.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/xmldiffViewer.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/bower.json 911856f Diff: https://reviews.apache.org/r/51647/diff/ Testing --- Manual unit testing Thanks, Akhil PB
Re: Review Request 51452: AMBARI-18261: CapSched View: Showing warning icons to refresh or restart capsched once after configs are saved
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51452/ --- (Updated Sept. 1, 2016, 1:28 p.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Patch updated Bugs: AMBARI-18261 https://issues.apache.org/jira/browse/AMBARI-18261 Repository: ambari Description --- Showing warning icons to refresh or restart capsched once after configs are saved Bug fixes Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js f300b5b contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js b86719f contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js ed22c2b contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js b244097 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js 89e7cac contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js 8118805 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js c15f100 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js ea5262d contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js edd8a3b contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js dd46b2c contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js a68a2aa contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js 6638b4c contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js acf6465 contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 0b13a8a contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 01a7d6a contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less 195b55d contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs a9ef778 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs 1f6fbda contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs 9073910 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs 73a9e21 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs 7b25af3 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs 262f380 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs 1bc3380 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs 7649512 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs a7901b8 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs fa35518 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs 9c3ffd0 Diff: https://reviews.apache.org/r/51452/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 51452: AMBARI-18261: CapSched View: Showing warning icons to refresh or restart capsched once after configs are saved
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51452/ --- (Updated Sept. 1, 2016, 11:36 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Patch updated with review comments Bugs: AMBARI-18261 https://issues.apache.org/jira/browse/AMBARI-18261 Repository: ambari Description --- Showing warning icons to refresh or restart capsched once after configs are saved Bug fixes Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js f300b5b contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js b86719f contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js ed22c2b contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js b244097 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js 89e7cac contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js 8118805 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js c15f100 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js ea5262d contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js edd8a3b contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js dd46b2c contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js a68a2aa contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js 6638b4c contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js acf6465 contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 0b13a8a contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 01a7d6a contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less 195b55d contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs a9ef778 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs 1f6fbda contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs 9073910 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs 73a9e21 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs 7b25af3 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs 262f380 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs 1bc3380 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs 7649512 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs a7901b8 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs fa35518 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs 9c3ffd0 Diff: https://reviews.apache.org/r/51452/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 51452: AMBARI-18261: CapSched View: Showing warning icons to refresh or restart capsched once after configs are saved
> On Aug. 31, 2016, 8:43 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js, line > > 270 > > <https://reviews.apache.org/r/51452/diff/1/?file=1486644#file1486644line270> > > > > - Why are we having this controller variable > > - Indentation can be made better. The controller variable would be used to call an api in controller. This code is incomplete. Next patch should have whole code. Indentation - How can we make it better? > On Aug. 31, 2016, 8:43 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js, line > > 300 > > <https://reviews.apache.org/r/51452/diff/1/?file=1486644#file1486644line300> > > > > Guess it might be better to put all finds into a promise array. Will try with promise array! - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51452/#review147417 ------- On Aug. 26, 2016, 7:09 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51452/ > --- > > (Updated Aug. 26, 2016, 7:09 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-18261 > https://issues.apache.org/jira/browse/AMBARI-18261 > > > Repository: ambari > > > Description > --- > > Showing warning icons to refresh or restart capsched once after configs are > saved > Bug fixes > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js > f300b5b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js > b86719f > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > ed22c2b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js > b244097 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > 89e7cac > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > 8118805 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > c15f100 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js > ea5262d > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > edd8a3b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > dd46b2c > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > a68a2aa > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > 6638b4c > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > acf6465 > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > 0b13a8a > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 01a7d6a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 195b55d > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > a9ef778 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs > 1f6fbda > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs > 9073910 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs > 73a9e21 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > 7b25af3 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs > 262f380 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > 1bc3380 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs > 7649512 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs > a7901b8 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs > fa35518 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs > 9c3ffd0 > > Diff: https://reviews.apache.org/r/51452/diff/ > > > Testing > --- > > Manual Unit Testing > > > Thanks, > > Akhil PB > >
Re: Review Request 49755: AMBARI-17602: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49755/ --- (Updated Aug. 23, 2016, 7:18 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Patch updated. Bugs: AMBARI-17602 https://issues.apache.org/jira/browse/AMBARI-17602 Repository: ambari Description --- Fetching current rm configuration of queues. Updating queue states based on states in configuration. Preemption implementation. Bug fixes. Diffs (updated) - contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java e5f5cb5 contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 770db51 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js bf74af6 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js 9b31e57 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js 7bb3f82 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js bfcd4b6 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 545d348 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js f42d2e4 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 683bc6f contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js e91c90f contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 49363d4 contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js c3976b4 contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 36228a1 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less e849ad4 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 6e310ad contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs b75237f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs e659f5c contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs b4891cd contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs bb82025 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs b1a8708 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs 2848fed contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs 9e25cc6 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs c430a44 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs 96cbe99 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs bd49c50 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs ef5663d contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js a5d0ef6 Diff: https://reviews.apache.org/r/49755/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 49755: AMBARI-17602: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49755/ --- (Updated Aug. 8, 2016, 11:28 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Patch updated Summary (updated) - AMBARI-17602: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation Bugs: AMBARI-17602 https://issues.apache.org/jira/browse/AMBARI-17602 Repository: ambari Description --- Fetching current rm configuration of queues. Updating queue states based on states in configuration. Preemption implementation. Bug fixes. Diffs (updated) - contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java 03520fe contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 86c1484 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js bf74af6 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js 9b31e57 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js 7bb3f82 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js bfcd4b6 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 545d348 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js f42d2e4 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 683bc6f contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js e91c90f contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 49363d4 contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js c3976b4 contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 36228a1 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less e849ad4 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 6e310ad contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs b75237f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs e659f5c contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs b4891cd contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs bb82025 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs b1a8708 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs 2848fed contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs 9e25cc6 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs c430a44 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs 96cbe99 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs bd49c50 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs ef5663d contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js a5d0ef6 Diff: https://reviews.apache.org/r/49755/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Review Request 50070: Capacity Scheduler View - Fix for nodelabel api compatibility issue in HDP-2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50070/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Bugs: AMBARI-17731 https://issues.apache.org/jira/browse/AMBARI-17731 Repository: ambari Description --- Fix for node label api compatibility issue in the HDP-2.5 Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 068c241 contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 4a9c6b0 Diff: https://reviews.apache.org/r/50070/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 49755: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49755/ --- (Updated July 15, 2016, 7:29 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Patch updated with FIX for HDP-2.5 node labels API compatability issue. Bugs: AMBARI-17602 https://issues.apache.org/jira/browse/AMBARI-17602 Repository: ambari Description --- Fetching current rm configuration of queues. Updating queue states based on states in configuration. Preemption implementation. Bug fixes. Diffs (updated) - contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java 03520fe contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 068c241 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js bf74af6 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js 9b31e57 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js 7bb3f82 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js bfcd4b6 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 545d348 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js f42d2e4 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 683bc6f contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js e91c90f contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 49363d4 contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js c3976b4 contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 4a9c6b0 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less e849ad4 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 6e310ad contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs b75237f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs e659f5c contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs b4891cd contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs bb82025 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs b1a8708 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs 2848fed contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs 9e25cc6 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs c430a44 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs 96cbe99 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs bd49c50 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs ef5663d contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js a5d0ef6 Diff: https://reviews.apache.org/r/49755/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 49755: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49755/ --- (Updated July 14, 2016, 10:28 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Updated with review comments Bugs: AMBARI-17602 https://issues.apache.org/jira/browse/AMBARI-17602 Repository: ambari Description --- Fetching current rm configuration of queues. Updating queue states based on states in configuration. Preemption implementation. Bug fixes. Diffs (updated) - contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java 03520fe contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 068c241 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js bf74af6 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js 9b31e57 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js 7bb3f82 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js bfcd4b6 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 545d348 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js f42d2e4 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 683bc6f contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js e91c90f contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 49363d4 contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js c3976b4 contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 4a9c6b0 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less e849ad4 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 6e310ad contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs b75237f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs e659f5c contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs b4891cd contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs bb82025 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs b1a8708 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs 2848fed contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs 9e25cc6 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs c430a44 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs 96cbe99 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs bd49c50 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs ef5663d contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js a5d0ef6 Diff: https://reviews.apache.org/r/49755/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Review Request 49755: Capacity Scheduler View - Fetching current RM configuration of queues and preemption implementation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49755/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Bugs: AMBARI-17602 https://issues.apache.org/jira/browse/AMBARI-17602 Repository: ambari Description --- Fetching current rm configuration of queues. Updating queue states based on states in configuration. Preemption implementation. Bug fixes. Diffs - contrib/views/capacity-scheduler/src/main/java/org/apache/ambari/view/capacityscheduler/ConfigurationService.java 03520fe contrib/views/capacity-scheduler/src/main/resources/ui/app/adapters.js 068c241 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/capacityInput.js bf74af6 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js 9b31e57 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js 7bb3f82 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js bfcd4b6 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 545d348 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js f42d2e4 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 683bc6f contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js e91c90f contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js 49363d4 contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js c3976b4 contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 4a9c6b0 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less e849ad4 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 6e310ad contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs b75237f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs e659f5c contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/preemption.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs b4891cd contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs bb82025 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs b1a8708 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs 2848fed contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/trace.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs 9e25cc6 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs c430a44 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs 96cbe99 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs bd49c50 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs ef5663d contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js a5d0ef6 Diff: https://reviews.apache.org/r/49755/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412307#file1412307line26> > > > > Where is the versions-table-wrap class defined? > > Wouldnt it cause the views/queues.js code to break? > > Akhil PB wrote: > versionPanel.hbs itself is a new file and class "versions-table-wrap" is > used for styling and styles are defined in application.less. > views/queues.js would not break since queues.js uses above as id and > versionPanel uses as class name. > > Sreenath Somarajapuram wrote: > "versions-table-wrap is used for styling and styles are defined in > application.less" > Can you share the line number in application.less? > > Akhil PB wrote: > queues.hbs has id="versions-table-wrap" and css also (line:217 in > application.less). > versionPanel.hbs has class="versions-table-wrap" and css are defined at > line:1259. > So the new changes would not break old code. > > Sreenath Somarajapuram wrote: > Well, as-per your patch there are only 1252 line in application.less! > > Akhil PB wrote: > line:1239 has css for versionPanel, but not complete. This would not > break old UI since there is seperate css at line:216. class "versions-table-wrap" is not used as of now. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139036 --- On June 27, 2016, 5:36 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48487/ > --- > > (Updated June 27, 2016, 5:36 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-17137 > https://issues.apache.org/jira/browse/AMBARI-17137 > > > Repository: ambari > > > Description > --- > > Capacity Scheduler View - Node label to queue mappings and save integration > for all tabs > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 7f7bc3b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > bbf0cab > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 113ad13 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > 7af45bb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 1ee7a6b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 518b677 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 93f6645 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > c0c56b6 > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 3dfe363 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 45146ef > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a32e02c > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > 7fef4be > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 9952045 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 17b279a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > 1eead4b >
Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412307#file1412307line26> > > > > Where is the versions-table-wrap class defined? > > Wouldnt it cause the views/queues.js code to break? > > Akhil PB wrote: > versionPanel.hbs itself is a new file and class "versions-table-wrap" is > used for styling and styles are defined in application.less. > views/queues.js would not break since queues.js uses above as id and > versionPanel uses as class name. > > Sreenath Somarajapuram wrote: > "versions-table-wrap is used for styling and styles are defined in > application.less" > Can you share the line number in application.less? > > Akhil PB wrote: > queues.hbs has id="versions-table-wrap" and css also (line:217 in > application.less). > versionPanel.hbs has class="versions-table-wrap" and css are defined at > line:1259. > So the new changes would not break old code. > > Sreenath Somarajapuram wrote: > Well, as-per your patch there are only 1252 line in application.less! line:1239 has css for versionPanel, but not complete. This would not break old UI since there is seperate css at line:216. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139036 --- On June 27, 2016, 5:36 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48487/ > --- > > (Updated June 27, 2016, 5:36 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-17137 > https://issues.apache.org/jira/browse/AMBARI-17137 > > > Repository: ambari > > > Description > --- > > Capacity Scheduler View - Node label to queue mappings and save integration > for all tabs > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 7f7bc3b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > bbf0cab > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 113ad13 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > 7af45bb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 1ee7a6b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 518b677 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 93f6645 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > c0c56b6 > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 3dfe363 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 45146ef > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a32e02c > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > 7fef4be > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 9952045 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 17b279a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > 1eead4b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs >
Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412307#file1412307line26> > > > > Where is the versions-table-wrap class defined? > > Wouldnt it cause the views/queues.js code to break? > > Akhil PB wrote: > versionPanel.hbs itself is a new file and class "versions-table-wrap" is > used for styling and styles are defined in application.less. > views/queues.js would not break since queues.js uses above as id and > versionPanel uses as class name. > > Sreenath Somarajapuram wrote: > "versions-table-wrap is used for styling and styles are defined in > application.less" > Can you share the line number in application.less? queues.hbs has id="versions-table-wrap" and css also (line:217 in application.less). versionPanel.hbs has class="versions-table-wrap" and css are defined at line:1259. So the new changes would not break old code. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139036 --- On June 27, 2016, 5:36 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48487/ > --- > > (Updated June 27, 2016, 5:36 a.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-17137 > https://issues.apache.org/jira/browse/AMBARI-17137 > > > Repository: ambari > > > Description > --- > > Capacity Scheduler View - Node label to queue mappings and save integration > for all tabs > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 7f7bc3b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > bbf0cab > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 113ad13 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > 7af45bb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 1ee7a6b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 518b677 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 93f6645 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > c0c56b6 > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 3dfe363 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 45146ef > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a32e02c > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > 7fef4be > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 9952045 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 17b279a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > 1eead4b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > e54e14b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > 55910ee > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs > PRE-CREATION > > contrib/vie
Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation
: https://reviews.apache.org/r/48487/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation
> On June 22, 2016, 10:42 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js, > > line 45 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412279#file1412279line45> > > > > Where is isNotOperator used? I guess its not used, just defined thinking that it might be useful in future. > On June 22, 2016, 10:42 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js, line > > 290 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412287#file1412287line290> > > > > Where is the values of store passed? Intended to pass store to getNodeLabels api in adapter. But it is not used inside this api. I guess i can remove it. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139046 ------- On June 9, 2016, 12:05 p.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48487/ > --- > > (Updated June 9, 2016, 12:05 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-17137 > https://issues.apache.org/jira/browse/AMBARI-17137 > > > Repository: ambari > > > Description > --- > > Capacity Scheduler View - Node label to queue mappings and save integration > for all tabs > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 7f7bc3b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > bbf0cab > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 113ad13 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > 7af45bb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 1ee7a6b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 518b677 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 93f6645 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > c0c56b6 > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 3dfe363 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 45146ef > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a32e02c > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > 7fef4be > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 9952045 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 17b279a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > 1eead4b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > e54e14b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > 55910ee > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > ee9616b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > b81474e > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/c
Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js, > > line 25 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412273#file1412273line25> > > > > Trailing space must be removed. Will remove the spaces. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139036 --- On June 9, 2016, 12:05 p.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48487/ > --- > > (Updated June 9, 2016, 12:05 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-17137 > https://issues.apache.org/jira/browse/AMBARI-17137 > > > Repository: ambari > > > Description > --- > > Capacity Scheduler View - Node label to queue mappings and save integration > for all tabs > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 7f7bc3b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > bbf0cab > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 113ad13 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > 7af45bb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 1ee7a6b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 518b677 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 93f6645 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > c0c56b6 > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 3dfe363 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 45146ef > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a32e02c > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > 7fef4be > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 9952045 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 17b279a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > 1eead4b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > e54e14b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > 55910ee > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > ee9616b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > b81474e > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs > aad16c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs > f11b786 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs > PRE-CREATION > > contrib/views/capacity-sched
Review Request 49141: Capacity Scheduler View: Javascript error causing new queue creation failed in Yarn Capacity Scheduler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49141/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Bugs: AMBARI-17395 https://issues.apache.org/jira/browse/AMBARI-17395 Repository: ambari Description --- Throws javascript errors while creating new queue. Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/totalCapacity.js cb0c6b0 Diff: https://reviews.apache.org/r/49141/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation
> On June 22, 2016, 10:12 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs, > > line 26 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412307#file1412307line26> > > > > Where is the versions-table-wrap class defined? > > Wouldnt it cause the views/queues.js code to break? versionPanel.hbs itself is a new file and class "versions-table-wrap" is used for styling and styles are defined in application.less. views/queues.js would not break since queues.js uses above as id and versionPanel uses as class name. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139036 ------- On June 9, 2016, 12:05 p.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48487/ > --- > > (Updated June 9, 2016, 12:05 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-17137 > https://issues.apache.org/jira/browse/AMBARI-17137 > > > Repository: ambari > > > Description > --- > > Capacity Scheduler View - Node label to queue mappings and save integration > for all tabs > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 7f7bc3b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > bbf0cab > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 113ad13 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > 7af45bb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 1ee7a6b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 518b677 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 93f6645 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > c0c56b6 > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 3dfe363 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 45146ef > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a32e02c > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > 7fef4be > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 9952045 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 17b279a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > 1eead4b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > e54e14b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > 55910ee > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > ee9616b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > b81474e > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs > aad16c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs > f11b786 > >
Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation
> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, > > line 164 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412286#file1412286line164> > > > > Why are we having the + after ? > > Akhil PB wrote: > Converting string number to integer number. + is for properties[cp]. ie +properties[cp] - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139032 ------- On June 9, 2016, 12:05 p.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48487/ > --- > > (Updated June 9, 2016, 12:05 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-17137 > https://issues.apache.org/jira/browse/AMBARI-17137 > > > Repository: ambari > > > Description > --- > > Capacity Scheduler View - Node label to queue mappings and save integration > for all tabs > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 7f7bc3b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > bbf0cab > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 113ad13 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > 7af45bb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 1ee7a6b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 518b677 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 93f6645 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > c0c56b6 > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 3dfe363 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 45146ef > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a32e02c > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > 7fef4be > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 9952045 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 17b279a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > 1eead4b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > e54e14b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > 55910ee > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > ee9616b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > b81474e > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs > aad16c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs > f11b786 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templa
Re: Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation
> On June 22, 2016, 8:50 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js, > > line 164 > > <https://reviews.apache.org/r/48487/diff/1/?file=1412286#file1412286line164> > > > > Why are we having the + after ? Converting string number to integer number. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/#review139032 --- On June 9, 2016, 12:05 p.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48487/ > --- > > (Updated June 9, 2016, 12:05 p.m.) > > > Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and > Sreenath Somarajapuram. > > > Bugs: AMBARI-17137 > https://issues.apache.org/jira/browse/AMBARI-17137 > > > Repository: ambari > > > Description > --- > > Capacity Scheduler View - Node label to queue mappings and save integration > for all tabs > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > 7f7bc3b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > bbf0cab > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > 113ad13 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > 7af45bb > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > 1ee7a6b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > 518b677 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > 93f6645 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > c0c56b6 > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 3dfe363 > contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js > 45146ef > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a32e02c > contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js > 7fef4be > contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > 9952045 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 17b279a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > 1eead4b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > e54e14b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > 55910ee > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > ee9616b > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > b81474e > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs > aad16c2 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs > f11b786 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs > PRE-CREATION > > contrib/views/capacity-sched
Re: Review Request 48398: Capacity scheduler view - problem with queue percent rounding
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48398/ --- (Updated June 10, 2016, 9:58 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Changes --- Review comments added Bugs: AMBARI-17109 https://issues.apache.org/jira/browse/AMBARI-17109 Repository: ambari Description --- Capacity scheduler view - problem with queue percent rounding Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/totalCapacity.js c36839c contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queues.js 4aeb442 Diff: https://reviews.apache.org/r/48398/diff/ Testing --- Thanks, Akhil PB
Review Request 48487: Capacity Scheduler View - Node label to queue mapping implementation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48487/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Bugs: AMBARI-17137 https://issues.apache.org/jira/browse/AMBARI-17137 Repository: ambari Description --- Capacity Scheduler View - Node label to queue mappings and save integration for all tabs Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js 7f7bc3b contrib/views/capacity-scheduler/src/main/resources/ui/app/components/confirmDiscardChanges.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components/displayNodeLabels.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editLabelCapacity.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components/editQueueCapacity.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components/labelCapacityBar.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js bbf0cab contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js 113ad13 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/saveConfigDialog.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js 7af45bb contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js 1ee7a6b contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js 518b677 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 93f6645 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js c0c56b6 contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 3dfe363 contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 45146ef contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js a32e02c contrib/views/capacity-scheduler/src/main/resources/ui/app/serializers.js 7fef4be contrib/views/capacity-scheduler/src/main/resources/ui/app/store.js 44b5800 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less 9952045 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 17b279a contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs 1eead4b contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs e54e14b contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs 55910ee contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/labelCapacity.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs ee9616b contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs b81474e contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs aad16c2 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs f11b786 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/confirmDiscardChanges.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayLeafLabel.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/displayRootLabel.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editLabelCapacity.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/editQueueCapacity.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/labelCapacityBar.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs 24f6938 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs 759c0f3 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/saveConfigDialog.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs f252005 contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js b2ae1d5 contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js 0dde62b contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js 5cef8e5 Diff: https://reviews.apache.org/r/48487/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Review Request 47814: Capacity Scheduler View - Save only, Save and Restart Rm and Delete queue integrations
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47814/ --- Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram. Bugs: AMBARI-16842 https://issues.apache.org/jira/browse/AMBARI-16842 Repository: ambari Description --- Save and Restart Rm, and Delete queue integrations in new capacity scheduler view. Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueBadge.js 1e2b77c contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js 3d4f7be contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js e981ea5 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 14ea85c contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js 46f14ad contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less 89b8eb7 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs 3837a03 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs 364bff2 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs 7ba9e62 contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js 5c3793f contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js 7cb71a7 Diff: https://reviews.apache.org/r/47814/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 47643: Capacity Scheduler View - Edit and validate queue name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47643/ --- (Updated May 23, 2016, 5:25 a.m.) Review request for Ambari and Sreenath Somarajapuram. Changes --- Patch updated with feedback Bugs: AMBARI-16792 https://issues.apache.org/jira/browse/AMBARI-16792 Repository: ambari Description --- Capacity Scheduler View - Edit and validate queue name Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js 02062a6 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js 69be18c contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 89d0e89 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less a60d39d contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs d57b2ba contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs c5c910a Diff: https://reviews.apache.org/r/47643/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Review Request 47643: Capacity Scheduler View - Edit and validate queue name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47643/ --- Review request for Ambari and Sreenath Somarajapuram. Bugs: AMBARI-16792 https://issues.apache.org/jira/browse/AMBARI-16792 Repository: ambari Description --- Capacity Scheduler View - Edit and validate queue name Diffs - contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js 02062a6 contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js 69be18c contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 89d0e89 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less a60d39d contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs d57b2ba contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs c5c910a Diff: https://reviews.apache.org/r/47643/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 46770: Capacity Scheduler View: New UI - queues save integration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46770/ --- (Updated May 9, 2016, 6:37 a.m.) Review request for Ambari and Sreenath Somarajapuram. Changes --- Updated patch with comments Bugs: AMBARI-15877 https://issues.apache.org/jira/browse/AMBARI-15877 Repository: ambari Description --- CapSched View: Queues save integration in new UI Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js 0f4d038 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs 753fa9b contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs 8e278f0 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs f25180f contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs b5c3c04 contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js 2628553 Diff: https://reviews.apache.org/r/46770/diff/ Testing --- Manual Unit Testing Thanks, Akhil PB
Re: Review Request 44704: CapSched View: Revamping the old UI
> On April 4, 2016, 10:45 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs, > > line 60 > > <https://reviews.apache.org/r/44704/diff/1/?file=1295742#file1295742line60> > > > > Can use bunded conditional class names. This got changed in later commits. I guess I would face conflicts in future patches. Timebeing I will do this. - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44704/#review126808 --- On April 13, 2016, 7:18 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44704/ > --- > > (Updated April 13, 2016, 7:18 a.m.) > > > Review request for Ambari and Sreenath Somarajapuram. > > > Bugs: AMBARI-15384 > https://issues.apache.org/jira/browse/AMBARI-15384 > > > Repository: ambari > > > Description > --- > > Revamping the old capsched UI into new better one > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > ac679b7 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js > 16b7d0a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 05bb64c > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a2d50b9 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > be79229 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 25e2aa9 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs > PRE-CREATION > > contrib/views/capacity-schedu
Re: Review Request 44704: CapSched View: Revamping the old UI
> On April 4, 2016, 9:05 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js, > > line 19 > > <https://reviews.apache.org/r/44704/diff/1/?file=1295725#file1295725line19> > > > > Looks like you can delete this file. > > Even if the file name is queueMappingParser.js, this is same as > > queueMappingInterpreter.js. > > Also correct th require. This file is removed. > On April 4, 2016, 9:05 a.m., Sreenath Somarajapuram wrote: > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs, > > line 28 > > <https://reviews.apache.org/r/44704/diff/1/?file=1295731#file1295731line28> > > > > Whay are we having an anchor tags inside link-to? And what is the > > purpose fo href="view.href". Here link-to tag is li, not anchor. When link-to is clicked, ember would add active class to link-to element. Since we have tab structure, I have used this to show active tab whenever user clicks on tab. Please refer http://stackoverflow.com/questions/11628489/emberjs-how-to-mark-active-menu-item-using-router-infrastructure - Akhil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44704/#review126795 --- On April 13, 2016, 7:18 a.m., Akhil PB wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44704/ > --- > > (Updated April 13, 2016, 7:18 a.m.) > > > Review request for Ambari and Sreenath Somarajapuram. > > > Bugs: AMBARI-15384 > https://issues.apache.org/jira/browse/AMBARI-15384 > > > Repository: ambari > > > Description > --- > > Revamping the old capsched UI into new better one > > > Diffs > - > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js > ac679b7 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js > 16b7d0a > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js > PRE-CREATION > contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js > 05bb64c > contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js > a2d50b9 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less > be79229 > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js > 25e2aa9 > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs > PRE-CREATION > > contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs > PRE-CREATION > > contrib/views/capaci
Re: Review Request 44704: CapSched View: Revamping the old UI
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44704/ --- (Updated April 13, 2016, 7:18 a.m.) Review request for Ambari and Sreenath Somarajapuram. Changes --- Fixed the review comments and updated diff with latest fixed patch. Bugs: AMBARI-15384 https://issues.apache.org/jira/browse/AMBARI-15384 Repository: ambari Description --- Revamping the old capsched UI into new better one Diffs (updated) - contrib/views/capacity-scheduler/src/main/resources/ui/app/components.js ac679b7 contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueHierarchy.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueMapping.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/components/queueSummary.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers.js 16b7d0a contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/advanced.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/capsched.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/editqueue.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queuesconf.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/scheduler.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/queueMappingParser.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/helpers/uppercase.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/initialize.js 05bb64c contrib/views/capacity-scheduler/src/main/resources/ui/app/router.js a2d50b9 contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less be79229 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates.js 25e2aa9 contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/advanced.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/accessControlList.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/editQueueCapacity.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueCapacity.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/partials/queueResources.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/queuesconf/editqueue.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/capsched/scheduler.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueHierarchy.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueMapping.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/components/queueSummary.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/versionsPanel.hbs PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editQueueCapacity.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/views/editqueue.js PRE-CREATION contrib/views/capacity-scheduler/src/main/resources/ui/app/views/queuesconf.js PRE-CREATION Diff: https://reviews.apache.org/r/44704/diff/ Testing --- Manual unit testing Thanks, Akhil PB
