Review Request 47882: HBase backups fail if there is no /user/hbase directory in HDFS

2016-05-26 Thread Andrew Onischuk
3cae192 Diff: https://reviews.apache.org/r/47882/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 47956: Automatically cleanup /var/run/ambari-server/stack-recommendations

2016-05-27 Thread Andrew Onischuk
Diff: https://reviews.apache.org/r/47956/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 47956: Automatically cleanup /var/run/ambari-server/stack-recommendations

2016-05-27 Thread Andrew Onischuk
/services/stackadvisor/commands/StackAdvisorCommandTest.java 263bbe1 Diff: https://reviews.apache.org/r/47956/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 47957: Add support for Ubuntu 16

2016-05-27 Thread Andrew Onischuk
test Thanks, Andrew Onischuk

Re: Review Request 47957: Add support for Ubuntu 16

2016-05-27 Thread Andrew Onischuk
/version_builder.py 415e940 Diff: https://reviews.apache.org/r/47957/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 47960: Make it possible to debug ambari-agent in runtime to investigate memory leaks etc.

2016-05-27 Thread Andrew Onischuk
/debug.py PRE-CREATION Diff: https://reviews.apache.org/r/47960/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 47915: Oozie and Hive Server start fail during EU with missing DB class exception

2016-05-27 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47915/#review135259 --- Ship it! Ship It! - Andrew Onischuk On May 27, 2016, 4:47

Review Request 48063: Redundant info under config tab for falcon

2016-05-31 Thread Andrew Onischuk
erver/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java 56e8a8a ambari-web/app/data/HDP2/site_properties.js beb420d Diff: https://reviews.apache.org/r/48063/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48072: Upgrade Catalog 2.4 is not idempotent

2016-05-31 Thread Andrew Onischuk
mbari/server/upgrade/UpgradeCatalog240Test.java 56e8a8a Diff: https://reviews.apache.org/r/48072/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48073: Exception while detecting JMX protocol for HISTORYSERVER

2016-05-31 Thread Andrew Onischuk
47961 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 3e78c37 Diff: https://reviews.apache.org/r/48073/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48063: Redundant info under config tab for falcon

2016-06-01 Thread Andrew Onischuk
he.org/r/48063/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48073: Exception while detecting JMX protocol for HISTORYSERVER

2016-06-01 Thread Andrew Onischuk
oller/internal/AbstractProviderModule.java d747961 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml f6f912e Diff: https://reviews.apache.org/r/48073/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48135: Ambari-server fails to start after reboot on Ubuntu

2016-06-01 Thread Andrew Onischuk
nfiguration.py c28909e Diff: https://reviews.apache.org/r/48135/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48135: Ambari-server fails to start after reboot on Ubuntu

2016-06-01 Thread Andrew Onischuk
server/src/main/python/ambari_server/serverConfiguration.py c28909e ambari-server/src/main/python/ambari_server_main.py a5e6f81 Diff: https://reviews.apache.org/r/48135/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48073: Exception while detecting JMX protocol for HISTORYSERVER

2016-06-02 Thread Andrew Onischuk
oller/internal/AbstractProviderModule.java d747961 ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml 3e78c37 Diff: https://reviews.apache.org/r/48073/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48202: NPE during EU at Update Target Stack step

2016-06-03 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48202/#review136052 --- Ship it! Ship It! - Andrew Onischuk On June 3, 2016, 10:05

Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-03 Thread Andrew Onischuk
--- mvn clean test Thanks, Andrew Onischuk

Review Request 48278: Service stop/start fail after Ambari upgrade due to missing config parameters

2016-06-06 Thread Andrew Onischuk
Diffs - ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml 114a0fa ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml 5f607e3 ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml 0501957 ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/configuration/oozie-env.xml 1d1c821 ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml ac7c7ed Diff: https://reviews.apache.org/r/48278/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48281: [ambari] ambari-agent restart is failing due to unsupported locale setting

2016-06-06 Thread Andrew Onischuk
LL= since LC_ALL was set to empty so set the export LC_ALL=C then restarted the ranger and it was successful. again facing the same issue: build detail: ambari-agent-2.4.0.0-625.x86_64 Diffs - ambari-agent/src/main/python/ambari_agent/main.py 32e522d Diff: https://reviews.apache.org/r/48281/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48282: YARN service check fails if there is no queue named "default"

2016-06-06 Thread Andrew Onischuk
y 379c268 ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 3744c26 ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 46e9f47 Diff: https://reviews.apache.org/r/48282/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48283: Namenode failed to start while installing a cluster from UI

2016-06-06 Thread Andrew Onischuk
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/yarn-env.xml 8cf516c ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml b517f91 ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml ef84187 Diff: https://reviews.apache.org/r/48283/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states

2016-06-06 Thread Andrew Onischuk
mbari-server/src/test/java/org/apache/ambari/server/controller/metrics/JMXPropertyProviderTest.java 4adea20 ambari-server/src/test/resources/hdfs_namenode_jmx_ha_only.json PRE-CREATION Diff: https://reviews.apache.org/r/48284/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
/ambari_commons/os_utils.py 4a636d9 Diff: https://reviews.apache.org/r/48207/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
/ambari_commons/os_utils.py 4a636d9 Diff: https://reviews.apache.org/r/48207/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48207/#review136102 ------- On June 6, 2016, 4:13 p.m., Andrew Onischuk wrote: > >

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
/ambari_commons/os_utils.py 4a636d9 Diff: https://reviews.apache.org/r/48207/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
mail. To reply, visit: https://reviews.apache.org/r/48207/#review136283 ------- On June 6, 2016, 4:29 p.m., Andrew Onischuk wrote: > > --- > This is an automatically gener

Re: Review Request 48207: Agents should automatically restart if there is a memory leak

2016-06-06 Thread Andrew Onischuk
/ambari_agent/TestController.py 5604769 ambari-common/src/main/python/ambari_commons/os_utils.py 4a636d9 Diff: https://reviews.apache.org/r/48207/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Andrew Onischuk
/functions/hdp_select.py (line 129) <https://reviews.apache.org/r/48044/#comment201488> I don't think we have ts in sudo permissions. Can we use test here? - Andrew Onischuk On June 7, 2016, 8:17 a.m., Laszlo Puskas wrote: > > -

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Andrew Onischuk
> On June 7, 2016, 8:53 a.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py, > > line 130 > > <https://reviews.apache.org/r/48044/diff/4/?file=1408660#file1408660line130> > > > > I don

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Andrew Onischuk
> On June 7, 2016, 8:53 a.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py, > > line 130 > > <https://reviews.apache.org/r/48044/diff/4/?file=1408660#file1408660line130> > > > > I don

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Andrew Onischuk
-- > > (Updated June 7, 2016, 8:17 a.m.) > > > Review request for Ambari, Andrew Onischuk, Oliver Szabo, Sumit Mohanty, and > Sebastian Toader. > > > Bugs: AMBARI-16952 > https://issues.apache.org/jira/browse/AMBARI-16952 >

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-07 Thread Andrew Onischuk
> On June 7, 2016, 8:57 a.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py, > > line 129 > > <https://reviews.apache.org/r/48044/diff/4/?file=1408660#file1408660line129> > > > > In

Review Request 48334: takeover_config_merge.py should provide XML, yaml, properties-diff capability

2016-06-07 Thread Andrew Onischuk
/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states

2016-06-07 Thread Andrew Onischuk
/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-06-08 Thread Andrew Onischuk
/functions/hdp_select.py (line 129) <https://reviews.apache.org/r/48044/#comment201718> The tuple of one items should have trailing comma, or else python interprets as a single value. >>> ('item') 'item' >>> ('item',) (&#x

Re: Review Request 48406: DevDeploy: Ambari server is not started because of invalid config

2016-06-08 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48406/#review136617 --- Ship it! Ship It! - Andrew Onischuk On June 8, 2016, 10:12

Review Request 48407: [Change log directory prefix for service FLUME] Flume service not starting after changing the log directory

2016-06-08 Thread Andrew Onischuk
mon-services/FLUME/1.4.0.2.0/package/scripts/flume.py 9df2ba6 ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 964280d Diff: https://reviews.apache.org/r/48407/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48284: Retrieve specific metrics when Ambari queries NameNode HA states

2016-06-08 Thread Andrew Onischuk
/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48410: Heartbeat lost of ambari agent during install

2016-06-08 Thread Andrew Onischuk
-sbhat-ambari- hosts-3-2 os-r7-sbhat-ambari-hosts-3-2.openstacklocal. Diffs - ambari-agent/conf/unix/ambari-agent.ini 8f2ab1b Diff: https://reviews.apache.org/r/48410/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48410: Ambari-agent could not successfully restart on non-root after running as root

2016-06-08 Thread Andrew Onischuk
/ambari-agent.log Diffs - ambari-agent/conf/unix/ambari-agent.ini 8f2ab1b Diff: https://reviews.apache.org/r/48410/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48410: Ambari-agent could not successfully restart on non-root after running as root

2016-06-08 Thread Andrew Onischuk
/48410/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48410: Ambari-agent could not successfully restart on non-root after running as root

2016-06-08 Thread Andrew Onischuk
/48410/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48416: Ambari warns the user about a bunch of rpm packages that are installed on barebone CentOS 7

2016-06-08 Thread Andrew Onischuk
/check_host.py 46b8199 Diff: https://reviews.apache.org/r/48416/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48419: Accumulo master start fails on non-root + umask 027

2016-06-08 Thread Andrew Onischuk
/1.6.1.2.2.0/package/scripts/accumulo_configuration.py 09a3d90 Diff: https://reviews.apache.org/r/48419/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
age/scripts/logfeeder.py (line 47) <https://reviews.apache.org/r/48348/#comment201864> Why do we run logsearch components as root? This is not recommended and our users don't have this sudo permission - Andrew Onischuk On June 9, 2016, 8:19 a.

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
> On June 9, 2016, 8:42 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py, > > line 47 > > <https://reviews.apache.org/r/48348/diff/2/?file=1411328#file1411328line47> > > > >

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
> On June 9, 2016, 8:42 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py, > > line 47 > > <https://reviews.apache.org/r/48348/diff/2/?file=1411328#file1411328line47> > > > >

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
> On June 9, 2016, 8:42 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py, > > line 47 > > <https://reviews.apache.org/r/48348/diff/2/?file=1411328#file1411328line47> > > > >

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
> On June 9, 2016, 8:42 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py, > > line 47 > > <https://reviews.apache.org/r/48348/diff/2/?file=1411328#file1411328line47> > > > >

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-09 Thread Andrew Onischuk
> On June 9, 2016, 8:42 a.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py, > > line 47 > > <https://reviews.apache.org/r/48348/diff/2/?file=1411328#file1411328line47> > > > >

Re: Review Request 48403: Fixed implementation of on-ambari-upgrade support. Patch 1 - change validation rules and available fields

2016-06-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48403/#review136805 --- Ship it! Ship It! - Andrew Onischuk On June 9, 2016, 1:12

Re: Review Request 48501: AMBARI-17147: OSError: [Errno 1] Operation not permitted with non-root ambari agent user

2016-06-09 Thread Andrew Onischuk
er to read ambari logs? - Andrew Onischuk On June 9, 2016, 6:56 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 48501: AMBARI-17147: OSError: [Errno 1] Operation not permitted with non-root ambari agent user

2016-06-09 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48501/#review136899 --- Ship it! Ship It! - Andrew Onischuk On June 9, 2016, 6:56

Review Request 48540: Ubuntu 16, Hive Metastore Start failed

2016-06-10 Thread Andrew Onischuk
er 'root'@'localhost' + /var/lib/ambari-agent/ambari-sudo.sh su mysql -s /bin/bash - -c 'mysql -u root -e "flush privileges;"' ERROR 1698 (28000): Access denied for user 'root'@'localhost' + /var/lib/ambari-agent/ambari-sudo.sh service mysql stop Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/addMysqlUser.sh 36ed58f Diff: https://reviews.apache.org/r/48540/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48546: Xml manifests should not include wildcards but full versions for package-version

2016-06-10 Thread Andrew Onischuk
propagate wildcards in package- version. Diffs - ambari-common/src/main/python/resource_management/libraries/script/script.py d11fb13 Diff: https://reviews.apache.org/r/48546/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48546: Wildcards shouldn't be used for package installation

2016-06-10 Thread Andrew Onischuk
m storm_2_5_0_0_688-slider-client-1.0.1.2.5.0.0-688.el6.x86_6 **Solution**: RE should do the change in manifests. To not propagate wildcards in package- version. Diffs - ambari-common/src/main/python/resource_management/libraries/script/script.py d11fb13 Diff: https://reviews.apache.org/r/48546/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-11 Thread Andrew Onischuk
/package/scripts/setup_logfeeder.py (line 90) <https://reviews.apache.org/r/48348/#comment202283> Since ambari agent tasks run from the same user as ambari-agent you can simply do: grp.getgrgid(os.getegid()).gr_name to get the group you need - Andrew Onischuk On J

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-11 Thread Andrew Onischuk
> On June 11, 2016, 4:28 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py, > > line 91 > > <https://reviews.apache.org/r/48348/diff/4/?file=1414799#file1414799line91> > > >

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-11 Thread Andrew Onischuk
;/var/lib/ambari-agent/data/" ambari-sudo.sh chown -R $current_user "/var/lib/ambari-agent/cache/" ambari-sudo.sh chown$current_user "/usr/lib/ambari-agent/" - Andrew Onischuk On June 10, 2016, 3:08 p.m., Oliver Szabo wrote: > > --

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-12 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48348/#review137158 --- Ship it! Thanks Oviler! - Andrew Onischuk On June 11, 2016

Re: Review Request 48348: AMBARI-17089: HDFS logs not picked by log feeder with umask 0027

2016-06-12 Thread Andrew Onischuk
/package/scripts/logfeeder.py (line 42) <https://reviews.apache.org/r/48348/#comment202321> Should be from config in config['configurations']['cluster-env']["fetch_nonlocal_groups"] - Andrew Onischuk On June 12,

Re: Review Request 48623: Fix configuration xml files that don't pass validation

2016-06-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48623/#review137253 --- Ship it! Ship It! - Andrew Onischuk On June 13, 2016, 9:24

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
123) <https://reviews.apache.org/r/48309/#comment202449> Can you please explain why did we remove the check for firewalld? - Andrew Onischuk On June 7, 2016, 11:11 a.m., Masahiro Tanaka wrote: > > --- > This is a

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > <https://reviews.apache.org/r/48309/diff/1/?file=1408121#file1408121line123> > > > > Can you please explain why did

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > <https://reviews.apache.org/r/48309/diff/1/?file=1408121#file1408121line123> > > > > Can you please explain why did

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > <https://reviews.apache.org/r/48309/diff/1/?file=1408121#file1408121line123> > > > > Can you please explain why did

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
> On June 13, 2016, 1:03 p.m., Andrew Onischuk wrote: > > ambari-common/src/main/python/ambari_commons/firewall.py, line 123 > > <https://reviews.apache.org/r/48309/diff/1/?file=1408121#file1408121line123> > > > > Can you please explain why did

Re: Review Request 48309: AMBARI-17047: Firewall check returns WARNING even if iptables and firewalld are stopped on CentOS7

2016-06-13 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48309/#review137293 --- Ship it! Ship It! - Andrew Onischuk On June 7, 2016, 11:11

Review Request 48641: yarncli throws log4j error "FileNotFoundException : /grid/0/log/yarn/hrt_qa/rm-audit.log"

2016-06-13 Thread Andrew Onischuk
iguration/yarn-env.xml c43b462 ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-env.xml 90ad1fc Diff: https://reviews.apache.org/r/48641/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48643: Ambari uses too small a window for region server shutdown

2016-06-13 Thread Andrew Onischuk
py 05bad1c ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/phoenix_service.py 0a42cda ambari-server/src/test/python/stacks/2.0.6/HBASE/test_phoenix_queryserver.py ac8b153 ambari-server/src/test/python/stacks/2.0.6/configs/default.json 04aa828 ambari-server/src/test/python/stacks/2.0.6/configs/secured.json 02f982e Diff: https://reviews.apache.org/r/48643/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48557: Fixed implementation of on-ambari-upgrade support. Patch 2: add logic for ambari-upgrade

2016-06-14 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48557/#review137472 --- Ship it! Ship It! - Andrew Onischuk On June 14, 2016, 9:07

Review Request 48683: One of RM failed to start after ambaru upgrade in secure cluster [Upgrade]

2016-06-14 Thread Andrew Onischuk
ackage/scripts/resourcemanager.py 0b80dc6 Diff: https://reviews.apache.org/r/48683/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48683: One of RM failed to start after ambaru upgrade in secure cluster [Upgrade]

2016-06-14 Thread Andrew Onischuk
401. Error 401 Authentication required HTTP ERROR 401 Problem accessing /webhdfs/v1/ats/done/. Reason: Authentication requiredPowered by Jetty:// Diffs - ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 0b80dc6 Diff: https://reviews.apache.org/r/48683/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48683: One of RM failed to start after ambaru upgrade in secure cluster [Upgrade]

2016-06-14 Thread Andrew Onischuk
Error 401 Authentication required HTTP ERROR 401 Problem accessing /webhdfs/v1/ats/done/. Reason: Authentication requiredPowered by Jetty:// Diffs (updated) - ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py 0b80dc6 Diff: https://reviews.apache.org/r/48683/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 47954: AMBARI-16907 Ambari web UI does not auto-set all required properties when user toggles on the Yarn CPU isolation feature on the web UI

2016-06-14 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47954/#review137506 --- Ship it! Ship It! - Andrew Onischuk On June 13, 2016, 2:39

Review Request 48690: org.apache.ambari.server.state.cluster.ClusterTest.testTransitionNonReportableHost fails intermittently on trunk.

2016-06-14 Thread Andrew Onischuk
nsitionNonReportableHost(ClusterTest.java:2375) Diffs - ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java 9a12a1b Diff: https://reviews.apache.org/r/48690/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48725: Supervisor start failed after Ambari upgrade (intermittent)

2016-06-15 Thread Andrew Onischuk
est/python/stacks/2.1/STORM/test_storm_supervisor.py c70e06c ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py f4f6bae ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 101fbe6 Diff: https://reviews.apache.org/r/48725/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48731: Yarn service check fails after Ambari upgrade from 2.0.2 to 2.4.0.0

2016-06-15 Thread Andrew Onischuk
24toermlevelsecha-r6-3.openstacklocal:8088/proxy/application_1465953261376_0004/, appUser=ambari-qa\n16/06/15 09:03:48 INFO distributedshell.Client: Application has completed successfully. Breaking monitoring loop\n16/06/15 09:03:48 INFO distributedshell.Client: Application completed successfully') 2016-06-15 09:03:48,569 - call['ambari-sudo.sh su ambari-qa -l -s /bin/bash -c 'curl --negotiate -u : -ksL --connect-timeout 5 http://os-r6-hoiqv-nat-s-c224toermlevelsecha-r6-3.openstacklocal:8088/ws/v1/cluster/apps/application_1465953261376_0004 1>/tmp/tmpVuRELY 2>/tmp/tmpbOO6CK''] {'path': '/usr/sbin:/sbin:/usr/local/bin:/bin:/usr/bin', 'quiet': False} 2016-06-15 09:03:48,624 - call returned (0, '') 2016-06-15 09:03:48,625 - call['ambari-sudo.sh su ambari-qa -l -s /bin/bash -c 'curl --negotiate -u : -ksL --connect-timeout 5 http://os-r6-hoiqv-nat-s-c224toermlevelsecha-r6-1.openstacklocal:8088/ws/v1/cluster/apps/application_1465953261376_0004 1>/tmp/tmpxUOtVQ 2>/tmp/tmpaGjttM''] {'path': '/usr/sbin:/sbin:/usr/local/bin:/bin:/usr/bin', 'quiet': False} 2016-06-15 09:03:48,686 - call returned (0, '') Command failed after 1 tries Diffs - ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py 131cd42 Diff: https://reviews.apache.org/r/48731/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Andrew Onischuk
281) <https://reviews.apache.org/r/48722/#comment202954> Do we really want to do this only if there are tasks pending. Could we do this always? This would make one time operations like start stop a component decommisions etc. much more responsive. - Andrew Onischuk On June 15

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-15 Thread Andrew Onischuk
time for BP scenario? - Andrew Onischuk On June 15, 2016, 2:55 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-15 Thread Andrew Onischuk
/package/scripts/mysql_service.py (line 49) <https://reviews.apache.org/r/48766/#comment203095> We should probably do a checked_call here to give an exception with a good information in case we cannot do this. Also why to we need timeout here? - Andrew Onischuk On June 15

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Andrew Onischuk
> On June 15, 2016, 11:44 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 54 > > <https://reviews.apache.org/r/48766/diff/1/?file=1420515#file1420515line54> > >

Review Request 48797: BG operations windown appeared after 90 seconds on clicking start all services

2016-06-16 Thread Andrew Onischuk
/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 4f8fda6 Diff: https://reviews.apache.org/r/48797/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Andrew Onischuk
reasonable exception in that case. - Andrew Onischuk On June 16, 2016, 9:20 p.m., Juanjo Marron wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Andrew Onischuk
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > <https://reviews.apache.org/r/48766/diff/2/?file=1421794#file1421794line63> > > > &

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-16 Thread Andrew Onischuk
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > <https://reviews.apache.org/r/48766/diff/2/?file=1421794#file1421794line63> > > > &

Re: Review Request 48829: AMBARI-17245 Failed to start Hive metastore due to UnicodeDecodeError

2016-06-17 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48829/#review138187 --- Ship it! Ship It! - Andrew Onischuk On June 17, 2016, 12:18

Re: Review Request 48766: MySQL service status needs to be more robust

2016-06-17 Thread Andrew Onischuk
> On June 16, 2016, 10:52 p.m., Andrew Onischuk wrote: > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py, > > line 63 > > <https://reviews.apache.org/r/48766/diff/2/?file=1421794#file1421794line63> > > > &

Review Request 48844: Operations during upgrade are permitted by all roles

2016-06-17 Thread Andrew Onischuk
rceProviderTest.java 5bcfd86 Diff: https://reviews.apache.org/r/48844/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 48852: Ambari displays a warning about config values not being at optimal values right after a clean install with no customization

2016-06-17 Thread Andrew Onischuk
https://reviews.apache.org/r/48852/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48852: Ambari displays a warning about config values not being at optimal values right after a clean install with no customization

2016-06-17 Thread Andrew Onischuk
erver/src/test/python/stacks/2.3/common/test_stack_advisor.py 1bd385f Diff: https://reviews.apache.org/r/48852/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48859: RU: YARN service check failed during RU

2016-06-17 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48859/#review138240 --- Ship it! Ship It! - Andrew Onischuk On June 17, 2016, 3:40

Re: Review Request 48863: Ambari-server upgrade results in "DB configs consistency check failed. "

2016-06-17 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48863/#review138285 --- Ship it! Ship It! - Andrew Onischuk On June 17, 2016, 6:30

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48722/#review138582 --- Ship it! Ship It! - Andrew Onischuk On June 16, 2016, 4:43

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Andrew Onischuk
t run more often with a more frequent heartbeat? Cause we don't want those redundant computations too often. - Andrew Onischuk On June 20, 2016, 1:08 p.m., Sebastian Toader wrote: > > --- > This is an automatically generat

Re: Review Request 48722: Reduce the idle time before first command from next stage is executed on a host

2016-06-20 Thread Andrew Onischuk
), which bring slowdown. Would be nice to deploy fullstack with and without your patch. And see if it brings speedup, and not actually slowdown. - Andrew Onischuk On June 20, 2016, 1:08 p.m., Sebastian Toader wrote: > > --- > T

Review Request 49018: Downloading sqoop client files throws error

2016-06-21 Thread Andrew Onischuk
nt/libraries/script/config_dictionary.py", line 73, in __getattr__ raise Fail("Configuration parameter '" + self.name + "' was not found in configurations dictionary!") resource_management.core.exceptions.Fail: Configuration parameter 'squoop-site' was not found in configurations dictionary! " } Could you please help take a look. Diffs - ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/metainfo.xml 83d0934 Diff: https://reviews.apache.org/r/49018/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Review Request 49024: Client installs failed on debian 7

2016-06-21 Thread Andrew Onischuk
s.py dfba302 Diff: https://reviews.apache.org/r/49024/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

Re: Review Request 48844: Operations during upgrade are permitted by all roles

2016-06-21 Thread Andrew Onischuk
22Test.java c052a6c ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java 5bcfd86 Diff: https://reviews.apache.org/r/48844/diff/ Testing --- mvn clean test Thanks, Andrew Onischuk

<    1   2   3   4   5   6   7   8   9   >