Review Request 61049: AMBARI-21553 Oozie server failed to restart post IOP 4.2 migration

2017-07-21 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61049/ --- Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan

Review Request 61050: AMBARI-21555 Hive restart fails to restart MySQL after Ambari upgrade against IOP 4.2.5

2017-07-21 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61050/ --- Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan

Re: Review Request 61050: AMBARI-21555 Hive restart fails to restart MySQL after Ambari upgrade against IOP 4.2.5

2017-07-24 Thread Di Li
as long as HDP yet to support MariaDB (where HDP uses mysql.d deamon instead) - Di --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61050/#review181265 ---------

Re: Review Request 61178: AMBARI-21572. Spark configuration mismatch post express upgrade

2017-07-27 Thread Di Li
ver_status"" ), one with Critical (IOP one alert id "SPARK2_THRIFTSERVER_PROCESS", wrong, should be removed, or the port updated from 4038 to 4040) - Di Li On July 27, 2017, 2:28 p.m., Attila Doroszlai wrote: > > --

Re: Review Request 61178: AMBARI-21572. Spark configuration mismatch post express upgrade

2017-07-27 Thread Di Li
> On July 27, 2017, 2:38 p.m., Di Li wrote: > > Hello Attila, > > > > The issue with the alert (2nd part of the issue), was BI stack has its own > > sparks thrift server alert that check hardcoded port 4038. HDP stack uses a > > different alert for the same

Re: Review Request 61214: AMBARI-21598. Spark Thrift Server stopped after upgrade due to undefined port

2017-07-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61214/#review181673 --- Ship it! Ship It! - Di Li On July 28, 2017, 2:50 p.m

Re: Review Request 61178: AMBARI-21572. Spark configuration mismatch post express upgrade

2017-07-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61178/#review181738 --- Ship it! Ship It! - Di Li On July 28, 2017, 9:44 p.m

Review Request 61239: AMBARI-21611 Failed to install packages before EU on powerpc

2017-07-28 Thread Di Li
one IOP x86, upgrade Ambari, patch with server jar, run install packages after registering HDP 2.6.2 stack. verify the error did not appear any more for ppc, both ppc and x86 cluster were able to finish the install package step successfully Thanks, Di Li

Re: Review Request 61239: AMBARI-21611 Failed to install packages before EU on powerpc

2017-07-31 Thread Di Li
eviews.apache.org/r/61239/#review181787 ------- On July 29, 2017, 2:12 a.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61239/ >

Re: Review Request 61239: AMBARI-21611 Failed to install packages before EU on powerpc

2017-07-31 Thread Di Li
majorVersion: %s", os, majorVersion); System.out.println(result); """ OUTPUT: OS: redhat, arch: ppc, majorVersion: 100 - Di --- This is an automatically generated e-mail. To reply, visit: h

Re: Review Request 61239: AMBARI-21611 Failed to install packages before EU on powerpc

2017-07-31 Thread Di Li
e to finish the install package step successfully Thanks, Di Li

Re: Review Request 61239: AMBARI-21611 Failed to install packages before EU on powerpc

2017-07-31 Thread Di Li
5542#file1785542line1123> > > > > Add a safeguard here in case indexOf returns -1. Only if > 0 should the > > substring method be called to get the os. > > This also assumes majorVersion is a single digit, instead look for the > > numeric characters from the en

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Di Li
/config-upgrade.xml Lines 125 (patched) <https://reviews.apache.org/r/61283/#comment257806> ranger-kafka-audit only exists in BI 4.2.5. For BI 4.2.0, the conf change should be just the ranger-kms-audit ones. For BI 4.2.5, it should be both ranger-kafka-audit and ranger-kms-audit. -

Re: Review Request 61283: AMBARI-21627. Cross-stack upgrade from IOP to HDP, ranger audit properties need to be deleted

2017-08-02 Thread Di Li
/config-upgrade.xml Lines 317 (patched) <https://reviews.apache.org/r/61283/#comment257807> ranger-hive-audit exists in both BI 4.2.0 and BI 4.2.5, so the change should be in both upgrade pack xml files. - Di Li On Aug. 1, 2017, 10:34 p.m., Alejandro Fernandez

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/#review181973 --- Ship it! Ship It! - Di Li On Aug. 2, 2017, 9:13 a.m

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Di Li
/services/HDFS/package/scripts/balancer-emulator/balancer.log Lines 2 (patched) <https://reviews.apache.org/r/61371/#comment257808> I don't think we need the two balancer log files as part of the HDFS service definition. Please remove them if they are not necessary. - Di Li On Aug. 2,

Re: Review Request 61371: AMBARI-21624. HDFS restart failed post Ambari upgrade when lzo compression was enabled

2017-08-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61371/#review181983 --- Ship it! Ship It! - Di Li On Aug. 2, 2017, 1:12 p.m

Re: Review Request 61377: Hive CLI does not work after upgrade

2017-08-02 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61377/#review181991 --- Ship it! Ship It! - Di Li On Aug. 2, 2017, 1:21 p.m

Re: Review Request 61403: AMBARI-21554. Regenerating keytabs fails in Stack Advisor after upgrading Ambari

2017-08-03 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61403/#review182107 --- Ship it! Ship It! - Di Li On Aug. 3, 2017, 12:54 p.m

Review Request 61415: AMBARI-21654 Post Ambari upgrade, BI value add 4.2 services should still be able to restart

2017-08-03 Thread Di Li
, their service defintions are NOT part of the stack shipped in Ambari) can restart now. Thanks, Di Li

Re: Review Request 61548: AMBARI-21698. Error starting client components on RedHat7 and BI 4.2.5 after Ambari upgrade

2017-08-10 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61548/#review182583 --- Ship it! Ship It! - Di Li On Aug. 10, 2017, 9:43 a.m

Re: Review Request 61786: AMBARI-21768. Spark History Server uses wrong log dir

2017-08-21 Thread Di Li
/config-upgrade.xml Lines 379 (patched) <https://reviews.apache.org/r/61786/#comment259382> Spark2 config in IOP 4.2.5 also has these properties. They are defined under different config types though, i.e spark2-default... - Di Li On Aug. 21, 2017, 4:23 p.m., Attila Doroszlai

Re: Review Request 60403: Add Kerberos HTTP SPNEGO authentication support to Ambari Metrics Monitor

2017-08-22 Thread Di Li
mp;a=commit&h=d260c89263ee0471514b4cfb8ce938134eceea12) Please close the review as needed. - Di Li On June 23, 2017, 10:49 p.m., Qin Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://

Re: Review Request 61861: Post Ambari upgrade on a migration cluster Oozie failed to restart when LZO compression is enabled

2017-08-23 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61861/#review183656 --- Ship it! Ship It! - Di Li On Aug. 23, 2017, 8:25 p.m., Sid

Re: Review Request 61875: Oozie server crashes post migration after regen kerberos keytabs and restart all services

2017-08-24 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61875/#review183734 --- Ship it! Ship It! - Di Li On Aug. 24, 2017, 8:59 a.m

Review Request 61948: AMBARI-21830 PowerPC - IOP/HDP migration, service restart fails post Ambari upgrade

2017-08-28 Thread Di Li
g services ( generating the repo_info data in the command-[taskid].json) is the repo id "redhat-ppc7" patched a cluster with the new section in repoinfo.xml, restart Ambari ( already upgraded), veify now can restart HDFS where it can install the Hadoop client Thanks, Di Li

Re: Review Request 62778: AMBARI-22137 - Different stack versions should be able to link to different extension versions

2017-10-05 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62778/#review187171 --- Ship it! Ship It! - Di Li On Oct. 4, 2017, 7:51 p.m., Tim

Review Request 62787: AMBARI-22136 Enable server_action tasks defined in EU/RU upgrade pack xml files to take parameters

2017-10-05 Thread Di Li
dRepositoryAction:84 - c: c 04 Oct 2017 11:32:18,590 INFO [Server Action Executor Worker 54] UpdateDesiredRepositoryAction:86 - END - Map commandParameters = getCommandParameters(); Thanks, Di Li

Re: Review Request 62787: AMBARI-22136 Enable server_action tasks defined in EU/RU upgrade pack xml files to take parameters

2017-10-05 Thread Di Li
ositoryAction:84 - c: c 04 Oct 2017 11:32:18,590 INFO [Server Action Executor Worker 54] UpdateDesiredRepositoryAction:86 - END - Map commandParameters = getCommandParameters(); Thanks, Di Li

Re: Review Request 62787: AMBARI-22136 Enable server_action tasks defined in EU/RU upgrade pack xml files to take parameters

2017-10-05 Thread Di Li
ositoryAction:84 - c: c 04 Oct 2017 11:32:18,590 INFO [Server Action Executor Worker 54] UpdateDesiredRepositoryAction:86 - END - Map commandParameters = getCommandParameters(); Thanks, Di Li

Re: Review Request 62943: AMBARI-22220 - Should be able to switch the extension version to which a stack version is linked

2017-10-14 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62943/#review188067 --- Ship it! Ship It! - Di Li On Oct. 13, 2017, 6:40 p.m., Tim

Review Request 63513: AMBARI-22337 each service should be able to implement server actions, package them add a jar to be loaded during EU

2017-11-02 Thread Di Li
. Thanks, Di Li

Re: Review Request 63513: AMBARI-22337 each service should be able to implement server actions, package them add a jar to be loaded during EU

2017-11-02 Thread Di Li
s, run EU, verify the external server action classes ran and were able to provide response back to EU. Thanks, Di Li

Re: Review Request 63513: AMBARI-22337 each service should be able to implement server actions, package them add a jar to be loaded during EU

2017-11-02 Thread Di Li
-mail. To reply, visit: https://reviews.apache.org/r/63513/#review189923 --- On Nov. 2, 2017, 7:30 p.m., Di Li wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 63640: AMBARI-22378 BI 4.2.5 repoinfo misses the redhat-ppc7 section

2017-11-07 Thread Di Li
/repoinfo.xml d1b155d Diff: https://reviews.apache.org/r/63640/diff/1/ Testing --- manually tested it by patching an Ambari 2.6.0 cluster with changes Thanks, Di Li

Review Request 63800: AMBARI-22431 Able to add config type if EU/RU of the same stack (minor version upgrade)

2017-11-14 Thread Di Li
zookeeper-fake that needs to be created and configured during EU. Thanks, Di Li

Re: Review Request 63800: AMBARI-22431 Able to add config type if EU/RU of the same stack (minor version upgrade)

2017-11-14 Thread Di Li
-7293bb6e1bf5__config_type_tests_hdp_2.6.zip Thanks, Di Li

Re: Review Request 63800: AMBARI-22431 Able to add config type if EU/RU of the same stack (minor version upgrade)

2017-11-14 Thread Di Li
/06efe434-a4fa-4b74-bede-7293bb6e1bf5__config_type_tests_hdp_2.6.zip Thanks, Di Li

Review Request 63877: AMBARI-22459 IOP/HDP migration NN HA restart post Ambari upgrade fails

2017-11-16 Thread Di Li
.2.5 NN HA cluster, modify the file after yum upgrade of ambari rpms to Ambari 2.6, then run ambari-server upgrade, then try to restart HDFS, verify HDFS can restart. Proceed with EU, verify EU is successful. Thanks, Di Li

Re: Review Request 64164: LZO Upgrade pre-check is missing from BigInsights Upgrade packs

2017-11-29 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64164/#review192132 --- Ship it! Ship It! - Di Li On Nov. 29, 2017, 4:35 p.m., Nate

Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-04 Thread Di Li
Testing --- upgrade ambari server rpms on an IOP 4.2.5 PPC cluster, replace ambari-server jar with the one built with the fixes, run ambari-server upgrade, verify ambari database has the repositories info in repo_version is updated from redhat7 to redhat-ppc7, verify post ambari upgrade, I could restart services without having ambari server threw exceptions. Thanks, Di Li

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-04 Thread Di Li
ps://reviews.apache.org/r/64311/diff/2/ Changes: https://reviews.apache.org/r/64311/diff/1-2/ Testing --- upgrade ambari server rpms on an IOP 4.2.5 PPC cluster, replace ambari-server jar with the one built with the fixes, run ambari-server upgrade, verify ambari database has the repositories info in repo_version is updated from redhat7 to redhat-ppc7, verify post ambari upgrade, I could restart services without having ambari server threw exceptions. Thanks, Di Li

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Di Li
happen at the ambari-upgrade time and needs to deal with BigInsights 4.2.5 repositories. - Di --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64311/#review192856 --- On Dec. 4, 2017, 8:08

Review Request 64344: AMBARI-22589 Ambari web UI stack version page is empty due to NPE when target stack does not contain all services from the current stack

2017-12-05 Thread Di Li
install a cluster with IOP 4.2.5 stack. register HDP 2.6 stack where it doesn;t have solr. verify UI, with the patch, pops up an alert dialog and also be able to show the stacks registered instead of an empty page. Thanks, Di Li

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Di Li
ps://reviews.apache.org/r/64311/diff/3/ Changes: https://reviews.apache.org/r/64311/diff/2-3/ Testing --- upgrade ambari server rpms on an IOP 4.2.5 PPC cluster, replace ambari-server jar with the one built with the fixes, run ambari-server upgrade, verify ambari database has the repositories info in repo_version is updated from redhat7 to redhat-ppc7, verify post ambari upgrade, I could restart services without having ambari server threw exceptions. Thanks, Di Li

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Di Li
; We really shouldn't be hardcoding stack names and versions like this. > > > > what change caused this problem? there must be a better workaround > > Di Li wrote: > Hello Jonathan, > > This is the code change that caused the err >>

Re: Review Request 64344: AMBARI-22589 Ambari web UI stack version page is empty due to NPE when target stack does not contain all services from the current stack

2017-12-05 Thread Di Li
/ Testing --- patch a trunk cluster to have it be able to install a cluster with IOP 4.2.5 stack. register HDP 2.6 stack where it doesn;t have solr. verify UI, with the patch, pops up an alert dialog and also be able to show the stacks registered instead of an empty page. Thanks, Di Li

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Di Li
upgrade, verify ambari database has the repositories info in repo_version is updated from redhat7 to redhat-ppc7, verify post ambari upgrade, I could restart services without having ambari server threw exceptions. Thanks, Di Li

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Di Li
; We really shouldn't be hardcoding stack names and versions like this. > > > > what change caused this problem? there must be a better workaround > > Di Li wrote: > Hello Jonathan, > > This is the code change that caused the err >>

Review Request 64771: AMBARI-22681 Ambari web UI failed to update stack repo directly from the Versions tab

2017-12-21 Thread Di Li
/ajax.js 3f85dfdc Diff: https://reviews.apache.org/r/64771/diff/1/ Testing --- existing JS unit tests. Patch a trunk cluster with the changes and verify the UI now can save URLs without having to go to the admin view. Thanks, Di Li

Review Request 64781: AMBARI-22680 Ambari web UI does not fail an invalid repo base URL during cluster installation

2017-12-21 Thread Di Li
during cluster install, verify the UI stops users from proceeding to the next page with an error about the URL being invalid. verify the UI moves to the next page when the urls are correct. Thanks, Di Li

Review Request 64809: AMBARI-22685 Stack OS/repos removed from cluster installation UI showed up on the Versions tab after cluster is installed

2017-12-22 Thread Di Li
, run thru cluster install. From Ambari web UI, on the Versions tab, check os/repos shown on the cluster, verify only the ones selected during the installation time remain. Thanks, Di Li

<    1   2   3   4   5