Re: Review Request 52785: Fix problem on Suse for ambari-agent installation

2016-10-13 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52785/#review152470 --- Ship it! Ship It! - Laszlo Puskas On Oct. 12, 2016, 2:36

Re: Review Request 52691: Provision actions to happen based only on specified dependencies

2016-10-20 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52691/#review153397 --- Ship it! Ship It! - Laszlo Puskas On Oct. 18, 2016, 6:17

Re: Review Request 53135: Fix constraint violations in adminprincipal table when installing database schema

2016-10-24 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53135/#review153691 --- Ship it! Ship It! - Laszlo Puskas On Oct. 24, 2016, 2:30

Re: Review Request 53188: AMBARI-18700 Add HDFS resources for Spark2 to AmbariPreupload script

2016-10-26 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53188/#review153881 --- Ship it! Ship It! - Laszlo Puskas On Oct. 26, 2016, 2:33

Re: Review Request 53228: AMBARI-18702 Fix typos

2016-10-27 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53228/#review154025 --- Ship it! Ship It! - Laszlo Puskas On Oct. 27, 2016, 2:49

Re: Review Request 53583: Optionally force username from LDAP authentication data to be lowercase in Ambari

2016-11-09 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53583/#review155423 --- Ship it! Ship It! - Laszlo Puskas On Nov. 8, 2016, 7:09 p.m

Re: Review Request 53576: AMBARI-18569 Execute topology tasks in parallel by hosts

2016-11-09 Thread Laszlo Puskas
er/src/main/java/org/apache/ambari/server/topology/TopologyManager.java (line 736) <https://reviews.apache.org/r/53576/#comment225367> Check the configuration for parallel execution here. - Laszlo Puskas On Nov. 9, 2016, 10:27 a.m., Attil

Re: Review Request 53778: Oozie config not shown as stale upon changing DefaultFS

2016-11-15 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53778/#review155900 --- Ship it! Ship It! - Laszlo Puskas On Nov. 15, 2016, 10:06

Review Request 53779: Post user creation hook takes kinit executable location from system variable

2016-11-15 Thread Laszlo Puskas
the location. (validation of the location availability of the executable is underway) Diffs - ambari-server/src/main/resources/scripts/post-user-creation-hook.sh 34169c1 Diff: https://reviews.apache.org/r/53779/diff/ Testing --- Manually done on local env. Thanks, Laszlo Puskas

Re: Review Request 53810: Oozie service check fails due to timeout

2016-11-16 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53810/#review156063 --- Ship it! Ship It! - Laszlo Puskas On Nov. 16, 2016, 2:12

Re: Review Request 54002: AMBARI-18966 Add check to ensure we do not have @Transactional annotations on private methods

2016-11-23 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54002/#review156745 --- Ship it! Ship It! - Laszlo Puskas On Nov. 23, 2016, 3:27

Review Request 54064: Optimize loading of views in cloud environments

2016-11-24 Thread Laszlo Puskas
, Laszlo Puskas

Re: Review Request 54064: Optimize loading of views in cloud environments

2016-11-24 Thread Laszlo Puskas
/ViewRegistryTest.java 6b560ee Diff: https://reviews.apache.org/r/54064/diff/ Testing --- Manually done locally and cloud env. Thanks, Laszlo Puskas

Re: Review Request 54064: Optimize loading of views in cloud environments

2016-11-24 Thread Laszlo Puskas
=1570132#file1570132line1571> > > > > Indentation is +1 level than needed. Formatted the whole class as it seemed the indentation was messed. - Laszlo --- This is an automatically generated e-mail. To r

Re: Review Request 54064: Optimize loading of views in cloud environments

2016-11-25 Thread Laszlo Puskas
/ViewRegistryTest.java 6b560ee Diff: https://reviews.apache.org/r/54064/diff/ Testing --- Manually done locally and cloud env. Thanks, Laszlo Puskas

Re: Review Request 54064: Optimize loading of views in cloud environments

2016-11-25 Thread Laszlo Puskas
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54064/#review156840 --- On Nov. 25, 2016, 9:17 a.m., Laszlo Puskas wrote: > > --- >

Review Request 54318: Escaped usernames passed to the post-user creation script

2016-12-02 Thread Laszlo Puskas
Diff: https://reviews.apache.org/r/54318/diff/ Testing --- Manually in progress. Thanks, Laszlo Puskas

Re: Review Request 54318: Escaped usernames passed to the post-user creation script

2016-12-05 Thread Laszlo Puskas
/post-user-creation-hook.sh 34169c1 Diff: https://reviews.apache.org/r/54318/diff/ Testing (updated) --- Successfully tested on local dev environment. Thanks, Laszlo Puskas

Re: Review Request 54364: Change Ranger Admin start script to setup db for ranger

2016-12-05 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54364/#review157985 --- Ship it! Ship It! - Laszlo Puskas On Dec. 5, 2016, 8:26 a.m

Re: Review Request 54252: Data model and Json parser for quick link profiles.

2016-12-09 Thread Laszlo Puskas
quicklinksprofile/Filter.java (line 59) <https://reviews.apache.org/r/54252/#comment229447> Factories could leverage GUICE. We have examples on how to do that. (that would reduce a bit the amount of the code :) ) - Laszlo Puskas On Dec. 2, 2016, 2:10 p.m.,

Re: Review Request 54612: AMBARI-19158. Plugin configuration ignored when directly running checkstyle goals

2016-12-12 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54612/#review158852 --- Ship it! Ship It! - Laszlo Puskas On Dec. 9, 2016, 10:31

Re: Review Request 54698: Disable security hook

2016-12-13 Thread Laszlo Puskas
/ZkMigrator.java (line 31) <https://reviews.apache.org/r/54698/#comment229909> You could use the org.apache.commons.cli framework to handle the arguments. (There are examples in the code base) - Laszlo Puskas On Dec. 13, 2016, 1:51 p.m., Attila Magyar

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

2016-12-15 Thread Laszlo Puskas
/DBAccessorImpl.java (line 1186) <https://reviews.apache.org/r/54743/#comment230254> break is missing here; is that deliberately? (i'd rathere repeat the block if the logic is the same) - Laszlo Puskas On Dec. 15, 2016, 8:55 a.m., Sebastian T

Re: Review Request 54743: Add PK to hostcomponentdesiredstate Table To Support FK Relationships

2016-12-15 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54743/#review159286 --- Ship it! Ship It! - Laszlo Puskas On Dec. 15, 2016, 8:55

Re: Review Request 54698: Disable security hook

2016-12-15 Thread Laszlo Puskas
ews.apache.org/r/54698/ > ------- > > (Updated Dec. 15, 2016, 9:26 a.m.) > > > Review request for Ambari, Attila Doroszlai, Dmitro Lisnichenko, Jaimin > Jetly, Laszlo Puskas, Oliver Szabo, Robert Levas, and Sebastian Toa

Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
/ambari_server/setupActions.py 7ea0752 Diff: https://reviews.apache.org/r/54933/diff/ Testing --- Manually. (Unit tests need to be ran yet!) Thanks, Laszlo Puskas

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
Total failures:0 OK Thanks, Laszlo Puskas

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
errors:0 Total failures:0 OK Thanks, Laszlo Puskas

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
org/r/54933/#review159842 --- On Dec. 21, 2016, 1:05 p.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
Total errors:0 Total failures:0 OK Thanks, Laszlo Puskas

Re: Review Request 54933: Support for setting Kerberos authentication related properties via the ambari-server command line tool.

2016-12-21 Thread Laszlo Puskas
support for these properties to be set from the command line using the ambari-server command. Usage: ambari-server setup-kerberos branch-2.5 commit f652f61e7bcd2eebe651d8cf96266d2b362bb578 Author: Laszlo Puskas Date:?? Wed Dec 21 20:28:28 2016 +0100 trunk commit

Re: Review Request 54939: AMBARI-19270. Log successful agent cache update at info level

2016-12-23 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54939/#review160047 --- Ship it! Ship It! - Laszlo Puskas On Dec. 21, 2016, 3:42

Re: Review Request 55171: Setup correct authentication and authorization mechanism between Yarn and Zookeeper

2017-01-04 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55171/#review160498 --- Ship it! Ship It! - Laszlo Puskas On Jan. 4, 2017, 3:10 p.m

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Laszlo Puskas
(These also could be managed with guice) Unit testing would be also easier. - Laszlo Puskas On Jan. 9, 2017, 3:07 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161236 --- Ship it! Ship It! - Laszlo Puskas On Jan. 9, 2017, 3:07 p.m

Re: Review Request 55425: Setup the correct authentication and authorization between Hive/Hcatalog and ZooKeeper

2017-01-11 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55425/#review161242 --- Ship it! Ship It! - Laszlo Puskas On Jan. 11, 2017, 2:24

Re: Review Request 55308: AMBARI-19414. Cannot install Accumulo via blueprint with default settings

2017-01-13 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55308/#review161540 --- Ship it! Ship It! - Laszlo Puskas On Jan. 11, 2017, 9:28

Re: Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

2017-01-16 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55513/#review161720 --- Ship it! Ship It! - Laszlo Puskas On Jan. 13, 2017, 6:14

Re: Review Request 55574: Setup the correct authentication and authorization between ZooKeeper and oozie

2017-01-16 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55574/#review161782 --- Ship it! Ship It! - Laszlo Puskas On Jan. 16, 2017, 7:07

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-18 Thread Laszlo Puskas
/DefaultTimeSource.java (line 29) <https://reviews.apache.org/r/55643/#comment233314> Why is this abstarction needed? Couldn't we simply use Calendar instead? - Laszlo Puskas On Jan. 17, 2017, 9:30 p.m., Balázs Bence

Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-18 Thread Laszlo Puskas
r.acl - removed * checked the hadoop-env.sh - doesn't contain the variable export HADOOP_ZKFC_OPTS Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-18 Thread Laszlo Puskas
* checked the configuration entry: ha.zookeeper.acl - removed * checked the hadoop-env.sh - doesn't contain the variable export HADOOP_ZKFC_OPTS Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-18 Thread Laszlo Puskas
https://reviews.apache.org/r/55680/#review162123 ----------- On Jan. 18, 2017, 3:58 p.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-18 Thread Laszlo Puskas
ew162125 ------- On Jan. 18, 2017, 3:58 p.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55680

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-18 Thread Laszlo Puskas
* checked the configuration entry: ha.zookeeper.acl - removed * checked the hadoop-env.sh - doesn't contain the variable export HADOOP_ZKFC_OPTS Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-18 Thread Laszlo Puskas
d * checked the hadoop-env.sh - doesn't contain the variable export HADOOP_ZKFC_OPTS Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-18 Thread Laszlo Puskas
contain the variable export HADOOP_ZKFC_OPTS Unit tests: Successfully ran on local machine / unrelated test failed though. Thanks, Laszlo Puskas

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-19 Thread Laszlo Puskas
ran on local machine / unrelated test failed though. Thanks, Laszlo Puskas

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-20 Thread Laszlo Puskas
/hadoop-ha/mycluster/ActiveStandbyElectorLock) Unit tests: Running in progress for trunk Thanks, Laszlo Puskas

Review Request 55762: Ambari db-cleanup tool fixed

2017-01-20 Thread Laszlo Puskas
a 0e2e0d8 Diff: https://reviews.apache.org/r/55762/diff/ Testing --- Manually. Thanks, Laszlo Puskas

Re: Review Request 55764: Ldap sync fails when there are special characters in distinguished names

2017-01-20 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55764/#review162439 --- Ship it! Ship It! - Laszlo Puskas On Jan. 20, 2017, 4:31

Re: Review Request 55777: Update quicklink.json files in stack definitions with authenticated/sso features

2017-01-20 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55777/#review162460 --- Ship it! Ship It! - Laszlo Puskas On Jan. 20, 2017, 6:30

Re: Review Request 55762: Ambari db-cleanup tool fixed

2017-01-20 Thread Laszlo Puskas
been added, the related guice module hasn;t been set into the tool's injector. The fix is to add the missing module to the db-cleanup tool's injector. branch-2.5: commit 8111ba662e849c27e4a9a04305b3ef2260c030e9 Author: Laszlo Puskas Date:?? Fri Jan 20 19:18:10 2017 +0100 AMBARI-196

Re: Review Request 55762: Ambari db-cleanup tool fixed

2017-01-24 Thread Laszlo Puskas
been added, the related guice module hasn;t been set into the tool's injector. The fix is to add the missing module to the db-cleanup tool's injector. branch-2.5: commit 8111ba662e849c27e4a9a04305b3ef2260c030e9 Author: Laszlo Puskas Date:?? Fri Jan 20 19:18:10 2017 +0100 AMBARI-196

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-24 Thread Laszlo Puskas
ted to trunk: commit a382bed7f55be632fd03e1b02bb8a01151234b24 Author: Laszlo Puskas Date: Fri Jan 20 12:41:02 2017 +0100 AMBARI-19613. ZKFC Zookeper connection is not secure. (Laszlo Puskas via stoader) branch-2.5 commit 00b2c42ccf6fe68267483a645f6e57e9c921f01b Author: Laszlo Puskas Date: Fri

Re: Review Request 55833: Supporting zookeeper security only from HDP 2.6

2017-01-24 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55833/#review162805 --- Ship it! Ship It! - Laszlo Puskas On Jan. 24, 2017, 1 p.m

Review Request 55883: Post user creation hook - input csv generated with READ permissions

2017-01-24 Thread Laszlo Puskas
r way. Thanks, Laszlo Puskas

Re: Review Request 55883: Post user creation hook - input csv generated with READ permissions

2017-01-25 Thread Laszlo Puskas
ystem user (not root ...) - opened the generated csv as the newlycreated user Unit test created. Thanks, Laszlo Puskas

Re: Review Request 55983: AMBARI-19712. Cluster creation fails due to database exception

2017-01-26 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55983/#review163124 --- Ship it! Ship It! - Laszlo Puskas On Jan. 26, 2017, 1:31

Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-26 Thread Laszlo Puskas
/post-user-creation-hook.sh ee8d2d1 ambari-server/src/test/java/org/apache/ambari/server/hooks/users/UserHookServiceTest.java 293b22a Diff: https://reviews.apache.org/r/55987/diff/ Testing --- Unit tests running. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-26 Thread Laszlo Puskas
/users/PostUserCreationHookServerActionTest.java f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing --- Unit tests running. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Laszlo Puskas
value is a bit problematic. - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55987/#review163162 --- On Jan. 2

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Laszlo Puskas
/server/serveraction/users/PostUserCreationHookServerActionTest.java f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing --- Unit tests running. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Laszlo Puskas
3b22a ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/PostUserCreationHookServerActionTest.java f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing --- Unit tests running. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Laszlo Puskas
/PostUserCreationHookServerActionTest.java f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing --- Unit tests running. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Laszlo Puskas
f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing (updated) --- Unit tests succeeded. Manual testing underway Thanks, Laszlo Puskas

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-29 Thread Laszlo Puskas
f5cdf48 Diff: https://reviews.apache.org/r/55987/diff/ Testing (updated) --- Unit tests succeeded. Manually tested changes. Thanks, Laszlo Puskas

Re: Review Request 56054: Inconsistent auth-to-local rules processing during Kerberos authentication

2017-01-29 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56054/#review163430 --- Ship it! Ship It! - Laszlo Puskas On Jan. 29, 2017, 12:50

Re: Review Request 56064: Format ZKFC commands failing while enabling NameNode HA

2017-01-30 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56064/#review163483 --- Ship it! Ship It! - Laszlo Puskas On Jan. 29, 2017, 8:43

Re: Review Request 56175: Setup correct authentication and authorization mechanism between Yarn Registry and Zookeeper

2017-02-01 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56175/#review163842 --- Ship it! Ship It! - Laszlo Puskas On Feb. 1, 2017, 4:43 p.m

Review Request 56600: Default group permissions for the user home directories created by the post user creation script should be 'hdfs' instead of 'hadoop'

2017-02-13 Thread Laszlo Puskas
bari-server/src/main/resources/scripts/post-user-creation-hook.sh 91511a0 Diff: https://reviews.apache.org/r/56600/diff/ Testing --- Manually, underway. Thanks, Laszlo Puskas

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-13 Thread Laszlo Puskas
/UpgradeCatalog250Test.java (line 1666) <https://reviews.apache.org/r/56599/#comment237174> Instead mocking tehe injector itself, add a module where instances are bound to mocks. - Laszlo Puskas On Feb. 13, 2017, 1:48 p.m., Attila Magyar

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-13 Thread Laszlo Puskas
> On Feb. 13, 2017, 3:08 p.m., Laszlo Puskas wrote: > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java, > > line 1672 > > <https://reviews.apache.org/r/56599/diff/1/?file=1631931#file1631931line1672> > > > > In

Re: Review Request 56599: ambari-server upgrade is not idempotent

2017-02-13 Thread Laszlo Puskas
> On Feb. 13, 2017, 3:08 p.m., Laszlo Puskas wrote: > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java, > > line 1672 > > <https://reviews.apache.org/r/56599/diff/1/?file=1631931#file1631931line1672> > > > > In

Re: Review Request 56713: Ambari server start returns prematurely before extracting views.

2017-02-15 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56713/#review165719 --- Ship it! Ship It! - Laszlo Puskas On Feb. 15, 2017, 3:24

Re: Review Request 56783: Removing secure ACLs from Kafka znodes during dekerberization

2017-02-17 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56783/#review165942 --- Ship it! Ship It! - Laszlo Puskas On Feb. 17, 2017, 3:16

Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-02-24 Thread Laszlo Puskas
r won't be notified about the success/failure of the operation) Diffs - ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py 123486e Diff: https://reviews.apache.org/r/57040/diff/ Testing --- Manually. Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-02-24 Thread Laszlo Puskas
acks/2.0.6/HDFS/test_namenode.py fae500f Diff: https://reviews.apache.org/r/57040/diff/ Testing (updated) --- Manually. Unit tests running... Thanks, Laszlo Puskas

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-02-24 Thread Laszlo Puskas
f Diff: https://reviews.apache.org/r/57040/diff/ Testing (updated) --- Manually. Unit tests success. Thanks, Laszlo Puskas

Review Request 57147: Added support for processing custom command script timeout

2017-02-28 Thread Laszlo Puskas
. Thanks, Laszlo Puskas

Re: Review Request 57147: Added support for processing custom command script timeout

2017-02-28 Thread Laszlo Puskas
on with the command output we can't get information about the balancer. - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57147/#review167110 -------

Re: Review Request 57147: Added support for processing custom command script timeout

2017-03-01 Thread Laszlo Puskas
s today. - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57147/#review167117 --- On Feb. 28, 2017, 6:01 p.m., Laszlo Puskas wrote:

Re: Review Request 57147: Added support for processing custom command script timeout

2017-03-02 Thread Laszlo Puskas
there will be no feedback about the success/failure of the command. - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57147/#review167547 ------- On Feb. 28, 2017, 6:01 p.m., Laszlo Puskas wrote

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-03-03 Thread Laszlo Puskas
ts running. Thanks, Laszlo Puskas

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-03-03 Thread Laszlo Puskas
ed on local unsecure cluster. Manually tested on local secure cluster Unit tests successfully ran. Thanks, Laszlo Puskas

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-03-03 Thread Laszlo Puskas
eviews.apache.org/r/57040/#review166728 --- On March 3, 2017, 8:52 a.m., Laszlo Puskas wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-03-03 Thread Laszlo Puskas
ng --- Manually tested on local unsecure cluster. Manually tested on local secure cluster Unit tests successfully ran. Thanks, Laszlo Puskas

Re: Review Request 57339: Server startup script keeps waiting even if DB consistency has failed

2017-03-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57339/#review167984 --- Ship it! Ship It! - Laszlo Puskas On March 6, 2017, 2:54

Re: Review Request 57324: HBase Master CPU Utilization Alert is in unknown state due to kinit error

2017-03-06 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57324/#review167985 --- Ship it! Ship It! - Laszlo Puskas On March 5, 2017, 9:38

Re: Review Request 57544: Atlas MetaData server start fails while granting permissions to HBase tables after unkerberizing the cluster

2017-03-14 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57544/#review168895 --- Ship it! Ship It! - Laszlo Puskas On March 12, 2017, 3:37

Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Laszlo Puskas
ators/ClusterConfigTypeValidatorTest.java PRE-CREATION Diff: https://reviews.apache.org/r/57733/diff/1/ Testing --- Manually tested on local environment. Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Laszlo Puskas
erver/topology/validators/ClusterConfigTypeValidatorTest.java PRE-CREATION Diff: https://reviews.apache.org/r/57733/diff/2/ Changes: https://reviews.apache.org/r/57733/diff/1-2/ Testing --- Manually tested on local environment. Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Laszlo Puskas
hanks, Laszlo Puskas

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Laszlo Puskas
/diff/2-3/ Testing --- Manually tested on local environment. Unit tests running. Thanks, Laszlo Puskas

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-17 Thread Laszlo Puskas
eeded. Thanks, Laszlo Puskas

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-18 Thread Laszlo Puskas
ually tested on local environment. Unit tests succeeded. Thanks, Laszlo Puskas

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-20 Thread Laszlo Puskas
e check. - Laszlo --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57733/#review169394 --- On March 18, 2017, 9:59 a.m., Laszlo Puskas w

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-20 Thread Laszlo Puskas
https://reviews.apache.org/r/57733/diff/5/ Changes: https://reviews.apache.org/r/57733/diff/4-5/ Testing --- Manually tested on local environment. Unit tests succeeded. Thanks, Laszlo Puskas

Re: Review Request 57770: Disabling security fails with AttributeError

2017-03-20 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57770/#review169414 --- Ship it! Ship It! - Laszlo Puskas On March 20, 2017, 9:07

Re: Review Request 57733: Configuration types are validated before the cluster resources are persisted.

2017-03-20 Thread Laszlo Puskas
57733/diff/5-6/ Testing --- Manually tested on local environment. Unit tests succeeded. Thanks, Laszlo Puskas

<    1   2   3   >