---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52785/#review152470
---
Ship it!
Ship It!
- Laszlo Puskas
On Oct. 12, 2016, 2:36
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52691/#review153397
---
Ship it!
Ship It!
- Laszlo Puskas
On Oct. 18, 2016, 6:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53135/#review153691
---
Ship it!
Ship It!
- Laszlo Puskas
On Oct. 24, 2016, 2:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53188/#review153881
---
Ship it!
Ship It!
- Laszlo Puskas
On Oct. 26, 2016, 2:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53228/#review154025
---
Ship it!
Ship It!
- Laszlo Puskas
On Oct. 27, 2016, 2:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53583/#review155423
---
Ship it!
Ship It!
- Laszlo Puskas
On Nov. 8, 2016, 7:09 p.m
er/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
(line 736)
<https://reviews.apache.org/r/53576/#comment225367>
Check the configuration for parallel execution here.
- Laszlo Puskas
On Nov. 9, 2016, 10:27 a.m., Attil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53778/#review155900
---
Ship it!
Ship It!
- Laszlo Puskas
On Nov. 15, 2016, 10:06
the location.
(validation of the location availability of the executable is underway)
Diffs
-
ambari-server/src/main/resources/scripts/post-user-creation-hook.sh 34169c1
Diff: https://reviews.apache.org/r/53779/diff/
Testing
---
Manually done on local env.
Thanks,
Laszlo Puskas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53810/#review156063
---
Ship it!
Ship It!
- Laszlo Puskas
On Nov. 16, 2016, 2:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54002/#review156745
---
Ship it!
Ship It!
- Laszlo Puskas
On Nov. 23, 2016, 3:27
,
Laszlo Puskas
/ViewRegistryTest.java
6b560ee
Diff: https://reviews.apache.org/r/54064/diff/
Testing
---
Manually done locally and cloud env.
Thanks,
Laszlo Puskas
=1570132#file1570132line1571>
> >
> > Indentation is +1 level than needed.
Formatted the whole class as it seemed the indentation was messed.
- Laszlo
---
This is an automatically generated e-mail. To r
/ViewRegistryTest.java
6b560ee
Diff: https://reviews.apache.org/r/54064/diff/
Testing
---
Manually done locally and cloud env.
Thanks,
Laszlo Puskas
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54064/#review156840
---
On Nov. 25, 2016, 9:17 a.m., Laszlo Puskas wrote:
>
> ---
>
Diff: https://reviews.apache.org/r/54318/diff/
Testing
---
Manually in progress.
Thanks,
Laszlo Puskas
/post-user-creation-hook.sh 34169c1
Diff: https://reviews.apache.org/r/54318/diff/
Testing (updated)
---
Successfully tested on local dev environment.
Thanks,
Laszlo Puskas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54364/#review157985
---
Ship it!
Ship It!
- Laszlo Puskas
On Dec. 5, 2016, 8:26 a.m
quicklinksprofile/Filter.java
(line 59)
<https://reviews.apache.org/r/54252/#comment229447>
Factories could leverage GUICE. We have examples on how to do that. (that
would reduce a bit the amount of the code :) )
- Laszlo Puskas
On Dec. 2, 2016, 2:10 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54612/#review158852
---
Ship it!
Ship It!
- Laszlo Puskas
On Dec. 9, 2016, 10:31
/ZkMigrator.java (line 31)
<https://reviews.apache.org/r/54698/#comment229909>
You could use the org.apache.commons.cli framework to handle the arguments.
(There are examples in the code base)
- Laszlo Puskas
On Dec. 13, 2016, 1:51 p.m., Attila Magyar
/DBAccessorImpl.java
(line 1186)
<https://reviews.apache.org/r/54743/#comment230254>
break is missing here; is that deliberately?
(i'd rathere repeat the block if the logic is the same)
- Laszlo Puskas
On Dec. 15, 2016, 8:55 a.m., Sebastian T
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54743/#review159286
---
Ship it!
Ship It!
- Laszlo Puskas
On Dec. 15, 2016, 8:55
ews.apache.org/r/54698/
> -------
>
> (Updated Dec. 15, 2016, 9:26 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Dmitro Lisnichenko, Jaimin
> Jetly, Laszlo Puskas, Oliver Szabo, Robert Levas, and Sebastian Toa
/ambari_server/setupActions.py 7ea0752
Diff: https://reviews.apache.org/r/54933/diff/
Testing
---
Manually.
(Unit tests need to be ran yet!)
Thanks,
Laszlo Puskas
Total failures:0
OK
Thanks,
Laszlo Puskas
errors:0
Total failures:0
OK
Thanks,
Laszlo Puskas
org/r/54933/#review159842
---
On Dec. 21, 2016, 1:05 p.m., Laszlo Puskas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&g
Total errors:0
Total failures:0
OK
Thanks,
Laszlo Puskas
support for these properties to be set from the command line
using the ambari-server command.
Usage:
ambari-server setup-kerberos
branch-2.5
commit f652f61e7bcd2eebe651d8cf96266d2b362bb578
Author: Laszlo Puskas
Date:?? Wed Dec 21 20:28:28 2016 +0100
trunk
commit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54939/#review160047
---
Ship it!
Ship It!
- Laszlo Puskas
On Dec. 21, 2016, 3:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55171/#review160498
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 4, 2017, 3:10 p.m
(These also could be managed with guice) Unit testing would be also easier.
- Laszlo Puskas
On Jan. 9, 2017, 3:07 p.m., Balázs Bence Sári wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55342/#review161236
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 9, 2017, 3:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55425/#review161242
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 11, 2017, 2:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55308/#review161540
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 11, 2017, 9:28
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55513/#review161720
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 13, 2017, 6:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55574/#review161782
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 16, 2017, 7:07
/DefaultTimeSource.java
(line 29)
<https://reviews.apache.org/r/55643/#comment233314>
Why is this abstarction needed? Couldn't we simply use Calendar instead?
- Laszlo Puskas
On Jan. 17, 2017, 9:30 p.m., Balázs Bence
r.acl - removed
* checked the hadoop-env.sh - doesn't contain the variable export
HADOOP_ZKFC_OPTS
Unit tests running.
Thanks,
Laszlo Puskas
* checked the configuration entry: ha.zookeeper.acl - removed
* checked the hadoop-env.sh - doesn't contain the variable export
HADOOP_ZKFC_OPTS
Unit tests running.
Thanks,
Laszlo Puskas
https://reviews.apache.org/r/55680/#review162123
-----------
On Jan. 18, 2017, 3:58 p.m., Laszlo Puskas wrote:
>
> ---
> This is an automatically generated e-ma
ew162125
-------
On Jan. 18, 2017, 3:58 p.m., Laszlo Puskas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55680
* checked the configuration entry: ha.zookeeper.acl - removed
* checked the hadoop-env.sh - doesn't contain the variable export
HADOOP_ZKFC_OPTS
Unit tests running.
Thanks,
Laszlo Puskas
d
* checked the hadoop-env.sh - doesn't contain the variable export
HADOOP_ZKFC_OPTS
Unit tests running.
Thanks,
Laszlo Puskas
contain the variable export
HADOOP_ZKFC_OPTS
Unit tests:
Successfully ran on local machine / unrelated test failed though.
Thanks,
Laszlo Puskas
ran on local machine / unrelated test failed though.
Thanks,
Laszlo Puskas
/hadoop-ha/mycluster/ActiveStandbyElectorLock)
Unit tests:
Running in progress for trunk
Thanks,
Laszlo Puskas
a
0e2e0d8
Diff: https://reviews.apache.org/r/55762/diff/
Testing
---
Manually.
Thanks,
Laszlo Puskas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55764/#review162439
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 20, 2017, 4:31
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55777/#review162460
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 20, 2017, 6:30
been added, the related guice
module hasn;t been set into the tool's injector.
The fix is to add the missing module to the db-cleanup tool's injector.
branch-2.5:
commit 8111ba662e849c27e4a9a04305b3ef2260c030e9
Author: Laszlo Puskas
Date:?? Fri Jan 20 19:18:10 2017 +0100
AMBARI-196
been added, the related guice
module hasn;t been set into the tool's injector.
The fix is to add the missing module to the db-cleanup tool's injector.
branch-2.5:
commit 8111ba662e849c27e4a9a04305b3ef2260c030e9
Author: Laszlo Puskas
Date:?? Fri Jan 20 19:18:10 2017 +0100
AMBARI-196
ted to
trunk:
commit a382bed7f55be632fd03e1b02bb8a01151234b24
Author: Laszlo Puskas
Date: Fri Jan 20 12:41:02 2017 +0100
AMBARI-19613. ZKFC Zookeper connection is not secure. (Laszlo Puskas via
stoader)
branch-2.5
commit 00b2c42ccf6fe68267483a645f6e57e9c921f01b
Author: Laszlo Puskas
Date: Fri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55833/#review162805
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 24, 2017, 1 p.m
r way.
Thanks,
Laszlo Puskas
ystem user (not root ...)
- opened the generated csv as the newlycreated user
Unit test created.
Thanks,
Laszlo Puskas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55983/#review163124
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 26, 2017, 1:31
/post-user-creation-hook.sh ee8d2d1
ambari-server/src/test/java/org/apache/ambari/server/hooks/users/UserHookServiceTest.java
293b22a
Diff: https://reviews.apache.org/r/55987/diff/
Testing
---
Unit tests running.
Manual testing underway
Thanks,
Laszlo Puskas
/users/PostUserCreationHookServerActionTest.java
f5cdf48
Diff: https://reviews.apache.org/r/55987/diff/
Testing
---
Unit tests running.
Manual testing underway
Thanks,
Laszlo Puskas
value is a bit problematic.
- Laszlo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55987/#review163162
---
On Jan. 2
/server/serveraction/users/PostUserCreationHookServerActionTest.java
f5cdf48
Diff: https://reviews.apache.org/r/55987/diff/
Testing
---
Unit tests running.
Manual testing underway
Thanks,
Laszlo Puskas
3b22a
ambari-server/src/test/java/org/apache/ambari/server/serveraction/users/PostUserCreationHookServerActionTest.java
f5cdf48
Diff: https://reviews.apache.org/r/55987/diff/
Testing
---
Unit tests running.
Manual testing underway
Thanks,
Laszlo Puskas
/PostUserCreationHookServerActionTest.java
f5cdf48
Diff: https://reviews.apache.org/r/55987/diff/
Testing
---
Unit tests running.
Manual testing underway
Thanks,
Laszlo Puskas
f5cdf48
Diff: https://reviews.apache.org/r/55987/diff/
Testing (updated)
---
Unit tests succeeded.
Manual testing underway
Thanks,
Laszlo Puskas
f5cdf48
Diff: https://reviews.apache.org/r/55987/diff/
Testing (updated)
---
Unit tests succeeded.
Manually tested changes.
Thanks,
Laszlo Puskas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56054/#review163430
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 29, 2017, 12:50
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56064/#review163483
---
Ship it!
Ship It!
- Laszlo Puskas
On Jan. 29, 2017, 8:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56175/#review163842
---
Ship it!
Ship It!
- Laszlo Puskas
On Feb. 1, 2017, 4:43 p.m
bari-server/src/main/resources/scripts/post-user-creation-hook.sh 91511a0
Diff: https://reviews.apache.org/r/56600/diff/
Testing
---
Manually, underway.
Thanks,
Laszlo Puskas
/UpgradeCatalog250Test.java
(line 1666)
<https://reviews.apache.org/r/56599/#comment237174>
Instead mocking tehe injector itself, add a module where instances are
bound to mocks.
- Laszlo Puskas
On Feb. 13, 2017, 1:48 p.m., Attila Magyar
> On Feb. 13, 2017, 3:08 p.m., Laszlo Puskas wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java,
> > line 1672
> > <https://reviews.apache.org/r/56599/diff/1/?file=1631931#file1631931line1672>
> >
> > In
> On Feb. 13, 2017, 3:08 p.m., Laszlo Puskas wrote:
> > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java,
> > line 1672
> > <https://reviews.apache.org/r/56599/diff/1/?file=1631931#file1631931line1672>
> >
> > In
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56713/#review165719
---
Ship it!
Ship It!
- Laszlo Puskas
On Feb. 15, 2017, 3:24
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56783/#review165942
---
Ship it!
Ship It!
- Laszlo Puskas
On Feb. 17, 2017, 3:16
r won't be notified
about the success/failure of the operation)
Diffs
-
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
123486e
Diff: https://reviews.apache.org/r/57040/diff/
Testing
---
Manually.
Unit tests running.
Thanks,
Laszlo Puskas
acks/2.0.6/HDFS/test_namenode.py fae500f
Diff: https://reviews.apache.org/r/57040/diff/
Testing (updated)
---
Manually.
Unit tests running...
Thanks,
Laszlo Puskas
f
Diff: https://reviews.apache.org/r/57040/diff/
Testing (updated)
---
Manually.
Unit tests success.
Thanks,
Laszlo Puskas
.
Thanks,
Laszlo Puskas
on with the command output we can't get information about the balancer.
- Laszlo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57147/#review167110
-------
s today.
- Laszlo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57147/#review167117
---
On Feb. 28, 2017, 6:01 p.m., Laszlo Puskas wrote:
there will be no feedback about the success/failure of the
command.
- Laszlo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57147/#review167547
-------
On Feb. 28, 2017, 6:01 p.m., Laszlo Puskas wrote
ts running.
Thanks,
Laszlo Puskas
ed on local unsecure cluster.
Manually tested on local secure cluster
Unit tests successfully ran.
Thanks,
Laszlo Puskas
eviews.apache.org/r/57040/#review166728
---
On March 3, 2017, 8:52 a.m., Laszlo Puskas wrote:
>
> ---
> This is an automatically generated e-mail. To re
ng
---
Manually tested on local unsecure cluster.
Manually tested on local secure cluster
Unit tests successfully ran.
Thanks,
Laszlo Puskas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57339/#review167984
---
Ship it!
Ship It!
- Laszlo Puskas
On March 6, 2017, 2:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57324/#review167985
---
Ship it!
Ship It!
- Laszlo Puskas
On March 5, 2017, 9:38
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57544/#review168895
---
Ship it!
Ship It!
- Laszlo Puskas
On March 12, 2017, 3:37
ators/ClusterConfigTypeValidatorTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/57733/diff/1/
Testing
---
Manually tested on local environment.
Unit tests running.
Thanks,
Laszlo Puskas
erver/topology/validators/ClusterConfigTypeValidatorTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/57733/diff/2/
Changes: https://reviews.apache.org/r/57733/diff/1-2/
Testing
---
Manually tested on local environment.
Unit tests running.
Thanks,
Laszlo Puskas
hanks,
Laszlo Puskas
/diff/2-3/
Testing
---
Manually tested on local environment.
Unit tests running.
Thanks,
Laszlo Puskas
eeded.
Thanks,
Laszlo Puskas
ually tested on local environment.
Unit tests succeeded.
Thanks,
Laszlo Puskas
e check.
- Laszlo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57733/#review169394
---
On March 18, 2017, 9:59 a.m., Laszlo Puskas w
https://reviews.apache.org/r/57733/diff/5/
Changes: https://reviews.apache.org/r/57733/diff/4-5/
Testing
---
Manually tested on local environment.
Unit tests succeeded.
Thanks,
Laszlo Puskas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57770/#review169414
---
Ship it!
Ship It!
- Laszlo Puskas
On March 20, 2017, 9:07
57733/diff/5-6/
Testing
---
Manually tested on local environment.
Unit tests succeeded.
Thanks,
Laszlo Puskas
101 - 200 of 273 matches
Mail list logo