ver/state/kerberos/KerberosServiceDescriptorTest.java
e1af515
Diff: https://reviews.apache.org/r/51713/diff/
Testing
---
unit tests, manually upgrades
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
e comment as above related to wording...
- Robert Levas
On Sept. 7, 2016, 1:18 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
NFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
NFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
eviews.apache.org/r/51713/#review148190
---
On Sept. 8, 2016, 11:09 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To re
mail. To reply, visit:
https://reviews.apache.org/r/51713/#review148199
---
On Sept. 8, 2016, 11:09 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-
ps://reviews.apache.org/r/51713/#review148190
-------
On Sept. 8, 2016, 11:09 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail.
cally generated e-mail. To reply, visit:
https://reviews.apache.org/r/51713/#review148190
-------
On Sept. 8, 2016, 11:09 a.m., Robert Levas wrote:
>
> ---
>
eviews.apache.org/r/51713/#review148193
---
On Sept. 8, 2016, 11:09 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To re
is is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51713/#review148193
---
On Sept. 8, 2016, 11:09 a.m., Robert Levas wrote:
>
> ---
> Thi
way
to know the versions explicity rather than asking the cluster object?
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51713/#review148193
---------
Wed Sep 07 22:51:30 EDT 2016
[INFO] Final Memory: 60M/1835M
[INFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
remove the "(if needed)" in text.
done.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51713/#review148190
-------
to DOWNGRADE.
> >
> > Doesn't that mean that this needs to check direction as well?
>
> Robert Levas wrote:
> On a downgrade (kicked off during the middle of the upgrade process), the
> previous and new versions appear to both the original version. Is t
> On Sept. 8, 2016, 12:06 p.m., Nate Cole wrote:
> > What will happen if, say, doing an Upgrade after this code has run, the
> > user decides to Downgrade? Will the old data be intact or does it get
> > overwritten?
>
> Robert Levas wrote:
> Looking at the
.apache.org/r/51713/#review148295
---
On Sept. 9, 2016, 9:42 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
NFO]
[INFO] Total time: 1:20:19.796s
[INFO] Finished at: Fri Sep 09 09:29:44 EDT 2016
[INFO] Final Memory: 62M/1882M
[INFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
NFO]
[INFO] Total time: 1:20:19.796s
[INFO] Finished at: Fri Sep 09 09:29:44 EDT 2016
[INFO] Final Memory: 62M/1882M
[INFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
KERBEROS and KERBEROS_SERVER as service/component then this
> > group should get skipped.
>
> Robert Levas wrote:
> Kerberos can be enabled and not require the KERBEROS services and the
> KERBEROS_CLIENT to be installed. In the manual case, they are not since we
>
erver/security/authentication/kerberos/AmbariKerberosAuthenticationPropertiesTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/51822/diff/
Testing
---
Manually tested...
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51818/#review148582
---
Ship it!
Ship It!
- Robert Levas
On Sept. 12, 2016, 3:13
[INFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
-test-patch/8643//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/8643//console
This message is automatically generated.
Thanks,
Robert Levas
and fail startup
> > on problems like this?
ok.. will fix.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51822/#review148699
---
s is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51822/#review148699
-------
On Sept. 13, 2016, 5 a.m., Robert Levas wrote:
>
> ---
> This is an automa
eply, visit:
https://reviews.apache.org/r/51822/#review148701
-------
On Sept. 13, 2016, 5 a.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51822/
&g
lly need to perform these operations?
- Robert Levas
On Sept. 13, 2016, 11:55 a.m., Balázs Bence Sári wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://rev
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/8643//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/8643//console
This message is automatically generated.
Thanks,
Robert Levas
results: PENDING
Thanks,
Robert Levas
er` class.
ambari-server/src/main/resources/webapp/WEB-INF/spring-security.xml (line 72)
<https://reviews.apache.org/r/51892/#comment216430>
This sets up the `AmbariAuthorizationFilter` and negates the need to inject
members. Therefore the code to invoke injection is removed from the
`Ambar
://builds.apache.org/job/Ambari-trunk-test-patch/8676//console
Thanks,
Robert Levas
/Ambari-trunk-test-patch/8676//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/8676//console
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51916/#review149079
---
Ship it!
Ship It!
- Robert Levas
On Sept. 15, 2016, 11:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51917/#review149080
---
Ship it!
Ship It!
- Robert Levas
On Sept. 15, 2016, 12:15
e 112)
<https://reviews.apache.org/r/51724/#comment217081>
The path to the SPNEGO keytab file and the SPNEGO principal name must not
be hard coded. There should be a relevant config property for this and it
should be set via the Kerberos descriptor.
- Robert Levas
On Sept. 8, 2016, 1:2
st/java/org/apache/ambari/server/security/authentication/kerberos/AmbariKerberosTicketValidatorTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/52068/diff/
Testing
---
Manual testing
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
cation.
- Robert Levas
On Sept. 19, 2016, 6:18 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
al Memory: 72M/692M
[INFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52068/#review149673
---
On Sept. 20, 2016, 10:41 a.m., Robert Levas wrote:
>
> ---
To reply, visit:
https://reviews.apache.org/r/52068/#review149684
-------
On Sept. 20, 2016, 10:41 a.m., Robert Levas wrote:
>
> ---
> This is an automatical
[INFO] Final Memory: 72M/692M
[INFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
d06aa1e
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
d97cd9a
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
c4e0a7c
Diff: https://reviews.apache.org/r/52163/diff/
Testing
---
Manually tested clean install and upgrade scenarios
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
eCatalog250Test.java
c4e0a7c
Diff: https://reviews.apache.org/r/52163/diff/
Testing
---
Manually tested clean install and upgrade scenarios
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
://reviews.apache.org/r/52170/diff/
Testing
---
Manually tested via Blueprint install.
Thanks,
Robert Levas
>
The file name should be `krberr.py` rather than `faked_kerberos.py`
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/spnego_kerberos_auth.py
(line 33)
<https://reviews.apache.org/r/51724/#comment217869>
See `curl_krb_request`
- Robert Levas
On Sept. 22,
.245s
[INFO] Finished at: Mon Sep 26 19:52:31 EDT 2016
[INFO] Final Memory: 67M/699M
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
/checks/SampleServiceCheck.java
(line 1)
<https://reviews.apache.org/r/52223/#comment218575>
Missing license header
- Robert Levas
On Sept. 23, 2016, 3:59 p.m., Tim Thorpe wrote:
>
> ---
> This is an automatically gener
, Skipped: 0, Time elapsed: 9.478 sec - in
org.apache.ambari.server.controller.internal.ConfigGroupResourceProviderTest
Results :
Tests run: 32, Failures: 0, Errors: 0, Skipped: 0
```
Thanks,
Robert Levas
---
>
> (Updated Sept. 28, 2016, 8:50 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, and Robert Levas.
>
>
> Bugs: AMBARI-18456
> https://issues.apache.org/jira/browse/AMBARI-18456
>
>
> Repository: ambari
>
>
>
> On Sept. 28, 2016, 9:54 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertServiceStateListener.java,
> > line 100
> > <https://reviews.apache.org/r/52345/diff/1/?file=1512284#file1512284line100>
&g
s.apache.org/r/52425/#comment219158>
Aren't the affectedClusters in this collection left with potentially
invalid data since they reference the old cluster instance?
- Robert Levas
On Sept. 30, 2016, 10:53 a.m., Jonathan Hurley wrote:
>
> --
[INFO]
```
# Jenkins test results: PENDING
Thanks,
Robert Levas
> On Sept. 30, 2016, 12:39 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java,
> > lines 1104-1110
> > <https://reviews.apache.org/r/52425/diff/1/?file=1516872#file1516872line1104>
> >
> >
n/Configuration.java
(line 2250)
<https://reviews.apache.org/r/52456/#comment219317>
"... for Ambari View requests."
- Robert Levas
On Sept. 30, 2016, 6:56 p.m., Sangeeta Ravindran wrote:
>
> ---
> This is an
e.org/job/Ambari-trunk-test-patch/8783//console
Thanks,
Robert Levas
://reviews.apache.org/r/52369/#comment219526>
group_type does not need to be that large.
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql (line 300)
<https://reviews.apache.org/r/52369/#comment219527>
group_type does not need to be that large.
Miss
> On Oct. 3, 2016, 4:17 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/GroupEntity.java,
> > lines 64-70
> > <https://reviews.apache.org/r/52369/diff/3/?file=1518897#file1518897line64>
> >
> > Is both
> On Oct. 3, 2016, 4:17 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java,
> > lines 955-960
> > <https://reviews.apache.org/r/52369/diff/3/?file=1518904#file1518904line955>
> >
> > ro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52500/#review151330
---
Ship it!
Ship It!
- Robert Levas
On Oct. 3, 2016, 11:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52500/#review151385
---
Ship it!
Ship It!
- Robert Levas
On Oct. 4, 2016, 4:14 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/#review151429
---
Ship it!
Ship It!
- Robert Levas
On Oct. 4, 2016, 6:40 p.m
? Was the latest
revision (3) a mistake?
- Robert Levas
On Oct. 5, 2016, 11:29 a.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52532/#review151543
---
Ship it!
Ship It!
- Robert Levas
On Oct. 5, 2016, 12:38 p.m
f: https://reviews.apache.org/r/52601/diff/
Testing
---
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
r.task.timeout` value should help there.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52601/#review151648
------
601/diff/
Testing
---
# Local test results: PENDING
# Jenkins test results: PENDING
Thanks,
Robert Levas
> On Oct. 3, 2016, 4:17 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java,
> > lines 955-960
> > <https://reviews.apache.org/r/52369/diff/3/?file=1518904#file1518904line955>
> >
> > ro
lable
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql (line 300)
<https://reviews.apache.org/r/52369/#comment220413>
group_type should be not nullable
- Robert Levas
On Oct. 3, 2016, 10:57 p.m., Vishal Ghugare wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52646/#review151866
---
Ship it!
Ship It!
- Robert Levas
On Oct. 7, 2016, 3:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52456/#review151944
---
Ship it!
Ship It!
- Robert Levas
On Oct. 4, 2016, 12:45 p.m
> On Oct. 9, 2016, 6:39 p.m., Robert Levas wrote:
> > Ship It!
>
> Sangeeta Ravindran wrote:
> Thank you Robert.
> Can you please help push the fix?
Pushed to trunk:
```
commit 34c5686c3a0f80a5c7b78ddf05bb41cb13202438
Author: Sangeeta Ravindran
Date: Mon Oct 1
/ambari/server/controller/KerberosHelperTest.java
b2eb738
Diff: https://reviews.apache.org/r/52749/diff/
Testing
---
Manually tested using the UI and BP ont he trunk and brach-2.5
# Jenkins test results: PENDING
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52709/#review152201
---
Ship it!
Ship It!
- Robert Levas
On Oct. 10, 2016, 7:21 p.m
/8847//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/8847//console
```
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52837/#review152650
---
Ship it!
Ship It!
- Robert Levas
On Oct. 13, 2016, 1:17 p.m
2691/#comment222047>
These should be `private` and possibly `private final`
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
(line 111)
<https://reviews.apache.org/r/52691/#comment222051>
Why is the length here 45 where the field in VARCHA
you fix?
- Robert Levas
On Oct. 13, 2016, 11:25 p.m., Vishal Ghugare wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
(line 267)
<https://reviews.apache.org/r/52930/#comment222066>
Missing Javadoc
- Robert Levas
On Oct. 17, 2016, 10:28 a.m., Dmytro Sen
/authorization/AmbariPamAuthenticationProvider.java
(line 161)
<https://reviews.apache.org/r/52369/#comment222680>
`AmbariPamAuthorization` should be `ambariPamAuthorization` - incorrect
name due to Ambari naming conventions.
- Robert Levas
On Oct. 17, 2016, 4:50 p.m., Vishal Ghugare
g/r/52369/#comment222685>
There should be a configuration option to allow the user to choose whether
groups should be automatically created or not.
- Robert Levas
On Oct. 17, 2016, 4:50 p.m., Vishal Ghugare wrote:
>
> ---
> Thi
> On Oct. 7, 2016, 1:55 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java,
> > line 817
> > <https://reviews.apache.org/r/52369/diff/4/?file=1519678#file1519678line817>
> >
> > Since th
nkins test results: PENDING
Thanks,
Robert Levas
> On Oct. 9, 2016, 6:39 p.m., Robert Levas wrote:
> > Ship It!
>
> Sangeeta Ravindran wrote:
> Thank you Robert.
> Can you please help push the fix?
>
> Robert Levas wrote:
> Pushed to trunk:
>
> ```
> commit 34c5686c3a0f80
like your accessment of this and protect against `null`. Thanks.
- Robert
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53060/#review153412
------
993M
[INFO]
# Jenkins test results: PENDING
Thanks,
Robert Levas
-----
On Oct. 20, 2016, 4:06 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53060/
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53068/#review153525
---
Ship it!
Ship It!
- Robert Levas
On Oct. 20, 2016, 1:02 p.m
> On Oct. 7, 2016, 1:55 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java,
> > line 817
> > <https://reviews.apache.org/r/52369/diff/4/?file=1519678#file1519678line817>
> >
> > Since th
> On Oct. 20, 2016, 9:36 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java,
> > lines 171-189
> > <https://reviews.apache.org/r/52369/diff/6/?file=1539952#file1539952line171>
> On Oct. 20, 2016, 9:36 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariPamAuthenticationProvider.java,
> > lines 171-189
> > <https://reviews.apache.org/r/52369/diff/6/?file=1539952#file1539952line171>
-
>
> (Updated Oct. 21, 2016, 10:19 a.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Robert Levas, and Sid Wagle.
>
>
> Bugs: AMBARI-14384
> https://issues.apache.org/jira/browse/AMBARI-14384
>
>
> Repository: ambari
>
>
> Des
r/src/test/python/TestAmbariServer.py 5746503
Diff: https://reviews.apache.org/r/53101/diff/
Testing
---
Thanks,
Robert Levas
E.sql 4922378
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f72b0ab
Diff: https://reviews.apache.org/r/53135/diff/
Testing
---
Manually created MySQL and PosgreSQL databases.
Thanks,
Robert Levas
ly created MySQL and PosgreSQL databases.
Thanks,
Robert Levas
/ldap/AmbariLdapDataPopulatorTest.java
34eadad
ambari-server/src/test/python/TestAmbariServer.py 5746503
Diff: https://reviews.apache.org/r/53101/diff/
Testing
---
Thanks,
Robert Levas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53142/#review153767
---
Ship it!
Ship It!
- Robert Levas
On Oct. 24, 2016, 1:16 p.m
ari_server/setupSecurity.py 119a7d8
ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java
34eadad
ambari-server/src/test/python/TestAmbariServer.py 5746503
Diff: https://reviews.apache.org/r/53101/diff/
Testing
---
Thanks,
Robert Levas
his is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53101/#review153703
---
On Oct. 25, 2016, 10:50 a.m., Robert Levas wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53185/#review153872
---
Ship it!
Ship It!
- Robert Levas
On Oct. 26, 2016, 8:19 a.m
ver/src/main/resources/upgrade-pack.xsd (line 77)
<https://reviews.apache.org/r/53251/#comment223636>
Shouldn't this be of type `security-type` from the definition above?
- Robert Levas
On Oct. 28, 2016, 10:18 a.m., Jonathan Hurley wrote:
>
> -
301 - 400 of 948 matches
Mail list logo
