Review Request 50450: API for bulk delete hostcomponent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50450/
---
Review request for Ambari, Alejandro Fernandez, Zhe (Joe) Wang, Nate Cole, and
Sumit Mohanty.
Bugs: AMBARI-18011
https://issues.apache.org/jira/browse/AMBARI-18011
Repository: ambari
Description
---
API for bulk delete hostcomponent.
This should do best effort to delete hostcomponents. Current implementation
fails fast in case of error.
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java
4990ad71c7dbd0d64ea7e817ace278aea8fe0f1d
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
5cf2de7b95939c9a55c5506988b2a6ba6801936c
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
075b85a806fc5de8552f605a858ad153d7e485c6
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
df2b476ee030e8de88300e04ecaf08f46cbcfc4d
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
3ad1f1fc7702b60d832e3819829ffd71c30e08f3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java
ef1b821ca05a563f0dbb3058877d335015bc6370
Diff: https://reviews.apache.org/r/50450/diff/
Testing
---
Unit test
Manual Test
delete http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/host_components
-d
'{"RequestInfo":{"query":"HostRoles/host_name.in(c6401.ambari.apache.org,c6402.ambari.apache.org)"}}'
Response : http://pastebin.com/GADF2ncH
Thanks,
Ajit Kumar
Re: Review Request 50666: AMBARI-10145 : Add support for tee to another Storage service?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50666/#review144370
---
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsAggregatorSink.java
(line 27)
<https://reviews.apache.org/r/50666/#comment210385>
Some documentation?
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsAggregatorSink.java
(line 29)
<https://reviews.apache.org/r/50666/#comment210384>
public keyword is not required in interfaces.
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TimelineMetricsAggregatorMemorySink.java
(line 37)
<https://reviews.apache.org/r/50666/#comment210379>
Any particular reason for having static block? Why not instantiated while
declaring the variable?
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TimelineMetricsAggregatorMemorySink.java
(line 38)
<https://reviews.apache.org/r/50666/#comment210378>
You don't need to add type.
hostAggregateRecords = new HashMap<>(); should work.
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TimelineMetricsAggregatorMemorySink.java
(line 47)
<https://reviews.apache.org/r/50666/#comment210383>
As per our coding convention formatting for if else block should be
if () {
} else {
}
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TimelineMetricsAggregatorMemorySink.java
(line 49)
<https://reviews.apache.org/r/50666/#comment210381>
Instead of storing hostAggregateMap, it should be copied and stored for
following reason:
- if hostAggregateMap is immutable, putAll in subsequent
saveHostAggregateRecords call will fail.
- Any add/delete operation on hostAggregateMap after calling
saveHostAggregateRecords will be impact hostAggregateRecords.
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TimelineMetricsAggregatorMemorySink.java
(line 59)
<https://reviews.apache.org/r/50666/#comment210382>
same here
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TimelineMetricsAggregatorMemorySink.java
(line 68)
<https://reviews.apache.org/r/50666/#comment210387>
Any reason why getters are not part of interface?
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/TimelineMetricsAggregatorMemorySink.java
(line 69)
<https://reviews.apache.org/r/50666/#comment210386>
Do you want to return copy or immutable map?
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessorTest.java
(line 256)
<https://reviews.apache.org/r/50666/#comment210380>
Map<TimelineClusterMetric, MetricClusterAggregate> clusterAggregateMap =
new HashMap<>();
- Ajit Kumar
On Aug. 1, 2016, 6:31 p.m., Jameel Mohamed wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50666/
> ---
>
> (Updated Aug. 1, 2016, 6:31 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-10145
> https://issues.apache.org/jira/browse/AMBARI-10145
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Added new Interface to drain aggregated metrics to external storage. Added
> unit test and sample implementation
> (TimelineMetricsAggregatorMemorySink.java) to store metrics in memory.
>
>
> Diffs
> -
>
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
> dfd730d
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
> e82d65a
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsAggregatorSink.java
> PRE-CREATION
>
> ambari-metrics/ambari-metrics-timelines
Review Request 50373: Fix xml KERBEROS/1.10.3-10/configuration/kerberos-env.xml
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50373/
---
Review request for Ambari, Andriy Babiichuk, Aleksandr Kovalenko, and Sumit
Mohanty.
Bugs: AMBARI-17867
https://issues.apache.org/jira/browse/AMBARI-17867
Repository: ambari
Description
---
Fix KERBEROS/1.10.3-10/configuration/kerberos-env.xml which has bad xml element
"host" at line number 89. This is breaking build
https://builds.apache.org/job/Ambari-trunk-Commit/5372
Unit test failing:
org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs
org.apache.ambari.server.AmbariException: File
/Users/ajit.kumar/workspace/ambari/ambari-server/target/test-classes/TestAmbaryServer.samples/../../../src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
didn't pass the validation. Error message is : cvc-complex-type.2.4.a: Invalid
content was found starting with element 'type'. One of '{maximum, minimum,
unit, delete, empty-value-valid, ui-only-property, read-only,
editable-only-at-install, show-property-name, increment-step, entries, hidden,
entries_editable, selection-cardinality, property-file-name,
property-file-type}' is expected.
at
org.apache.ambari.server.stack.StackManager.validateAllPropertyXmlsInFolderRecursively(StackManager.java:452)
at
org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs(ServicePropertiesTest.java:48)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:119)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
at
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
at
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
Diffs
-
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
0e219a4
Diff: https://reviews.apache.org/r/50373/diff/
Testing
---
Thanks,
Ajit Kumar
Review Request 50210: Add atlas.authentication.method.kerberos property to conf/atlas-application.properties
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50210/ --- Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit Mohanty. Bugs: AMBARI-17803 https://issues.apache.org/jira/browse/AMBARI-17803 Repository: ambari Description --- Add atlas.authentication.method.kerberos property to conf/atlas-application.properties for Hive, Storm, Falcon, Sqoop Diffs - ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py 947d441 Diff: https://reviews.apache.org/r/50210/diff/ Testing --- Tested manually with kerberized and unkerberized cluster. Unkerberized cluster: atlas.authentication.method.kerberos=False Kerberized cluster: atlas.authentication.method.kerberos=True Thanks, Ajit Kumar
Review Request 50159: HiveServer interactive stop should wait for 30 second before sending hard kill command
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50159/
---
Review request for Ambari, Jayush Luniya and Sumit Mohanty.
Bugs: AMBARI-17776
https://issues.apache.org/jira/browse/AMBARI-17776
Repository: ambari
Description
---
HiveServer interactive stop should wait for 30 second before sending hard kill
command
Diffs
-
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
1edcdca
ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 2a0674d
Diff: https://reviews.apache.org/r/50159/diff/
Testing
---
Manually tested.
2016-07-18 20:41:53,026 - Execute['! (ls /var/run/hive/hive-interactive.pid
>/dev/null 2>&1 && ps -p 541 >/dev/null 2>&1)'] {'tries': 10, 'try_sleep': 3}
2016-07-18 20:41:53,059 - Retrying after 3 seconds. Reason: Execution of '! (ls
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1)' returned 1.
2016-07-18 20:41:56,082 - Retrying after 3 seconds. Reason: Execution of '! (ls
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1)' returned 1.
2016-07-18 20:41:59,103 - Retrying after 3 seconds. Reason: Execution of '! (ls
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1)' returned 1.
2016-07-18 20:42:02,126 - Retrying after 3 seconds. Reason: Execution of '! (ls
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1)' returned 1.
2016-07-18 20:42:05,150 - Retrying after 3 seconds. Reason: Execution of '! (ls
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1)' returned 1.
2016-07-18 20:42:08,171 - Retrying after 3 seconds. Reason: Execution of '! (ls
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1)' returned 1.
2016-07-18 20:42:11,195 - Retrying after 3 seconds. Reason: Execution of '! (ls
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1)' returned 1.
2016-07-18 20:42:14,217 - Retrying after 3 seconds. Reason: Execution of '! (ls
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1)' returned 1.
2016-07-18 20:42:17,240 - Retrying after 3 seconds. Reason: Execution of '! (ls
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1)' returned 1.
2016-07-18 20:42:20,262 - Execute['ambari-sudo.sh kill -9 541'] {'not_if': '!
(ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1) '}
2016-07-18 20:42:20,298 - Execute['! (ls /var/run/hive/hive-interactive.pid
>/dev/null 2>&1 && ps -p 541 >/dev/null 2>&1)'] {'tries': 20, 'try_sleep': 3}
2016-07-18 20:42:20,316 - Retrying after 3 seconds. Reason: Execution of '! (ls
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null
2>&1)' returned 1.
2016-07-18 20:42:23,338 - File['/var/run/hive/hive-interactive.pid'] {'action':
['delete']}
2016-07-18 20:42:23,338 - Deleting File['/var/run/hive/hive-interactive.pid']
2016-07-18 20:42:23,338 - Stopping LLAP
Thanks,
Ajit Kumar
Re: Review Request 49691: Autoskip failure for blueprint deployment
Ambari Groovy Client .. SUCCESS [11.331s] [INFO] Ambari Shell .. SUCCESS [0.023s] [INFO] Ambari Python Shell ... SUCCESS [0.048s] [INFO] Ambari Groovy Shell ... SUCCESS [8.679s] [INFO] ambari-logsearch .. SUCCESS [0.143s] [INFO] Ambari Logsearch Appender . SUCCESS [0.145s] [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.935s] [INFO] Ambari Logsearch Portal ... SUCCESS [0.913s] [INFO] Ambari Logsearch Log Feeder ... SUCCESS [13.400s] [INFO] Ambari Logsearch Assembly . SUCCESS [0.086s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 1:09:54.830s [INFO] Finished at: Thu Jul 07 11:05:16 PDT 2016 [INFO] Final Memory: 121M/1001M [INFO] File Attachments blueprint.json https://reviews.apache.org/media/uploaded/files/2016/07/07/03db77b8-7fba-48c3-b34b-5dcb75e217b7__blueprint.json Thanks, Ajit Kumar
Re: Review Request 49691: Autoskip failure for blueprint deployment
> On July 8, 2016, 5:14 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java,
> > line 2464
> > <https://reviews.apache.org/r/49691/diff/2/?file=1438788#file1438788line2464>
> >
> > Move it out as a constant? Say in ExecutionCommand.java. Is
> > Setting.SETTING_NAME_SKIP_FAILURE accessble here?
Replaced "skip_failure" in AmbariManagementControllerImpl.java and
HostComponentResourceProvider.java with Setting.SETTING_NAME_SKIP_FAILURE.
- Ajit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49691/#review141244
-------
On July 7, 2016, 6:09 p.m., Ajit Kumar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49691/
> ---
>
> (Updated July 7, 2016, 6:09 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nahappan Somasundaram, and
> Sumit Mohanty.
>
>
> Bugs: AMBARI-17599
> https://issues.apache.org/jira/browse/AMBARI-17599
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Currently if a cluster deployment is scheduled and any install/start task
> fails, all other queued tasks are cancelled. Ideally it should be possible
> for user to pass a flag to skip failures for best effort deployment instead
> of failing fast on error.
>
> While creating a blueprint json, user can provide deployment settings as
> follows :
>
> "settings" : [
> {
> "deployment_settings" : [{
> "skip_failure" : "true"
>}]
> }
> ]
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> aaf69df
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
> 9d8389a
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
> de7f209
>
> ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
> c6279bc
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
> 926d253
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java
> 0edbaea
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
> aeb9a2d
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
> 3cdca4d
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
> cee9406
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
> a9c26cc
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
> 7ec6088
> ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java
> c03d833
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
> 714
>
> ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
> 0b06eb8
>
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterDeployWithHostsSyspreppedTest.java
> d49c21d
>
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
> ad441e4
>
> ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
> e979173
>
> ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java
> 5615d12
>
> Diff: https://reviews.apache.org/r/49691/diff/
>
>
> Testing
> ---
>
> Tested manually by creating a cluster with blueprint (attached). It has
> deployment_settings as follows
> "settings" : [
> {
> "deployment_settings" : [{
> "skip_failure" : "true"
>}]
> }
> ]
>
> mvn test
>
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [8.590s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.024s]
> [INFO] Ambari Web SUCCESS [37.028s]
> [INFO] Ambari Views .. SUCCESS [3.221s]
Re: Review Request 49691: Autoskip failure for blueprint deployment
SUCCESS [0.023s] [INFO] Ambari Python Shell ... SUCCESS [0.048s] [INFO] Ambari Groovy Shell ... SUCCESS [8.679s] [INFO] ambari-logsearch .. SUCCESS [0.143s] [INFO] Ambari Logsearch Appender . SUCCESS [0.145s] [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.935s] [INFO] Ambari Logsearch Portal ... SUCCESS [0.913s] [INFO] Ambari Logsearch Log Feeder ... SUCCESS [13.400s] [INFO] Ambari Logsearch Assembly . SUCCESS [0.086s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 1:09:54.830s [INFO] Finished at: Thu Jul 07 11:05:16 PDT 2016 [INFO] Final Memory: 121M/1001M [INFO] File Attachments blueprint.json https://reviews.apache.org/media/uploaded/files/2016/07/07/03db77b8-7fba-48c3-b34b-5dcb75e217b7__blueprint.json Thanks, Ajit Kumar
Review Request 49691: Autoskip failure for blueprint deployment
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49691/
---
Review request for Ambari, Alejandro Fernandez, Nahappan Somasundaram, and
Sumit Mohanty.
Bugs: AMBARI-17599
https://issues.apache.org/jira/browse/AMBARI-17599
Repository: ambari
Description
---
Currently if a cluster deployment is scheduled and any install/start task
fails, all other queued tasks are cancelled. Ideally it should be possible for
user to pass a flag to skip failures for best effort deployment instead of
failing fast on error.
While creating a blueprint json, user can provide deployment settings as
follows :
"settings" : [
{
"deployment_settings" : [{
"skip_failure" : "true"
}]
}
]
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
ba93d25
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java
9d8389a
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
46fc652
ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java
c6279bc
ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
849c696
ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java
0edbaea
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
aeb9a2d
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopology.java
3cdca4d
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterTopologyImpl.java
cee9406
ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java
00ecb98
ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java
7ec6088
ambari-server/src/main/java/org/apache/ambari/server/topology/Setting.java
c03d833
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
714
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
0b06eb8
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterInstallWithoutStartTest.java
0382b03
ambari-server/src/test/java/org/apache/ambari/server/topology/LogicalRequestTest.java
e979173
ambari-server/src/test/java/org/apache/ambari/server/topology/SettingTest.java
5615d12
Diff: https://reviews.apache.org/r/49691/diff/
Testing
---
Tested manually by creating a cluster with blueprint (attached). It has
deployment_settings as follows
"settings" : [
{
"deployment_settings" : [{
"skip_failure" : "true"
}]
}
]
File Attachments
blueprint.json
https://reviews.apache.org/media/uploaded/files/2016/07/07/03db77b8-7fba-48c3-b34b-5dcb75e217b7__blueprint.json
Thanks,
Ajit Kumar
Re: Review Request 48670: Return well formatted error response while deleting host with clients installed.
> On June 15, 2016, 9:23 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java,
> > line 930
> > <https://reviews.apache.org/r/48670/diff/1/?file=1417435#file1417435line930>
> >
> > I also talked to Sumit, we're not going to distinguish between clients
> > so any components should cause a failure.
Thanks. As we won't be differentiating b/w client and other components, this
patch will result in error message for clients as for other components. I'll
push this patch.
- Ajit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48670/#review137853
-------
On June 14, 2016, 12:29 a.m., Ajit Kumar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48670/
> ---
>
> (Updated June 14, 2016, 12:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit
> Mohanty.
>
>
> Bugs: AMBARI-17210
> https://issues.apache.org/jira/browse/AMBARI-17210
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Return well formatted error response while deleting host with clients
> installed.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
> 46fc65295f72bae39c534cd9684f2d76d1e30224
>
> Diff: https://reviews.apache.org/r/48670/diff/
>
>
> Testing
> ---
>
> Manual testing
>
> delete
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6403.ambari.apache.org
> {
> "status" : 500,
> "message" : "org.apache.ambari.server.controller.spi.SystemException: An
> internal system exception occurred: Cannot remove host
> c6403.ambari.apache.org from c1. The following roles exist, and these
> components must be stopped if running, and then deleted: HDFS_CLIENT,
> MAPREDUCE2_CLIENT, YARN_CLIENT, ZOOKEEPER_CLIENT"
> }
>
>
> Thanks,
>
> Ajit Kumar
>
>
Re: Review Request 48750: AMBARI-17150 : Ambari Metrics components packages do not have vendor before upgrade, but for new versions it appears
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48750/#review137834
---
Ship it!
Please make sure while building metrics, no other version of surefire is being
linked.
ambari-metrics/ambari-metrics-timelineservice/pom.xml (line 711)
<https://reviews.apache.org/r/48750/#comment203016>
As far as I remember, I had changed pom.version to project.version because
of a build warning. Can you please check if you are not getting any warning
because of this revert?
- Ajit Kumar
On June 15, 2016, 8:29 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48750/
> ---
>
> (Updated June 15, 2016, 8:29 p.m.)
>
>
> Review request for Ambari, Ajit Kumar, Dmytro Sen, Sumit Mohanty, and Sid
> Wagle.
>
>
> Bugs: AMBARI-17150
> https://issues.apache.org/jira/browse/AMBARI-17150
>
>
> Repository: ambari
>
>
> Description
> ---
>
> In December 2015 changes were made such that Ambari metrics project's parent
> is Ambari. This change was done to make sure the surefire plugin library is
> inherited.
>
> However, AMS pom.xml did not have any Vendor (organization) information, and
> hence it inherited from Ambari project ('Apache Software Foundation'). Hence,
> the released AMS packages have no Vendor and the new ones will have it thus
> causing upgrade command to fail
>
> suse1101:~ # zypper up ambari-metrics-hadoop-sink
> Loading repository data...
> Reading installed packages...
> There is an update candidate for 'ambari-metrics-hadoop-sink', but it is from
> different vendor. Use 'zypper install
> ambari-metrics-hadoop-sink-2.4.0.0-569.x86_64' to install this candidate.
> Resolving package dependencies...
> Nothing to do.
>
> Fix
> Remove the hierarchy and add surefire plugin dependency in Ambari metrics
> project.
>
> Related review board
> https://reviews.apache.org/r/41269
>
>
> Diffs
> -
>
> ambari-metrics/ambari-metrics-common/pom.xml af37d28
> ambari-metrics/ambari-metrics-timelineservice/pom.xml ed612cc
> ambari-metrics/pom.xml 36d817e
>
> Diff: https://reviews.apache.org/r/48750/diff/
>
>
> Testing
> ---
>
> mvn clean package
>
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [9.364s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.028s]
> [INFO] Ambari Web SUCCESS [24.758s]
> [INFO] Ambari Views .. SUCCESS [1.338s]
> [INFO] Ambari Admin View . SUCCESS [9.822s]
> [INFO] ambari-metrics SUCCESS [0.586s]
> [INFO] Ambari Metrics Common . SUCCESS [1.081s]
> [INFO] Ambari Metrics Hadoop Sink SUCCESS [0.955s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.453s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.562s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.389s]
> [INFO] Ambari Metrics Collector .. SUCCESS [2:17.967s]
> [INFO] Ambari Metrics Monitor SUCCESS [2.207s]
> [INFO] Ambari Metrics Grafana SUCCESS [54.849s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [2:22.821s]
> [INFO] Ambari Server . SUCCESS [1:31.407s]
> [INFO] Ambari Functional Tests ... SUCCESS [1.977s]
> [INFO] Ambari Agent .. SUCCESS [23.784s]
> [INFO] Ambari Client . SUCCESS [0.032s]
> [INFO] Ambari Python Client .. SUCCESS [0.618s]
> [INFO] Ambari Groovy Client .. SUCCESS [1.972s]
> [INFO] Ambari Shell .. SUCCESS [0.044s]
> [INFO] Ambari Python Shell ... SUCCESS [0.463s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.830s]
> [INFO] ambari-logsearch .. SUCCESS [0.233s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.316s]
> [INFO] Ambari Logsearch So
Re: Review Request 48670: Return well formatted error response while deleting host with clients installed.
> On June 14, 2016, 11:54 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java,
> > line 930
> > <https://reviews.apache.org/r/48670/diff/1/?file=1417435#file1417435line930>
> >
> > How is this a fix?
> > If a host has any masters, we shouldn't allow deleting it. Slaves must
> > be stopped. Clients can be in any state.
I had a discussion with Sumit and we aggreed on failing even for clients.
- Ajit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48670/#review137629
---
On June 14, 2016, 12:29 a.m., Ajit Kumar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48670/
> ---
>
> (Updated June 14, 2016, 12:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit
> Mohanty.
>
>
> Bugs: AMBARI-17210
> https://issues.apache.org/jira/browse/AMBARI-17210
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Return well formatted error response while deleting host with clients
> installed.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
> 46fc65295f72bae39c534cd9684f2d76d1e30224
>
> Diff: https://reviews.apache.org/r/48670/diff/
>
>
> Testing
> ---
>
> Manual testing
>
> delete
> http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6403.ambari.apache.org
> {
> "status" : 500,
> "message" : "org.apache.ambari.server.controller.spi.SystemException: An
> internal system exception occurred: Cannot remove host
> c6403.ambari.apache.org from c1. The following roles exist, and these
> components must be stopped if running, and then deleted: HDFS_CLIENT,
> MAPREDUCE2_CLIENT, YARN_CLIENT, ZOOKEEPER_CLIENT"
> }
>
>
> Thanks,
>
> Ajit Kumar
>
>
Review Request 48670: Return well formatted error response while deleting host with clients installed.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48670/
---
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit
Mohanty.
Bugs: AMBARI-17210
https://issues.apache.org/jira/browse/AMBARI-17210
Repository: ambari
Description
---
Return well formatted error response while deleting host with clients installed.
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
46fc65295f72bae39c534cd9684f2d76d1e30224
Diff: https://reviews.apache.org/r/48670/diff/
Testing
---
Manual testing
delete
http://c6401.ambari.apache.org:8080/api/v1/clusters/c1/hosts/c6403.ambari.apache.org
{
"status" : 500,
"message" : "org.apache.ambari.server.controller.spi.SystemException: An
internal system exception occurred: Cannot remove host c6403.ambari.apache.org
from c1. The following roles exist, and these components must be stopped if
running, and then deleted: HDFS_CLIENT, MAPREDUCE2_CLIENT, YARN_CLIENT,
ZOOKEEPER_CLIENT"
}
Thanks,
Ajit Kumar
Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/ --- (Updated May 31, 2016, 8:32 p.m.) Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. Changes --- Removed rca tables from *-CREATE.sql. Now cleanup runs as part of SchemaUpgradeHelper. Bugs: AMBARI-16692 https://issues.apache.org/jira/browse/AMBARI-16692 Repository: ambari Description --- RCA Database tables is not used anymore. This older, un-necessary data causes many Ambari DB queries to return more slowly than necessary. If the database gets large enough, it can have significant impact on the way ambari-server functions. The Ambari Server upgrade process should detect the presence of these older, deprecated tables, and automate the process of cleaning up this data. Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeHelper.java d4272ba3760d5e5e0100f104159565bc28df02e5 ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 31dd8f23e4410da7ce65d7c746fb6eb740ee8536 ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3c4f1caa5df407b1e4735238cd330db44f019271 ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f31af161b02fc44c398aa1371b639588b6c19c51 ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d1147b7d956c65992e78e2daacd8b94fab4fc082 ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 5a7a6a58978d347a8d3d68813e68866e489ce9b1 ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-DROP.sql a5380433131038abd15f1df05db8750e5e64ae0c ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 2dba3b70e1669bce368109ac89344d540640167d ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e769e5bd11230d8543ed82f80d4bb4be810b9385 ambari-server/src/main/resources/AmbariRCA-DML-Oracle-CLEANUP.sql 1f0f3c2b07a7d60be7c851b27dcde1777e5caa1f ambari-server/src/main/resources/AmbariRCA-DML-Postgres-CLEANUP.sql 3f07096ddf5e27b13ab0c8cd9dcc9e91ad500bee ambari-server/src/main/resources/upgrade/ddl/AmbariRCA-DDL-Oracle-UPGRADE.sql f4027683bc5a8fc7ba7973d6270fc5ff3c9a4d0f ambari-server/src/main/resources/upgrade/ddl/AmbariRCA-DDL-Postgres-UPGRADE.sql d9a7a758ab2a87d8d1ce8c8544926f7bb2a241e7 Diff: https://reviews.apache.org/r/43126/diff/ Testing (updated) --- manual testing Thanks, Ajit Kumar
Re: Review Request 46661: Put HBase master UI into readonly mode for secure deployment for HDP 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46661/ --- (Updated May 23, 2016, 9:08 p.m.) Review request for Ambari, Robert Levas, Sumit Mohanty, and Sid Wagle. Changes --- set hbase.master.ui.readonly to false when kerberos is disabled. Use cluster-env to check if kerberos is enabled. Bugs: AMBARI-16164 https://issues.apache.org/jira/browse/AMBARI-16164 Repository: ambari Description --- Currently in secure deployment, user can request compaction / splitting through hbase master UI. This potentially exposes vulnerability to various attacks. There is config parameter, hbase.master.ui.readonly, with default value of false. In secure deployment, Master UI should be put to readonly mode (setting the above parameter to true). Admin can always request compaction / splitting through hbase shell. Diffs (updated) - ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 689e1fd Diff: https://reviews.apache.org/r/46661/diff/ Testing --- Manual testing, sceenshot attached (after kerberizing cluster). File Attachments hbase-site.png https://reviews.apache.org/media/uploaded/files/2016/05/11/75e8d2ae-99a4-4e8d-8a69-52cd974734fb__hbase-site.png Thanks, Ajit Kumar
Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables
> On May 16, 2016, 9:47 p.m., Sid Wagle wrote: > > What about RCA tables not a part of Ambari DB ? Only postgres-embedded-create.sql has ambarirca db. Users who are facing this issue have stand alone DB server and don't use postgres-embedded. Ideally we should remove ambarirca db from postgres-embedded-create.sql as well. - Ajit --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/#review133450 --- On May 16, 2016, 9:28 p.m., Ajit Kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43126/ > --- > > (Updated May 16, 2016, 9:28 p.m.) > > > Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-16692 > https://issues.apache.org/jira/browse/AMBARI-16692 > > > Repository: ambari > > > Description > --- > > RCA Database tables is not used anymore. This older, un-necessary data causes > many Ambari DB queries to return more slowly than necessary. If the database > gets large enough, it can have significant impact on the way ambari-server > functions. > The Ambari Server upgrade process should detect the presence of these older, > deprecated tables, and automate the process of cleaning up this data. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 3547ad3 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > f36e640 > > Diff: https://reviews.apache.org/r/43126/diff/ > > > Testing > --- > > Unit test > > > Thanks, > > Ajit Kumar > >
Review Request 43126: Ambari Upgrade should clean older RCA Database tables
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43126/ --- Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-16692 https://issues.apache.org/jira/browse/AMBARI-16692 Repository: ambari Description --- RCA Database tables is not used anymore. This older, un-necessary data causes many Ambari DB queries to return more slowly than necessary. If the database gets large enough, it can have significant impact on the way ambari-server functions. The Ambari Server upgrade process should detect the presence of these older, deprecated tables, and automate the process of cleaning up this data. Diffs - ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java 3547ad3 ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java f36e640 Diff: https://reviews.apache.org/r/43126/diff/ Testing --- Unit test Thanks, Ajit Kumar
Re: Review Request 46962: Hive View and Pig View : one user overriding job details of other user in database
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46962/#review133376
---
Minor code formatting comments.
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
(line 305)
<https://reviews.apache.org/r/46962/#comment197732>
space after if
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
(line 309)
<https://reviews.apache.org/r/46962/#comment197729>
You can use Math.max as well
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
(line 312)
<https://reviews.apache.org/r/46962/#comment197734>
space after }, catch
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
(line 318)
<https://reviews.apache.org/r/46962/#comment197731>
Is maxId == 0 valid?
ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
(line 51)
<https://reviews.apache.org/r/46962/#comment197725>
No wild card imports.
ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
(line 414)
<https://reviews.apache.org/r/46962/#comment197724>
It is good practise to use {} even for 1 line if blocks.
space should be after if and not after (
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
(line 61)
<https://reviews.apache.org/r/46962/#comment197723>
Indexed newBean = (Indexed) BeanUtils.cloneBean(obj);
contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
(line 53)
<https://reviews.apache.org/r/46962/#comment197722>
Indexed newBean = (Indexed) BeanUtils.cloneBean(obj);
- Ajit Kumar
On May 16, 2016, 1:59 p.m., Nitiraj Rathore wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46962/
> ---
>
> (Updated May 16, 2016, 1:59 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav
> Nagar, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-16242
> https://issues.apache.org/jira/browse/AMBARI-16242
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Earlier :
> the id for dynamic entity was created in the application with the use of
> instance data for that view. This data is dependent on users and created
> separate sequences for each user. So the id for one user was also generated
> for other user. Hence the data in db of one user was getting overriden by
> other user.
>
> In this patch :
> Now the id is generated using table_sequence techique of JPA. table for
> sequence is ambari_sequence. UpgradeCatalog240.java will add the current
> sequence number for existing tables and for new table the sequence name will
> be added automatically. As sequence size of 50 is provided for better
> performances
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
> dc8d9b7
>
> ambari-server/src/main/java/org/apache/ambari/server/view/persistence/DataStoreImpl.java
> 0ed260d
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/persistence/DataStoreStorage.java
> 1e8f07f
>
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/JobService.java
> f7f883b
>
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/persistence/DataStoreStorage.java
> 7ae7721
>
> Diff: https://reviews.apache.org/r/46962/diff/
>
>
> Testing
> ---
>
> Following manual testing has been done.
> 1. upgrade script creates correct current sequences. Done by manually
> upgrading old ambari with existing views. Next job will allocate 50 more ids
> 2. for new tables the entry in ambari_sequence is automatically added and the
> ids will start from 1.
>
>
> Thanks,
>
> Nitiraj Rathore
>
>
Review Request 46661: Put HBase master UI into readonly mode for secure deployment for HDP 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46661/ --- Review request for Ambari, Robert Levas, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-16164 https://issues.apache.org/jira/browse/AMBARI-16164 Repository: ambari Description --- Currently in secure deployment, user can request compaction / splitting through hbase master UI. This potentially exposes vulnerability to various attacks. There is config parameter, hbase.master.ui.readonly, with default value of false. In secure deployment, Master UI should be put to readonly mode (setting the above parameter to true). Admin can always request compaction / splitting through hbase shell. Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 3d689d7dd4f9c5bd98d5d4e0152775fd7ea012a2 Diff: https://reviews.apache.org/r/46661/diff/ Testing --- Manual testing, sceenshot attached (after kerberizing cluster). File Attachments hbase-site.png https://reviews.apache.org/media/uploaded/files/2016/05/11/75e8d2ae-99a4-4e8d-8a69-52cd974734fb__hbase-site.png Thanks, Ajit Kumar
Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47142/#review132523 --- Ship it! Ship It! - Ajit Kumar On May 10, 2016, 7:56 p.m., Aravindan Vijayan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47142/ > --- > > (Updated May 10, 2016, 7:56 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-16412 > https://issues.apache.org/jira/browse/AMBARI-16412 > > > Repository: ambari > > > Description > --- > > Adding TopN support to AMS API > > Following are supported. > > 1. Top "N" hosts when 1 metric is requested for "H" hosts. > 2. Top "N" metrics when "M" metrics (or a pattern) are requested for 0 or 1 > hosts. > 3. When more than 20 hosts are requested, AMS defaults to Top N hosts > condition with N=20. > > > Diffs > - > > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TopNConfig.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java > 89c67d1 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java > a0ecbcc > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java > cf30e24 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java > ded64e3 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java > 632df3f > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/ConditionBuilder.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultCondition.java > 99a6125 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java > 6ee0006 > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java > PRE-CREATION > > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java > 4cfc415 > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java > 9c6617c > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestTimelineMetricStore.java > 16bbf0e > > ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcherTest.java > 277a98c > > Diff: https://reviews.apache.org/r/47142/diff/ > > > Testing > --- > > Manually tested. > Unit tests pass. > > > Thanks, > > Aravindan Vijayan > >
Re: Review Request 47142: AMBARI-16412 : Support TopN queries in AMS
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47142/#review132515
---
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/ConditionBuilder.java
(line 29)
<https://reviews.apache.org/r/47142/#comment196739>
private?
Any particular reason to choose List instead of collection?
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java
(line 27)
<https://reviews.apache.org/r/47142/#comment196740>
private?
Integer or int?
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java
(line 149)
<https://reviews.apache.org/r/47142/#comment196742>
CollectionsUtils.isNotEmpty
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java
(line 161)
<https://reviews.apache.org/r/47142/#comment196741>
CollectionsUtils.isEmpty
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java
(line 561)
<https://reviews.apache.org/r/47142/#comment196738>
new ArrayList<>();
or you can do Arrays.asList("h1", "h2", "h3", "h4");
- Ajit Kumar
On May 10, 2016, 6:41 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47142/
> ---
>
> (Updated May 10, 2016, 6:41 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
>
>
> Bugs: AMBARI-16412
> https://issues.apache.org/jira/browse/AMBARI-16412
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Adding TopN support to AMS API
>
> Following are supported.
>
> 1. Top "N" hosts when 1 metric is requested for "H" hosts.
> 2. Top "N" metrics when "M" metrics (or a pattern) are requested for 0 or 1
> hosts.
> 3. When more than 20 hosts are requested, AMS defaults to Top N hosts
> condition with N=20.
>
>
> Diffs
> -
>
>
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/TopNConfig.java
> PRE-CREATION
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
> 89c67d1
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
> a0ecbcc
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
> cf30e24
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStore.java
> ded64e3
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricStoreWatcher.java
> 632df3f
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/ConditionBuilder.java
> PRE-CREATION
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/DefaultCondition.java
> 99a6125
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/PhoenixTransactSQL.java
> 6ee0006
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/query/TopNCondition.java
> PRE-CREATION
>
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/webapp/TimelineWebServices.java
> 4cfc415
>
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TestPhoenixTransactSQL.java
> 9c6617c
>
> ambari-metrics/ambari-
Review Request 47086: Modifications in Hive Interactive configs should trigger only Hive Interactive restart.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47086/ --- Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle. Bugs: AMBARI-16297 https://issues.apache.org/jira/browse/AMBARI-16297 Repository: ambari Description --- Modifications in Hive Interactive configs should trigger only Hive Interactive restart. Diffs - ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml ff98f37fcc0d3bee574a1d373d7a28172c1e75be Diff: https://reviews.apache.org/r/47086/diff/ Testing --- Manual testing Thanks, Ajit Kumar
Re: Review Request 46944: AMBARI-16230: Sporadic errors when deploying the cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46944/#review131590 --- Ship it! Ship It! - Ajit Kumar On May 3, 2016, 7:36 p.m., Oliver Szabo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46944/ > --- > > (Updated May 3, 2016, 7:36 p.m.) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, and Sebastian > Toader. > > > Bugs: AMBARI-16230 > https://issues.apache.org/jira/browse/AMBARI-16230 > > > Repository: ambari > > > Description > --- > > 2 different type of errors can occur during adding any new service to Ambari: > > org.apache.ambari.server.AmbariException: Unable to create a default alert > group for unknown service in cluster > > org.apache.ambari.server.ServiceNotFoundException: Service not found, > clusterName=c1, serviceName= > > The reason is that: ServiceInstalledEvent can be handled quicker than > ServiceImpl.persist() can finish > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > 47342f3 > > Diff: https://reviews.apache.org/r/46944/diff/ > > > Testing > --- > > Unit Testing is in progress.. > FT: added new services about 10 times, has no any errors thrown. > > > Thanks, > > Oliver Szabo > >
Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46545/#review131542 --- Ship it! Ship It! - Ajit Kumar On May 3, 2016, 4:33 p.m., Nahappan Somasundaram wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46545/ > --- > > (Updated May 3, 2016, 4:33 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, > Jayush Luniya, and Sumit Mohanty. > > > Bugs: AMBARI-16029 > https://issues.apache.org/jira/browse/AMBARI-16029 > > > Repository: ambari > > > Description > --- > > AMBARI-16029: Ambari version history - Create DB table, constraints and > sequence id. > > ** Issue ** > In order to support tracking of ambari version, a DB table is required. > > ** Fix ** > Create ambari_operation_history table to store from version, to version, > install type, start and stop timestamps. > > > Diffs > - > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > 319afa579e6f5090588fb90fe619ee7b6bae6d78 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql > 9a20b8c05801f61a91a092afd4424173a94d7f17 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql > e1da7190d6fb929277c834b29cb537107d857bc3 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql > ab1eec42fcba467e0bae19674a7877c79eb77b8e > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > bd869f454ae7ec1c84a9cbd418875f10c023a0c2 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql > fdba489f2d0759e9c1282dfad38036f9bce3673d > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql > a1da8e5c8343ae554b4e95717cda085c7f79bc46 > > Diff: https://reviews.apache.org/r/46545/diff/ > > > Testing > --- > > ** 1. mvn clean install ** > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ... SUCCESS [5.113s] > [INFO] Apache Ambari Project POM . SUCCESS [0.038s] > [INFO] Ambari Web SUCCESS [26.897s] > [INFO] Ambari Views .. SUCCESS [1.400s] > [INFO] Ambari Admin View . SUCCESS [9.242s] > [INFO] ambari-metrics SUCCESS [0.346s] > [INFO] Ambari Metrics Common . SUCCESS [0.528s] > [INFO] Ambari Metrics Hadoop Sink SUCCESS [1.237s] > [INFO] Ambari Metrics Flume Sink . SUCCESS [0.566s] > [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.600s] > [INFO] Ambari Metrics Storm Sink . SUCCESS [1.531s] > [INFO] Ambari Metrics Collector .. SUCCESS [7.183s] > [INFO] Ambari Metrics Monitor SUCCESS [1.853s] > [INFO] Ambari Metrics Grafana SUCCESS [1.031s] > [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.252s] > [INFO] Ambari Server . SUCCESS [2:58.522s] > [INFO] Ambari Functional Tests ... SUCCESS [2.194s] > [INFO] Ambari Agent .. SUCCESS [25.339s] > [INFO] Ambari Client . SUCCESS [0.047s] > [INFO] Ambari Python Client .. SUCCESS [0.947s] > [INFO] Ambari Groovy Client .. SUCCESS [2.196s] > [INFO] Ambari Shell .. SUCCESS [0.038s] > [INFO] Ambari Python Shell ... SUCCESS [0.693s] > [INFO] Ambari Groovy Shell ... SUCCESS [0.907s] > [INFO] ambari-logsearch .. SUCCESS [0.253s] > [INFO] Ambari Logsearch Portal ... SUCCESS [7.069s] > [INFO] Ambari Logsearch Log Feeder ... SUCCESS [1.570s] > [INFO] Ambari Logsearch Appender . SUCCESS [0.190s] > [INFO] Ambari Logsearch Assembly . SUCCESS [0.079s] > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Tot
Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.
> On May 2, 2016, 9:44 p.m., Ajit Kumar wrote: > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql, line 837 > > <https://reviews.apache.org/r/46545/diff/2/?file=1369067#file1369067line837> > > > > Othere tables have start_time as the column name. It will be good to > > have the same name. > > Nahappan Somasundaram wrote: > Originally it was start_timestamp and stop_timestamp. One of the reviews > was end_timestamp made more sense; this meant that start_timestamp would > change to begin_timestamp. (Start<->Stop, Begin<->End). start time and end time should be fine. You can look at cluster version table for example. - Ajit --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46545/#review131379 --- On May 2, 2016, 9:24 p.m., Nahappan Somasundaram wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46545/ > --- > > (Updated May 2, 2016, 9:24 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, > Jayush Luniya, and Sumit Mohanty. > > > Bugs: AMBARI-16029 > https://issues.apache.org/jira/browse/AMBARI-16029 > > > Repository: ambari > > > Description > --- > > AMBARI-16029: Ambari version history - Create DB table, constraints and > sequence id. > > ** Issue ** > In order to support tracking of ambari version, a DB table is required. > > ** Fix ** > Create ambari_operation_history table to store from version, to version, > install type, start and stop timestamps. > > > Diffs > - > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > 319afa579e6f5090588fb90fe619ee7b6bae6d78 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql > 9a20b8c05801f61a91a092afd4424173a94d7f17 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql > e1da7190d6fb929277c834b29cb537107d857bc3 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql > ab1eec42fcba467e0bae19674a7877c79eb77b8e > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > bd869f454ae7ec1c84a9cbd418875f10c023a0c2 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql > fdba489f2d0759e9c1282dfad38036f9bce3673d > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql > a1da8e5c8343ae554b4e95717cda085c7f79bc46 > > Diff: https://reviews.apache.org/r/46545/diff/ > > > Testing > --- > > ** 1. mvn clean install ** > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ... SUCCESS [5.113s] > [INFO] Apache Ambari Project POM . SUCCESS [0.038s] > [INFO] Ambari Web SUCCESS [26.897s] > [INFO] Ambari Views .. SUCCESS [1.400s] > [INFO] Ambari Admin View . SUCCESS [9.242s] > [INFO] ambari-metrics SUCCESS [0.346s] > [INFO] Ambari Metrics Common . SUCCESS [0.528s] > [INFO] Ambari Metrics Hadoop Sink SUCCESS [1.237s] > [INFO] Ambari Metrics Flume Sink . SUCCESS [0.566s] > [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.600s] > [INFO] Ambari Metrics Storm Sink . SUCCESS [1.531s] > [INFO] Ambari Metrics Collector .. SUCCESS [7.183s] > [INFO] Ambari Metrics Monitor SUCCESS [1.853s] > [INFO] Ambari Metrics Grafana SUCCESS [1.031s] > [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.252s] > [INFO] Ambari Server . SUCCESS [2:58.522s] > [INFO] Ambari Functional Tests ... SUCCESS [2.194s] > [INFO] Ambari Agent .. SUCCESS [25.339s] > [INFO] Ambari Client . SUCCESS [0.047s] > [INFO] Ambari Python Client .. SUCCESS [0.947s] > [INFO] Ambari Groovy Client .. SUCCESS [2.196s] > [INFO] Ambari Shell .. SUCCESS [0.038s] > [INFO] Ambari Python Shell ... SUCCESS [0.693s] > [INFO] Ambari
Re: Review Request 46545: AMBARI-16029: Ambari version history - Create DB table, constraints and sequence id.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46545/#review131379 --- ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql (line 837) <https://reviews.apache.org/r/46545/#comment195329> Othere tables have start_time as the column name. It will be good to have the same name. ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql (line 856) <https://reviews.apache.org/r/46545/#comment195323> missed renaming this. - Ajit Kumar On May 2, 2016, 9:24 p.m., Nahappan Somasundaram wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46545/ > --- > > (Updated May 2, 2016, 9:24 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Ajit Kumar, Jonathan Hurley, > Jayush Luniya, and Sumit Mohanty. > > > Bugs: AMBARI-16029 > https://issues.apache.org/jira/browse/AMBARI-16029 > > > Repository: ambari > > > Description > --- > > AMBARI-16029: Ambari version history - Create DB table, constraints and > sequence id. > > ** Issue ** > In order to support tracking of ambari version, a DB table is required. > > ** Fix ** > Create ambari_operation_history table to store from version, to version, > install type, start and stop timestamps. > > > Diffs > - > > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql > 319afa579e6f5090588fb90fe619ee7b6bae6d78 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql > 9a20b8c05801f61a91a092afd4424173a94d7f17 > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql > e1da7190d6fb929277c834b29cb537107d857bc3 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql > ab1eec42fcba467e0bae19674a7877c79eb77b8e > ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql > bd869f454ae7ec1c84a9cbd418875f10c023a0c2 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql > fdba489f2d0759e9c1282dfad38036f9bce3673d > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql > a1da8e5c8343ae554b4e95717cda085c7f79bc46 > > Diff: https://reviews.apache.org/r/46545/diff/ > > > Testing > --- > > ** 1. mvn clean install ** > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ... SUCCESS [5.113s] > [INFO] Apache Ambari Project POM . SUCCESS [0.038s] > [INFO] Ambari Web SUCCESS [26.897s] > [INFO] Ambari Views .. SUCCESS [1.400s] > [INFO] Ambari Admin View . SUCCESS [9.242s] > [INFO] ambari-metrics SUCCESS [0.346s] > [INFO] Ambari Metrics Common . SUCCESS [0.528s] > [INFO] Ambari Metrics Hadoop Sink SUCCESS [1.237s] > [INFO] Ambari Metrics Flume Sink . SUCCESS [0.566s] > [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.600s] > [INFO] Ambari Metrics Storm Sink . SUCCESS [1.531s] > [INFO] Ambari Metrics Collector .. SUCCESS [7.183s] > [INFO] Ambari Metrics Monitor SUCCESS [1.853s] > [INFO] Ambari Metrics Grafana SUCCESS [1.031s] > [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.252s] > [INFO] Ambari Server . SUCCESS [2:58.522s] > [INFO] Ambari Functional Tests ... SUCCESS [2.194s] > [INFO] Ambari Agent .. SUCCESS [25.339s] > [INFO] Ambari Client . SUCCESS [0.047s] > [INFO] Ambari Python Client .. SUCCESS [0.947s] > [INFO] Ambari Groovy Client .. SUCCESS [2.196s] > [INFO] Ambari Shell .. SUCCESS [0.038s] > [INFO] Ambari Python Shell ... SUCCESS [0.693s] > [INFO] Ambari Groovy Shell ... SUCCESS [0.907s] > [INFO] ambari-logsearch .. SUCCESS [0.253s] > [INFO] Ambari Logsearch Portal ... SUCCESS [7.069s] > [INFO] Ambari Logsearch Log Feeder ... SUC
Review Request 46750: Add dryrun API for host delete
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46750/
---
Review request for Ambari, Nahappan Somasundaram, Sumit Mohanty, and Sid Wagle.
Bugs: AMBARI-16145
https://issues.apache.org/jira/browse/AMBARI-16145
Repository: ambari
Description
---
API should be take dry_run directive and check if requested host can be deleted
w/o deleting the host and should return error if any, like host is not in
delete friendly state.
It should also support bulk delete format
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java
c9b0878
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
4dc47be
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java
1c91477
Diff: https://reviews.apache.org/r/46750/diff/
Testing
---
curl -i -X DELETE -u admin:admin -H 'X-Requested-By:ambari'
http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts/?dry_run=true -d
'{"RequestInfo":{"query":"Hosts/host_name.in(c6401.ambari.apache.org,c6402.ambari.apache.org)"}}'
{
"deleteResult" : [
{
"deleted" : {
"key" : "c6402.ambari.apache.org"
}
},
{
"error" : {
"key" : "c6401.ambari.apache.org",
"code" : 500,
"message" : "org.apache.ambari.server.AmbariException: Cannot remove
host c6401.ambari.apache.org from a. The following roles exist, and these
components must be stopped if running, and then deleted: ZOOKEEPER_SERVER"
}
}
]
}
curl -i -X DELETE -u admin:admin -H 'X-Requested-By:ambari'
'http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts/?dry_run=true/host_name=c6401.ambari.apache.org'
{
"status" : 500,
"message" : "org.apache.ambari.server.controller.spi.SystemException: An
internal system exception occurred: Cannot remove host c6401.ambari.apache.org
from a. The following roles exist, and these components must be stopped if
running, and then deleted: ZOOKEEPER_SERVER"
}
curl -i -X DELETE -u admin:admin -H 'X-Requested-By:ambari'
'http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts/?dry_run=true/host_name=c6402.ambari.apache.org'
200 OK
Thanks,
Ajit Kumar
Review Request 46748: Add getDeleteDirectives to org.apache.ambari.server.api.resources.ResourceDefinition
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46748/ --- Review request for Ambari, Jayush Luniya, Robert Levas, and Sumit Mohanty. Bugs: AMBARI-16142 https://issues.apache.org/jira/browse/AMBARI-16142 Repository: ambari Description --- Add delete directive to RequestDefinition and handle it in Delete requests. It will be useful for usecases like dry run Diffs - ambari-server/src/main/java/org/apache/ambari/server/api/resources/BaseResourceDefinition.java c8bf87d ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceDefinition.java f98379c ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseRequest.java 88b8170 ambari-server/src/main/java/org/apache/ambari/server/api/services/RequestFactory.java e12cb42 ambari-server/src/test/java/org/apache/ambari/server/api/services/BaseRequestTest.java d4affea ambari-server/src/test/java/org/apache/ambari/server/api/services/RequestFactoryTest.java 0ef4312 ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/AuditEventCreatorTestHelper.java 29bd8e9 Diff: https://reviews.apache.org/r/46748/diff/ Testing --- Unit tests. Thanks, Ajit Kumar
Review Request 45592: Fix bad entry in hbase-env.sh that were added as part of 2.2.0-2.2.1.1 upgrade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45592/
---
Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Sumit
Mohanty.
Bugs: AMBARI-16001
https://issues.apache.org/jira/browse/AMBARI-16001
Repository: ambari
Description
---
Ambari upgrades, 2.2.0-2.2.1.1 adds a bad entry to the hbase-env
{code}export HBASE_OPTS="-Djava.io.tmpdir={{java_io_tmpdir}}\""{code}
With broken hbase-env user cannot run any mapreduce services for hbase.
Currently it needs to be fixed manually.
{code}
export HBASE_OPTS="${HBASE_OPTS} -Djava.io.tmpdir={{java_io_tmpdir}}"
{code}
It will be good if just upgrading to 2.2.2 fixes this issue rather than
mucking around with configs.
Diffs
-
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog222.java
f988a7a
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog222Test.java
f0158fd
Diff: https://reviews.apache.org/r/45592/diff/
Testing
---
Unit tests
Thanks,
Ajit Kumar
Re: Review Request 46353: AMBARI-15957: Ambari functional tests: Support auto start for service components
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46353/#review129593 --- Ship it! Ship It! - Ajit Kumar On April 19, 2016, 5:36 p.m., Nahappan Somasundaram wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46353/ > --- > > (Updated April 19, 2016, 5:36 p.m.) > > > Review request for Ambari, Ajit Kumar, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-15957 > https://issues.apache.org/jira/browse/AMBARI-15957 > > > Repository: ambari > > > Description > --- > > AMBARI-15957: Ambari functional tests: Support auto start for service > components > > ** Issue ** > Add *recovery_enabled* parameter to SetServiceComponentStateWebRequest > > > Diffs > - > > > ambari-funtest/src/test/java/org/apache/ambari/funtest/server/api/servicecomponent/SetServiceComponentStateWebRequest.java > f74fceaed1c189e92fec339456a52f71bb418d06 > > Diff: https://reviews.apache.org/r/46353/diff/ > > > Testing > --- > > ** 1. mvn clean install ** > > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 47 licence. > [INFO] > [INFO] --- maven-jar-plugin:2.3.2:jar (default-jar) @ ambari-funtest --- > [WARNING] JAR will be empty - no content was marked for inclusion! > [INFO] Building jar: > /Users/nsomasundaram/ambari/ambari-funtest/target/ambari-funtest-2.0.0.0-SNAPSHOT.jar > [INFO] > [INFO] --- maven-assembly-plugin:2.2-beta-5:single (make-assembly) @ > ambari-funtest --- > [INFO] Reading assembly descriptor: src/main/assemblies/empty.xml > [INFO] > [INFO] --- maven-assembly-plugin:2.2-beta-5:single (build-tarball) @ > ambari-funtest --- > [INFO] Reading assembly descriptor: src/main/assemblies/empty.xml > [INFO] > [INFO] --- maven-failsafe-plugin:2.19.1:verify (run-verify) @ ambari-funtest > --- > [INFO] Tests are skipped. > [INFO] > [INFO] --- maven-install-plugin:2.3.1:install (default-install) @ > ambari-funtest --- > [INFO] Installing > /Users/nsomasundaram/ambari/ambari-funtest/target/ambari-funtest-2.0.0.0-SNAPSHOT.jar > to > /Users/nsomasundaram/.m2/repository/org/apache/ambari/ambari-funtest/2.0.0.0-SNAPSHOT/ambari-funtest-2.0.0.0-SNAPSHOT.jar > [INFO] Installing /Users/nsomasundaram/ambari/ambari-funtest/pom.xml to > /Users/nsomasundaram/.m2/repository/org/apache/ambari/ambari-funtest/2.0.0.0-SNAPSHOT/ambari-funtest-2.0.0.0-SNAPSHOT.pom > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 5.157s > [INFO] Finished at: Mon Apr 18 20:48:57 PDT 2016 > [INFO] Final Memory: 38M/451M > [INFO] > > > ** 2. mvn verify ** > > --- > T E S T S > --- > Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m > -Djava.awt.headless=true > > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 3.586s > [INFO] Finished at: Mon Apr 18 21:00:27 PDT 2016 > [INFO] Final Memory: 22M/314M > [INFO] > > > > Thanks, > > Nahappan Somasundaram > >
Review Request 46172: Pass request object to delete API in resource providers
-server/src/test/java/org/apache/ambari/server/controller/internal/AmbariPrivilegeResourceProviderTest.java 98494d8 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ArtifactResourceProviderTest.java 33a228a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintResourceProviderTest.java 30e7c01 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java e2146d0 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterControllerImplTest.java 3f292ca ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterKerberosDescriptorResourceProviderTest.java 2d72cb0 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterPrivilegeResourceProviderTest.java bff15af ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterResourceProviderTest.java 7292be2 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ComponentResourceProviderTest.java 286b3cf ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java 5b9785e ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProviderTest.java 6f7db80 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/CredentialResourceProviderTest.java 31bf191 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/FeedResourceProviderTest.java 39a0509 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupPrivilegeResourceProviderTest.java 205f467 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/GroupResourceProviderTest.java 7d1bddf ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java a2e1fda ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostKerberosIdentityResourceProviderTest.java 1b1b4ac ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostResourceProviderTest.java c16013a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/InstanceResourceProviderTest.java 1a74ac3 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/LdapSyncEventResourceProviderTest.java 8a12c13 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/MemberResourceProviderTest.java 26a5cff ambari-server/src/test/java/org/apache/ambari/server/controller/internal/PermissionResourceProviderTest.java fb4454e ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProviderTest.java d07ed76 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java ea4afde ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestScheduleResourceProviderTest.java cb4d8aa ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RoleAuthorizationResourceProviderTest.java 23afa8f ambari-server/src/test/java/org/apache/ambari/server/controller/internal/SchemaImplTest.java 1c3d14a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java e113347 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/SettingResourceProviderTest.java c133220 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java 435587d ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TargetClusterResourceProviderTest.java 96c6db4 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/TaskResourceProviderTest.java 587febe ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserAuthorizationResourceProviderTest.java c19e5ad ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java 28a061c ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserResourceProviderTest.java 3dd4ad2 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java b384b8a ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetLayoutResourceProviderTest.java 2f05402 ambari-server/src/test/java/org/apache/ambari/server/controller/internal/WidgetResourceProviderTest.java 8192f38 Diff: https://reviews.apache.org/r/46172/diff/ Testing --- Unit tests Thanks, Ajit Kumar
Re: Review Request 46169: Add dryrun method on request object
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46169/
---
(Updated April 14, 2016, 2:30 p.m.)
Review request for Ambari, Jayush Luniya, Nate Cole, and Sumit Mohanty.
Changes
---
Renamed variable and fixed unit tests.
Bugs: AMBARI-15870
https://issues.apache.org/jira/browse/AMBARI-15870
Repository: ambari
Description
---
To implement dry-run version of an API, request needs to be parsed manually to
figure out if request has dry-run directive.
It will be good to add a method on Request object method itself which
centralizes parsing and logic for figuring out dry-run directive
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/api/resources/VersionDefinitionResourceDefinition.java
12b91e3
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestImpl.java
f27f621
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java
f8f8290
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Request.java
50eed9a
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestImplTest.java
93fe36f
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
ea4afde
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
633815e
Diff: https://reviews.apache.org/r/46169/diff/
Testing (updated)
---
Hadoop QA commented on AMBARI-15870:
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12798670/rb46169.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/6435//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/6435//console
Thanks,
Ajit Kumar
Re: Review Request 43927: Add support for bulk delete host API
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43927/
---
(Updated April 12, 2016, 6:37 p.m.)
Review request for Ambari, Alejandro Fernandez, Zhe (Joe) Wang, Nate Cole,
Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-15847
https://issues.apache.org/jira/browse/AMBARI-15847
Repository: ambari
Description (updated)
---
Currently if anyone has to delete more than 1 host, a script is required to
call delete host api in a loop for each host. This api takes in query and
instead of failing fast on the first error, puts the best effort to delete all
requested hosts. Response is a json object which has deleted keys and keys
which failed to delete with exception.
As there is a json response, it will always return 200 OK. It is backward
compatible, for request with only one host it won't return json object and will
return error code in case of exception instead of 200 OK.
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/api/services/HostService.java
c54d30f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
322eab8
Diff: https://reviews.apache.org/r/43927/diff/
Testing (updated)
---
Tested different usecases including backward compatibility:
{code}
curl -u admin:admin -H 'X-Requested-By: ambari' -X DELETE
http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts/c6401.ambari.apache.org
{
"status" : 500,
"message" : "org.apache.ambari.server.controller.spi.SystemException: An
internal system exception occurred: Cannot remove host c6401.ambari.apache.org
from a. The following roles exist, and these components must be stopped if
running, and then deleted: ZOOKEEPER_SERVER"
}
curl -u admin:admin -H 'X-Requested-By: ambari' -X DELETE
http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts -d
'{"RequestInfo":{"query":"Hosts/host_name.in(c6401.ambari.apache.org,c6402.ambari.apache.org)"}}'
{
"deleteResult" : [
{
"error" : {
"key" : "c6402.ambari.apache.org",
"code" : 404,
"message" : "org.apache.ambari.server.HostNotFoundException: Host not
found, hostname=c6402.ambari.apache.org"
}
},
{
"error" : {
"key" : "c6401.ambari.apache.org",
"code" : 500,
"message" : "org.apache.ambari.server.AmbariException: Cannot remove
host c6401.ambari.apache.org from a. The following roles exist, and these
components must be stopped if running, and then deleted: ZOOKEEPER_SERVER"
}
}
]
}
curl -u admin:admin -H 'X-Requested-By: ambari' -X DELETE
http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts -d
'{"RequestInfo":{"query":"Hosts/host_name.in(c6401.ambari.apache.org,c6402.ambari.apache.org)"}}'
{
"deleteResult" : [
{
"deleted" : {
"key" : "c6402.ambari.apache.org"
}
},
{
"error" : {
"key" : "c6401.ambari.apache.org",
"code" : 500,
"message" : "org.apache.ambari.server.AmbariException: Cannot remove
host c6401.ambari.apache.org from a. The following roles exist, and these
components must be stopped if running, and then deleted: ZOOKEEPER_SERVER"
}
}
]
}
{code}
Thanks,
Ajit Kumar
Re: Review Request 43926: Frameworks support for bulk delete API
> On April 12, 2016, 3:41 p.m., Nate Cole wrote:
> > What is the status of this review?
It is ready for review now.
- Ajit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43926/#review128436
---
On April 12, 2016, 6:33 p.m., Ajit Kumar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43926/
> ---
>
> (Updated April 12, 2016, 6:33 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Zhe (Joe) Wang, Nate Cole,
> Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-15150
> https://issues.apache.org/jira/browse/AMBARI-15150
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Currently DELETE API only returns status code and no body. This doesn't fit
> well in bulk delete scenario as user needs to know which keys were deleted
> and which one failed and why. For this, ResourceProvider needs to return
> metadata as part of RequestStatus object which can be translated to metadata
> for Result object at API layer.
>
> At API layer, for all failed keys, reason code (like 404) is required which
> will make scripting easy instead of just including error message as string.
> API response for bulk delete
> {code}
> curl -u admin:admin -H 'X-Requested-By: ambari' -X DELETE
> http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts -d
> '{"RequestInfo":{"query":"Hosts/host_name.in(c6401.ambari.apache.org,c6402.ambari.apache.org)"}}'
> {
> "deleteResult" : [
> {
> "deleted" : {
> "key" : "c6402.ambari.apache.org"
> }
> },
> {
> "error" : {
> "key" : "c6401.ambari.apache.org",
> "code" : 500,
> "message" : "org.apache.ambari.server.AmbariException: Cannot remove
> host c6401.ambari.apache.org from a. The following roles exist, and these
> components must be stopped if running, and then deleted: ZOOKEEPER_SERVER"
> }
> }
> ]
> }
> {code}
>
>
> Sample code for how each resource provider can set metadata for delete
> https://reviews.apache.org/r/43927/.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/BaseManagementHandler.java
> c34f0d7
>
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java
> 691a3ee
>
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/DeleteHandler.java
> 8580196
>
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/QueryCreateHandler.java
> 534ee7b
>
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/UpdateHandler.java
> bb66fae
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/DeleteResultMetadata.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java
> fabab62
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultImpl.java
> adcbde1
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultMetadata.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/serializers/JsonSerializer.java
> c17f162
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
> ac9935d
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DeleteStatusMetaData.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStatusImpl.java
> b0fde8a
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/RequestStatus.java
> f9847a9
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/RequestStatusMetaData.java
> PRE-CREATION
>
> ambari-server/src/test/java/org/apache/ambari/server/api/handlers/DeleteHandlerTest.java
> fb70be6
>
> ambari-server/src/test/java/org/apache/ambari/server/api/services/DeleteResultMetaDataTest.java
> PRE-CREATION
>
> ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java
> d854dcf
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/DeleteStatusMetaDataTest.java
> PRE-CREATION
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestStatusImplTest.java
> cd61822
>
> Diff: https://reviews.apache.org/r/43926/diff/
>
>
> Testing
> ---
>
> manual testing
> Unit test
>
>
> Thanks,
>
> Ajit Kumar
>
>
Re: Review Request 43926: Frameworks support for bulk delete API
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43926/
---
(Updated April 12, 2016, 6:33 p.m.)
Review request for Ambari, Alejandro Fernandez, Zhe (Joe) Wang, Nate Cole,
Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-15150
https://issues.apache.org/jira/browse/AMBARI-15150
Repository: ambari
Description (updated)
---
Currently DELETE API only returns status code and no body. This doesn't fit
well in bulk delete scenario as user needs to know which keys were deleted and
which one failed and why. For this, ResourceProvider needs to return metadata
as part of RequestStatus object which can be translated to metadata for Result
object at API layer.
At API layer, for all failed keys, reason code (like 404) is required which
will make scripting easy instead of just including error message as string.
API response for bulk delete
{code}
curl -u admin:admin -H 'X-Requested-By: ambari' -X DELETE
http://c6401.ambari.apache.org:8080/api/v1/clusters/a/hosts -d
'{"RequestInfo":{"query":"Hosts/host_name.in(c6401.ambari.apache.org,c6402.ambari.apache.org)"}}'
{
"deleteResult" : [
{
"deleted" : {
"key" : "c6402.ambari.apache.org"
}
},
{
"error" : {
"key" : "c6401.ambari.apache.org",
"code" : 500,
"message" : "org.apache.ambari.server.AmbariException: Cannot remove
host c6401.ambari.apache.org from a. The following roles exist, and these
components must be stopped if running, and then deleted: ZOOKEEPER_SERVER"
}
}
]
}
{code}
Sample code for how each resource provider can set metadata for delete
https://reviews.apache.org/r/43927/.
Diffs (updated)
-
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/BaseManagementHandler.java
c34f0d7
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/CreateHandler.java
691a3ee
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/DeleteHandler.java
8580196
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/QueryCreateHandler.java
534ee7b
ambari-server/src/main/java/org/apache/ambari/server/api/handlers/UpdateHandler.java
bb66fae
ambari-server/src/main/java/org/apache/ambari/server/api/services/DeleteResultMetadata.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/Result.java
fabab62
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultImpl.java
adcbde1
ambari-server/src/main/java/org/apache/ambari/server/api/services/ResultMetadata.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/serializers/JsonSerializer.java
c17f162
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractResourceProvider.java
ac9935d
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DeleteStatusMetaData.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestStatusImpl.java
b0fde8a
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/RequestStatus.java
f9847a9
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/RequestStatusMetaData.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/handlers/DeleteHandlerTest.java
fb70be6
ambari-server/src/test/java/org/apache/ambari/server/api/services/DeleteResultMetaDataTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/api/services/serializers/JsonSerializerTest.java
d854dcf
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/DeleteStatusMetaDataTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestStatusImplTest.java
cd61822
Diff: https://reviews.apache.org/r/43926/diff/
Testing (updated)
---
manual testing
Unit test
Thanks,
Ajit Kumar
Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45347/#review125933
---
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
(line 185)
<https://reviews.apache.org/r/45347/#comment188862>
Use foreach loop instead of iterator.
If possible, move common logic to a method.
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
(line 189)
<https://reviews.apache.org/r/45347/#comment188865>
return
Boolean.parseBoolean(setting.get(Settings.SETTING_NAME_RECOVERY_ENABLED)); ?
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
(line 211)
<https://reviews.apache.org/r/45347/#comment188861>
Do we need to add if condition on cluster name similiar to
servicename/componentname in code block above?
ambari-server/src/main/java/org/apache/ambari/server/topology/Settings.java
(line 72)
<https://reviews.apache.org/r/45347/#comment188864>
retun Collections.emptySet()
- Ajit Kumar
On March 29, 2016, 6:44 p.m., Nahappan Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45347/
> ---
>
> (Updated March 29, 2016, 6:44 p.m.)
>
>
> Review request for Ambari, Ajit Kumar, Jonathan Hurley, Nate Cole, Sumit
> Mohanty, Sebastian Toader, and Sid Wagle.
>
>
> Bugs: AMBARI-15592
> https://issues.apache.org/jira/browse/AMBARI-15592
>
>
> Repository: ambari
>
>
> Description
> ---
>
> AMBARI-15592: Auto-start services - support blueprint deployment.
>
> ** Issue: **
> Define a JSON structure to specify settings for auto start in a blueprint and
> use that information to enable or disable auto start for components during
> deployment.
>
> ** Changes **
> Added a new section in the blueprint called "settings" which is a collection
> of various setting names to collection of properties. For auto start, the
> following setting names are used:
> *recovery_settings*: {"recovery_enabled" : "true" } specifies that auto start
> should be enabled for all components. Can also be specified within a
> collection, to support a uniform schema.
> *service_settings*: Collection of service names and the recovery values.
> [{"name":"HDFS", "recovery_enabled":"false"},{...}] overrides cluster level
> recovery settings.
> *component_settings*: Collection of component names and the corresponding
> recovery values. [{"name":"HDFS_CLIENT", "recovery_enabled":"true"},{...}].
> Overrides both service settings and recovery settings.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
> 8578d6beca91bf411d0c3dafeaee42d2dd23caea
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntity.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
> a5e2fa1c7a2adaadc8bbe9de15b913cd9a7ca456
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java
> 11311dba0f1174248d24276a41837d7284e41607
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
> cca28ca1529d6bccdf7a870dab7c317c1a334b1d
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
> bea036421c64b70b4bceffcbd0d13c26020a7ed1
> ambari-server/src/main/java/org/apache/ambari/server/topology/Settings.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/SettingsFactory.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
> 38a3614ae3543ae1de0ea0bfd4191951c6d5c5ff
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> f8c97ca11040bff414626189591d86d4781be478
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
> b306c0ab7687c6fe05c818acefa2d063e5b111ed
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql
> 37744f8bc729e374a1db76f6509a6e85bffb37d0
> ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
> eba1745d8c7a3e1b677cb8b8fc33d9ae09d0cf68
> ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
> cad0a39d824fdbf03b1ec6cd2a99dec79fa916d2
> ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE
Re: Review Request 45347: AMBARI-15592: Auto-start services - support blueprint deployment.
> On March 29, 2016, 1:25 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java,
> > lines 116-119
> > <https://reviews.apache.org/r/45347/diff/3/?file=1317579#file1317579line116>
> >
> > I understand that blueprint names are unique, but at the same time,
> > this doesn't seem like the right approach for a hashCode/equals
> > implementation. It should be based off of the unique fields for this
> > entity, not just the blueprint name.
>
> Nahappan Somasundaram wrote:
> It is based on both blueprintName and settingName which form a unique
> combination:
> return 31 * blueprintName.hashCode() + settingName.hashCode();
>
> For example in BlueprintConfigEntityPK.java where blueprint name and
> config type form a unique combination:
> @Override
> public int hashCode() {
> return 31 * blueprintName.hashCode() + type.hashCode();
> }
>
> If there is a different way to generate the hash code, we can try that as
> well.
I like Objects.hash(...) api than manually computing.
- Ajit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45347/#review125872
---
On March 29, 2016, 5:47 p.m., Nahappan Somasundaram wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45347/
> -------
>
> (Updated March 29, 2016, 5:47 p.m.)
>
>
> Review request for Ambari, Ajit Kumar, Jonathan Hurley, Nate Cole, Sumit
> Mohanty, Sebastian Toader, and Sid Wagle.
>
>
> Bugs: AMBARI-15592
> https://issues.apache.org/jira/browse/AMBARI-15592
>
>
> Repository: ambari
>
>
> Description
> ---
>
> AMBARI-15592: Auto-start services - support blueprint deployment.
>
> ** Issue: **
> Define a JSON structure to specify settings for auto start in a blueprint and
> use that information to enable or disable auto start for components during
> deployment.
>
> ** Changes **
> Added a new section in the blueprint called "settings" which is a collection
> of various setting names to collection of properties. For auto start, the
> following setting names are used:
> *recovery_settings*: {"recovery_enabled" : "true" } specifies that auto start
> should be enabled for all components. Can also be specified within a
> collection, to support a uniform schema.
> *service_settings*: Collection of service names and the recovery values.
> [{"name":"HDFS", "recovery_enabled":"false"},{...}] overrides cluster level
> recovery settings.
> *component_settings*: Collection of component names and the corresponding
> recovery values. [{"name":"HDFS_CLIENT", "recovery_enabled":"true"},{...}].
> Overrides both service settings and recovery settings.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintEntity.java
> 8578d6beca91bf411d0c3dafeaee42d2dd23caea
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntity.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/BlueprintSettingsEntityPK.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
> a5e2fa1c7a2adaadc8bbe9de15b913cd9a7ca456
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/Blueprint.java
> 11311dba0f1174248d24276a41837d7284e41607
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintFactory.java
> cca28ca1529d6bccdf7a870dab7c317c1a334b1d
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintImpl.java
> bea036421c64b70b4bceffcbd0d13c26020a7ed1
> ambari-server/src/main/java/org/apache/ambari/server/topology/Settings.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/topology/SettingsFactory.java
> PRE-CREATION
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
> 38a3614ae3543ae1de0ea0bfd4191951c6d5c5ff
> ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql
> f8c97ca11040bff414626189591d86d4781be478
> ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql
> b306c0ab7687c6fe05c818acefa2d063e5b111ed
> ambari-server/src/mai
