> On April 20, 2017, 4:44 p.m., Oliver Szabo wrote:
> > Ship It!
>
> Keta Patel wrote:
> Thank you!
> Could you please help me with pushing in the change?
>
> Oliver Szabo wrote:
> thanks for the contribution.
>
g/r/58493/#review172467
---
On April 20, 2017, 4:43 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
-----
On April 20, 2017, 4:43 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58493/
>
he results of the logsearch tests after applying the patch are shown in the
screenshot "all_tests_successful.png" on the Jira.
Note: The description for testing has been updated by removing the aspect of
correcting the behavior for Ambari Administrator role for the Logsearch UI.
Thanks,
Keta Patel
TOR" property from the UI, it will not affect the Ambari
admin's accessibility to the Logsearch UI. Ambari Admins will always be allowed
to login.
The results of the logsearch tests after applying the patch are shown in the
screenshot "all_tests_successful.png" on the Jira.
Thanks,
Keta Patel
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58493/#review172211
---
On April 20, 2017, 11:07 a.m., Keta Patel wrote:
>
> ---
> This is an autom
property from the UI, it will not affect the Ambari
admin's accessibility to the Logsearch UI. Ambari Admins will always be allowed
to login.
The results of the logsearch tests after applying the patch are shown in the
screenshot "all_tests_successful.png" on the Jira.
Thanks,
Keta Patel
iew148187
---
On Sept. 7, 2016, 4:57 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
tch
https://reviews.apache.org/media/uploaded/files/2016/09/07/ca2655a2-7ad1-4af8-abee-b952b4040e4b__AMBARI-18071-Sep6.patch
Thanks,
Keta Patel
so
that the subsequent valid "submit" calls, on closing pop-up(s) can be
processed.
**TESTING:**
ambari-web unit tests affter applying the patch:
30182 tests complete (46 seconds)
151 tests pending
Also, did manual testing by adding a timeout in the submit() of
step4_controller.js to allow multiple clicks to be registered on the Next
button.
Thanks,
Keta Patel
troller.js to allow multiple clicks to be registered on the Next
button.
Thanks,
Keta Patel
I have done manual testing.
Log in as a user who is allowed to access encrypted zones.
Go to the Ambari View instance (with Local/Remote cluster configuration).
Open the encrypted zone folder and open an existing file in this directory.
The user can successfully preview the file without the "No KeyProvider
configured" error.
Thanks,
Keta Patel
it:
https://reviews.apache.org/r/49387/#review143428
---
On July 25, 2016, 8:47 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
sts:
29371 tests complete (43 seconds)
154 tests pending
File Attachments
AMBARI-17041-July21-ES6.patch
https://reviews.apache.org/media/uploaded/files/2016/07/21/866014d0-310d-4e05-8290-2f82de990824__AMBARI-17041-July21-ES6.patch
Thanks,
Keta Patel
] && attributes[0][FINAL][index]
> > === "true"
> >
> > You can skip cheking attributes[0][FINAL][index], just check
> > attributes[0][FINAL][index] === "true".
> >
> > If property "attributes[0][FINAL][index]&quo
views.apache.org/r/49912/#review142077
---
On July 11, 2016, 6:43 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
(42 seconds)
154 tests pending
**With the latest patch "AMBARI-17041-July21-updated.patch" the following is
the result of ambari-web tests:
29343 tests complete (55 seconds)
154 tests pending
File Attachments
AMBARI-17041-July21-ES6.patch
https://reviews.apache.org/media/uploaded/files/2016/07/21/866014d0-310d-4e05-8290-2f82de990824__AMBARI-17041-July21-ES6.patch
Thanks,
Keta Patel
b
tests are successful. Please let me know if I was making any mistake earlier or
if I could update the patch in some other way.
Thank you!
- Keta
---
This is an automatically generated e-mail. To reply, visit:
:
29292 tests complete (42 seconds)
154 tests pending
File Attachments (updated)
AMBARI-17041-July21-ES6.patch
https://reviews.apache.org/media/uploaded/files/2016/07/21/866014d0-310d-4e05-8290-2f82de990824__AMBARI-17041-July21-ES6.patch
Thanks,
Keta Patel
nding
With the new patch "AMBARI-17041-trunk-July13.patch" the following is the
result of ambari-web tests:
29021 tests complete (26 seconds)
154 tests pending
**With the new patch "AMBARI-17041-trunk-July20.patch" the following is the
result of ambari-web tests:
29292 tests complete (42 seconds)
154 tests pending
Thanks,
Keta Patel
ated the patch "AMBARI-17041-July20.patch" as per your suggestion.
Thank you!
- Keta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49387/#review142938
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49387/#review141391
---
On July 8, 2016, 9:15 p.m., Keta Patel wrote:
>
> ---
he fix required in
"configs_saver_test.js" to avoid test failure of existing tests.
If the proposed solution is acceptable, I will create a new patch with the
necessary new tests.
The existing ambari-web tests after applying the patch:
28977 tests complete (37 seconds)
154 tests pending
With the new latest patch "AMBARI-17041-trunk-July08.patch" the following is
result of ambari-web tests:
29017 tests complete (48 seconds)
154 tests pending
Thanks,
Keta Patel
g/r/49387/#review141280
---
On July 8, 2016, 9:05 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
esting
---
No new test cases are written in the patch apart from the fix required in
"configs_saver_test.js" to avoid test failure of existing tests.
If the proposed solution is acceptable, I will create a new patch with the
necessary new tests.
The existing ambari-web tests after applying the patch:
28977 tests complete (37 seconds)
154 tests pending
Thanks,
Keta Patel
failure of existing tests.
If the proposed solution is acceptable, I will create a new patch with the
necessary new tests.
The existing ambari-web tests after applying the patch:
28977 tests complete (37 seconds)
154 tests pending
Thanks,
Keta Patel
iew134858
---
On May 25, 2016, 5:48 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
e of a user/group is "VIEW.USER". If it is, then the
privilege returned is "CLUSTER.NONE", otherwise the calculated effective
privilege is returned.
I have attached the result of tests run for ambari-admin in the attachments
"ambari_admin_test_cases_before_fix.tiff" and
"ambari_admin_test_cases_after_fix.tiff" on the JIRA.
Thanks,
Keta Patel
> On May 13, 2016, 10:24 p.m., Richard Zang wrote:
> > Ship It!
>
> Keta Patel wrote:
> Thank you Richard!
> Could you please help me push in the changes.
Thank you Richard!
Committed to
Trunk:
https://github.com/apache/ambari/commit/e306c393d05ea3d6c28f004a452
g/r/46808/#review133219
---
On May 13, 2016, 5:29 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
RI-15552-May-13.patch".
Thank you!
- Keta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132985
-----
5552-May-11.patch
AMBARI-15552-May-12.patch
https://reviews.apache.org/media/uploaded/files/2016/05/12/53ad4716-1620-4e88-b191-5c950f0a10f2__AMBARI-15552-May-12.patch
AMBARI-15552-May-13.patch
https://reviews.apache.org/media/uploaded/files/2016/05/13/b9771a40-26dc-488e-baf0-a955295e50c8__AMBARI-15552-May-13.patch
Thanks,
Keta Patel
uploaded/files/2016/05/10/3103f74e-e4a5-4814-8539-cd82a842af88__AMBARI-15552-May-10.patch
AMBARI-15552-May-11.patch
https://reviews.apache.org/media/uploaded/files/2016/05/11/67e503d1-4c68-467d-a587-d0af24a2ff3d__AMBARI-15552-May-11.patch
AMBARI-15552-May-12.patch
https://reviews.apache.org/media/uploaded/files/2016/05/12/53ad4716-1620-4e88-b191-5c950f0a10f2__AMBARI-15552-May-12.patch
Thanks,
Keta Patel
are in mygroup. Change aaa to "cluster
> > administrator", confirm, then change aaa back to None, aaa stays at
> > "cluster administrator" because loadUser() happens before delete finishes.
>
> Keta Patel wrote:
> As per your suggestion, I have added
effective
privilege.
File Attachments (updated)
AMBARI-15552-May-05.patch
https://reviews.apache.org/media/uploaded/files/2016/05/05/18b572fb-d55b-470a-ab3e-64fb05165e35__AMBARI-15552-May-05.patch
AMBARI-15552-May-10.patch
https://reviews.apache.org/media/uploaded/files/2016/05/10/3103f74e-e4a5-4814-8539-cd82a842af88__AMBARI-15552-May-10.patch
AMBARI-15552-May-11.patch
https://reviews.apache.org/media/uploaded/files/2016/05/11/67e503d1-4c68-467d-a587-d0af24a2ff3d__AMBARI-15552-May-11.patch
Thanks,
Keta Patel
e group's effective
privilege.
File Attachments
AMBARI-15552-May-05.patch
https://reviews.apache.org/media/uploaded/files/2016/05/05/18b572fb-d55b-470a-ab3e-64fb05165e35__AMBARI-15552-May-05.patch
AMBARI-15552-May-10.patch
https://reviews.apache.org/media/uploaded/files/2016/05/10/3103f74e-e4a5-4814-8539-cd82a842af88__AMBARI-15552-May-10.patch
AMBARI-15552-May-11.patch
https://reviews.apache.org/media/uploaded/files/2016/05/11/67e503d1-4c68-467d-a587-d0af24a2ff3d__AMBARI-15552-May-11.patch
Thanks,
Keta Patel
body.
Thank you!
- Keta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132555
---
On May 10,
in the patch "AMBARI-15552-May-11.patch".
- Keta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46808/#review132558
---
On May 10, 2016, 7:49 p.m., Keta Patel wrote:
>
> ---
/05/d6d24e4f-f57d-40ff-bc31-31303c6c1d45__step6.tiff
step7.tiff
https://reviews.apache.org/media/uploaded/files/2016/05/05/07b36b93-804a-494d-93e5-66b45db85023__step7.tiff
AMBARI-15552-May-10.patch
https://reviews.apache.org/media/uploaded/files/2016/05/10/3103f74e-e4a5-4814-8539-cd82a842af88__AMBARI-15552-May-10.patch
Thanks,
Keta Patel
il. To reply, visit:
https://reviews.apache.org/r/46808/#review132335
---
On May 10, 2016, 7:48 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46808/
> --
/05/d6d24e4f-f57d-40ff-bc31-31303c6c1d45__step6.tiff
step7.tiff
https://reviews.apache.org/media/uploaded/files/2016/05/05/07b36b93-804a-494d-93e5-66b45db85023__step7.tiff
AMBARI-15552-May-10.patch
https://reviews.apache.org/media/uploaded/files/2016/05/10/3103f74e-e4a5-4814-8539-cd82a842af88__AMBARI-15552-May-10.patch
Thanks,
Keta Patel
ot;mygroup"
> > Changed user "aaa"'s role to Cluster Administrator. (Success)
> > Changed user "aaa"'s role back to None. (Failed)
> > Refresh browser aaa's role went back to Cluster User.
>
> Keta Patel wrote:
> Hello Richard,
> T
test trunk code. For your reference I am
attaching the patch here again as "AMBARI-15552-May-05.patch".
Please let me know if the behavior is still inconsistent.
Thank you,
Keta
- Keta
---
This is an
https://reviews.apache.org/media/uploaded/files/2016/05/05/f5899879-f28c-4886-96cb-e3d40a65cc02__step4.tiff
step5.tiff
https://reviews.apache.org/media/uploaded/files/2016/05/05/9c79a159-8b70-4d5f-8969-3353ba668a77__step5.tiff
step6.tiff
https://reviews.apache.org/media/uploaded/files/2016/05/05/d6d24e4f-f57d-40ff-bc31-31303c6c1d45__step6.tiff
step7.tiff
https://reviews.apache.org/media/uploaded/files/2016/05/05/07b36b93-804a-494d-93e5-66b45db85023__step7.tiff
Thanks,
Keta Patel
lection for Groups is tested for:
1. the new selected role has the same privilege as the group's effective
privilege.
2. the new selected role has greater privilege than the group's effective
privilege.
3. the new selected role has lower privilege than the group's effective
privilege.
Thanks,
Keta Patel
BARI-15979-topError.patch
AMBARI-15979-April-26-updated.patch
https://reviews.apache.org/media/uploaded/files/2016/04/26/8631c255-73b9-4179-ba70-6372a69ac225__AMBARI-15979-April-26-updated.patch
Thanks,
Keta Patel
/3/?file=1359898#file1359898line134>
> >
> > Please put validations in utils/validation.js
I have updated this in the new patch "AMBARI-15979-April-26.patch"
- Keta
---
This is an automatica
.org/media/uploaded/files/2016/04/21/03bc972a-b076-4520-948b-3a204082eca0__AMBARI-15979-inlineError.patch
AMBARI-15979-topError.patch
https://reviews.apache.org/media/uploaded/files/2016/04/21/8b4e9a7b-96cb-4a17-9c9c-56e59b5fd349__AMBARI-15979-topError.patch
Thanks,
Keta Patel
iew130483
---
On April 25, 2016, 4:37 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46475/#review130159
---
On April 25, 2016, 4:37 p.m., Keta Patel wrote:
>
>
ews.apache.org/media/uploaded/files/2016/04/21/03bc972a-b076-4520-948b-3a204082eca0__AMBARI-15979-inlineError.patch
AMBARI-15979-topError.patch
https://reviews.apache.org/media/uploaded/files/2016/04/21/8b4e9a7b-96cb-4a17-9c9c-56e59b5fd349__AMBARI-15979-topError.patch
Thanks,
Keta Patel
inline error messages vs top error messages).
- Keta
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46475/#review129904
---
On A
ews.apache.org/media/uploaded/files/2016/04/21/8b4e9a7b-96cb-4a17-9c9c-56e59b5fd349__AMBARI-15979-topError.patch
Thanks,
Keta Patel
dded that check the validate functions added for widget name and
description.
Both widget name and description are tested for:
1. all valid characters
2. invalid characters
3. length of input
4. empty string
Ambari-Web tests with the patch:
25671 tests complete (33 seconds)
154 tests pending
Thanks,
Keta Patel
g/r/46394/#review129711
---
On April 19, 2016, 4:33 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
iew129558
---
On April 19, 2016, 4:33 p.m., Keta Patel wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
s in the User's name in the List view of Roles as
seen in attachment "names with No URI encoding.tiff" on the Jira.
Ambari-Web tests (orginal):
24689 tests complete (28 seconds)
145 tests pending
Ambari-Web tests (after fix):
24689 tests complete (27 seconds)
145 tests pending
Thanks,
Keta Patel
> On March 14, 2016, 5:47 p.m., Di Li wrote:
> > Ship It!
>
> Keta Patel wrote:
> Thank you Di!
>
> Di Li wrote:
> can you reattach the latest build via the "Update Diff" option? Your
> AMBARI-15310_Mar10.patch is not up to download via
mponent name and trancate it with
> > ... when it reaches the limite.
> >
> > For example, ExtraLongZookeeperComponentName would be dispalyed as
> >
> > ExtraLongZook.../Zookeeper
> >
> > The ExtraLongZookeeperComponentName is still displayed on zookeeper'
59 matches
Mail list logo
