Review Request 58978: Ranger Quick links not showing load balancer in Ranger-admin HA

2017-05-03 Thread Xi Wang
/views/common/quick_link_view_test.js 71790782d1 Diff: https://reviews.apache.org/r/58978/diff/1/ Testing --- 30380 passing (34s) 157 pending Thanks, Xi Wang

Re: Review Request 58861: AMBARI-20896 - Provide ability to visualize per cluster data from Grafana dashboards

2017-04-28 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58861/#review173401 --- Ship it! Ship It! - Xi Wang On April 28, 2017, 4:22 p.m

Re: Review Request 58445: AMBARI-20738 - Cannot add repo for additional OS to an existing HDP version

2017-04-17 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58445/#review172139 --- Ship it! Ship It! - Xi Wang On April 13, 2017, 6:56 p.m

Re: Review Request 58433: Add more database options for beacon in stack advisor

2017-04-13 Thread Xi Wang
/diff/2/ Changes: https://reviews.apache.org/r/58433/diff/1-2/ Testing --- 20664 passing (27s) 128 pending Thanks, Xi Wang

Review Request 58433: Add more database options for beacon in stack advisor

2017-04-13 Thread Xi Wang
) 128 pending Thanks, Xi Wang

Review Request 58405: Update the Accordion styles in horton style

2017-04-12 Thread Xi Wang
://reviews.apache.org/r/58405/diff/1/ Testing --- 20675 passing (25s) 128 pending Thanks, Xi Wang

Re: Review Request 58260: AMBARI-20700 - UI should use the URL as-given by the backend

2017-04-11 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58260/#review171626 --- Ship it! Ship It! - Xi Wang On April 6, 2017, 11 p.m

Review Request 58257: Side Nav: improve views dropdown menu

2017-04-06 Thread Xi Wang
background. Diffs - ambari-web/app/styles/theme/bootstrap-ambari.css b063fcfa34 Diff: https://reviews.apache.org/r/58257/diff/1/ Testing --- 20606 passing (25s) 128 pending Thanks, Xi Wang

Re: Review Request 58124: AMBARI-20651 - When in Upgrade paused state, links should be disabled for less privileged user

2017-04-04 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58124/#review171050 --- Ship it! Ship It! - Xi Wang On March 31, 2017, 4:35 p.m

Review Request 58016: Auto-Start Services Switch button broken

2017-03-28 Thread Xi Wang
://reviews.apache.org/r/58016/diff/1/ Testing --- 20606 passing (25s) 128 pending Thanks, Xi Wang

Re: Review Request 58007: AMBARI-20613 - Host Filtering interaction is confusing and cumbersome to perform simple filtering

2017-03-28 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58007/#review170346 --- Ship it! Ship It! - Xi Wang On March 28, 2017, 3:14 p.m

Review Request 58000: Unable to scroll down collapsed navigation bar if it's higher that viewport

2017-03-28 Thread Xi Wang
e for "collapsed "sidebar. Diffs - ambari-web/app/styles/theme/bootstrap-ambari.css b289517 ambari-web/vendor/scripts/theme/bootstrap-ambari.js 5cdbb55 Diff: https://reviews.apache.org/r/58000/diff/1/ Testing --- 20606 passing (24s) 128 pending Thanks, Xi Wang

Review Request 57967: Test and fix new Accordions styles on Ambari

2017-03-27 Thread Xi Wang
) 128 pending Thanks, Xi Wang

Review Request 57656: Side Nav: several issues and adjustments

2017-03-15 Thread Xi Wang
656/diff/1/ Testing --- 20577 passing (28s) 153 pending Thanks, Xi Wang

Review Request 57526: Side Nav: several issues tested on IE 11

2017-03-10 Thread Xi Wang
lapse side navi menu. Diffs - ambari-web/app/styles/theme/bootstrap-ambari.css 3adcbe9 ambari-web/vendor/scripts/theme/bootstrap-ambari.js c193f7f Diff: https://reviews.apache.org/r/57526/diff/1/ Testing --- 20559 passing (27s) 153 pending Thanks, Xi Wang

Review Request 57008: Side Nav: multiple fixes after integrated to trunk

2017-02-23 Thread Xi Wang
/theme/bootstrap-ambari.js 1c81aeb Diff: https://reviews.apache.org/r/57008/diff/ Testing --- 20375 passing (37s) 153 pending Thanks, Xi Wang

Re: Review Request 56961: DataNode Storage alert is duplicated

2017-02-22 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56961/#review166464 --- Ship it! Ship It! - Xi Wang On Feb. 22, 2017, 5:02 p.m

Re: Review Request 56777: AMBARI-20058 - 'Final' is not shown correctly in config diff tool and in older versions

2017-02-17 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56777/#review165963 --- Ship it! Ship It! - Xi Wang On Feb. 16, 2017, 7:02 p.m

Re: Review Request 56033: Remove white border from the content area in popup wizards

2017-01-27 Thread Xi Wang
he JIRA. - Xi --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56033/#review163323 --- On Jan. 27, 2017, 11:25 a.m., Xi Wang wrote: > > -

Review Request 56033: Remove white border from the content area in popup wizards

2017-01-27 Thread Xi Wang
ambari-web/app/views/common/modal_popups/log_tail_popup.js 1e6924f ambari-web/app/views/main/admin/stack_upgrade/upgrade_history_view.js c4a428e Diff: https://reviews.apache.org/r/56033/diff/ Testing --- 20325 passing (26s) 153 pending Thanks, Xi Wang

Re: Review Request 55733: AMBARI-19637 - No baseURL field on Register Version page if repoinfo.xml contains only one baseurl

2017-01-19 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55733/#review162380 --- Ship it! Ship It! - Xi Wang On Jan. 19, 2017, 3:26 p.m

Re: Review Request 55596: AMBARI-19576 - Downgrade request fails as existing Upgrade request is considered 'in progress'

2017-01-17 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55596/#review161894 --- Ship it! Ship It! - Xi Wang On Jan. 16, 2017, 6:17 p.m

Review Request 55514: Improve "Install Wizard step 2-10" after new guidelines

2017-01-13 Thread Xi Wang
Testing --- 20236 passing (24s) 153 pending Thanks, Xi Wang

Review Request 55367: Improve "Install Wizard step 1" after new guidelines

2017-01-09 Thread Xi Wang
ambari-web/app/templates/wizard/step1.hbs 3b85895 Diff: https://reviews.apache.org/r/55367/diff/ Testing --- 20205 passing (19s) 153 pending Thanks, Xi Wang

Review Request 55290: Improve "Install Wizard step 0" after new guidelines

2017-01-06 Thread Xi Wang
ambari-web/app/styles/theme/bootstrap-ambari.css 5a641b3 ambari-web/app/styles/wizard.less 1398f12 ambari-web/app/templates/wizard/step0.hbs 07c9857 Diff: https://reviews.apache.org/r/55290/diff/ Testing --- 20157 passing (19s) 153 pending Thanks, Xi Wang

Re: Review Request 55289: Auto refresh yarn queues when capacity scheduler config is changed from hive configs page

2017-01-06 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55289/#review160794 --- Ship it! Ship It! - Xi Wang On Jan. 6, 2017, 4:15 p.m

Re: Review Request 55234: AMBARI-19393 - Cluster User role is able to view auto start page

2017-01-05 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55234/#review160640 --- Ship it! Ship It! - Xi Wang On Jan. 5, 2017, 2:42 p.m

Review Request 55233: Improve and Fix "Hosts page" after new guidelines

2017-01-05 Thread Xi Wang
shadow, should not Hosts table: 4. Text in every table row was not centered. Diffs - ambari-web/app/styles/application.less 7d18cf5 Diff: https://reviews.apache.org/r/55233/diff/ Testing --- 19976 passing (20s) 153 pending Thanks, Xi Wang

Re: Review Request 55159: AMBARI-19348 - Version number is incorrect when upgrade wizard is opened from Upgrade History

2017-01-04 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55159/#review160530 --- Ship it! Ship It! - Xi Wang On Jan. 3, 2017, 5:36 p.m

Review Request 55095: Improve and Fix "Admin page" after new guidelines

2016-12-29 Thread Xi Wang
iff/ Testing --- 19838 passing (20s) 153 pending Thanks, Xi Wang

Review Request 55062: Improve and Fix "Services page" after new guidelines

2016-12-27 Thread Xi Wang
pear. Diffs - ambari-web/app/styles/enhanced_service_dashboard.less 0d549d7 ambari-web/app/views/main/service/widgets/create/expression_view.js 436e3e9 Diff: https://reviews.apache.org/r/55062/diff/ Testing --- 19829 passing (21s) 153 pending Thanks, Xi Wang

Review Request 54922: Improve and Fix "Dashboard page" after new guidelines

2016-12-20 Thread Xi Wang
/diff/ Testing ------- 19713 passing (18s) 153 pending Thanks, Xi Wang

Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-19 Thread Xi Wang
i-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 Diff: https://reviews.apache.org/r/54460/diff/ Testing (updated) --- 19713 passing (21s) 153 pending Thanks, Xi Wang

Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-09 Thread Xi Wang
i-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 Diff: https://reviews.apache.org/r/54460/diff/ Testing --- Thanks, Xi Wang

Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-09 Thread Xi Wang
-49b6-b794-138199c53ae0__AMBARI-19117.patch Thanks, Xi Wang

Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-09 Thread Xi Wang
i-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 Diff: https://reviews.apache.org/r/54460/diff/ Testing --- Thanks, Xi Wang

Re: Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-08 Thread Xi Wang
lerts.less 77cc13c ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 2ea42f7 Diff: https://reviews.apache.org/r/54460/diff/ Testing --- Thanks, Xi Wang

Review Request 54460: Implement Create Alerts: PORT alert configs page (step 2)

2016-12-06 Thread Xi Wang
ain/alerts/definitions_configs_controller_test.js 2ea42f7 Diff: https://reviews.apache.org/r/54460/diff/ Testing --- Thanks, Xi Wang

Re: Review Request 54406: Improve and Fix "Wizard pages" after new guidelines

2016-12-06 Thread Xi Wang
ambari.css d10a13b ambari-web/app/styles/wizard.less 57dae45 ambari-web/app/templates/wizard/step8.hbs 5c2e8e6 Diff: https://reviews.apache.org/r/54406/diff/ Testing (updated) --- 19926 tests complete (47 seconds) 155 tests pending Thanks, Xi Wang

Re: Review Request 54050: AMBARI-18981 - Manage JournalNodes Wizard: Display only the steps needed for DELETE ONLY task

2016-12-05 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54050/#review158099 --- Ship it! Ship It! - Xi Wang On Dec. 5, 2016, 5:43 p.m

Review Request 54406: Improve and Fix "Wizard pages" after new guidelines

2016-12-05 Thread Xi Wang
app/styles/wizard.less 57dae45 ambari-web/app/templates/wizard/step8.hbs 5c2e8e6 Diff: https://reviews.apache.org/r/54406/diff/ Testing --- Thanks, Xi Wang

Review Request 53904: Implement Create Alerts: step 1 select alert type

2016-11-18 Thread Xi Wang
Testing --- Thanks, Xi Wang

Re: Review Request 53833: AMBARI-18916 - Manage JournalNodes Wizard: Text adjustments

2016-11-16 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53833/#review156165 --- Ship it! Ship It! - Xi Wang On Nov. 16, 2016, 5:54 p.m

Review Request 53821: Implement Create Alerts: Create a base wizard for all steps

2016-11-16 Thread Xi Wang
p2_view.js step3_view.js *4 templates* in folder: templates/main/alerts/create wizard.hbs step1.hbs step2.hbs step3.hbs Diffs - ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 36bc232 Diff: https://reviews.apache.org/r/53821/diff/ Testing --- Thanks, Xi Wang

Re: Review Request 53771: AMBARI-18890 - Enable "Auto Start" feature for services & components by default

2016-11-15 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53771/#review156001 --- Ship it! Ship It! - Xi Wang On Nov. 14, 2016, 7:08 p.m

Re: Review Request 53565: Add ability to Skip Host check option on bootstrap page

2016-11-08 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53565/#review155386 --- Ship it! Ship It! - Xi Wang On Nov. 8, 2016, 12:09 p.m

Re: Review Request 53332: Improve wizard styles and apply on Ambari

2016-10-31 Thread Xi Wang
.hbs f4fea26 ambari-web/app/templates/wizard/step7.hbs 0f8fa8d ambari-web/app/templates/wizard/step8.hbs 1af0683 ambari-web/app/templates/wizard/step9.hbs d1bcf3d Diff: https://reviews.apache.org/r/53332/diff/ Testing --- 26147 tests complete (20 seconds) 57 tests pending Thanks,

Review Request 53332: Improve wizard styles and apply on Ambari

2016-10-31 Thread Xi Wang
/app/templates/wizard/step9.hbs d1bcf3d Diff: https://reviews.apache.org/r/53332/diff/ Testing --- 26147 tests complete (20 seconds) 57 tests pending Thanks, Xi Wang

Re: Review Request 52183: Support creating/editing alert target which notification_type is ALERT_SCRIPT in web client

2016-10-12 Thread Xi Wang
cause this is part of alert notifications management. - Xi Wang On Sept. 22, 2016, 7:24 p.m., yao lei wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Review Request 48361: VDF: install wizard "Select Version" UI issues

2016-06-07 Thread Xi Wang
ambari-web/app/styles/common.less 738edce Diff: https://reviews.apache.org/r/48361/diff/ Testing --- 28646 tests complete (27 seconds) 154 tests pending Thanks, Xi Wang

Review Request 48191: VDF: Register Version UI inconsistencies + bug

2016-06-02 Thread Xi Wang
should be active stacks, not all. 2. As for the filters on Versions page, the placeholder of Name and Version filter should be in normal weight. 3. Add a "close icon" at the end of Name and Version filter. 4. Kill the slight shift when entering text in Name and Version filter. Thanks, Xi Wang

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-21 Thread Xi Wang
ews/main/admin/stack_upgrade/services_view_test.js 9a42c42 ambari-web/test/views/wizard/step1_view_test.js 0dacad8 Diff: https://reviews.apache.org/r/45792/diff/ Testing --- 25612 tests complete (26 seconds) 154 tests pending Thanks, Xi Wang

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-21 Thread Xi Wang
te (26 seconds) 154 tests pending Thanks, Xi Wang

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-20 Thread Xi Wang
w_test.js 9a42c42 ambari-web/test/views/wizard/step1_view_test.js 0dacad8 Diff: https://reviews.apache.org/r/45792/diff/ Testing --- 25612 tests complete (26 seconds) 154 tests pending Thanks, Xi Wang

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-20 Thread Xi Wang
ews/main/admin/stack_upgrade/services_view_test.js 9a42c42 ambari-web/test/views/wizard/step1_view_test.js 0dacad8 Diff: https://reviews.apache.org/r/45792/diff/ Testing --- 25612 tests complete (26 seconds) 154 tests pending Thanks, Xi Wang

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-19 Thread Xi Wang
b/test/mappers/stack_mapper_test.js 0bc0f3c ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js 9a42c42 ambari-web/test/views/wizard/step1_view_test.js 0dacad8 Diff: https://reviews.apache.org/r/45792/diff/ Testing --- 25612 tests complete (26 seconds) 154 tests pending Thanks, Xi Wang

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-19 Thread Xi Wang
0f3c ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js 9a42c42 ambari-web/test/views/wizard/step1_view_test.js 0dacad8 Diff: https://reviews.apache.org/r/45792/diff/ Testing --- 25612 tests complete (26 seconds) 154 tests pending Thanks, Xi Wang

Re: Review Request 46061: AMBARI-15816: EU/RU - cannot resume upgrade after pausing on a manual task

2016-04-11 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46061/#review128286 --- Ship it! Ship It! - Xi Wang On April 11, 2016, 4:16 p.m

Re: Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-07 Thread Xi Wang
b/test/mappers/stack_mapper_test.js 0bc0f3c ambari-web/test/views/main/admin/stack_upgrade/services_view_test.js 9a42c42 ambari-web/test/views/wizard/step1_view_test.js 0dacad8 Diff: https://reviews.apache.org/r/45792/diff/ Testing (updated) --- 25612 tests complete (26 seconds) 154 tests pending Thanks, Xi Wang

Review Request 45792: Integrate Version Registration in Select Stack Page

2016-04-05 Thread Xi Wang
s.apache.org/r/45792/diff/ Testing --- Thanks, Xi Wang

Re: Review Request 45568: AMBARI-15658. If there is a host with no components then host page spins

2016-03-31 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45568/#review126482 --- Ship it! Ship It! - Xi Wang On March 31, 2016, 3:31 p.m

Re: Review Request 45143: AMBARI-15504. Host filter: minor UX edits

2016-03-22 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45143/#review124892 --- Ship it! Ship It! - Xi Wang On March 22, 2016, 2:09 p.m

Re: Review Request 44960: AMBARI-15466. RBAC: Add dialog popup to explain roles

2016-03-18 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44960/#review124072 --- Ship it! Ship It! - Xi Wang On March 17, 2016, 7:54 a.m

Review Request 44814: Version Register/manage: UX edits #1

2016-03-14 Thread Xi Wang
/main/admin/stack_upgrade/upgrade_version_column.hbs c343151 ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_column_view.js 346c10c Diff: https://reviews.apache.org/r/44814/diff/ Testing --- All UT passed Thanks, Xi Wang

Re: Review Request 44809: RBAC: Name filter does not work for user with no role

2016-03-14 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44809/#review123511 --- Ship it! Ship It! - Xi Wang On March 14, 2016, 2:12 p.m

Re: Review Request 44723: AMBARI-15394 Add second parameter to App.format.role()

2016-03-11 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44723/#review123235 --- Ship it! Ship It! - Xi Wang On March 11, 2016, 2:17 p.m

Re: Review Request 44723: AMBARI-15394 Add second parameter to App.format.role()

2016-03-11 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44723/#review123198 --- Ship it! Ship It! - Xi Wang On March 11, 2016, 11:50 a.m

Re: Review Request 44683: AMBARI-14556. Role based access control UX fixes

2016-03-11 Thread Xi Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44683/#review123188 --- Ship it! Ship It! - Xi Wang On March 10, 2016, 5:20 p.m