Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

2016-10-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/#review151217 --- Ship it! Ship It! - Alejandro Fernandez On Oct. 3, 2016,

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

2016-10-03 Thread Aravindan Vijayan
> On Oct. 3, 2016, 7:04 p.m., Alejandro Fernandez wrote: > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py, > > line 150 > > > > > > Will hostname_hash ever be negative? Ideally,

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

2016-10-03 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/#review151213 ---

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

2016-10-03 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/ --- (Updated Oct. 3, 2016, 6:52 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

2016-10-03 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/#review151209 --- Fix it, then Ship it! Please add unit tests maybe another Jira

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

2016-10-03 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/ --- (Updated Oct. 3, 2016, 6:22 p.m.) Review request for Ambari, Dmytro Sen, Sumit

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

2016-09-29 Thread Dmytro Sen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/#review150852 --- Ship it! Ship It! - Dmytro Sen On Сен. 29, 2016, 2:46 п.п.,

Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

2016-09-29 Thread Aravindan Vijayan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/ --- Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. Bugs: