Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-21 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review138890
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 21, 2016, 12:11 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 21, 2016, 12:11 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  9e0fb7c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  cedb3f9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  4db9f10 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  42c4979 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 3461ad4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  b1c2468d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 426b452 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-21 Thread Mugdha Varadkar 


> On June 21, 2016, 1:04 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml,
> >  line 704
> > 
> >
> > Nonrolling upgrades have already stopped all services, no need to call 
> > "stop" again.

Updated in latest patch


> On June 21, 2016, 1:04 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml,
> >  line 942
> > 
> >
> > If have 2 consecutive groups that run on all hosts, then don't need the 
> > "sequential" flag. That is used when you have say 3 hosts, one step runs on 
> > A and another step runs on B, and you want step A to finish then step B, as 
> > opposed to them running in parallel because B isn't already running a task.

Updated in latest patch


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review138725
---


On June 21, 2016, 12:11 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 21, 2016, 12:11 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  9e0fb7c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  cedb3f9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  4db9f10 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  42c4979 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 3461ad4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  b1c2468d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 426b452 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-21 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/
---

(Updated June 21, 2016, 12:11 p.m.)


Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
Gunturi, and Velmurugan Periasamy.


Changes
---

Handle Alejandro Fernandez comment to remove "sequential" flag, stop task from 
nonrolling-2.x.xml and re-order hdp-select, conf-select


Bugs: AMBARI-17165
https://issues.apache.org/jira/browse/AMBARI-17165


Repository: ambari


Description
---

Revisiting execution of java patches during upgrade for Ranger Service


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 9e0fb7c 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 cedb3f9 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 4db9f10 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
 4fd5801 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
 272a3cc 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
b0cff68 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
0b72254 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 111b432 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 9365646 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 42c4979 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
712241b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
4187d64 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
3461ad4 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 e83b54b 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 b1c2468d 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
4065e87 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
426b452 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 460e6b3 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
6ce4c81 

Diff: https://reviews.apache.org/r/48549/diff/


Testing
---

Tested Ranger upgrade from stack 2.4 to 2.5


Thanks,

Mugdha Varadkar

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-20 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review138725
---




ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
 (line 942)


If have 2 consecutive groups that run on all hosts, then don't need the 
"sequential" flag. That is used when you have say 3 hosts, one step runs on A 
and another step runs on B, and you want step A to finish then step B, as 
opposed to them running in parallel because B isn't already running a task.



ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 (line 704)


Nonrolling upgrades have already stopped all services, no need to call 
"stop" again.


- Alejandro Fernandez


On June 16, 2016, 11:57 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 16, 2016, 11:57 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  9e0fb7c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  cedb3f9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  b86a09b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  42c4979 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 3461ad4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  b1c2468d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 426b452 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-20 Thread Mugdha Varadkar 


> On June 17, 2016, 10:55 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py,
> >  line 53
> > 
> >
> > Shouldn't the callers of this function pass in the correct upgrade_type 
> > already so we don't have to check params.restart_type?

Caller of the function will get upgrade_type when it is called from start(). 
upgrade_type will not be available when it is called from configure().


> On June 17, 2016, 10:55 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml,
> >  line 878
> > 
> >
> > No need to specify sequential="true".
> > This means that the orchestartion will stop all Ranger Admins, then on 
> > all call set_pre_start(), which does hdp-select and conf-select.
> > 
> > Typically, we call hdp-select and conf-select in pre_upgrade_restart() 
> > function in python.

Had to introduce this because setup_ranger_java_patches task is supposed to be 
run in pre-upgrade step and at this time the ranger configs should point to new 
(to-upgrade-version) version. This way before the java patches are called the 
/usr/hdp/current will point to the new version.


> On June 17, 2016, 10:55 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml, 
> > line 453
> > 
> >
> > Doesn't pre-upgrade already imply that the direction is only during 
> > UPGRADE, and hence the function setup_ranger_database may not need to check 
> > for it, although it doesn't hurt.
> > This is not going to be a rolling upgrade if we have to stop all Ranger 
> > Admins

When I checked the pre-upgrade tasks were also being called during downgrade. 
However during downgrade Ranger does not require the java patches/database 
setup to be called, hence had to introduce this check.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review138343
---


On June 16, 2016, 11:57 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 16, 2016, 11:57 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  9e0fb7c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  cedb3f9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  b86a09b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  42c4979 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 3461ad4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  b1c2468d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 426b452 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-17 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review138343
---




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 (line 53)


Shouldn't the callers of this function pass in the correct upgrade_type 
already so we don't have to check params.restart_type?



ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
 (line 878)


No need to specify sequential="true".
This means that the orchestartion will stop all Ranger Admins, then on all 
call set_pre_start(), which does hdp-select and conf-select.

Typically, we call hdp-select and conf-select in pre_upgrade_restart() 
function in python.



ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml (line 
453)


Doesn't pre-upgrade already imply that the direction is only during 
UPGRADE, and hence the function setup_ranger_database may not need to check for 
it, although it doesn't hurt.
This is not going to be a rolling upgrade if we have to stop all Ranger 
Admins


- Alejandro Fernandez


On June 16, 2016, 11:57 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 16, 2016, 11:57 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  9e0fb7c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  cedb3f9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  b86a09b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  42c4979 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 3461ad4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  b1c2468d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 426b452 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-17 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review138238
---


Ship it!




Ship It!

- Jonathan Hurley


On June 16, 2016, 7:57 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 16, 2016, 7:57 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
>  9e0fb7c 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  cedb3f9 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  b86a09b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  42c4979 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 3461ad4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  b1c2468d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 426b452 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-15 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/
---

(Updated June 15, 2016, 12:41 p.m.)


Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
Gunturi, and Velmurugan Periasamy.


Changes
---

Updating execution of java patches to pre-upgrade block


Bugs: AMBARI-17165
https://issues.apache.org/jira/browse/AMBARI-17165


Repository: ambari


Description
---

Revisiting execution of java patches during upgrade for Ranger Service


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 29ac561 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 b86a09b 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
 4fd5801 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
 272a3cc 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
b0cff68 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
0b72254 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 111b432 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 9365646 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 464c444 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
712241b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
4187d64 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
dd04b64 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 e83b54b 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 27461e8 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
4065e87 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
ad1bc34 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 460e6b3 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
6ce4c81 

Diff: https://reviews.apache.org/r/48549/diff/


Testing
---

Tested Ranger upgrade from stack 2.4 to 2.5


Thanks,

Mugdha Varadkar

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-13 Thread Alejandro Fernandez 


> On June 10, 2016, 5:40 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml,
> >  line 889
> > 
> >
> > hosts="all" is the default, you can remove it.
> > sequential="true" isn't needed since it is only useful when two 
> > consecutive tasks need to run one after the other even though they are on 
> > different hosts.
> > 
> > Why is there a stop and start in post-upgrade?
> > What are you trying to achieve here?
> > 
> > Pre-upgrade is any steps to execute before restarting the component, 
> > Post-upgrade is after restarting. So if there are any other stop-start 
> > steps, it means the component is being restarted twice!
> 
> Nate Cole wrote:
> I agree with Alejandro here, it looks like you're stopping all admins, 
> java-patching only one, then starting them all.  They should all need 
> patching, no?  And if that's the case that can all be handled on the python 
> side with nothing but restart for the component in the UP.
> 
> Jonathan Hurley wrote:
> I think that stopping all and running the patch on 1 is correct. The 
> patch executes `db_setup.py -javapatch`, so I'd expect that since it's done 
> on the database that you'd only want it done once. But you'd also want all of 
> them down.
> 
> With that said, I still don't understand why this is being done 
> post-upgrade.
> 
> Mugdha Varadkar wrote:
> Yes db_setup.py -javapatch needs to run only at one host.
> 
> The reason behind this addition is java patches failures: when we try to 
> run Java patches with Ranger services started. That's why I have stopped 
> service (from all hosts, in case of HA) before starting to execute Java 
> patches. 
> 
> It needs to be a part of post upgrade, because it needs to be applied 
> only on one host also it needs to have config properties of new version.

Please setup a quick 10 min discussion with Jonathan or myself to go over this.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review137042
---


On June 10, 2016, 12:47 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 10, 2016, 12:47 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  f40f760 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> ea5ff5a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7fb03dc 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 7f988e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-13 Thread Mugdha Varadkar 


> On June 10, 2016, 5:40 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml,
> >  line 889
> > 
> >
> > hosts="all" is the default, you can remove it.
> > sequential="true" isn't needed since it is only useful when two 
> > consecutive tasks need to run one after the other even though they are on 
> > different hosts.
> > 
> > Why is there a stop and start in post-upgrade?
> > What are you trying to achieve here?
> > 
> > Pre-upgrade is any steps to execute before restarting the component, 
> > Post-upgrade is after restarting. So if there are any other stop-start 
> > steps, it means the component is being restarted twice!
> 
> Nate Cole wrote:
> I agree with Alejandro here, it looks like you're stopping all admins, 
> java-patching only one, then starting them all.  They should all need 
> patching, no?  And if that's the case that can all be handled on the python 
> side with nothing but restart for the component in the UP.
> 
> Jonathan Hurley wrote:
> I think that stopping all and running the patch on 1 is correct. The 
> patch executes `db_setup.py -javapatch`, so I'd expect that since it's done 
> on the database that you'd only want it done once. But you'd also want all of 
> them down.
> 
> With that said, I still don't understand why this is being done 
> post-upgrade.

Yes db_setup.py -javapatch needs to run only at one host.

The reason behind this addition is java patches failures: when we try to run 
Java patches with Ranger services started. That's why I have stopped service 
(from all hosts, in case of HA) before starting to execute Java patches. 

It needs to be a part of post upgrade, because it needs to be applied only on 
one host also it needs to have config properties of new version.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review137042
---


On June 10, 2016, 12:47 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 10, 2016, 12:47 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  f40f760 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> ea5ff5a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7fb03dc 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 7f988e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-11 Thread Jonathan Hurley 


> On June 10, 2016, 1:40 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml,
> >  line 889
> > 
> >
> > hosts="all" is the default, you can remove it.
> > sequential="true" isn't needed since it is only useful when two 
> > consecutive tasks need to run one after the other even though they are on 
> > different hosts.
> > 
> > Why is there a stop and start in post-upgrade?
> > What are you trying to achieve here?
> > 
> > Pre-upgrade is any steps to execute before restarting the component, 
> > Post-upgrade is after restarting. So if there are any other stop-start 
> > steps, it means the component is being restarted twice!
> 
> Nate Cole wrote:
> I agree with Alejandro here, it looks like you're stopping all admins, 
> java-patching only one, then starting them all.  They should all need 
> patching, no?  And if that's the case that can all be handled on the python 
> side with nothing but restart for the component in the UP.

I think that stopping all and running the patch on 1 is correct. The patch 
executes `db_setup.py -javapatch`, so I'd expect that since it's done on the 
database that you'd only want it done once. But you'd also want all of them 
down.

With that said, I still don't understand why this is being done post-upgrade.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review137042
---


On June 10, 2016, 8:47 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 10, 2016, 8:47 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  f40f760 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> ea5ff5a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7fb03dc 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 7f988e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-10 Thread Nate Cole 


> On June 10, 2016, 1:40 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml,
> >  line 889
> > 
> >
> > hosts="all" is the default, you can remove it.
> > sequential="true" isn't needed since it is only useful when two 
> > consecutive tasks need to run one after the other even though they are on 
> > different hosts.
> > 
> > Why is there a stop and start in post-upgrade?
> > What are you trying to achieve here?
> > 
> > Pre-upgrade is any steps to execute before restarting the component, 
> > Post-upgrade is after restarting. So if there are any other stop-start 
> > steps, it means the component is being restarted twice!

I agree with Alejandro here, it looks like you're stopping all admins, 
java-patching only one, then starting them all.  They should all need patching, 
no?  And if that's the case that can all be handled on the python side with 
nothing but restart for the component in the UP.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review137042
---


On June 10, 2016, 8:47 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 10, 2016, 8:47 a.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  f40f760 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> ea5ff5a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7fb03dc 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 7f988e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-10 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review137042
---




ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
 (line 889)


hosts="all" is the default, you can remove it.
sequential="true" isn't needed since it is only useful when two consecutive 
tasks need to run one after the other even though they are on different hosts.

Why is there a stop and start in post-upgrade?
What are you trying to achieve here?

Pre-upgrade is any steps to execute before restarting the component, 
Post-upgrade is after restarting. So if there are any other stop-start steps, 
it means the component is being restarted twice!


- Alejandro Fernandez


On June 10, 2016, 12:47 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 10, 2016, 12:47 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  f40f760 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> ea5ff5a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7fb03dc 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 7f988e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-10 Thread Velmurugan Periasamy 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/#review137008
---


Ship it!




Ship It!

- Velmurugan Periasamy


On June 10, 2016, 12:47 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48549/
> ---
> 
> (Updated June 10, 2016, 12:47 p.m.)
> 
> 
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17165
> https://issues.apache.org/jira/browse/AMBARI-17165
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Revisiting execution of java patches during upgrade for Ranger Service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  4fd5801 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  272a3cc 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
> b0cff68 
>   ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
> 0b72254 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  111b432 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  9365646 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  f40f760 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 712241b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 4187d64 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> ea5ff5a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  e83b54b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7fb03dc 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> 4065e87 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 7f988e3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  460e6b3 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> 6ce4c81 
> 
> Diff: https://reviews.apache.org/r/48549/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger upgrade from stack 2.4 to 2.5
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 48549: AMBARI-17165 Handle Java patches execution during Ranger upgrade

2016-06-10 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48549/
---

Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth 
Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17165
https://issues.apache.org/jira/browse/AMBARI-17165


Repository: ambari


Description
---

Revisiting execution of java patches during upgrade for Ranger Service


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
 4fd5801 
  
ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
 272a3cc 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.3.xml 
b0cff68 
  ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/upgrade-2.4.xml 
0b72254 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
 111b432 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
 9365646 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 f40f760 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
712241b 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
4187d64 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
ea5ff5a 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
 e83b54b 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 7fb03dc 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
4065e87 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
7f988e3 
  
ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
 460e6b3 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
6ce4c81 

Diff: https://reviews.apache.org/r/48549/diff/


Testing
---

Tested Ranger upgrade from stack 2.4 to 2.5


Thanks,

Mugdha Varadkar