Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-26 Thread Gautam Borad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/
---

(Updated July 26, 2016, 2:46 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev Konar, 
Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.


Changes
---

Patch contains changes of using ambari smokeuser for making alert calls.


Bugs: AMBARI-17771
https://issues.apache.org/jira/browse/AMBARI-17771


Repository: ambari


Description
---

Update alert definition URI after stack is updated.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/RANGER/0.6.0/alerts.json 
0bced55 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 a1b93e3 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
96b1400 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 86e0964 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
2099958 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
 PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/50140/diff/


Testing
---

Tested on a centos 6 cluster after upgrade and checked that the alert works 
fine for Ranger Admin.


Thanks,

Gautam Borad

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-24 Thread Gautam Borad 


> On July 21, 2016, 6:18 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml,
> >  line 379
> > 
> >
> > We havent restarted RANGER on the new version at this point right? So 
> > we are setting alerts beforehand? Shouldnt we do this after RANGER is 
> > upgraded?
> > 
> > Also what about DOWNGRADE? If we go all the way to Finalize step and 
> > kick DOWNGRADE will old alerts be restored?

@Jayush, the attached patch was tested for both upgrade and downgrade scenarios 
and it worked fine.


- Gautam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review143116
---


On July 21, 2016, 12:36 p.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> ---
> 
> (Updated July 21, 2016, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
> https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a1915c00853b2817b815124752063222d59d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7f277fb02cf24e64b16171c2cd13cb94f9518ada 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 43c6265b00240790ed96aadcaddff5b7b97d4b95 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> ---
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-21 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review143116
---




ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 (line 379)


We havent restarted RANGER on the new version at this point right? So we 
are setting alerts beforehand? Shouldnt we do this after RANGER is upgraded?

Also what about DOWNGRADE? If we go all the way to Finalize step and kick 
DOWNGRADE will old alerts be restored?


- Jayush Luniya


On July 21, 2016, 12:36 p.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> ---
> 
> (Updated July 21, 2016, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
> https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a1915c00853b2817b815124752063222d59d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7f277fb02cf24e64b16171c2cd13cb94f9518ada 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 43c6265b00240790ed96aadcaddff5b7b97d4b95 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> ---
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-21 Thread Jayush Luniya 


> On July 21, 2016, 3:30 p.m., Jonathan Hurley wrote:
> > It would have been nice to break this type of server action out into 
> > something more generic for alert updates. That way, future changes like 
> > this won't need to worry about broadcasting events. However, it's not 
> > necessary for this release.

+1 with Jonathan. @Gautam can you file a follow up JIRA on this?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review143087
---


On July 21, 2016, 12:36 p.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> ---
> 
> (Updated July 21, 2016, 12:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
> https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a1915c00853b2817b815124752063222d59d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7f277fb02cf24e64b16171c2cd13cb94f9518ada 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 43c6265b00240790ed96aadcaddff5b7b97d4b95 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> ---
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-21 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review143087
---


Ship it!




It would have been nice to break this type of server action out into something 
more generic for alert updates. That way, future changes like this won't need 
to worry about broadcasting events. However, it's not necessary for this 
release.

- Jonathan Hurley


On July 21, 2016, 8:36 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> ---
> 
> (Updated July 21, 2016, 8:36 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
> https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a1915c00853b2817b815124752063222d59d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 7f277fb02cf24e64b16171c2cd13cb94f9518ada 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 43c6265b00240790ed96aadcaddff5b7b97d4b95 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> ---
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-20 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review142932
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (line 72)


Change this a bit to be clearer in the logs:
"Updating the alert definition for ranger_admin_process"



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (line 93)


I don't think this log statement adds much value.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (line 94)


I don't think this is going to actually broadcast the 
AlertInvalidationEvent. You might need to it manually like this:


https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java#L322-L326

```
  // invalidate and publish the definition hash
  Set invalidatedHosts = 
alertDefinitionHash.invalidateHosts(entity);
  AlertHashInvalidationEvent event = new AlertHashInvalidationEvent(
  entity.getClusterId(), invalidatedHosts);

  eventPublisher.publish(event);
```

I can't remember why it wasn't a part of `merge()` ... seems like it should 
be, but I don't think it's very safe to add it there at this late stage.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (lines 100 - 102)


Probably not needed either; there are a log of installs which don't use 
Ranger.


- Jonathan Hurley


On July 19, 2016, 11:26 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> ---
> 
> (Updated July 19, 2016, 11:26 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
> https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7d9615568fb3ef02ded4816c02959c882ce43f50 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 964ec3f649cec538af7865aacf51f5c0e18230a4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  c82e938b7f285107980bdda4efac095e267d3530 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 49ff6da745821e6314dc62ef0bcee78f328460a0 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> ---
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-19 Thread Gautam Borad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/
---

(Updated July 19, 2016, 3:26 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev Konar, 
Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.


Changes
---

Address Jonathan's review comments


Bugs: AMBARI-17771
https://issues.apache.org/jira/browse/AMBARI-17771


Repository: ambari


Description
---

Update alert definition URI after stack is updated.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7d9615568fb3ef02ded4816c02959c882ce43f50 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
964ec3f649cec538af7865aacf51f5c0e18230a4 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 c82e938b7f285107980bdda4efac095e267d3530 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
49ff6da745821e6314dc62ef0bcee78f328460a0 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
 PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/50140/diff/


Testing
---

Tested on a centos 6 cluster after upgrade and checked that the alert works 
fine for Ranger Admin.


Thanks,

Gautam Borad

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-18 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review142687
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (line 65)


This should never be null. If it was null, then m_clusters above it would 
also be null and you'd get a NPE even before here.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (lines 79 - 87)


Out of curiousity, would it be easier to just read the values from the JSON 
file directly? That way you don't have to duplicate it here?



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (line 91)


It already exists, so you can just call merge() on it.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (line 103)


Remove and log instead.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (lines 106 - 107)


This can't happen.



ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
 (lines 82 - 83)


If this test class is in the same package, you should be able to access 
these directly.


- Jonathan Hurley


On July 18, 2016, 11:45 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> ---
> 
> (Updated July 18, 2016, 11:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
> https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a1915c00853b2817b815124752063222d59d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 47d9fdb999ef6e7051bd339502e98d30b7c53fc2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> dd7a87f72d1cbbbc9db6027af6c61292743a133a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> ---
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-18 Thread Gautam Borad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev Konar, 
Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17771
https://issues.apache.org/jira/browse/AMBARI-17771


Repository: ambari


Description
---

Update alert definition URI after stack is updated.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7be5a1915c00853b2817b815124752063222d59d 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
47d9fdb999ef6e7051bd339502e98d30b7c53fc2 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
dd7a87f72d1cbbbc9db6027af6c61292743a133a 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
 PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/50140/diff/


Testing
---

Tested on a centos 6 cluster after upgrade and checked that the alert works 
fine for Ranger Admin.


Thanks,

Gautam Borad