Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/#review151217
---


Ship it!




Ship It!

- Alejandro Fernandez


On Oct. 3, 2016, 6:52 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52391/
> ---
> 
> (Updated Oct. 3, 2016, 6:52 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18487
> https://issues.apache.org/jira/browse/AMBARI-18487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change metric monitor sharding strategy to hostname based.
> 2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
> already FIXED*
> 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  fa5b694 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  4d0ec14 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  3982c4e 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  3ca3a31 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
> 
> Diff: https://reviews.apache.org/r/52391/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Aravindan Vijayan]

> On Oct. 3, 2016, 7:04 p.m., Alejandro Fernandez wrote:
> > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py,
> >  line 150
> > 
> >
> > Will hostname_hash ever be negative?

Ideally, no. In any case, we are guarded for it in 

Line 150 : *index = index if index >= 0 else index + size*


- Aravindan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/#review151213
---


On Oct. 3, 2016, 6:52 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52391/
> ---
> 
> (Updated Oct. 3, 2016, 6:52 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18487
> https://issues.apache.org/jira/browse/AMBARI-18487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change metric monitor sharding strategy to hostname based.
> 2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
> already FIXED*
> 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  fa5b694 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  4d0ec14 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  3982c4e 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  3ca3a31 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
> 
> Diff: https://reviews.apache.org/r/52391/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/#review151213
---




ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
(line 149)


Will hostname_hash ever be negative?


- Alejandro Fernandez


On Oct. 3, 2016, 6:52 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52391/
> ---
> 
> (Updated Oct. 3, 2016, 6:52 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18487
> https://issues.apache.org/jira/browse/AMBARI-18487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change metric monitor sharding strategy to hostname based.
> 2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
> already FIXED*
> 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  fa5b694 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  4d0ec14 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  3982c4e 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  3ca3a31 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
> 
> Diff: https://reviews.apache.org/r/52391/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/
---

(Updated Oct. 3, 2016, 6:52 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18487
https://issues.apache.org/jira/browse/AMBARI-18487


Repository: ambari


Description
---

1. Change metric monitor sharding strategy to hostname based.
2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
already FIXED*
3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 fa5b694 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
 4d0ec14 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 3982c4e 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 3ca3a31 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
050af16 

Diff: https://reviews.apache.org/r/52391/diff/


Testing
---

Manually tested.
Unit tests pass.


Thanks,

Aravindan Vijayan

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/#review151209
---


Fix it, then Ship it!




Please add unit tests maybe another Jira but this should be unit tested.


ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 (line 352)


Please leave comments about why we need to track expirey vs first call.


- Sid Wagle


On Oct. 3, 2016, 6:22 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52391/
> ---
> 
> (Updated Oct. 3, 2016, 6:22 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18487
> https://issues.apache.org/jira/browse/AMBARI-18487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change metric monitor sharding strategy to hostname based.
> 2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
> already FIXED*
> 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  fa5b694 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  4d0ec14 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  3982c4e 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
>  3ca3a31 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
> 
> Diff: https://reviews.apache.org/r/52391/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/
---

(Updated Oct. 3, 2016, 6:22 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18487
https://issues.apache.org/jira/browse/AMBARI-18487


Repository: ambari


Description (updated)
---

1. Change metric monitor sharding strategy to hostname based.
2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was 
already FIXED*
3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 fa5b694 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
 4d0ec14 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 3982c4e 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py
 3ca3a31 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
050af16 

Diff: https://reviews.apache.org/r/52391/diff/


Testing
---

Manually tested.
Unit tests pass.


Thanks,

Aravindan Vijayan

Re: Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/#review150852
---


Ship it!




Ship It!

- Dmytro Sen


On Сен. 29, 2016, 2:46 п.п., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52391/
> ---
> 
> (Updated Сен. 29, 2016, 2:46 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-18487
> https://issues.apache.org/jira/browse/AMBARI-18487
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Change metric monitor sharding strategy to hostname based.
> 2. Fix issues in AbstractTimelineMetricSink
> 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  426eb42 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
>  4d0ec14 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  b720ba9 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
>  f44ca35 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
>  3982c4e 
>   
> ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
> 050af16 
> 
> Diff: https://reviews.apache.org/r/52391/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Unit tests pass.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 52391: AMBARI-18487 : Test and refine Collector writes w.r.t sharing and timeouts

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52391/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-18487
https://issues.apache.org/jira/browse/AMBARI-18487


Repository: ambari


Description
---

1. Change metric monitor sharding strategy to hostname based.
2. Fix issues in AbstractTimelineMetricSink
3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry.


Diffs
-

  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
 426eb42 
  
ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java
 4d0ec14 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 b720ba9 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java
 f44ca35 
  
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py
 3982c4e 
  ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py 
050af16 

Diff: https://reviews.apache.org/r/52391/diff/


Testing
---

Manually tested.
Unit tests pass.


Thanks,

Aravindan Vijayan