Re: Review Request 37107: Add a tool and environment for building Aurora packages.

2015-08-05 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/#review94236 --- build-artifact.sh (line 32)

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

2015-08-05 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/#review94238 --- builder/deb/ubuntu-trusty/Dockerfile (line 50)

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

2015-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/ --- (Updated Aug. 5, 2015, 3:12 p.m.) Review request for Aurora, Benjamin Staffin,

Re: Review Request 37107: Add a tool and environment for building Aurora packages.

2015-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37107/ --- (Updated Aug. 5, 2015, 5:32 p.m.) Review request for Aurora, Benjamin Staffin,

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-05 Thread Maxim Khutornenko
On Aug. 4, 2015, 6:57 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, line 154 https://reviews.apache.org/r/37049/diff/1/?file=1028142#file1028142line154 This seems like a new pattern that's inconsistent with the

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/ --- (Updated Aug. 5, 2015, 6:51 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/#review94282 --- src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37049/#review94283 --- Ship it! Master (2130f7e) is green with this patch.

Re: Review Request 37049: Integrating DelayExecutor into the scheduler's transaction handling.

2015-08-05 Thread Maxim Khutornenko
On Aug. 5, 2015, 7:03 p.m., Maxim Khutornenko wrote: src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, lines 192-197 https://reviews.apache.org/r/37049/diff/2/?file=1032776#file1032776line192 Are you certain this is no longer needed? The setup above is shared

Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37137/ --- Review request for Aurora and Zameer Manji. Bugs: AURORA-1125

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37137/#review94293 --- This is being nit-picky, but is it a glitch that the video makes it

Review Request 37139: Resources: moving calculation methods from Resources

2015-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37139/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1415

Re: Review Request 37136: Configure vagrant environment for sudo-less docker.

2015-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37136/#review94294 --- examples/vagrant/provision-dev-cluster.sh (line 99)

Re: Review Request 37136: Configure vagrant environment for sudo-less docker.

2015-08-05 Thread Bill Farner
On Aug. 5, 2015, 7:55 p.m., Maxim Khutornenko wrote: examples/vagrant/provision-dev-cluster.sh, line 99 https://reviews.apache.org/r/37136/diff/1/?file=1032812#file1032812line99 Don't you want groupadd docker and newgrp docker here as well? The docker group is already created when

Re: Review Request 37136: Configure vagrant environment for sudo-less docker.

2015-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37136/#review94296 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 5, 2015, 7:05

Re: Review Request 37139: Resources: moving calculation methods from Resources

2015-08-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37139/#review94298 --- Ship it! Master (61c63ea) is green with this patch.

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37137/#review94299 --- Master (61c63ea) is red with this patch.

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37137/ --- (Updated Aug. 5, 2015, 8:28 p.m.) Review request for Aurora and Zameer Manji.

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Joshua Cohen
On Aug. 5, 2015, 7:38 p.m., Bill Farner wrote: This is being nit-picky, but is it a glitch that the video makes it seem like the first pulse is really sudden compared to the subsqeuent ones? Probably just an artifact of the screen recording. The pulse speed is constant in browser. -

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37137/#review94302 --- Ship it! Ship It! - Bill Farner On Aug. 5, 2015, 8:28 p.m.,

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37137/#review94301 --- Master (61c63ea) is green with this patch.

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37137/#review94303 --- src/main/resources/scheduler/assets/css/app.css (line 436)

Review Request 37141: DbStorage: remove @Transactional left behind in /r/37049.

2015-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37141/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Joshua Cohen
On Aug. 5, 2015, 8:49 p.m., Zameer Manji wrote: src/main/resources/scheduler/assets/css/app.css, line 436 https://reviews.apache.org/r/37137/diff/2/?file=1032840#file1032840line436 If we are going to add the -webkit prefix then I think we should do the same for -moz. Otherwise I

Re: Review Request 37141: DbStorage: remove @Transactional left behind in /r/37049.

2015-08-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37141/#review94306 --- Master (8a8ed2d) is red with this patch.

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37137/#review94308 --- Ship it! Ship It! - Zameer Manji On Aug. 5, 2015, 1:28 p.m.,

Re: Review Request 37141: DbStorage: remove @Transactional left behind in /r/37049.

2015-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37141/#review94310 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 5, 2015, 8:51

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Joshua Cohen
On Aug. 5, 2015, 8:49 p.m., Zameer Manji wrote: src/main/resources/scheduler/assets/css/app.css, line 436 https://reviews.apache.org/r/37137/diff/2/?file=1032840#file1032840line436 If we are going to add the -webkit prefix then I think we should do the same for -moz. Otherwise I

Re: Review Request 37137: Add indications of continued activity to the Update page.

2015-08-05 Thread Zameer Manji
On Aug. 5, 2015, 1:49 p.m., Zameer Manji wrote: src/main/resources/scheduler/assets/css/app.css, line 436 https://reviews.apache.org/r/37137/diff/2/?file=1032840#file1032840line436 If we are going to add the -webkit prefix then I think we should do the same for -moz. Otherwise I

Review Request 37144: Resources: moving calculation methods from Resources

2015-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37144/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1415

Re: Review Request 37144: Resources: moving calculation methods from Resources

2015-08-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37144/#review94319 --- Ship it! Master (8adc9bd) is green with this patch.

Re: Review Request 37144: Resources: moving calculation methods from Resources

2015-08-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37144/#review94320 --- Ship it! Ship It! - Bill Farner On Aug. 5, 2015, 9:25 p.m.,

Re: Review Request 37157: Create Dockerfiles for building Aurora

2015-08-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37157/#review94345 --- Ship it! Master (8adc9bd) is green with this patch.

Review Request 37153: Resources: reversing Resource/ResourceSlot relationship

2015-08-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37153/ --- Review request for Aurora and Bill Farner. Repository: aurora Description