Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106558 --- Ship it! A working build on Arch, thanks for that\! - Stephan

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

2015-11-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40334/#review106575 --- Ship it! Master (7b494f4) is green with this patch.

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106577 --- build-support/thrift/.gitignore (line 1)

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40334/#review106573 --- Right diff2, wrong review - that was intended for

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106572 --- This is now rebased against https://reviews.apache.org/r/40334/ in

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/#review106576 --- Ship it! Master (7b494f4) is green with this patch.

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 15, 2015, 4:34 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106588 --- Master (7b494f4) is red with this patch.

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote: > > build-support/thrift/.gitignore, line 1 > > > > > > How about wildcards so we don't trip over this when upgrading > > bison/thrift? Sounds good - done. > On

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 15, 2015, 7:45 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40334/#review106574 --- OK - diff 3 restored to normal, just a pants rev bump. Sorry

Re: Review Request 40334: Upgrade to pants `0.0.59` to avoid pytest errors.

2015-11-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40334/#review106580 --- Ship it! Ship It! - Bill Farner On Nov. 15, 2015, 3:36 p.m.,

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote: > > build-support/thrift/Makefile, line 50 > > > > > > On OS X 10.11 i get the following from this line: > > ``` > > sha256=$(curl -s

Re: Review Request 40324: Isolate the `third_party/` repo to `mesos.native`.

2015-11-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/#review106579 --- Ship it! LGTM, thanks! - Bill Farner On Nov. 14, 2015, 4:18

Re: Review Request 40310: Replace Twitter checkstyle with pants checkstyle.

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40310/ --- (Updated Nov. 15, 2015, 9:02 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote: > > build-support/thrift/Makefile, line 50 > > > > > > On OS X 10.11 i get the following from this line: > > ``` > > sha256=$(curl -s

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/ --- (Updated Nov. 15, 2015, 9:13 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
> On Nov. 15, 2015, 7:57 p.m., Aurora ReviewBot wrote: > > Master (7b494f4) is red with this patch. > > ./build-support/jenkins/build.sh > > > > 02:52:16 00:00 [ivy-imports] > > 02:52:16 00:00 [unpack-jars] > > 02:52:16 00:00 [unpack-jars] > > 02:52:16 00:00 [deferred-sources] > >

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106591 --- Master (7b494f4) is red with this patch.

Re: Review Request 40323: Improve the isolation in the thrift build.

2015-11-15 Thread John Sirois
> On Nov. 15, 2015, 9:27 p.m., Aurora ReviewBot wrote: > > Master (7b494f4) is red with this patch. > > ./build-support/jenkins/build.sh > > > > 04:22:02 00:00 [ivy-imports] > > 04:22:02 00:00 [unpack-jars] > > 04:22:02 00:00 [unpack-jars] > > 04:22:02 00:00

Re: Review Request 39170: Fix NPE on accessing crons set at impossible dates

2015-11-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39170/#review106566 --- Brice - this would be nice to land. Are you able to put time