Re: Review Request 63316: Directly call 'registered' in SchedulerLifecycle as opposed to having it be a pubsub event

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/ --- (Updated Oct. 26, 2017, 3:14 a.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 63281: Clean up TaskList component layout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63281/#review189268 --- Ship it! Master (5201cf1) is green with this patch. ./build-s

Re: Review Request 63316: Directly call 'registered' in SchedulerLifecycle as opposed to having it be a pubsub event

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/#review189266 --- Ship it! Master (5201cf1) is green with this patch. ./build-s

Review Request 63316: Directly call 'registered' in SchedulerLifecycle as opposed to having it be a pubsub event

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/ --- Review request for Aurora, David McLaughlin, Stephan Erb, and Bill Farner. Repo

Review Request 63316: Directly call 'registered' in SchedulerLifecycle as opposed to having it be a pubsub event

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63316/ --- Review request for Aurora, David McLaughlin, Stephan Erb, and Bill Farner. Repo

Re: Review Request 63221: reload instance page once a neighbor item is clicked

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189256 --- This is shipped to master. - David McLaughlin On Oct. 25, 2017,

Re: Review Request 63221: reload instance page once a neighbor item is clicked

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189255 --- Ship it! Ship It! - David McLaughlin On Oct. 25, 2017, 10:26

Re: Review Request 63221: reload instance page once a neighbor item is clicked

> On Oct. 25, 2017, 9:54 p.m., David McLaughlin wrote: > > Looks good. Please also move deep-equal from "devDependencies" to > > "dependencies" in package.json. Done. - Reza --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 63221: reload instance page once a neighbor item is clicked

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/ --- (Updated Oct. 25, 2017, 10:26 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 63221: reload instance page once a neighbor item is clicked

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189250 --- Looks good. Please also move deep-equal from "devDependencies" to

Re: Review Request 63221: reload instance page once a neighbor item is clicked

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/ --- (Updated Oct. 25, 2017, 9:51 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 63221: reload instance page once a neighbor item is clicked

> On Oct. 24, 2017, 10:40 p.m., David McLaughlin wrote: > > ui/src/main/js/pages/Instance.js > > Lines 2 (patched) > > > > > > I don't see this dependency in package.json. If the build is green, > > that means this co

Re: Review Request 63221: reload instance page once a neighbor item is clicked

> On Oct. 24, 2017, 10:40 p.m., David McLaughlin wrote: > > ui/src/main/js/pages/Instance.js > > Lines 2 (patched) > > > > > > I don't see this dependency in package.json. If the build is green, > > that means this co

Re: Review Request 63306: Add release notes for new UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63306/#review189245 --- Ship it! Thanks :) - Stephan Erb On Oct. 25, 2017, 10:25 p.m

Re: Review Request 63306: Add release notes for new UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63306/ --- (Updated Oct. 25, 2017, 8:25 p.m.) Review request for Aurora and Stephan Erb.

Review Request 63306: Add release notes for new UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63306/ --- Review request for Aurora. Repository: aurora Description --- Add releas

Re: Review Request 63281: Clean up TaskList component layout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63281/ --- (Updated Oct. 25, 2017, 8:08 p.m.) Review request for Aurora, Kai Huang and Rez

Re: Review Request 63281: Clean up TaskList component layout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63281/#review189228 --- Ship it! Ship It! - Reza Motamedi On Oct. 24, 2017, 11:32 p.

Re: Review Request 63281: Clean up TaskList component layout.

> On Oct. 25, 2017, 5:10 p.m., Kai Huang wrote: > > ui/src/main/js/components/TaskListItemActions.js > > Lines 3 (patched) > > > > > > s/TaskListItemActioins/TaskListItemHost/ ? > > David McLaughlin wrote: > The i

Re: Review Request 63262: Add a package.json file in the plugin directory to allow custom dependencies

> On Oct. 25, 2017, 6:08 p.m., Reza Motamedi wrote: > > Ship It! Works like a charm! Thanks. - Reza --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63262/#review189222 ---

Re: Review Request 63262: Add a package.json file in the plugin directory to allow custom dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63262/#review189222 --- Ship it! Ship It! - Reza Motamedi On Oct. 24, 2017, 9:46 p.m

Re: Review Request 63236: Refactor veto logic to use direct method calls as opposed to pubsub events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63236/#review189213 --- Shipped to master, feel free to close this diff. - David McLaughl

Re: Review Request 63236: Refactor veto logic to use direct method calls as opposed to pubsub events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63236/#review189211 --- Ship it! Master (f2755e1) is green with this patch. ./build-s

Re: Review Request 63281: Clean up TaskList component layout.

> On Oct. 25, 2017, 5:10 p.m., Kai Huang wrote: > > ui/src/main/js/components/TaskListItemActions.js > > Lines 3 (patched) > > > > > > s/TaskListItemActioins/TaskListItemHost/ ? The idea is that we might add more acti

Re: Review Request 63281: Clean up TaskList component layout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63281/#review189207 --- Ship it! LGTM ui/src/main/js/components/TaskListItemActions.j

Re: Review Request 63236: Refactor veto logic to use direct method calls as opposed to pubsub events.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63236/ --- (Updated Oct. 25, 2017, 5:01 p.m.) Review request for Aurora and Bill Farner.