Re: Review Request 66573: Add initial interval before searching for preemption slots

2018-04-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66573/#review200968 --- Ship it! Master (cbe99f5) is green with this patch.

Re: Review Request 66573: Add initial interval before searching for preemption slots

2018-04-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66573/#review200954 --- Ship it! Ship It! - David McLaughlin On April 12, 2018,

Re: Review Request 66573: Add initial interval before searching for preemption slots

2018-04-11 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66573/#review200950 --- Ship it! Ship It! - Santhosh Kumar Shanmugham On April 11,

Review Request 66573: Add initial interval before searching for preemption slots

2018-04-11 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66573/ --- Review request for Aurora, David McLaughlin, Santhosh Kumar Shanmugham, and

Re: Review Request 66570: Remove flaky test/assertion in PendingTaskProcessorTest

2018-04-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66570/#review200947 --- Ship it! Master (c05632b) is green with this patch.

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

2018-04-11 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66186/#review200944 --- Ship it! Did you notice any real performance improvements? -

Re: Review Request 66570: Remove flaky test/assertion in PendingTaskProcessorTest

2018-04-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66570/#review200939 --- Ship it! Ship It! - David McLaughlin On April 11, 2018,

Review Request 66570: Remove flaky test/assertion in PendingTaskProcessorTest

2018-04-11 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66570/ --- Review request for Aurora, Santhosh Kumar Shanmugham and Stephan Erb.

Re: Review Request 66186: Upgrade to psutil with optimized Process.children()

2018-04-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66186/ --- (Updated April 12, 2018, 12:13 a.m.) Review request for Aurora, Reza Motamedi

Re: Review Request 66502: Update python virtualenv

2018-04-11 Thread Stephan Erb
> On April 10, 2018, 11:37 a.m., Stephan Erb wrote: > > Thanks for the patch! We also have another virtulenv version specified > > here: > > https://github.com/apache/aurora/blob/master/build-support/virtualenv#L17. > > Do you think you can bump that one as well? > > se choi wrote: >

Re: Review Request 66536: Add more preemption metrics (jobs preempted, preemptors) and logging statements

2018-04-11 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66536/#review200932 --- Ship it! Master (2d6108b) is green with this patch.

Re: Review Request 66536: Add more preemption metrics (jobs preempted, preemptors) and logging statements

2018-04-11 Thread Jordan Ly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66536/ --- (Updated April 11, 2018, 8:36 p.m.) Review request for Aurora, David

Re: Review Request 66536: Add more preemption metrics (jobs preempted, preemptors) and logging statements

2018-04-11 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66536/#review200925 --- Ship it! Looks useful, thanks!

Re: Review Request 66536: Add more preemption metrics (jobs preempted, preemptors) and logging statements

2018-04-11 Thread Santhosh Kumar Shanmugham
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66536/#review200915 --- Ship it!

Re: Review Request 66502: Update python virtualenv

2018-04-11 Thread se choi
> On April 10, 2018, 6:37 p.m., Stephan Erb wrote: > > Thanks for the patch! We also have another virtulenv version specified > > here: > > https://github.com/apache/aurora/blob/master/build-support/virtualenv#L17. > > Do you think you can bump that one as well? Homebrew has 5.2.0, wondering