va/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
b4d27f69ad5d4cce03da9f04424dc35d30e8af29
Diff: https://reviews.apache.org/r/51929/diff/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
`). Am I missing something?
Good catch. There was a legitimate use of the `Optional` in the
original diff but it's no longer needed after we changed to return `Set<String`
instead of `Map<String, Boolean>`.
- Maxim
---------
efits in that. This is the classic assign-or-throw pattern.
The `result.get()` returns a Set and we don't pass nulls for collections.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apach
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52167/#review150053
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 22, 2016, 6
a86dc82cafa7f5436d2b8d00c6db575ff8311eea
Diff: https://reviews.apache.org/r/52141/diff/
Testing
---
unit and e2e tests
Thanks,
Maxim Khutornenko
visit:
https://reviews.apache.org/r/52141/#review14
-------
On Sept. 22, 2016, 5:38 a.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52141/
>
generated e-mail. To reply, visit:
https://reviews.apache.org/r/52141/#review15
-------
On Sept. 22, 2016, 5:38 a.m., Maxim Khutornenko wrote:
>
> ---
> This is an automatically
/org/apache/aurora/scheduler/cron/quartz/CronIT.java
8556253fc11f6027316871eb9dc66d8627a77fe6
Diff: https://reviews.apache.org/r/52141/diff/
Testing
---
unit and e2e tests
Thanks,
Maxim Khutornenko
/SchedulerDriverService.java
(line 124)
<https://reviews.apache.org/r/52074/#comment217589>
nit: add newline above
src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java (line 372)
<https://reviews.apache.org/r/52074/#comment217592>
Can be inlined below.
- Maxim
t; This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51876/
> ---
>
> (Updated Sept. 20, 2016, 12:25 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Z
/r/51876/#comment217567>
This is exactly the problem I alluded to above. What if there is no entry
for a given `status` here?
- Maxim Khutornenko
On Sept. 20, 2016, 12:25 a.m., Kai Huang wrote:
>
> ---
> This is an
inly more possible than before to hit our
default 40 tasks per second limit now. Fixed.
- Maxim
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51929/#review149681
va/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
b4d27f69ad5d4cce03da9f04424dc35d30e8af29
Diff: https://reviews.apache.org/r/51929/diff/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
`if` unnecessary here and we can adjust the
> > penality in any case? We will remove the group if `hasMore()` returns
> > false, so any penality should be fine.
>
> Maxim Khutornenko wrote:
> Not sure I follow. This is the place that applies penalty accrued inside
> the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52087/#review149690
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 20, 2016, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51980/#review149674
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 19, 2016, 6
a/blob/795a2728c623c35bd509d582c24684a6921c74ad/src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java#L194-L208)
and making it a public method of the `NearestFit` itself (e.g.:
`getPendingReason(Query.Builder query)`. You can query that method and marry
the results right within the `PendingTasks`.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51929/#review149290
---
@ReviewBot retry
- Maxim Khutornenko
On Sept. 16, 2016, 9:53
/state/TaskAssignerImplTest.java
b4d27f69ad5d4cce03da9f04424dc35d30e8af29
Diff: https://reviews.apache.org/r/51929/diff/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
9/diff/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51973/#review149271
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 16, 2016, 8
change a release
note would be great.
- Maxim Khutornenko
On Sept. 16, 2016, 8:36 p.m., Renan DelValle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
t; > `CompletableFuture` and to give it a value we use `null`.
> >
> > Have you considered using `new Object()` instead so we don't have to
> > add this exception to our rules?
>
> Maxim Khutornenko wrote:
> I am not comfortable substituting a `Void` wit
including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
sagree I can reorder
though.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51759/#review149044
---
On Sept. 16, 2
single `write()` transaction.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51765/#review149229
---
On Sept. 14, 20
want to get a reading on updated
metrics. Since everything else that can post stats is mocked, there is no
reason to use a real object here.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.o
`AwaitableResult` into
`CompletableFuture` and it makes perfect sense to channel that error upstream.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51759/#review149227
-----
t.java
72562e6bd9a9860c834e6a9faa094c28600a8fed
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java
b4d27f69ad5d4cce03da9f04424dc35d30e8af29
Diff: https://reviews.apache.org/r/51929/diff/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
and decided to keep the original
contract. Now that the aproach fully shaped up, I can see how it can be
simplified by not returning the exhaustive map of things. Refactored to return
only what's needed. Thanks for bringing this up!
- Maxim
-------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51874/#review149216
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 15, 2016, 7
> 01:19:57 04:18 [complete][31m
> >FAILURE[0m
> >
> >
> > I will refresh this build result if you post a review containing
> > "@ReviewBot retry"
@ReviewBot retry
- Maxim
uction clusters.
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51924/#review149097
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 15, 2016, 6
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
1c0a3fa84874d7bc185b78f13d2664cb4d8dd72f
Diff: https://reviews.apache.org/r/51763/diff/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
ast mention it is about
> > killing a cron job.
Good point. Rephrased.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51763/#review148933
--
st a small set that you think need
> > this change.
>
> Maxim Khutornenko wrote:
> > Also, does this cover all state change consumers that interact on
> storage when the event is fired or is this a subset
>
> This covers all known high frequency consumers that
/CommandLineDriverSettingsModule.java
(line 82)
<https://reviews.apache.org/r/51874/#comment216516>
Did you try to rollback to pre 0.15 scheduler while changing the framework
name? Trying to see if we can drop this 'backwards incompatible' statement now.
- Maxim Khutornenko
On Sept. 14, 2016, 8:
terIT.java
196df4754b553f05e50b66ad2f84271901bc9eba
Diff: https://reviews.apache.org/r/51759/diff/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51759/#review148950
---
On Sept. 14, 2016, 5:25 p.m., Maxim Khutornenko wrote:
>
> ---
> This is an
e an optional one to
exclusively process 'TASK_RUNNING'. Since it's now status aware, it would make
sense to consolidate status management here and avoid the if-else switch
upstream.
Also, I'd use `mesos_pb2.TASK_RUNNING` instead of relying on string const.
- Ma
deploying to test and production clusters.
Thanks,
Maxim Khutornenko
TION
>
> src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java
> 99c27e8012f10a67ce5f1b84d258e7a5608995c7
> src/test/java/org/apache/aurora/scheduler/scheduling/TaskThrottlerTest.java
> 7d104aa2ea4a4d99be4711f666d18beca238284e
>
> src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
> 94f5ca565476f62d72879837a0e7dafabcf30432
> src/test/java/org/apache/aurora/scheduler/testing/BatchWorkerUtil.java
> PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
> 196df4754b553f05e50b66ad2f84271901bc9eba
>
> Diff: https://reviews.apache.org/r/51759/diff/
>
>
> Testing
> ---
>
> All types of testing including deploying to test and production clusters.
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
deploying to test and production clusters.
Thanks,
Maxim Khutornenko
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51759/#review148837
---
On Sept. 14, 2016, 12:16 a.m., Maxim Khutornenko wrote:
>
> ---
/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
1c0a3fa84874d7bc185b78f13d2664cb4d8dd72f
Diff: https://reviews.apache.org/r/51763/diff/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
a busy loop where we are queuing
> > the same item over and over until it is can finally be executed? This
> > sounds rather problematic.
> >
> > 2) This changes the order of work items. Are you sure that no storage
> > client requires writes t
/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
-
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
1c0a3fa84874d7bc185b78f13d2664cb4d8dd72f
Diff: https://reviews.apache.org/r/51763/diff/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51712/#review148762
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 13, 2016, 6
>
> (Updated Sept. 12, 2016, 10:26 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
>
>
> Bugs: AURORA-1764
> https://issues.apache.org/jira/browse/AURORA-1764
>
>
> Repository: aurora
>
>
> Description
>
`BatchWorker` and did not find it up to the task. Looking at it again though, I
don't see any reasons why it would not satisfy the current version! Thanks for
the nudge, the diff is incoming.
- Maxim
---
This is an automatically generate
y generated e-mail. To reply, visit:
https://reviews.apache.org/r/51765/#review148434
-------
On Sept. 9, 2016, 6:52 p.m., Maxim Khutornenko wrote:
>
> ---
> Th
iff: https://reviews.apache.org/r/51759/diff/
Testing
---
All types of testing including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
logical to expect it at the end
while going through the code. Moved.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51759/#review148501
---
en implied or expected as far as cross-transaction boundaries
go. That said, the order is preserved for a given work type. We re-queue
incomplete items in the same order they were received.
- Maxim
---
This is an automatically generated
> On Sept. 12, 2016, 7:31 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/resources/ResourceSettings.java,
> > lines 22-33
> > <https://reviews.apache.org/r/51807/diff/1/?file=1496737#file1496737line22>
> >
> > This is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51807/#review148600
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 12, 2016, 1
> On Sept. 12, 2016, 7:48 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/api/__init__.py, line 264
> > <https://reviews.apache.org/r/51712/diff/4/?file=1497099#file1497099line264>
> >
> > Why not going all the way to the cli
e dual writing/reading).
- Maxim Khutornenko
On Sept. 12, 2016, 7:39 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
views.apache.org/r/51662/
> ---
>
> (Updated Sept. 12, 2016, 5:49 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> AURORA-1602 Aurora admin com
views.apache.org/r/51807/
> ---
>
> (Updated Sept. 12, 2016, 1:38 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> We plan to open source a very simple Mesos ResourceEstimator and
> Qos
-
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51662/
> -------
>
> (Updated Sept. 9, 2016, 6:43 p.m.)
>
>
> Review
clusters.
Thanks,
Maxim Khutornenko
and production clusters.
Thanks,
Maxim Khutornenko
including deploying to test and production clusters.
Thanks,
Maxim Khutornenko
> On Sept. 8, 2016, 6:18 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/admin/admin.py, line 351
> > <https://reviews.apache.org/r/51662/diff/7/?file=1494553#file1494553line351>
> >
> > Needs clarifcation that `reconciliation_explicit_batch_
pdated Sept. 8, 2016, 5:27 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> ---
>
> AURORA-1602 Aurora admin commands for reconcilation
>
>
> Diffs
> ---
nt215687>
Please be explicit in the name, e.g.: `reconcile_tasks`
src/main/python/apache/aurora/admin/admin.py (line 351)
<https://reviews.apache.org/r/51662/#comment215699>
Needs clarifcation that `reconciliation_explicit_batch_size` is a scheduler
setting.
- Maxim Khutor
to be updated as well
to pass both (old and new) arguments. Please, test in vagrant with different
combinations of scheduler and client versions.
- Maxim Khutornenko
On Sept. 8, 2016, 12:03 a.m., Zameer Manji wrote
62/#review148089
---
On Sept. 7, 2016, 9:08 p.m., Karthik Anantha Padmanabhan wrote:
>
> -------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews
ertion that was not in sync.
Suggest dropping this line and adding it into the client RB that will
actually allow zero `watch_secs`.
- Maxim Khutornenko
On Sept. 7, 2016, 10:36 p.m., Kai Huang wrote:
>
> ---
> This is a
on runs.
This would let you cut the bulk of the changes below.
src/main/python/apache/aurora/admin/admin.py (line 355)
<https://reviews.apache.org/r/51662/#comment215437>
The default here would be 0 if you accept my suggestion above.
- Maxim Khutornenko
On Sept. 6, 2016, 11:34 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51384/#review148035
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 7, 2016, 3
> On Sept. 2, 2016, 9:37 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> > line 913
> > <https://reviews.apache.org/r/51384/diff/7/?file=1489641#file1489641line913>
> >
> > This wi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51536/#review147922
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 6, 2016, 6
ted e-mail. To reply, visit:
> https://reviews.apache.org/r/51536/
> ---
>
> (Updated Sept. 6, 2016, 6:46 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.
>
>
> Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51580/#review147853
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 5, 2016, 6
m., Stephan Erb wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51595/
> ---
>
> (Updated Sept. 2, 2016, 9:14 a.m.)
>
>
> Review request for Auror
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51602/#review147701
---
Ship it!
Ship It!
- Maxim Khutornenko
On Sept. 2, 2016, 2
e `details.updateEvents` for example.
It should be more compact and most importantly, perform better on large
metadata counts. You can validate the last assumption via `./gradlew jmh
-Pbenchmarks='UpdateStoreBenchmarks.JobDetailsBenchmark'` or create a new
benchmark to test fetching job s
iew147358
---
On Aug. 30, 2016, 8:52 p.m., Kai Huang wrote:
>
> -------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51536/
> ---
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51535/#review147346
---
Ship it!
Good catch!
- Maxim Khutornenko
On Aug. 30, 2016
/FlaggedZooKeeperConfig.java
(line 78)
<https://reviews.apache.org/r/51506/#comment214449>
I suggest against placing a version number into the warning message. We've
had a few past examples when we did not follow up on deprecation warnings as
promised.
- Maxim Khutornenko
On Aug. 29, 2016, 11:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51307/#review147179
---
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 23, 2016, 9
> On Aug. 29, 2016, 4:33 p.m., Maxim Khutornenko wrote:
> > Not against this change but rather curious what your thoughts are wrt the
> > larger picture here. Are you intending to get rid of all static helps in
> > `Stats` in favor of the `StatsProvider`?
>
> Zamee
u move it into the `JobUpdateSummary` the metadata will
be automatically exposed via the existing `getJobUpdateSummaries` RPC.
- Maxim Khutornenko
On Aug. 28, 2016, 3:58 a.m., Santhosh Kumar Shanmugham wrote:
>
> ---
> This is a
are wrt the
larger picture here. Are you intending to get rid of all static helps in
`Stats` in favor of the `StatsProvider`?
- Maxim Khutornenko
On Aug. 26, 2016, 10:11 p.m., Zameer Manji wrote:
>
> ---
> This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51474/#review147136
---
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 27, 2016, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51298/#review146441
---
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 22, 2016, 8
://markmail.org/message/d4j6lkncqkua5a23
- Maxim Khutornenko
On Aug. 15, 2016, 9:11 p.m., Min Cai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50168/#review145455
---
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 11, 2016, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50902/#review145393
---
Ship it!
Ship It!
- Maxim Khutornenko
On Aug. 8, 2016, 5:13
branch to
your github remote and post a link here for review. Care to give it a try?
- Maxim Khutornenko
On Aug. 8, 2016, 5:13 p.m., Mehrdad Nurolahzade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
che.org/r/50168/#comment211556>
If we want to make it truly generic I think we also need to support
ROLL_FORWARD_PAUSED -> ROLLING_BACK transition. That will cover *all* active
states.
- Maxim Khutornenko
On Aug. 9, 2016, 10:41 p.m., Igo
1 - 100 of 737 matches
Mail list logo
