Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189256 --- This is shipped to master. - David McLaughlin On Oct. 25,

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189255 --- Ship it! Ship It! - David McLaughlin On Oct. 25, 2017,

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread Reza Motamedi
> On Oct. 25, 2017, 9:54 p.m., David McLaughlin wrote: > > Looks good. Please also move deep-equal from "devDependencies" to > > "dependencies" in package.json. Done. - Reza --- This is an automatically generated e-mail. To reply,

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/ --- (Updated Oct. 25, 2017, 10:26 p.m.) Review request for Aurora, David

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/ --- (Updated Oct. 25, 2017, 9:51 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread David McLaughlin
> On Oct. 24, 2017, 10:40 p.m., David McLaughlin wrote: > > ui/src/main/js/pages/Instance.js > > Lines 2 (patched) > > > > > > I don't see this dependency in package.json. If the build is green, > > that means this

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-25 Thread Reza Motamedi
> On Oct. 24, 2017, 10:40 p.m., David McLaughlin wrote: > > ui/src/main/js/pages/Instance.js > > Lines 2 (patched) > > > > > > I don't see this dependency in package.json. If the build is green, > > that means this

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-24 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189110 --- ui/src/main/js/pages/Instance.js Lines 2 (patched)

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review189014 --- Ship it! Master (a673c5b) is green with this patch.

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/ --- (Updated Oct. 24, 2017, 12:09 a.m.) Review request for Aurora, David

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Reza Motamedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/ --- (Updated Oct. 24, 2017, midnight) Review request for Aurora, David McLaughlin

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Reza Motamedi
> On Oct. 23, 2017, 7:47 p.m., David McLaughlin wrote: > > ui/src/main/js/pages/Instance.js > > Line 34 (original), 38 (patched) > > > > > > enzyme allows you to update props, you can most likely test that when > >

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review188979 --- ui/src/main/js/pages/Instance.js Line 34 (original), 38

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review188977 --- Master (ec64011) is red with this patch.

Re: Review Request 63221: reload instance page once a neighbor item is clicked

2017-10-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63221/#review188973 --- Master (ec64011) is red with this patch.