Re: Review Request 51893: Allow cookie based authentication

> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review152662 --- Ship it! Master (8256000) is green with this patch.

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 14, 2016, 12:40 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review152660 --- Master (8256000) is red with this patch.

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 13, 2016, 7:10 p.m., Santhosh Kumar Shanmugham wrote: > > src/test/python/apache/aurora/common/test_cookie_auth_module.py, line 18 > > > > > > Can we also have a negative test case, where the COOKIE auth

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 14, 2016, 11:52 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review152557 --- docs/operations/security.md (line 203)

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review152131 --- Ship it! Master (b272b88) is green with this patch.

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 11, 2016, 1:58 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 7, 2016, 3:47 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/common/cookie_auth_module.py, line 31 > > > > > > You should be able to drop the expanduser call now that you're using > >

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151804 --- src/main/python/apache/aurora/common/cookie_auth_module.py (line

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151777 --- This patch does not apply cleanly against master (09b8e58), do

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 7, 2016, 10:49 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 6, 2016, 5:40 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/cli/client.py, line 85 > > > > > > I think we can move this import to the top with the rest of the > > imports? The only

Re: Review Request 51893: Allow cookie based authentication

> On Oct. 6, 2016, 4:46 p.m., Stephan Erb wrote: > > docs/operations/security.md, line 181 > > > > > > Does this require modifications of the scheduler? How does it pick up > > the necessary information in your

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151685 --- Can you add some tests for `CookieAuthModule`? I suspect this

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151674 --- Code looks much better now. Thanks for your effort.

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151640 --- Master (5fc633c) is green with this patch.

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 6, 2016, 11:14 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151639 --- This patch does not apply cleanly against master (5fc633c), do

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 6, 2016, 9:16 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 6, 2016, 9:10 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 6, 2016, 9:10 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151636 --- This patch does not apply cleanly against master (5fc633c), do

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 6, 2016, 9:06 a.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151503 --- Master (251ef5a) is red with this patch.

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151502 --- The new code looks good to me. Thanks for your follow-up. Please

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 5, 2016, 2:10 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 5, 2016, 2:04 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151499 --- Master (251ef5a) is red with this patch.

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Oct. 5, 2016, 1:46 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review151376 --- Thanks for the patch and sorry for the massiv delay. Would be

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review149031 --- Master (5069f93) is red with this patch.

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Sept. 15, 2016, 7:17 a.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review148949 --- Master (5069f93) is red with this patch.

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Sept. 14, 2016, 6:19 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review148920 --- Master (5069f93) is red with this patch.

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Sept. 14, 2016, 4:17 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review148914 --- Master (5069f93) is red with this patch.

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- (Updated Sept. 14, 2016, 4:03 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/#review148913 --- Master (5069f93) is red with this patch.

Review Request 51893: Allow cookie based authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51893/ --- Review request for Aurora. Repository: aurora Description --- This