Re: Review Request 35587: Suppress task reconciliation status update logging.

2015-06-18 Thread Bill Farner
On June 18, 2015, 4:42 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java, line 314 https://reviews.apache.org/r/35587/diff/1/?file=986660#file986660line314 What's being tested here? If i'm reading correctly, this test case

Re: Review Request 35587: Suppress task reconciliation status update logging.

2015-06-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/ --- (Updated June 18, 2015, 5:04 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35587: Suppress task reconciliation status update logging.

2015-06-18 Thread Maxim Khutornenko
On June 18, 2015, 4:42 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java, line 314 https://reviews.apache.org/r/35587/diff/1/?file=986660#file986660line314 What's being tested here? If i'm reading correctly, this test case

Re: Review Request 35587: Suppress task reconciliation status update logging.

2015-06-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/#review88388 ---

Re: Review Request 35639: Filtering explicit reconciliation tasks by SLAVE_ASSIGNED_STATES.

2015-06-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35639/#review88477 --- Ship it! Ship It! - Bill Farner On June 19, 2015, 1:21 a.m.,

Review Request 35639: Filtering explicit reconciliation tasks by SLAVE_ASSIGNED_STATES.

2015-06-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35639/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1361

Re: Review Request 35587: Suppress task reconciliation status update logging.

2015-06-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35587/#review88415 --- Ship it! Master (af7e1a7) is green with this patch.

Re: Review Request 35613: Fixing broken gradle dependency scanner.

2015-06-18 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/#review88447 --- Master (e271634) is red with this patch.

Review Request 35630: DbTaskStore perf: add a task store API to list task job keys.

2015-06-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35630/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-1298

Review Request 35627: Explicitly bind SessionContext.

2015-06-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35627/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1352

Re: Review Request 35627: Explicitly bind SessionContext.

2015-06-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35627/ --- (Updated June 18, 2015, 2:40 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35627: Explicitly bind SessionContext.

2015-06-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35627/#review88440 --- Ship it!

Review Request 35613: Fixing broken gradle dependency scanner.

2015-06-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 35627: Explicitly bind SessionContext.

2015-06-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35627/ --- (Updated June 18, 2015, 2:55 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 35630: DbTaskStore perf: add a task store API to list task job keys.

2015-06-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35630/#review88452 --- Ship it!

Re: Review Request 35630: DbTaskStore perf: add a task store API to list task job keys.

2015-06-18 Thread Bill Farner
On June 18, 2015, 11:08 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml, line 167 https://reviews.apache.org/r/35630/diff/1/?file=987636#file987636line167 Is DISTINCT necessary given the Set result type? Functionally it's

Re: Review Request 35633: Fixing stylecheck errors.

2015-06-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35633/#review88456 --- Ship it! Ship It! - Bill Farner On June 18, 2015, 11:15 p.m.,

Review Request 35633: Fixing stylecheck errors.

2015-06-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35633/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 35630: DbTaskStore perf: add a task store API to list task job keys.

2015-06-18 Thread Maxim Khutornenko
On June 18, 2015, 11:08 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml, line 167 https://reviews.apache.org/r/35630/diff/1/?file=987636#file987636line167 Is DISTINCT necessary given the Set result type? Bill Farner

Re: Review Request 35613: Fixing broken gradle dependency scanner.

2015-06-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/#review88458 --- @ReviewBot retry - Maxim Khutornenko On June 18, 2015, 10:12

Re: Review Request 35630: DbTaskStore perf: add a task store API to list task job keys.

2015-06-18 Thread Bill Farner
On June 18, 2015, 11:08 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml, line 167 https://reviews.apache.org/r/35630/diff/1/?file=987636#file987636line167 Is DISTINCT necessary given the Set result type? Bill Farner

Re: Review Request 35613: Fixing broken gradle dependency scanner.

2015-06-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35613/#review88464 --- Ship it! Ship It! - Kevin Sweeney On June 18, 2015, 3:12 p.m.,

Re: Review Request 35633: Fixing stylecheck errors.

2015-06-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35633/#review88465 --- Ship it! Ship It! - Kevin Sweeney On June 18, 2015, 4:15 p.m.,